X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=gtk2_ardour%2Fplugin_ui.cc;h=b4a412aa3f6e60ec5ffdb1c1ded371ebee9efd90;hb=ffc50fcf9da9f98ce2f261cffc2a01be20af32ed;hp=a91a5bf9d1f875897d37c55b42852e855b6c4755;hpb=c86210a9d5bdb7b36ad58552a1f99f53d48781b3;p=ardour.git diff --git a/gtk2_ardour/plugin_ui.cc b/gtk2_ardour/plugin_ui.cc index a91a5bf9d1..b4a412aa3f 100644 --- a/gtk2_ardour/plugin_ui.cc +++ b/gtk2_ardour/plugin_ui.cc @@ -1,5 +1,5 @@ /* - Copyright (C) 2000 Paul Davis + Copyright (C) 2000 Paul Davis This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -17,38 +17,51 @@ */ +#ifdef WAF_BUILD +#include "gtk2ardour-config.h" +#endif + #include #include #include #include -#include -#include -#include +#include "pbd/stl_delete.h" +#include "pbd/xml++.h" +#include "pbd/failed_constructor.h" #include +#include #include #include #include #include #include #include +#include -#include +#include "midi++/manager.h" -#include -#include -#include -#ifdef VST_SUPPORT -#include +#include "ardour/session.h" +#include "ardour/plugin.h" +#include "ardour/plugin_insert.h" +#include "ardour/ladspa_plugin.h" +#ifdef WINDOWS_VST_SUPPORT +#include "ardour/windows_vst_plugin.h" +#include "windows_vst_plugin_ui.h" #endif -#ifdef HAVE_LV2 -#include +#ifdef LXVST_SUPPORT +#include "ardour/lxvst_plugin.h" +#include "lxvst_plugin_ui.h" +#endif +#ifdef LV2_SUPPORT +#include "ardour/lv2_plugin.h" #include "lv2_plugin_ui.h" #endif #include +#include "ardour_window.h" #include "ardour_ui.h" #include "prompter.h" #include "plugin_ui.h" @@ -56,6 +69,9 @@ #include "gui_thread.h" #include "public_editor.h" #include "keyboard.h" +#include "latency_gui.h" +#include "plugin_eq_gui.h" +#include "new_plugin_preset_dialog.h" #include "i18n.h" @@ -64,28 +80,37 @@ using namespace ARDOUR; using namespace PBD; using namespace Gtkmm2ext; using namespace Gtk; -using namespace sigc; -PluginUIWindow::PluginUIWindow (Gtk::Window* win, boost::shared_ptr insert, bool scrollable) +PluginUIWindow::PluginUIWindow ( + Gtk::Window* win, + boost::shared_ptr insert, + bool scrollable, + bool editor) : parent (win) + , was_visible (false) + , _keyboard_focused (false) { bool have_gui = false; - non_gtk_gui = false; - was_visible = false; Label* label = manage (new Label()); label->set_markup ("THIS IS THE PLUGIN UI"); - if (insert->plugin()->has_editor()) { + std::cout << "SHOW UI " << insert->plugin()->unique_id() + << " editor: " << editor << std::endl; + if (editor && insert->plugin()->has_editor()) { switch (insert->type()) { - case ARDOUR::VST: - have_gui = create_vst_editor (insert); + case ARDOUR::Windows_VST: + have_gui = create_windows_vst_editor (insert); + break; + + case ARDOUR::LXVST: + have_gui = create_lxvst_editor (insert); break; case ARDOUR::AudioUnit: have_gui = create_audiounit_editor (insert); break; - + case ARDOUR::LADSPA: error << _("Eh? LADSPA plugins don't have editors!") << endmsg; break; @@ -95,7 +120,7 @@ PluginUIWindow::PluginUIWindow (Gtk::Window* win, boost::shared_ptrKeyboardFocused.connect (sigc::mem_fun (*this, &PluginUIWindow::keyboard_focused)); add (*pu); - - set_wmclass (X_("ardour_plugin_editor"), "Ardour"); + set_wmclass (X_("ardour_plugin_editor"), PROGRAM_NAME); - signal_map_event().connect (mem_fun (*pu, &GenericPluginUI::start_updating)); - signal_unmap_event().connect (mem_fun (*pu, &GenericPluginUI::stop_updating)); + signal_map_event().connect (sigc::mem_fun (*pu, &GenericPluginUI::start_updating)); + signal_unmap_event().connect (sigc::mem_fun (*pu, &GenericPluginUI::stop_updating)); } // set_position (Gtk::WIN_POS_MOUSE); set_name ("PluginEditor"); add_events (Gdk::KEY_PRESS_MASK|Gdk::KEY_RELEASE_MASK|Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK); - signal_delete_event().connect (bind (sigc::ptr_fun (just_hide_it), reinterpret_cast (this)), false); - insert->GoingAway.connect (mem_fun(*this, &PluginUIWindow::plugin_going_away)); + signal_delete_event().connect (sigc::bind (sigc::ptr_fun (just_hide_it), reinterpret_cast (this)), false); + insert->DropReferences.connect (death_connection, invalidator (*this), boost::bind (&PluginUIWindow::plugin_going_away, this), gui_context()); gint h = _pluginui->get_preferred_height (); gint w = _pluginui->get_preferred_width (); if (scrollable) { if (h > 600) h = 600; - if (w > 600) w = 600; - - if (w < 0) { - w = 450; - } } - set_default_size (w, h); + set_default_size (w, h); + set_resizable (_pluginui->resizable()); } PluginUIWindow::~PluginUIWindow () { + delete _pluginui; } void @@ -173,14 +194,37 @@ PluginUIWindow::on_leave_notify_event (GdkEventCrossing *ev) return false; } +bool +PluginUIWindow::on_focus_in_event (GdkEventFocus *ev) +{ + Window::on_focus_in_event (ev); + //Keyboard::the_keyboard().magic_widget_grab_focus (); + return false; +} + +bool +PluginUIWindow::on_focus_out_event (GdkEventFocus *ev) +{ + Window::on_focus_out_event (ev); + //Keyboard::the_keyboard().magic_widget_drop_focus (); + return false; +} + void PluginUIWindow::on_show () { + set_role("plugin_ui"); + if (_pluginui) { - _pluginui->update_presets (); + _pluginui->update_preset_list (); + _pluginui->update_preset (); } - Window::on_show (); + if (_pluginui) { + if (_pluginui->on_window_show (_title)) { + Window::on_show (); + } + } if (parent) { // set_transient_for (*parent); @@ -191,57 +235,108 @@ void PluginUIWindow::on_hide () { Window::on_hide (); + + if (_pluginui) { + _pluginui->on_window_hide (); + } +} + +void +PluginUIWindow::set_title(const std::string& title) +{ + Gtk::Window::set_title(title); + _title = title; } bool -PluginUIWindow::create_vst_editor(boost::shared_ptr insert) +#ifdef WINDOWS_VST_SUPPORT +PluginUIWindow::create_windows_vst_editor(boost::shared_ptr insert) +#else +PluginUIWindow::create_windows_vst_editor(boost::shared_ptr) +#endif { -#ifndef VST_SUPPORT +#ifndef WINDOWS_VST_SUPPORT return false; #else - boost::shared_ptr vp; + boost::shared_ptr vp; - if ((vp = boost::dynamic_pointer_cast (insert->plugin())) == 0) { + if ((vp = boost::dynamic_pointer_cast (insert->plugin())) == 0) { error << _("unknown type of editor-supplying plugin (note: no VST support in this version of ardour)") << endmsg; throw failed_constructor (); } else { - VSTPluginUI* vpu = new VSTPluginUI (insert, vp); - + WindowsVSTPluginUI* vpu = new WindowsVSTPluginUI (insert, vp); + _pluginui = vpu; + _pluginui->KeyboardFocused.connect (sigc::mem_fun (*this, &PluginUIWindow::keyboard_focused)); add (*vpu); vpu->package (*this); } - non_gtk_gui = true; return true; #endif } bool +#ifdef LXVST_SUPPORT +PluginUIWindow::create_lxvst_editor(boost::shared_ptr insert) +#else +PluginUIWindow::create_lxvst_editor(boost::shared_ptr) +#endif +{ +#ifndef LXVST_SUPPORT + return false; +#else + + boost::shared_ptr lxvp; + + if ((lxvp = boost::dynamic_pointer_cast (insert->plugin())) == 0) { + error << _("unknown type of editor-supplying plugin (note: no linuxVST support in this version of ardour)") + << endmsg; + throw failed_constructor (); + } else { + LXVSTPluginUI* lxvpu = new LXVSTPluginUI (insert, lxvp); + + _pluginui = lxvpu; + _pluginui->KeyboardFocused.connect (sigc::mem_fun (*this, &PluginUIWindow::keyboard_focused)); + add (*lxvpu); + lxvpu->package (*this); + } + + return true; +#endif +} + +bool +#ifdef AUDIOUNIT_SUPPORT PluginUIWindow::create_audiounit_editor (boost::shared_ptr insert) +#else +PluginUIWindow::create_audiounit_editor (boost::shared_ptr) +#endif { -#if !defined(HAVE_AUDIOUNITS) || !defined(GTKOSX) +#ifndef AUDIOUNIT_SUPPORT return false; #else VBox* box; _pluginui = create_au_gui (insert, &box); + _pluginui->KeyboardFocused.connect (sigc::mem_fun (*this, &PluginUIWindow::keyboard_focused)); add (*box); - non_gtk_gui = true; - extern sigc::signal ApplicationActivationChanged; - ApplicationActivationChanged.connect (mem_fun (*this, &PluginUIWindow::app_activated)); + Application::instance()->ActivationChanged.connect (mem_fun (*this, &PluginUIWindow::app_activated)); return true; #endif } void +#ifdef GTKOSX PluginUIWindow::app_activated (bool yn) +#else +PluginUIWindow::app_activated (bool) +#endif { -#if defined (HAVE_AUDIOUNITS) && defined(GTKOSX) - cerr << "APP activated ? " << yn << endl; +#ifdef AUDIOUNIT_SUPPORT if (_pluginui) { if (yn) { if (was_visible) { @@ -254,19 +349,16 @@ PluginUIWindow::app_activated (bool yn) hide (); _pluginui->deactivate (); } - } + } #endif } bool PluginUIWindow::create_lv2_editor(boost::shared_ptr insert) { -#ifndef HAVE_LV2 - return false; -#else - +#ifdef HAVE_SUIL boost::shared_ptr vp; - + if ((vp = boost::dynamic_pointer_cast (insert->plugin())) == 0) { error << _("create_lv2_editor called on non-LV2 plugin") << endmsg; throw failed_constructor (); @@ -277,132 +369,392 @@ PluginUIWindow::create_lv2_editor(boost::shared_ptr insert) lpu->package (*this); } - non_gtk_gui = false; return true; +#else + return false; #endif } +void +PluginUIWindow::keyboard_focused (bool yn) +{ + _keyboard_focused = yn; +} + bool PluginUIWindow::on_key_press_event (GdkEventKey* event) { - if (non_gtk_gui) { - return false; - } - - if (!key_press_focus_accelerator_handler (*this, event)) { - return PublicEditor::instance().on_key_press_event(event); - } else { + if (_keyboard_focused) { + if (_pluginui) { + if (_pluginui->non_gtk_gui()) { + _pluginui->forward_key_event (event); + } else { + return relay_key_press (event, this); + } + } return true; + } else { + /* for us to be getting key press events, there really + MUST be a _pluginui, but just to be safe, check ... + */ + + if (_pluginui) { + if (_pluginui->non_gtk_gui()) { + /* pass editor window as the window for the event + to be handled in, not this one, because there are + no widgets in this window that we want to have + key focus. + */ + return relay_key_press (event, &PublicEditor::instance()); + } else { + return relay_key_press (event, this); + } + } else { + return false; + } } } bool -PluginUIWindow::on_key_release_event (GdkEventKey* event) +PluginUIWindow::on_key_release_event (GdkEventKey *event) { - return true; + if (_keyboard_focused) { + if (_pluginui) { + if (_pluginui->non_gtk_gui()) { + _pluginui->forward_key_event (event); + } + return true; + } + return false; + } else { + return true; + } } void PluginUIWindow::plugin_going_away () { - ENSURE_GUI_THREAD(mem_fun(*this, &PluginUIWindow::plugin_going_away)); - + ENSURE_GUI_THREAD (*this, &PluginUIWindow::plugin_going_away) + if (_pluginui) { _pluginui->stop_updating(0); } + + death_connection.disconnect (); + delete_when_idle (this); } PlugUIBase::PlugUIBase (boost::shared_ptr pi) - : insert (pi), - plugin (insert->plugin()), - save_button(_("Add")), - bypass_button (_("Bypass")), - latency_gui (*pi, pi->session().frame_rate(), pi->session().get_block_size()) -{ - //preset_combo.set_use_arrows_always(true); - set_popdown_strings (preset_combo, plugin->get_presets()); - preset_combo.set_size_request (100, -1); - preset_combo.set_active_text (""); - preset_combo.signal_changed().connect(mem_fun(*this, &PlugUIBase::setting_selected)); + : insert (pi) + , plugin (insert->plugin()) + , add_button (_("Add")) + , save_button (_("Save")) + , delete_button (_("Delete")) + , bypass_button (ArdourButton::led_default_elements) + , plugin_analysis_expander (_("Plugin analysis")) + , latency_gui (0) + , latency_dialog (0) + , eqgui (0) +{ + _preset_modified.set_size_request (16, -1); + _preset_combo.signal_changed().connect(sigc::mem_fun(*this, &PlugUIBase::preset_selected)); + ARDOUR_UI::instance()->set_tip (_preset_combo, _("Presets (if any) for this plugin\n(Both factory and user-created)")); + ARDOUR_UI::instance()->set_tip (add_button, _("Save a new preset")); + ARDOUR_UI::instance()->set_tip (save_button, _("Save the current preset")); + ARDOUR_UI::instance()->set_tip (delete_button, _("Delete the current preset")); + ARDOUR_UI::instance()->set_tip (bypass_button, _("Disable signal processing by the plugin")); + _no_load_preset = 0; + + update_preset_list (); + update_preset (); + + add_button.set_name ("PluginAddButton"); + add_button.signal_clicked().connect (sigc::mem_fun (*this, &PlugUIBase::add_plugin_setting)); save_button.set_name ("PluginSaveButton"); - save_button.signal_clicked().connect(mem_fun(*this, &PlugUIBase::save_plugin_setting)); + save_button.signal_clicked().connect(sigc::mem_fun(*this, &PlugUIBase::save_plugin_setting)); - insert->ActiveChanged.connect (bind( - mem_fun(*this, &PlugUIBase::processor_active_changed), - boost::weak_ptr(insert))); - + delete_button.set_name ("PluginDeleteButton"); + delete_button.signal_clicked().connect (sigc::mem_fun (*this, &PlugUIBase::delete_plugin_setting)); + + insert->ActiveChanged.connect (active_connection, invalidator (*this), boost::bind (&PlugUIBase::processor_active_changed, this, boost::weak_ptr(insert)), gui_context()); + + bypass_button.set_name ("plugin bypass button"); + bypass_button.set_text (_("Bypass")); bypass_button.set_active (!pi->active()); + bypass_button.signal_button_release_event().connect (sigc::mem_fun(*this, &PlugUIBase::bypass_button_release)); + focus_button.add_events (Gdk::ENTER_NOTIFY_MASK|Gdk::LEAVE_NOTIFY_MASK); + + focus_button.signal_button_release_event().connect (sigc::mem_fun(*this, &PlugUIBase::focus_toggled)); + focus_button.add_events (Gdk::ENTER_NOTIFY_MASK|Gdk::LEAVE_NOTIFY_MASK); + + /* these images are not managed, so that we can remove them at will */ + + focus_out_image = new Image (get_icon (X_("computer_keyboard"))); + focus_in_image = new Image (get_icon (X_("computer_keyboard_active"))); + + focus_button.add (*focus_out_image); - bypass_button.set_name ("PluginBypassButton"); - bypass_button.signal_toggled().connect (mem_fun(*this, &PlugUIBase::bypass_toggled)); + ARDOUR_UI::instance()->set_tip (focus_button, string_compose (_("Click to allow the plugin to receive keyboard events that %1 would normally use as a shortcut"), PROGRAM_NAME)); + ARDOUR_UI::instance()->set_tip (bypass_button, _("Click to enable/disable this plugin")); + + plugin_analysis_expander.property_expanded().signal_changed().connect( sigc::mem_fun(*this, &PlugUIBase::toggle_plugin_analysis)); + plugin_analysis_expander.set_expanded(false); + + insert->DropReferences.connect (death_connection, invalidator (*this), boost::bind (&PlugUIBase::plugin_going_away, this), gui_context()); + + plugin->PresetAdded.connect (*this, invalidator (*this), boost::bind (&PlugUIBase::preset_added_or_removed, this), gui_context ()); + plugin->PresetRemoved.connect (*this, invalidator (*this), boost::bind (&PlugUIBase::preset_added_or_removed, this), gui_context ()); + plugin->PresetLoaded.connect (*this, invalidator (*this), boost::bind (&PlugUIBase::update_preset, this), gui_context ()); + plugin->ParameterChanged.connect (*this, invalidator (*this), boost::bind (&PlugUIBase::parameter_changed, this, _1, _2), gui_context ()); +} + +PlugUIBase::~PlugUIBase() +{ + delete eqgui; + delete latency_gui; +} + +void +PlugUIBase::plugin_going_away () +{ + /* drop references to the plugin/insert */ + insert.reset (); + plugin.reset (); + death_connection.disconnect (); +} + +void +PlugUIBase::set_latency_label () +{ + framecnt_t const l = insert->effective_latency (); + framecnt_t const sr = insert->session().frame_rate (); + + string t; + + if (l < sr / 1000) { + t = string_compose (_("latency (%1 samples)"), l); + } else { + t = string_compose (_("latency (%1 ms)"), (float) l / ((float) sr / 1000.0f)); + } + + latency_label.set_text (t); +} + +void +PlugUIBase::latency_button_clicked () +{ + if (!latency_gui) { + latency_gui = new LatencyGUI (*(insert.get()), insert->session().frame_rate(), insert->session().get_block_size()); + latency_dialog = new ArdourWindow (_("Edit Latency")); + latency_dialog->add (*latency_gui); + latency_dialog->signal_hide().connect (sigc::mem_fun (*this, &PlugUIBase::set_latency_label)); + } + + latency_dialog->show_all (); } void PlugUIBase::processor_active_changed (boost::weak_ptr weak_p) { - ENSURE_GUI_THREAD(bind (mem_fun(*this, &PlugUIBase::processor_active_changed), weak_p)); - boost::shared_ptr p (weak_p); + ENSURE_GUI_THREAD (*this, &PlugUIBase::processor_active_changed, weak_p); + boost::shared_ptr p (weak_p.lock()); + if (p) { bypass_button.set_active (!p->active()); } } void -PlugUIBase::setting_selected() +PlugUIBase::preset_selected () { - if (preset_combo.get_active_text().length() > 0) { - if (!plugin->load_preset(preset_combo.get_active_text())) { - warning << string_compose(_("Plugin preset %1 not found"), preset_combo.get_active_text()) << endmsg; + if (_no_load_preset) { + return; + } + + if (_preset_combo.get_active_text().length() > 0) { + const Plugin::PresetRecord* pr = plugin->preset_by_label (_preset_combo.get_active_text()); + if (pr) { + plugin->load_preset (*pr); + } else { + warning << string_compose(_("Plugin preset %1 not found"), + _preset_combo.get_active_text()) << endmsg; } } } void -PlugUIBase::save_plugin_setting () +PlugUIBase::add_plugin_setting () { - ArdourPrompter prompter (true); - prompter.set_prompt(_("Name of New Preset:")); - prompter.add_button (Gtk::Stock::ADD, Gtk::RESPONSE_ACCEPT); - prompter.set_response_sensitive (Gtk::RESPONSE_ACCEPT, false); - - prompter.show_all(); + NewPluginPresetDialog d (plugin); - switch (prompter.run ()) { + switch (d.run ()) { case Gtk::RESPONSE_ACCEPT: + if (d.name().empty()) { + break; + } - string name; - - prompter.get_result(name); + if (d.replace ()) { + plugin->remove_preset (d.name ()); + } - if (name.length()) { - if(plugin->save_preset(name)){ - set_popdown_strings (preset_combo, plugin->get_presets()); - preset_combo.set_active_text (name); - } + Plugin::PresetRecord const r = plugin->save_preset (d.name()); + if (!r.uri.empty ()) { + plugin->load_preset (r); } break; } } void -PlugUIBase::bypass_toggled () +PlugUIBase::save_plugin_setting () { - bool x; + string const name = _preset_combo.get_active_text (); + plugin->remove_preset (name); + Plugin::PresetRecord const r = plugin->save_preset (name); + if (!r.uri.empty ()) { + plugin->load_preset (r); + } +} + +void +PlugUIBase::delete_plugin_setting () +{ + plugin->remove_preset (_preset_combo.get_active_text ()); +} - if ((x = bypass_button.get_active()) == insert->active()) { - insert->set_active (!x); - if (insert->active()) { - bypass_button.set_label (_("Bypass")); +bool +PlugUIBase::bypass_button_release (GdkEventButton*) +{ + bool view_says_bypassed = (bypass_button.active_state() != 0); + + if (view_says_bypassed != insert->active()) { + if (view_says_bypassed) { + insert->activate (); } else { - bypass_button.set_label (_("Active")); + insert->deactivate (); + } + } + + return false; +} + +bool +PlugUIBase::focus_toggled (GdkEventButton*) +{ + if (Keyboard::the_keyboard().some_magic_widget_has_focus()) { + Keyboard::the_keyboard().magic_widget_drop_focus(); + focus_button.remove (); + focus_button.add (*focus_out_image); + focus_out_image->show (); + ARDOUR_UI::instance()->set_tip (focus_button, string_compose (_("Click to allow the plugin to receive keyboard events that %1 would normally use as a shortcut"), PROGRAM_NAME)); + KeyboardFocused (false); + } else { + Keyboard::the_keyboard().magic_widget_grab_focus(); + focus_button.remove (); + focus_button.add (*focus_in_image); + focus_in_image->show (); + ARDOUR_UI::instance()->set_tip (focus_button, string_compose (_("Click to allow normal use of %1 keyboard shortcuts"), PROGRAM_NAME)); + KeyboardFocused (true); + } + + return true; +} + +void +PlugUIBase::toggle_plugin_analysis() +{ + if (plugin_analysis_expander.get_expanded() && + !plugin_analysis_expander.get_child()) { + // Create the GUI + if (eqgui == 0) { + eqgui = new PluginEqGui (insert); } + + Gtk::Window *toplevel = (Gtk::Window*) plugin_analysis_expander.get_ancestor (GTK_TYPE_WINDOW); + + if (toplevel) { + toplevel->get_size (pre_eq_size.width, pre_eq_size.height); + } + + plugin_analysis_expander.add (*eqgui); + plugin_analysis_expander.show_all (); + eqgui->start_listening (); + } + + if (!plugin_analysis_expander.get_expanded()) { + + // Hide & remove from expander + + eqgui->hide (); + eqgui->stop_listening (); + plugin_analysis_expander.remove(); + + Gtk::Window *toplevel = (Gtk::Window*) plugin_analysis_expander.get_ancestor (GTK_TYPE_WINDOW); + + if (toplevel) { + toplevel->resize (pre_eq_size.width, pre_eq_size.height); + } + } +} + +void +PlugUIBase::update_preset_list () +{ + vector preset_labels; + vector presets = plugin->get_presets(); + + ++_no_load_preset; + + for (vector::const_iterator i = presets.begin(); i != presets.end(); ++i) { + preset_labels.push_back (i->label); } + + set_popdown_strings (_preset_combo, preset_labels); + + --_no_load_preset; +} + +void +PlugUIBase::update_preset () +{ + Plugin::PresetRecord p = plugin->last_preset(); + + ++_no_load_preset; + _preset_combo.set_active_text (p.label); + --_no_load_preset; + + save_button.set_sensitive (!p.uri.empty() && p.user); + delete_button.set_sensitive (!p.uri.empty() && p.user); + + update_preset_modified (); +} + +void +PlugUIBase::update_preset_modified () +{ + if (plugin->last_preset().uri.empty()) { + _preset_modified.set_text (""); + return; + } + + bool const c = plugin->parameter_changed_since_last_preset (); + if (_preset_modified.get_text().empty() == c) { + _preset_modified.set_text (c ? "*" : ""); + } +} + +void +PlugUIBase::parameter_changed (uint32_t, float) +{ + update_preset_modified (); } void -PlugUIBase::update_presets () +PlugUIBase::preset_added_or_removed () { - set_popdown_strings (preset_combo, plugin->get_presets()); + /* Update both the list and the currently-displayed preset */ + update_preset_list (); + update_preset (); }