X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=gtk2_ardour%2Fstrip_silence_dialog.cc;h=d8022444072b50ae7c6138d6c028ce5c64b9895d;hb=65f215bb4cac5eaada3eddab7c5c08e66788726d;hp=2fb4b5923f9cd122a96f321fed20f6f03a52467a;hpb=3cd8138a419cb165f56070ace0b21a1e63ec5a43;p=ardour.git diff --git a/gtk2_ardour/strip_silence_dialog.cc b/gtk2_ardour/strip_silence_dialog.cc index 2fb4b5923f..d802244407 100644 --- a/gtk2_ardour/strip_silence_dialog.cc +++ b/gtk2_ardour/strip_silence_dialog.cc @@ -30,11 +30,7 @@ #include "audio_clock.h" #include "gui_thread.h" #include "strip_silence_dialog.h" -#include "canvas_impl.h" #include "region_view.h" -#include "simpleline.h" -#include "waveview.h" -#include "simplerect.h" #include "rgb_macros.h" #include "i18n.h" #include "logmeter.h" @@ -47,16 +43,15 @@ using namespace ArdourCanvas; StripSilenceDialog::StripSilenceDialog (Session* s, list const & v) : ArdourDialog (_("Strip Silence")) , ProgressReporter () - , _minimum_length (new AudioClock (X_("silence duration"), true, "", true, false, true, false)) - , _fade_length (new AudioClock (X_("silence duration"), true, "", true, false, true, false)) - , _peaks_ready_connection (0) + , _minimum_length (new AudioClock (X_("silence duration"), true, "", true, false, true, false)) + , _fade_length (new AudioClock (X_("silence duration"), true, "", true, false, true, false)) , _destroying (false) { - set_session (s); + set_session (s); - for (list::const_iterator r = v.begin(); r != v.end(); ++r) { - views.push_back (ViewInterval (*r)); - } + for (list::const_iterator r = v.begin(); r != v.end(); ++r) { + views.push_back (ViewInterval (*r)); + } Gtk::HBox* hbox = Gtk::manage (new Gtk::HBox); @@ -80,38 +75,39 @@ StripSilenceDialog::StripSilenceDialog (Session* s, list const & v) table->attach (*_minimum_length, 1, 2, n, n + 1, Gtk::FILL); ++n; - _minimum_length->set_session (s); - _minimum_length->set_mode (AudioClock::Frames); - _minimum_length->set (1000, true); + _minimum_length->set_session (s); + _minimum_length->set_mode (AudioClock::Frames); + _minimum_length->set (1000, true); table->attach (*Gtk::manage (new Gtk::Label (_("Fade length"), 1, 0.5)), 0, 1, n, n + 1, Gtk::FILL); - table->attach (*_fade_length, 1, 2, n, n + 1, Gtk::FILL); + table->attach (*_fade_length, 1, 2, n, n + 1, Gtk::FILL); ++n; - _fade_length->set_session (s); - _fade_length->set_mode (AudioClock::Frames); - _fade_length->set (64, true); + _fade_length->set_session (s); + _fade_length->set_mode (AudioClock::Frames); + _fade_length->set (64, true); hbox->pack_start (*table); get_vbox()->pack_start (*hbox, false, false); - add_button (Gtk::Stock::CANCEL, Gtk::RESPONSE_CANCEL); - add_button (Gtk::Stock::APPLY, Gtk::RESPONSE_OK); + cancel_button = add_button (Gtk::Stock::CANCEL, Gtk::RESPONSE_CANCEL); + apply_button = add_button (Gtk::Stock::APPLY, Gtk::RESPONSE_OK); set_default_response (Gtk::RESPONSE_OK); get_vbox()->pack_start (_progress_bar, true, true, 12); show_all (); - _threshold.get_adjustment()->signal_value_changed().connect (sigc::mem_fun (*this, &StripSilenceDialog::threshold_changed)); - _minimum_length->ValueChanged.connect (sigc::mem_fun (*this, &StripSilenceDialog::restart_thread)); + _threshold.get_adjustment()->signal_value_changed().connect (sigc::mem_fun (*this, &StripSilenceDialog::threshold_changed)); + _minimum_length->ValueChanged.connect (sigc::mem_fun (*this, &StripSilenceDialog::restart_thread)); + _fade_length->ValueChanged.connect (sigc::mem_fun (*this, &StripSilenceDialog::restart_thread)); update_silence_rects (); update_threshold_line (); /* Create a thread which runs while the dialogue is open to compute the silence regions */ - Completed.connect (_completed_connection, MISSING_INVALIDATOR, boost::bind (&StripSilenceDialog::update, this), gui_context ()); + Completed.connect (_completed_connection, invalidator(*this), boost::bind (&StripSilenceDialog::update, this), gui_context ()); _thread_should_finish = false; pthread_create (&_thread, 0, StripSilenceDialog::_detection_thread_work, this); } @@ -122,7 +118,6 @@ StripSilenceDialog::~StripSilenceDialog () _destroying = true; /* Terminate our thread */ - _lock.lock (); _interthread_info.cancel = true; _thread_should_finish = true; @@ -133,25 +128,29 @@ StripSilenceDialog::~StripSilenceDialog () delete _minimum_length; delete _fade_length; - - delete _peaks_ready_connection; } void StripSilenceDialog::silences (AudioIntervalMap& m) { - for (list::iterator v = views.begin(); v != views.end(); ++v) { - pair,AudioIntervalResult> newpair (v->view->region(), v->intervals); - m.insert (newpair); - } + for (list::iterator v = views.begin(); v != views.end(); ++v) { + pair,AudioIntervalResult> newpair (v->view->region(), v->intervals); + m.insert (newpair); + } } void StripSilenceDialog::drop_rects () { - for (list::iterator v = views.begin(); v != views.end(); ++v) { - v->view->drop_silent_frames (); - } + // called by parent when starting to progess (dialog::run returned), + // but before the dialog is destoyed. + + for (list::iterator v = views.begin(); v != views.end(); ++v) { + v->view->drop_silent_frames (); + } + + cancel_button->set_sensitive (false); + apply_button->set_sensitive (false); } void @@ -188,10 +187,10 @@ StripSilenceDialog::update_silence_rects () { /* Lock so that we don't contend with the detection thread for access to the silence regions */ Glib::Threads::Mutex::Lock lm (_lock); - double const y = _threshold.get_value(); + double const y = _threshold.get_value(); - for (list::iterator v = views.begin(); v != views.end(); ++v) { - v->view->set_silent_frames (v->intervals, y); + for (list::iterator v = views.begin(); v != views.end(); ++v) { + v->view->set_silent_frames (v->intervals, y); } } @@ -206,18 +205,18 @@ StripSilenceDialog::_detection_thread_work (void* arg) void * StripSilenceDialog::detection_thread_work () { - ARDOUR_UI::instance()->register_thread ("gui", pthread_self(), "silence", 32); + ARDOUR_UI::instance()->register_thread ("gui", pthread_self(), "silence", 32); /* Hold this lock when we are doing work */ _lock.lock (); while (1) { for (list::iterator i = views.begin(); i != views.end(); ++i) { - boost::shared_ptr ar = boost::dynamic_pointer_cast ((*i).view->region()); + boost::shared_ptr ar = boost::dynamic_pointer_cast ((*i).view->region()); - if (ar) { - i->intervals = ar->find_silence (dB_to_coefficient (threshold ()), minimum_length (), _interthread_info); - } + if (ar) { + i->intervals = ar->find_silence (dB_to_coefficient (threshold ()), minimum_length (), fade_length(), _interthread_info); + } if (_interthread_info.cancel) { break; @@ -250,7 +249,7 @@ StripSilenceDialog::restart_thread () method to be called after our destructor has finished executing. If this happens, bad things follow; _lock cannot be locked and Ardour hangs. So if we are destroying, just bail early. - */ + */ return; } @@ -277,13 +276,13 @@ StripSilenceDialog::threshold_changed () framecnt_t StripSilenceDialog::minimum_length () const { - return _minimum_length->current_duration (views.front().view->region()->position()); + return std::max((framecnt_t)1, _minimum_length->current_duration (views.front().view->region()->position())); } framecnt_t StripSilenceDialog::fade_length () const { - return _fade_length->current_duration (views.front().view->region()->position()); + return std::max((framecnt_t)0, _fade_length->current_duration (views.front().view->region()->position())); } void