X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=libs%2Fardour%2Fcontrol_protocol_manager.cc;h=6a8dd77d55c21a890c14f912c06640bba2c37599;hb=d345d446883c0425f8312149d04abc62076e36fc;hp=47f8d5bf983095ff0dcab481e4efaed6bae971d3;hpb=f6fdd8dcbf41f864e9f0cc32dabe81fe3533ddfe;p=ardour.git

diff --git a/libs/ardour/control_protocol_manager.cc b/libs/ardour/control_protocol_manager.cc
index 47f8d5bf98..6a8dd77d55 100644
--- a/libs/ardour/control_protocol_manager.cc
+++ b/libs/ardour/control_protocol_manager.cc
@@ -25,6 +25,7 @@
 
 #include "control_protocol/control_protocol.h"
 
+#include "ardour/debug.h"
 #include "ardour/session.h"
 #include "ardour/control_protocol_manager.h"
 #include "ardour/control_protocol_search_path.h"
@@ -73,7 +74,7 @@ ControlProtocolManager::set_session (Session* s)
 			if ((*i)->requested || (*i)->mandatory) {
 				instantiate (**i);
 				(*i)->requested = false;
-				
+
 				if ((*i)->protocol && (*i)->state) {
 					(*i)->protocol->set_state (*(*i)->state, Stateful::loading_state_version);
 				}
@@ -110,6 +111,8 @@ ControlProtocolManager::session_going_away()
 ControlProtocol*
 ControlProtocolManager::instantiate (ControlProtocolInfo& cpi)
 {
+	/* CALLER MUST HOLD LOCK */
+
 	if (_session == 0) {
 		return 0;
 	}
@@ -126,8 +129,6 @@ ControlProtocolManager::instantiate (ControlProtocolInfo& cpi)
 		return 0;
 	}
 
-
-	Glib::Mutex::Lock lm (protocols_lock);
 	control_protocols.push_back (cpi.protocol);
 
 	return cpi.protocol;
@@ -172,9 +173,12 @@ ControlProtocolManager::load_mandatory_protocols ()
 		return;
 	}
 
+	Glib::Mutex::Lock lm (protocols_lock);
+
 	for (list<ControlProtocolInfo*>::iterator i = control_protocol_info.begin(); i != control_protocol_info.end(); ++i) {
 		if ((*i)->mandatory && ((*i)->protocol == 0)) {
-			info << string_compose (_("Instantiating mandatory control protocol %1"), (*i)->name) << endmsg;
+			DEBUG_TRACE (DEBUG::ControlProtocols,
+				     string_compose (_("Instantiating mandatory control protocol %1"), (*i)->name));
 			instantiate (**i);
 		}
 	}
@@ -194,8 +198,9 @@ ControlProtocolManager::discover_control_protocols ()
 	find_matching_files_in_search_path (control_protocol_search_path (),
 			dylib_extension_pattern, cp_modules);
 
-	info << string_compose (_("looking for control protocols in %1"), control_protocol_search_path().to_string()) << endmsg;
-
+	DEBUG_TRACE (DEBUG::ControlProtocols, 
+		     string_compose (_("looking for control protocols in %1"), control_protocol_search_path().to_string()));
+	
 	for (vector<sys::path>::iterator i = cp_modules.begin(); i != cp_modules.end(); ++i) {
 		control_protocol_discover ((*i).to_string());
 	}
@@ -208,12 +213,13 @@ ControlProtocolManager::control_protocol_discover (string path)
 
 	if ((descriptor = get_descriptor (path)) != 0) {
 
-		ControlProtocolInfo* cpi = new ControlProtocolInfo ();
-
 		if (!descriptor->probe (descriptor)) {
-			info << string_compose (_("Control protocol %1 not usable"), descriptor->name) << endmsg;
+			DEBUG_TRACE (DEBUG::ControlProtocols,
+				     string_compose (_("Control protocol %1 not usable"), descriptor->name));
 		} else {
 
+			ControlProtocolInfo* cpi = new ControlProtocolInfo ();
+
 			cpi->descriptor = descriptor;
 			cpi->name = descriptor->name;
 			cpi->path = path;
@@ -225,7 +231,8 @@ ControlProtocolManager::control_protocol_discover (string path)
 
 			control_protocol_info.push_back (cpi);
 
-			info << string_compose(_("Control surface protocol discovered: \"%1\""), cpi->name) << endmsg;
+			DEBUG_TRACE (DEBUG::ControlProtocols, 
+				     string_compose(_("Control surface protocol discovered: \"%1\""), cpi->name));
 		}
 
 		dlclose (descriptor->module);
@@ -293,6 +300,8 @@ ControlProtocolManager::set_state (const XMLNode& node, int /*version*/)
 	XMLNodeConstIterator citer;
 	XMLProperty* prop;
 
+	Glib::Mutex::Lock lm (protocols_lock);
+
 	clist = node.children();
 
 	for (citer = clist.begin(); citer != clist.end(); ++citer) {
@@ -324,7 +333,7 @@ ControlProtocolManager::set_state (const XMLNode& node, int /*version*/)
 }
 
 XMLNode&
-ControlProtocolManager::get_state (void)
+ControlProtocolManager::get_state ()
 {
 	XMLNode* root = new XMLNode (state_node_name);
 	Glib::Mutex::Lock lm (protocols_lock);
@@ -338,12 +347,10 @@ ControlProtocolManager::get_state (void)
 			child->add_property (X_("active"), "yes");
 			// should we update (*i)->state here?  probably.
 			root->add_child_nocopy (*child);
-		}
-		else if ((*i)->state) {
+		} else if ((*i)->state) {
 			// keep ownership clear
 			root->add_child_copy (*(*i)->state);
-		}
-		else {
+		} else {
 			child = new XMLNode (X_("Protocol"));
 			child->add_property (X_("name"), (*i)->name);
 			child->add_property (X_("active"), "no");