X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=libs%2Fardour%2Fmidi_model.cc;h=b5e93ae494e829a719a9b4e0a48496c5920ded1f;hb=24b514797ab265bf48eb93d6c2c812ce5232fdba;hp=1297b0c3ea831f4694e04c123280d9cc18850d28;hpb=110311e1860d6fb18b1985ca47f33126ae69f678;p=ardour.git diff --git a/libs/ardour/midi_model.cc b/libs/ardour/midi_model.cc index 1297b0c3ea..b5e93ae494 100644 --- a/libs/ardour/midi_model.cc +++ b/libs/ardour/midi_model.cc @@ -18,23 +18,27 @@ */ -#include -#include #include +#include +#include #include #include -#include "pbd/error.h" -#include "pbd/enumwriter.h" + #include "pbd/compose.h" +#include "pbd/enumwriter.h" +#include "pbd/error.h" + +#include "evoral/Control.hpp" + #include "midi++/events.h" +#include "ardour/automation_control.h" +#include "ardour/midi_automation_list_binder.h" #include "ardour/midi_model.h" #include "ardour/midi_source.h" #include "ardour/midi_state_tracker.h" -#include "ardour/smf_source.h" -#include "ardour/types.h" #include "ardour/session.h" -#include "ardour/midi_automation_list_binder.h" +#include "ardour/types.h" #include "i18n.h" @@ -59,7 +63,7 @@ MidiModel::new_note_diff_command (const string name) { boost::shared_ptr ms = _midi_source.lock (); assert (ms); - + return new NoteDiffCommand (ms->model(), name); } @@ -69,7 +73,7 @@ MidiModel::new_sysex_diff_command (const string name) { boost::shared_ptr ms = _midi_source.lock (); assert (ms); - + return new SysExDiffCommand (ms->model(), name); } @@ -79,7 +83,7 @@ MidiModel::new_patch_change_diff_command (const string name) { boost::shared_ptr ms = _midi_source.lock (); assert (ms); - + return new PatchChangeDiffCommand (ms->model(), name); } @@ -160,84 +164,55 @@ MidiModel::NoteDiffCommand::side_effect_remove (const NotePtr note) side_effect_removals.insert (note); } -void -MidiModel::NoteDiffCommand::change (const NotePtr note, Property prop, - uint8_t new_value) +Variant +MidiModel::NoteDiffCommand::get_value (const NotePtr note, Property prop) { - assert (note); - - NoteChange change; - switch (prop) { case NoteNumber: - if (new_value == note->note()) { - return; - } - change.old_value = note->note(); - break; + return Variant(note->note()); case Velocity: - if (new_value == note->velocity()) { - return; - } - change.old_value = note->velocity(); - break; + return Variant(note->velocity()); case Channel: - if (new_value == note->channel()) { - return; - } - change.old_value = note->channel(); - break; - - + return Variant(note->channel()); case StartTime: - fatal << "MidiModel::DiffCommand::change() with integer argument called for start time" << endmsg; - /*NOTREACHED*/ - break; + return Variant(note->time()); case Length: - fatal << "MidiModel::DiffCommand::change() with integer argument called for length" << endmsg; - /*NOTREACHED*/ - break; + return Variant(note->length()); } - change.note = note; - change.property = prop; - change.new_value = new_value; - - _changes.push_back (change); + return Variant(); } -void -MidiModel::NoteDiffCommand::change (const NotePtr note, Property prop, - TimeType new_time) +Variant::Type +MidiModel::NoteDiffCommand::value_type(Property prop) { - assert (note); - - NoteChange change; - switch (prop) { case NoteNumber: - case Channel: case Velocity: - fatal << "MidiModel::NoteDiffCommand::change() with time argument called for note, channel or velocity" << endmsg; - break; - + case Channel: + return Variant::INT; case StartTime: - if (Evoral::musical_time_equal (note->time(), new_time)) { - return; - } - change.old_time = note->time(); - break; case Length: - if (Evoral::musical_time_equal (note->length(), new_time)) { - return; - } - change.old_time = note->length(); - break; + return Variant::BEATS; } - change.note = note; - change.property = prop; - change.new_time = new_time; + return Variant::NOTHING; +} + +void +MidiModel::NoteDiffCommand::change (const NotePtr note, + Property prop, + const Variant& new_value) +{ + assert (note); + + const NoteChange change = { + prop, note, 0, get_value(note, prop), new_value + }; + + if (change.old_value == new_value) { + return; + } _changes.push_back (change); } @@ -285,22 +260,30 @@ MidiModel::NoteDiffCommand::operator() () for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { Property prop = i->property; + + if (!i->note) { + /* note found during deserialization, so try + again now that the model state is different. + */ + i->note = _model->find_note (i->note_id); + assert (i->note); + } + switch (prop) { case NoteNumber: if (temporary_removals.find (i->note) == temporary_removals.end()) { _model->remove_note_unlocked (i->note); temporary_removals.insert (i->note); } - i->note->set_note (i->new_value); + i->note->set_note (i->new_value.get_int()); break; case StartTime: if (temporary_removals.find (i->note) == temporary_removals.end()) { _model->remove_note_unlocked (i->note); temporary_removals.insert (i->note); - } - i->note->set_time (i->new_time); + i->note->set_time (i->new_value.get_beats()); break; case Channel: @@ -308,24 +291,23 @@ MidiModel::NoteDiffCommand::operator() () _model->remove_note_unlocked (i->note); temporary_removals.insert (i->note); } - i->note->set_channel (i->new_value); + i->note->set_channel (i->new_value.get_int()); break; /* no remove-then-add required for these properties, since we do not index them */ case Velocity: - i->note->set_velocity (i->new_value); + i->note->set_velocity (i->new_value.get_int()); break; case Length: - i->note->set_length (i->new_time); + i->note->set_length (i->new_value.get_beats()); break; } } - for (set::iterator i = temporary_removals.begin(); i != temporary_removals.end(); ++i) { NoteDiffCommand side_effects (model(), "side effects"); if (_model->add_note_unlocked (*i, &side_effects)) { @@ -333,23 +315,9 @@ MidiModel::NoteDiffCommand::operator() () *this += side_effects; } else { /* The note that we removed earlier could not be re-added. This change record - must say that the note was removed. It is an un-note. + must say that the note was removed. We'll keep the changes we made, though, + as if the note is re-added by the undo the changes must also be undone. */ - - /* We didn't change it... */ - for (ChangeList::iterator j = _changes.begin(); j != _changes.end(); ) { - - ChangeList::iterator k = j; - ++k; - - if (*i == j->note) { - _changes.erase (j); - } - - j = k; - } - - /* ...in fact, we removed it */ _removed_notes.push_back (*i); } } @@ -375,46 +343,89 @@ MidiModel::NoteDiffCommand::undo () _model->remove_note_unlocked(*i); } - for (NoteList::iterator i = _removed_notes.begin(); i != _removed_notes.end(); ++i) { - _model->add_note_unlocked(*i); - } + /* Apply changes first; this is important in the case of a note change which + resulted in the note being removed by the overlap checker. If the overlap + checker removes a note, it will be in _removed_notes. We are going to re-add + it below, but first we must undo the changes we made so that the overlap + checker doesn't refuse the re-add. + */ /* notes we modify in a way that requires remove-then-add to maintain ordering */ set temporary_removals; + + /* lazily discover any affected notes that were not discovered when + * loading the history because of deletions, etc. + */ + + for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { + if (!i->note) { + i->note = _model->find_note (i->note_id); + assert (i->note); + } + } + for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { Property prop = i->property; + switch (prop) { case NoteNumber: - if (temporary_removals.find (i->note) == temporary_removals.end()) { + if (temporary_removals.find (i->note) == temporary_removals.end() && + find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) { + + /* We only need to mark this note for re-add if (a) we haven't + already marked it and (b) it isn't on the _removed_notes + list (which means that it has already been removed and it + will be re-added anyway) + */ + _model->remove_note_unlocked (i->note); temporary_removals.insert (i->note); } - i->note->set_note (i->old_value); - break; - case Velocity: - i->note->set_velocity (i->old_value); + i->note->set_note (i->old_value.get_int()); break; + case StartTime: - if (temporary_removals.find (i->note) == temporary_removals.end()) { + if (temporary_removals.find (i->note) == temporary_removals.end() && + find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) { + + /* See above ... */ + _model->remove_note_unlocked (i->note); temporary_removals.insert (i->note); } - i->note->set_time (i->old_time); - break; - case Length: - i->note->set_length (i->old_time); + i->note->set_time (i->old_value.get_beats()); break; + case Channel: - if (temporary_removals.find (i->note) == temporary_removals.end()) { + if (temporary_removals.find (i->note) == temporary_removals.end() && + find (_removed_notes.begin(), _removed_notes.end(), i->note) == _removed_notes.end()) { + + /* See above ... */ + _model->remove_note_unlocked (i->note); temporary_removals.insert (i->note); } - i->note->set_channel (i->old_value); + i->note->set_channel (i->old_value.get_int()); + break; + + /* no remove-then-add required for these properties, since we do not index them + */ + + case Velocity: + i->note->set_velocity (i->old_value.get_int()); + break; + + case Length: + i->note->set_length (i->old_value.get_beats()); break; } } + for (NoteList::iterator i = _removed_notes.begin(); i != _removed_notes.end(); ++i) { + _model->add_note_unlocked(*i); + } + for (set::iterator i = temporary_removals.begin(); i != temporary_removals.end(); ++i) { _model->add_note_unlocked (*i); } @@ -480,10 +491,10 @@ Evoral::Sequence::NotePtr MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note) { unsigned int note; - XMLProperty* prop; + XMLProperty const * prop; unsigned int channel; - unsigned int time; - unsigned int length; + MidiModel::TimeType time; + MidiModel::TimeType length; unsigned int velocity; gint id; @@ -516,7 +527,7 @@ MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note) time_str >> time; } else { warning << "note information missing time" << endmsg; - time = 0; + time = MidiModel::TimeType(); } if ((prop = xml_note->property("length")) != 0) { @@ -524,7 +535,7 @@ MidiModel::NoteDiffCommand::unmarshal_note (XMLNode *xml_note) length_str >> length; } else { warning << "note information missing length" << endmsg; - length = 1; + length = MidiModel::TimeType(1); } if ((prop = xml_note->property("velocity")) != 0) { @@ -553,9 +564,9 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change) { ostringstream old_value_str (ios::ate); if (change.property == StartTime || change.property == Length) { - old_value_str << change.old_time; + old_value_str << change.old_value.get_beats(); } else { - old_value_str << (unsigned int) change.old_value; + old_value_str << change.old_value.get_int(); } xml_change->add_property ("old", old_value_str.str()); } @@ -563,16 +574,24 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change) { ostringstream new_value_str (ios::ate); if (change.property == StartTime || change.property == Length) { - new_value_str << change.new_time; + new_value_str << change.new_value.get_beats(); } else { - new_value_str << (unsigned int) change.new_value; + new_value_str << change.new_value.get_int(); } xml_change->add_property ("new", new_value_str.str()); } ostringstream id_str; - id_str << change.note->id(); - xml_change->add_property ("id", id_str.str()); + if (change.note) { + id_str << change.note->id(); + xml_change->add_property ("id", id_str.str()); + } else if (change.note_id) { + warning << _("Change has no note, using note ID") << endmsg; + id_str << change.note_id; + xml_change->add_property ("id", id_str.str()); + } else { + error << _("Change has no note or note ID") << endmsg; + } return *xml_change; } @@ -580,14 +599,15 @@ MidiModel::NoteDiffCommand::marshal_change (const NoteChange& change) MidiModel::NoteDiffCommand::NoteChange MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change) { - XMLProperty* prop; + XMLProperty const * prop; NoteChange change; + change.note_id = 0; if ((prop = xml_change->property("property")) != 0) { change.property = (Property) string_2_enum (prop->value(), change.property); } else { fatal << "!!!" << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } if ((prop = xml_change->property ("id")) == 0) { @@ -600,7 +620,9 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change) if ((prop = xml_change->property ("old")) != 0) { istringstream old_str (prop->value()); if (change.property == StartTime || change.property == Length) { - old_str >> change.old_time; + Evoral::Beats old_time; + old_str >> old_time; + change.old_value = old_time; } else { int integer_value_so_that_istream_does_the_right_thing; old_str >> integer_value_so_that_istream_does_the_right_thing; @@ -608,13 +630,15 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change) } } else { fatal << "!!!" << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } if ((prop = xml_change->property ("new")) != 0) { istringstream new_str (prop->value()); if (change.property == StartTime || change.property == Length) { - new_str >> change.new_time; + Evoral::Beats new_time; + new_str >> new_time; + change.new_value = Variant(new_time); } else { int integer_value_so_that_istream_does_the_right_thing; new_str >> integer_value_so_that_istream_does_the_right_thing; @@ -622,19 +646,17 @@ MidiModel::NoteDiffCommand::unmarshal_change (XMLNode *xml_change) } } else { fatal << "!!!" << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } /* we must point at the instance of the note that is actually in the model. - so go look for it ... + so go look for it ... it may not be there (it could have been + deleted in a later operation, so store the note id so that we can + look it up again later). */ change.note = _model->find_note (note_id); - - if (!change.note) { - warning << "MIDI note #" << note_id << " not found in model - programmers should investigate this" << endmsg; - return change; - } + change.note_id = note_id; return change; } @@ -704,29 +726,29 @@ MidiModel::NoteDiffCommand::get_state () diff_command->add_property("midi-source", _model->midi_source()->id().to_s()); XMLNode* changes = diff_command->add_child(DIFF_NOTES_ELEMENT); - for_each(_changes.begin(), _changes.end(), + for_each(_changes.begin(), _changes.end(), boost::bind ( boost::bind (&XMLNode::add_child_nocopy, changes, _1), boost::bind (&NoteDiffCommand::marshal_change, this, _1))); XMLNode* added_notes = diff_command->add_child(ADDED_NOTES_ELEMENT); - for_each(_added_notes.begin(), _added_notes.end(), + for_each(_added_notes.begin(), _added_notes.end(), boost::bind( boost::bind (&XMLNode::add_child_nocopy, added_notes, _1), boost::bind (&NoteDiffCommand::marshal_note, this, _1))); XMLNode* removed_notes = diff_command->add_child(REMOVED_NOTES_ELEMENT); - for_each(_removed_notes.begin(), _removed_notes.end(), + for_each(_removed_notes.begin(), _removed_notes.end(), boost::bind ( boost::bind (&XMLNode::add_child_nocopy, removed_notes, _1), boost::bind (&NoteDiffCommand::marshal_note, this, _1))); - /* if this command had side-effects, store that state too + /* if this command had side-effects, store that state too */ if (!side_effect_removals.empty()) { XMLNode* side_effect_notes = diff_command->add_child(SIDE_EFFECT_REMOVALS_ELEMENT); - for_each(side_effect_removals.begin(), side_effect_removals.end(), + for_each(side_effect_removals.begin(), side_effect_removals.end(), boost::bind ( boost::bind (&XMLNode::add_child_nocopy, side_effect_notes, _1), boost::bind (&NoteDiffCommand::marshal_note, this, _1))); @@ -761,6 +783,19 @@ MidiModel::SysExDiffCommand::operator() () { MidiModel::WriteLock lock (_model->edit_lock ()); + for (list::iterator i = _removed.begin(); i != _removed.end(); ++i) { + _model->remove_sysex_unlocked (*i); + } + + /* find any sysex events that were missing when unmarshalling */ + + for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { + if (!i->sysex) { + i->sysex = _model->find_sysex (i->sysex_id); + assert (i->sysex); + } + } + for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { switch (i->property) { case Time: @@ -778,6 +813,19 @@ MidiModel::SysExDiffCommand::undo () { MidiModel::WriteLock lock (_model->edit_lock ()); + for (list::iterator i = _removed.begin(); i != _removed.end(); ++i) { + _model->add_sysex_unlocked (*i); + } + + /* find any sysex events that were missing when unmarshalling */ + + for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { + if (!i->sysex) { + i->sysex = _model->find_sysex (i->sysex_id); + assert (i->sysex); + } + } + for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { switch (i->property) { case Time: @@ -791,6 +839,12 @@ MidiModel::SysExDiffCommand::undo () _model->ContentsChanged(); /* EMIT SIGNAL */ } +void +MidiModel::SysExDiffCommand::remove (SysExPtr sysex) +{ + _removed.push_back(sysex); +} + XMLNode& MidiModel::SysExDiffCommand::marshal_change (const Change& change) { @@ -822,14 +876,14 @@ MidiModel::SysExDiffCommand::marshal_change (const Change& change) MidiModel::SysExDiffCommand::Change MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change) { - XMLProperty* prop; + XMLProperty const * prop; Change change; if ((prop = xml_change->property ("property")) != 0) { change.property = (Property) string_2_enum (prop->value(), change.property); } else { fatal << "!!!" << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } if ((prop = xml_change->property ("id")) == 0) { @@ -844,7 +898,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change) old_str >> change.old_time; } else { fatal << "!!!" << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } if ((prop = xml_change->property ("new")) != 0) { @@ -852,7 +906,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change) new_str >> change.new_time; } else { fatal << "!!!" << endmsg; - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ } /* we must point at the instance of the sysex that is actually in the model. @@ -860,11 +914,7 @@ MidiModel::SysExDiffCommand::unmarshal_change (XMLNode *xml_change) */ change.sysex = _model->find_sysex (sysex_id); - - if (!change.sysex) { - warning << "Sys-ex #" << sysex_id << " not found in model - programmers should investigate this" << endmsg; - return change; - } + change.sysex_id = sysex_id; return change; } @@ -899,7 +949,7 @@ MidiModel::SysExDiffCommand::get_state () diff_command->add_property ("midi-source", _model->midi_source()->id().to_s()); XMLNode* changes = diff_command->add_child(DIFF_SYSEXES_ELEMENT); - for_each (_changes.begin(), _changes.end(), + for_each (_changes.begin(), _changes.end(), boost::bind ( boost::bind (&XMLNode::add_child_nocopy, changes, _1), boost::bind (&SysExDiffCommand::marshal_change, this, _1))); @@ -952,6 +1002,7 @@ MidiModel::PatchChangeDiffCommand::change_channel (PatchChangePtr patch, uint8_t c.patch = patch; c.old_channel = patch->channel (); c.new_channel = channel; + c.patch_id = patch->id(); _changes.push_back (c); } @@ -964,6 +1015,7 @@ MidiModel::PatchChangeDiffCommand::change_program (PatchChangePtr patch, uint8_t c.patch = patch; c.old_program = patch->program (); c.new_program = program; + c.patch_id = patch->id(); _changes.push_back (c); } @@ -976,7 +1028,7 @@ MidiModel::PatchChangeDiffCommand::change_bank (PatchChangePtr patch, int bank) c.patch = patch; c.old_bank = patch->bank (); c.new_bank = bank; - + _changes.push_back (c); } @@ -985,7 +1037,7 @@ MidiModel::PatchChangeDiffCommand::operator() () { { MidiModel::WriteLock lock (_model->edit_lock ()); - + for (list::iterator i = _added.begin(); i != _added.end(); ++i) { _model->add_patch_change_unlocked (*i); } @@ -993,7 +1045,16 @@ MidiModel::PatchChangeDiffCommand::operator() () for (list::iterator i = _removed.begin(); i != _removed.end(); ++i) { _model->remove_patch_change_unlocked (*i); } - + + /* find any patch change events that were missing when unmarshalling */ + + for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { + if (!i->patch) { + i->patch = _model->find_patch_change (i->patch_id); + assert (i->patch); + } + } + set temporary_removals; for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { @@ -1041,7 +1102,16 @@ MidiModel::PatchChangeDiffCommand::undo () for (list::iterator i = _removed.begin(); i != _removed.end(); ++i) { _model->add_patch_change_unlocked (*i); } - + + /* find any patch change events that were missing when unmarshalling */ + + for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { + if (!i->patch) { + i->patch = _model->find_patch_change (i->patch_id); + assert (i->patch); + } + } + set temporary_removals; for (ChangeList::iterator i = _changes.begin(); i != _changes.end(); ++i) { @@ -1071,7 +1141,7 @@ MidiModel::PatchChangeDiffCommand::undo () for (set::iterator i = temporary_removals.begin(); i != temporary_removals.end(); ++i) { _model->add_patch_change_unlocked (*i); } - + } _model->ContentsChanged (); /* EMIT SIGNAL */ @@ -1158,25 +1228,26 @@ MidiModel::PatchChangeDiffCommand::marshal_change (const Change& c) s << c.patch->id (); n->add_property ("id", s.str ()); } - + return *n; } MidiModel::PatchChangePtr MidiModel::PatchChangeDiffCommand::unmarshal_patch_change (XMLNode* n) { - XMLProperty* prop; - Evoral::event_id_t id; - Evoral::MusicalTime time = 0; - uint8_t channel = 0; - uint8_t program = 0; + XMLProperty const * prop; + XMLProperty const * prop_id; + Evoral::event_id_t id = 0; + Evoral::Beats time = Evoral::Beats(); + int channel = 0; + int program = 0; int bank = 0; - if ((prop = n->property ("id")) != 0) { - istringstream s (prop->value()); + if ((prop_id = n->property ("id")) != 0) { + istringstream s (prop_id->value()); s >> id; } - + if ((prop = n->property ("time")) != 0) { istringstream s (prop->value ()); s >> time; @@ -1198,6 +1269,7 @@ MidiModel::PatchChangeDiffCommand::unmarshal_patch_change (XMLNode* n) } PatchChangePtr p (new Evoral::PatchChange (time, channel, program, bank)); + assert(prop_id); p->set_id (id); return p; } @@ -1205,8 +1277,9 @@ MidiModel::PatchChangeDiffCommand::unmarshal_patch_change (XMLNode* n) MidiModel::PatchChangeDiffCommand::Change MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n) { - XMLProperty* prop; + XMLProperty const * prop; Change c; + int an_int; prop = n->property ("property"); assert (prop); @@ -1215,7 +1288,11 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n) prop = n->property ("id"); assert (prop); Evoral::event_id_t const id = atoi (prop->value().c_str()); - + + /* we need to load via an int intermediate for all properties that are + actually uint8_t (char/byte). + */ + prop = n->property ("old"); assert (prop); { @@ -1223,11 +1300,14 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n) if (c.property == Time) { s >> c.old_time; } else if (c.property == Channel) { - s >> c.old_channel; + s >> an_int; + c.old_channel = an_int; } else if (c.property == Program) { - s >> c.old_program; + s >> an_int; + c.old_program = an_int; } else if (c.property == Bank) { - s >> c.old_bank; + s >> an_int; + c.old_bank = an_int; } } @@ -1235,19 +1315,23 @@ MidiModel::PatchChangeDiffCommand::unmarshal_change (XMLNode* n) assert (prop); { istringstream s (prop->value ()); + if (c.property == Time) { s >> c.new_time; } else if (c.property == Channel) { - s >> c.new_channel; + s >> an_int; + c.new_channel = an_int; } else if (c.property == Program) { - s >> c.new_program; + s >> an_int; + c.new_program = an_int; } else if (c.property == Bank) { - s >> c.new_bank; + s >> an_int; + c.new_bank = an_int; } } c.patch = _model->find_patch_change (id); - assert (c.patch); + c.patch_id = id; return c; } @@ -1290,7 +1374,7 @@ MidiModel::PatchChangeDiffCommand::get_state () diff_command->add_property("midi-source", _model->midi_source()->id().to_s()); XMLNode* added = diff_command->add_child (ADDED_PATCH_CHANGES_ELEMENT); - for_each (_added.begin(), _added.end(), + for_each (_added.begin(), _added.end(), boost::bind ( boost::bind (&XMLNode::add_child_nocopy, added, _1), boost::bind (&PatchChangeDiffCommand::marshal_patch_change, this, _1) @@ -1298,13 +1382,13 @@ MidiModel::PatchChangeDiffCommand::get_state () ); XMLNode* removed = diff_command->add_child (REMOVED_PATCH_CHANGES_ELEMENT); - for_each (_removed.begin(), _removed.end(), + for_each (_removed.begin(), _removed.end(), boost::bind ( boost::bind (&XMLNode::add_child_nocopy, removed, _1), boost::bind (&PatchChangeDiffCommand::marshal_patch_change, this, _1) ) ); - + XMLNode* changes = diff_command->add_child (DIFF_PATCH_CHANGES_ELEMENT); for_each (_changes.begin(), _changes.end(), boost::bind ( @@ -1327,25 +1411,23 @@ MidiModel::PatchChangeDiffCommand::get_state () * `Discrete' mode). */ bool -MidiModel::write_to (boost::shared_ptr source) +MidiModel::write_to (boost::shared_ptr source, + const Glib::Threads::Mutex::Lock& source_lock) { ReadLock lock(read_lock()); const bool old_percussive = percussive(); set_percussive(false); - boost::shared_ptr ms = _midi_source.lock (); - assert (ms); - - source->drop_model(); - source->mark_streaming_midi_write_started (note_mode()); + source->drop_model(source_lock); + source->mark_streaming_midi_write_started (source_lock, note_mode()); - for (Evoral::Sequence::const_iterator i = begin(0, true); i != end(); ++i) { - source->append_event_unlocked_beats(*i); + for (Evoral::Sequence::const_iterator i = begin(TimeType(), true); i != end(); ++i) { + source->append_event_beats(source_lock, *i); } set_percussive(old_percussive); - source->mark_streaming_write_completed(); + source->mark_streaming_write_completed(source_lock); set_edited(false); @@ -1358,7 +1440,7 @@ MidiModel::write_to (boost::shared_ptr source) of the model. */ bool -MidiModel::sync_to_source () +MidiModel::sync_to_source (const Glib::Threads::Mutex::Lock& source_lock) { ReadLock lock(read_lock()); @@ -1366,16 +1448,24 @@ MidiModel::sync_to_source () set_percussive(false); boost::shared_ptr ms = _midi_source.lock (); - assert (ms); - - ms->mark_streaming_midi_write_started (note_mode()); + if (!ms) { + error << "MIDI model has no source to sync to" << endmsg; + return false; + } + + /* Invalidate and store active notes, which will be picked up by the iterator + on the next roll if time progresses linearly. */ + ms->invalidate(source_lock, + ms->session().transport_rolling() ? &_active_notes : NULL); + + ms->mark_streaming_midi_write_started (source_lock, note_mode()); - for (Evoral::Sequence::const_iterator i = begin(0, true); i != end(); ++i) { - ms->append_event_unlocked_beats(*i); + for (Evoral::Sequence::const_iterator i = begin(TimeType(), true); i != end(); ++i) { + ms->append_event_beats(source_lock, *i); } set_percussive (old_percussive); - ms->mark_streaming_write_completed (); + ms->mark_streaming_write_completed (source_lock); set_edited (false); @@ -1390,28 +1480,27 @@ MidiModel::sync_to_source () * destroying the original note durations. */ bool -MidiModel::write_section_to (boost::shared_ptr source, Evoral::MusicalTime begin_time, Evoral::MusicalTime end_time) +MidiModel::write_section_to (boost::shared_ptr source, + const Glib::Threads::Mutex::Lock& source_lock, + Evoral::Beats begin_time, + Evoral::Beats end_time) { ReadLock lock(read_lock()); MidiStateTracker mst; - Evoral::MusicalTime extra_note_on_time = end_time; const bool old_percussive = percussive(); set_percussive(false); - boost::shared_ptr ms = _midi_source.lock (); - assert (ms); - - source->drop_model(); - source->mark_streaming_midi_write_started (note_mode()); + source->drop_model(source_lock); + source->mark_streaming_midi_write_started (source_lock, note_mode()); - for (Evoral::Sequence::const_iterator i = begin(0, true); i != end(); ++i) { - const Evoral::Event& ev (*i); + for (Evoral::Sequence::const_iterator i = begin(TimeType(), true); i != end(); ++i) { + const Evoral::Event& ev (*i); if (ev.time() >= begin_time && ev.time() < end_time) { - const Evoral::MIDIEvent* mev = - static_cast* > (&ev); + const Evoral::MIDIEvent* mev = + static_cast* > (&ev); if (!mev) { continue; @@ -1421,45 +1510,29 @@ MidiModel::write_section_to (boost::shared_ptr source, Evoral::Music if (mev->is_note_off()) { if (!mst.active (mev->note(), mev->channel())) { - - /* add a note-on at the start of the range we're writing - to the file. velocity is just an arbitary reasonable value. + /* the matching note-on was outside the + time range we were given, so just + ignore this note-off. */ - - Evoral::MIDIEvent on (mev->event_type(), extra_note_on_time, 3, 0, true); - on.set_type (mev->type()); - on.set_note (mev->note()); - on.set_channel (mev->channel()); - on.set_velocity (mev->velocity()); - - cerr << "Add note on for odd note off, note = " << (int) on.note() << endl; - source->append_event_unlocked_beats (on); - mst.add (on.note(), on.channel()); - mst.dump (cerr); - extra_note_on_time += 1.0/128.0; + continue; } - cerr << "MIDI Note off (note = " << (int) mev->note() << endl; - source->append_event_unlocked_beats (*i); + source->append_event_beats (source_lock, *i); mst.remove (mev->note(), mev->channel()); - mst.dump (cerr); } else if (mev->is_note_on()) { - cerr << "MIDI Note on (note = " << (int) mev->note() << endl; mst.add (mev->note(), mev->channel()); - source->append_event_unlocked_beats(*i); - mst.dump (cerr); + source->append_event_beats(source_lock, *i); } else { - cerr << "MIDI other event type\n"; - source->append_event_unlocked_beats(*i); + source->append_event_beats(source_lock, *i); } } } - mst.resolve_notes (*source, end_time); + mst.resolve_notes (*source, source_lock, end_time); set_percussive(old_percussive); - source->mark_streaming_write_completed(); + source->mark_streaming_write_completed(source_lock); set_edited(false); @@ -1544,25 +1617,19 @@ MidiModel::find_sysex (gint sysex_id) MidiModel::WriteLock MidiModel::edit_lock() { - boost::shared_ptr ms = _midi_source.lock (); - assert (ms); + boost::shared_ptr ms = _midi_source.lock(); + Glib::Threads::Mutex::Lock* source_lock = 0; - Glib::Mutex::Lock* source_lock = new Glib::Mutex::Lock (ms->mutex()); - ms->invalidate(); // Release cached iterator's read lock on model - return WriteLock(new WriteLockImpl(source_lock, _lock, _control_lock)); -} - -/** Lock just the model, the source lock must already be held. - * This should only be called from libardour/evoral places - */ -MidiModel::WriteLock -MidiModel::write_lock() -{ - boost::shared_ptr ms = _midi_source.lock (); - assert (ms); + if (ms) { + /* Take source lock and invalidate iterator to release its lock on model. + Add currently active notes to _active_notes so we can restore them + if playback resumes at the same point after the edit. */ + source_lock = new Glib::Threads::Mutex::Lock(ms->mutex()); + ms->invalidate(*source_lock, + ms->session().transport_rolling() ? &_active_notes : NULL); + } - assert (!ms->mutex().trylock ()); - return WriteLock(new WriteLockImpl(NULL, _lock, _control_lock)); + return WriteLock(new WriteLockImpl(source_lock, _lock, _control_lock)); } int @@ -1580,7 +1647,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) TimeType ea = note->end_time(); const Pitches& p (pitches (note->channel())); - NotePtr search_note(new Note(0, 0, 0, note->note())); + NotePtr search_note(new Note(0, TimeType(), TimeType(), note->note())); set to_be_deleted; bool set_note_length = false; bool set_note_time = false; @@ -1588,8 +1655,8 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) TimeType note_length = note->length(); DEBUG_TRACE (DEBUG::Sequence, string_compose ("%1 checking overlaps for note %2 @ %3\n", this, (int)note->note(), note->time())); - - for (Pitches::const_iterator i = p.lower_bound (search_note); + + for (Pitches::const_iterator i = p.lower_bound (search_note); i != p.end() && (*i)->note() == note->note(); ++i) { TimeType sb = (*i)->time(); @@ -1598,9 +1665,9 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) if ((sb > sa) && (eb <= ea)) { overlap = OverlapInternal; - } else if ((eb >= sa) && (eb <= ea)) { + } else if ((eb > sa) && (eb <= ea)) { overlap = OverlapStart; - } else if ((sb > sa) && (sb <= ea)) { + } else if ((sb > sa) && (sb < ea)) { overlap = OverlapEnd; } else if ((sa >= sb) && (sa <= eb) && (ea <= eb)) { overlap = OverlapExternal; @@ -1641,12 +1708,12 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) case InsertMergeExtend: if (cmd) { cmd->change ((*i), NoteDiffCommand::Length, note->end_time() - (*i)->time()); - } + } (*i)->set_length (note->end_time() - (*i)->time()); return -1; /* do not add the new note */ break; default: - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ /* stupid gcc */ break; } @@ -1682,7 +1749,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) note_length = min (note_length, (*i)->end_time() - note->time()); break; default: - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ /* stupid gcc */ break; } @@ -1701,7 +1768,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) /* cannot add in this case */ return -1; default: - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ /* stupid gcc */ break; } @@ -1719,14 +1786,14 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) to_be_deleted.insert (*i); break; default: - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ /* stupid gcc */ break; } break; default: - /*NOTREACHED*/ + abort(); /*NOTREACHED*/ /* stupid gcc */ break; } @@ -1743,14 +1810,14 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) if (set_note_time) { if (cmd) { cmd->change (note, NoteDiffCommand::StartTime, note_time); - } + } note->set_time (note_time); } if (set_note_length) { if (cmd) { cmd->change (note, NoteDiffCommand::Length, note_length); - } + } note->set_length (note_length); } @@ -1758,7 +1825,7 @@ MidiModel::resolve_overlaps_unlocked (const NotePtr note, void* arg) } InsertMergePolicy -MidiModel::insert_merge_policy () const +MidiModel::insert_merge_policy () const { /* XXX ultimately this should be a per-track or even per-model policy */ boost::shared_ptr ms = _midi_source.lock (); @@ -1771,9 +1838,10 @@ void MidiModel::set_midi_source (boost::shared_ptr s) { boost::shared_ptr old = _midi_source.lock (); - + if (old) { - old->invalidate (); + Source::Lock lm(old->mutex()); + old->invalidate (lm); } _midi_source_connections.drop_connections (); @@ -1799,7 +1867,7 @@ MidiModel::set_midi_source (boost::shared_ptr s) void MidiModel::source_interpolation_changed (Evoral::Parameter p, Evoral::ControlList::InterpolationStyle s) { - Glib::Mutex::Lock lm (_control_lock); + Glib::Threads::Mutex::Lock lm (_control_lock); control(p)->list()->set_interpolation (s); } @@ -1818,7 +1886,7 @@ MidiModel::control_list_interpolation_changed (Evoral::Parameter p, Evoral::Cont void MidiModel::source_automation_state_changed (Evoral::Parameter p, AutoState s) { - Glib::Mutex::Lock lm (_control_lock); + Glib::Threads::Mutex::Lock lm (_control_lock); boost::shared_ptr al = boost::dynamic_pointer_cast (control(p)->list ()); al->set_automation_state (s); } @@ -1859,7 +1927,7 @@ MidiModel::midi_source () return _midi_source.lock (); } -/** Moves notes, controllers and sys-ex to insert silence at the start of the model. +/** Moves notes, patch changes, controllers and sys-ex to insert silence at the start of the model. * Adds commands to the session's current undo stack to reflect the movements. */ void @@ -1867,16 +1935,28 @@ MidiModel::insert_silence_at_start (TimeType t) { boost::shared_ptr s = _midi_source.lock (); assert (s); - + /* Notes */ if (!notes().empty ()) { NoteDiffCommand* c = new_note_diff_command ("insert silence"); - + for (Notes::const_iterator i = notes().begin(); i != notes().end(); ++i) { c->change (*i, NoteDiffCommand::StartTime, (*i)->time() + t); } - + + apply_command_as_subcommand (s->session(), c); + } + + /* Patch changes */ + + if (!patch_changes().empty ()) { + PatchChangeDiffCommand* c = new_patch_change_diff_command ("insert silence"); + + for (PatchChanges::const_iterator i = patch_changes().begin(); i != patch_changes().end(); ++i) { + c->change_time (*i, (*i)->time() + t); + } + apply_command_as_subcommand (s->session(), c); } @@ -1885,7 +1965,7 @@ MidiModel::insert_silence_at_start (TimeType t) for (Controls::iterator i = controls().begin(); i != controls().end(); ++i) { boost::shared_ptr ac = boost::dynamic_pointer_cast (i->second); XMLNode& before = ac->alist()->get_state (); - i->second->list()->shift (0, t); + i->second->list()->shift (0, t.to_double()); XMLNode& after = ac->alist()->get_state (); s->session().add_command (new MementoCommand (new MidiAutomationListBinder (s, i->first), &before, &after)); } @@ -1903,42 +1983,24 @@ MidiModel::insert_silence_at_start (TimeType t) } } -/** Transpose notes in a time range by a given number of semitones. Notes - * will be clamped at 0 and 127 if the transposition would make them exceed - * that range. - * - * @param from Start time. - * @param end End time. - * @param semitones Number of semitones to transpose by (+ve is higher, -ve is lower). - */ void -MidiModel::transpose (TimeType from, TimeType to, int semitones) +MidiModel::transpose (NoteDiffCommand* c, const NotePtr note_ptr, int semitones) { - boost::shared_ptr s = midi_source (); - - NoteDiffCommand* c = new_note_diff_command (_("transpose")); - - for (Notes::iterator i = notes().begin(); i != notes().end(); ++i) { - - if ((*i)->time() >= to) { - - /* finished */ - break; - - } else if ((*i)->time() >= from) { - - int new_note = (*i)->note() + semitones; - - if (new_note < 0) { - new_note = 0; - } else if (new_note > 127) { - new_note = 127; - } + int new_note = note_ptr->note() + semitones; - c->change (*i, NoteDiffCommand::NoteNumber, (uint8_t) new_note); - - } + if (new_note < 0) { + new_note = 0; + } else if (new_note > 127) { + new_note = 127; } - apply_command (s->session (), c); + c->change (note_ptr, NoteDiffCommand::NoteNumber, (uint8_t) new_note); +} + +void +MidiModel::control_list_marked_dirty () +{ + AutomatableSequence::control_list_marked_dirty (); + + ContentsChanged (); /* EMIT SIGNAL */ }