X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=libs%2Fpbd%2Fcontrollable.cc;h=6b92e84926332eebea63d2d7c8c7771e629e81d3;hb=36f04367dff567a24f94b8686b0625d9b51210ef;hp=959abe443d9c8e9d93b9ae3e207f3e7a9ec276a9;hpb=106024330230fca331e2f611fec42ec1f4f43e5a;p=ardour.git

diff --git a/libs/pbd/controllable.cc b/libs/pbd/controllable.cc
index 959abe443d..6b92e84926 100644
--- a/libs/pbd/controllable.cc
+++ b/libs/pbd/controllable.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2000-2007 Paul Davis 
+    Copyright (C) 2000-2007 Paul Davis
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -34,9 +34,9 @@ PBD::Signal1<void,Controllable*> Controllable::StopLearning;
 PBD::Signal3<void,Controllable*,int,int> Controllable::CreateBinding;
 PBD::Signal1<void,Controllable*> Controllable::DeleteBinding;
 
-Glib::StaticRWLock Controllable::registry_lock = GLIBMM_STATIC_RW_LOCK_INIT;
+Glib::Threads::RWLock Controllable::registry_lock;
 Controllable::Controllables Controllable::registry;
-PBD::ScopedConnectionList registry_connections;
+PBD::ScopedConnectionList* registry_connections = 0;
 const std::string Controllable::xml_node_name = X_("Controllable");
 
 Controllable::Controllable (const string& name, Flag f)
@@ -52,18 +52,22 @@ Controllable::add (Controllable& ctl)
 {
 	using namespace boost;
 
-	Glib::RWLock::WriterLock lm (registry_lock);
+	Glib::Threads::RWLock::WriterLock lm (registry_lock);
 	registry.insert (&ctl);
 
+	if (!registry_connections) {
+		registry_connections = new ScopedConnectionList;
+	}
+
 	/* Controllable::remove() is static - no need to manage this connection */
 
-	ctl.DropReferences.connect_same_thread (registry_connections, boost::bind (&Controllable::remove, &ctl));
+	ctl.DropReferences.connect_same_thread (*registry_connections, boost::bind (&Controllable::remove, &ctl));
 }
 
 void
 Controllable::remove (Controllable* ctl)
 {
-	Glib::RWLock::WriterLock lm (registry_lock);
+	Glib::Threads::RWLock::WriterLock lm (registry_lock);
 
 	for (Controllables::iterator i = registry.begin(); i != registry.end(); ++i) {
 		if ((*i) == ctl) {
@@ -76,7 +80,7 @@ Controllable::remove (Controllable* ctl)
 Controllable*
 Controllable::by_id (const ID& id)
 {
-	Glib::RWLock::ReaderLock lm (registry_lock);
+	Glib::Threads::RWLock::ReaderLock lm (registry_lock);
 
 	for (Controllables::iterator i = registry.begin(); i != registry.end(); ++i) {
 		if ((*i)->id() == id) {
@@ -89,7 +93,7 @@ Controllable::by_id (const ID& id)
 Controllable*
 Controllable::by_name (const string& str)
 {
-	Glib::RWLock::ReaderLock lm (registry_lock);
+	Glib::Threads::RWLock::ReaderLock lm (registry_lock);
 
 	for (Controllables::iterator i = registry.begin(); i != registry.end(); ++i) {
 		if ((*i)->_name == str) {
@@ -103,11 +107,21 @@ XMLNode&
 Controllable::get_state ()
 {
 	XMLNode* node = new XMLNode (xml_node_name);
-	LocaleGuard lg (X_("POSIX"));
+	LocaleGuard lg;
 	char buf[64];
 
-	node->add_property (X_("name"), _name); // not reloaded from XML state, just there to look at
-	_id.print (buf, sizeof (buf));
+	/* Waves' "Pressure3" has a parameter called "µ-iness"
+	 * which causes a  parser error : Input is not proper UTF-8, indicate encoding !
+	 *  Bytes: 0xB5 0x2D 0x69 0x6E
+	 *          <Controllable name="�-iness" id="2391" flags="" value="0.000000000000" p
+	 */
+
+	// this is not reloaded from XML, but it must be present because it is
+	// used to find and identify XML nodes by various Controllable-derived objects
+
+	node->add_property (X_("name"), _name);
+
+	id().print (buf, sizeof (buf));
 	node->add_property (X_("id"), buf);
 	node->add_property (X_("flags"), enum_2_string (_flags));
 	snprintf (buf, sizeof (buf), "%2.12f", get_value());
@@ -124,17 +138,12 @@ Controllable::get_state ()
 int
 Controllable::set_state (const XMLNode& node, int /*version*/)
 {
-	LocaleGuard lg (X_("POSIX"));
+	LocaleGuard lg;
 	const XMLProperty* prop;
 
 	Stateful::save_extra_xml (node);
 
-	if ((prop = node.property (X_("id"))) != 0) {
-		_id = prop->value();
-	} else {
-		error << _("Controllable state node has no ID property") << endmsg;
-		return -1;
-	}
+	set_id (node);
 
 	if ((prop = node.property (X_("flags"))) != 0) {
 		_flags = (Flag) string_2_enum (prop->value(), _flags);
@@ -144,8 +153,8 @@ Controllable::set_state (const XMLNode& node, int /*version*/)
 		float val;
 
 		if (sscanf (prop->value().c_str(), "%f", &val) == 1) {
-			set_value (val);
-		} 
+			set_value (val, NoGroup);
+		}
         }
 
         return 0;