X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Ffilter.h;h=3c2a49792d97ac197439b477164304e162eac94c;hb=b56ca8250b8eae123c0992a50f5cabe99e655763;hp=e7e8b389f217a7c78313a0ce93b427b2a204faec;hpb=98bbaf1e907e927dbd26131cbdef243a82fdc2d1;p=dcpomatic.git

diff --git a/src/lib/filter.h b/src/lib/filter.h
index e7e8b389f..3c2a49792 100644
--- a/src/lib/filter.h
+++ b/src/lib/filter.h
@@ -1,39 +1,51 @@
 /*
-    Copyright (C) 2012 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2021 Carl Hetherington <cth@carlh.net>
 
-    This program is free software; you can redistribute it and/or modify
+    This file is part of DCP-o-matic.
+
+    DCP-o-matic is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
+    DCP-o-matic is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+    along with DCP-o-matic.  If not, see <http://www.gnu.org/licenses/>.
 
 */
 
+
 /** @file src/filter.h
- *  @brief A class to describe one of FFmpeg's video or post-processing filters.
+ *  @brief A class to describe one of FFmpeg's video or audio filters.
  */
 
-#ifndef DVDOMATIC_FILTER_H
-#define DVDOMATIC_FILTER_H
+
+#ifndef DCPOMATIC_FILTER_H
+#define DCPOMATIC_FILTER_H
+
 
 #include <string>
 #include <vector>
 
+
 /** @class Filter
- *  @brief A class to describe one of FFmpeg's video or post-processing filters.
+ *  @brief A class to describe one of FFmpeg's video or audio filters.
+ *
+ *  We don't support FFmpeg's post-processing filters here as they cannot cope with greater than
+ *  8bpp.  FFmpeg quantizes e.g. yuv422p10le down to yuv422p before running such filters, which
+ *  we don't really want to do.
  */
 class Filter
 {
 public:
-	Filter (std::string, std::string, std::string, std::string);
+	Filter (std::string i, std::string n, std::string c, std::string f);
+
+	Filter (Filter const&) = delete;
+	Filter& operator= (Filter const&) = delete;
 
 	/** @return our id */
 	std::string id () const {
@@ -45,20 +57,19 @@ public:
 		return _name;
 	}
 
-	/** @return string for a FFmpeg video filter descriptor */
-	std::string vf () const {
-		return _vf;
+	/** @return string for a FFmpeg filter descriptor */
+	std::string ffmpeg () const {
+		return _ffmpeg;
 	}
-	
-	/** @return string for a FFmpeg post-processing descriptor */
-	std::string pp () const {
-		return _pp;
+
+	std::string category () const {
+		return _category;
 	}
-	
+
 	static std::vector<Filter const *> all ();
-	static Filter const * from_id (std::string);
+	static Filter const * from_id (std::string d);
 	static void setup_filters ();
-	static std::pair<std::string, std::string> ffmpeg_strings (std::vector<Filter const *> const &);
+	static std::string ffmpeg_string (std::vector<Filter const *> const & filters);
 
 private:
 
@@ -66,14 +77,14 @@ private:
 	std::string _id;
 	/** user-visible name */
 	std::string _name;
-	/** string for a FFmpeg video filter descriptor */
-	std::string _vf;
-	/** string for a FFmpeg post-processing descriptor */
-	std::string _pp;
+	std::string _category;
+	/** string for a FFmpeg filter descriptor */
+	std::string _ffmpeg;
 
 	/** all available filters */
 	static std::vector<Filter const *> _filters;
 	static void maybe_add (std::string, std::string, std::string, std::string);
 };
 
+
 #endif