X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fjob.cc;h=0feda64355fd95cc0e2d18472c7305cd94b6ec86;hb=b029cb06c4e0fca1fad9fecd78939efe5532fa9a;hp=1416ddfc20c4d1906b785a67ddc8506d40894b17;hpb=c4403784febdbdd42e9c32e67fadb147f11fe566;p=dcpomatic.git

diff --git a/src/lib/job.cc b/src/lib/job.cc
index 1416ddfc2..0feda6435 100644
--- a/src/lib/job.cc
+++ b/src/lib/job.cc
@@ -51,7 +51,6 @@ using namespace dcpomatic;
 /** @param film Associated film, or 0 */
 Job::Job (shared_ptr<const Film> film)
 	: _film (film)
-	, _thread (0)
 	, _state (NEW)
 	, _start_time (0)
 	, _sub_start_time (0)
@@ -63,19 +62,25 @@ Job::Job (shared_ptr<const Film> film)
 
 Job::~Job ()
 {
-	if (_thread) {
-		_thread->interrupt ();
-		/* We can't use DCPOMATIC_ASSERT here as it may throw an exception */
-		if (_thread->joinable ()) {
-			try {
-				_thread->join ();
-			} catch (...) {
-				/* Too late to do anything about this */
-			}
-		}
+#ifdef DCPOMATIC_DEBUG
+	/* Any subclass should have called stop_thread in its destructor */
+	assert (!_thread.joinable());
+#endif
+}
+
+void
+Job::stop_thread ()
+{
+	if (!_thread.joinable()) {
+		return;
 	}
 
-	delete _thread;
+	_thread.interrupt ();
+	try {
+		_thread.join ();
+	} catch (...) {
+		/* Too late to do anything about this */
+	}
 }
 
 /** Start the job in a separate thread, returning immediately */
@@ -85,9 +90,9 @@ Job::start ()
 	set_state (RUNNING);
 	_start_time = time (0);
 	_sub_start_time = time (0);
-	_thread = new boost::thread (boost::bind (&Job::run_wrapper, this));
+	_thread = boost::thread (boost::bind(&Job::run_wrapper, this));
 #ifdef DCPOMATIC_LINUX
-	pthread_setname_np (_thread->native_handle(), "job-wrapper");
+	pthread_setname_np (_thread.native_handle(), "job-wrapper");
 #endif
 }
 
@@ -117,6 +122,42 @@ Job::run_wrapper ()
 		set_progress (1);
 		set_state (FINISHED_ERROR);
 
+	} catch (dcp::StartCompressionError& e) {
+
+		bool done = false;
+
+#ifdef DCPOMATIC_WINDOWS
+#if (__GNUC__ && !__x86_64__)
+		/* 32-bit */
+		set_error (
+			_("Failed to encode the DCP."),
+			_("This error has probably occurred because you are running the 32-bit version of DCP-o-matic and "
+			  "trying to use too many encoding threads.  Please reduce the 'number of threads DCP-o-matic should "
+			  "use' in the General tab of Preferences and try again.")
+			);
+		done = true;
+#else
+		/* 64-bit */
+		if (running_32_on_64()) {
+			set_error (
+				_("Failed to encode the DCP."),
+				_("This error has probably occurred because you are running the 32-bit version of DCP-o-matic.  Please re-install DCP-o-matic with the 64-bit installer and try again.")
+				);
+			done = true;
+		}
+#endif
+#endif
+
+		if (!done) {
+			set_error (
+				e.what (),
+				string (_("It is not known what caused this error.")) + "  " + REPORT_PROBLEM
+				);
+		}
+
+		set_progress (1);
+		set_state (FINISHED_ERROR);
+
 	} catch (OpenFileError& e) {
 
 		set_error (
@@ -173,13 +214,7 @@ Job::run_wrapper ()
 		set_progress (1);
 		set_state (FINISHED_ERROR);
 
-	} catch (dcp::MissingAssetError& e) {
-
-		set_error (e.message(), e.path().string());
-		set_progress (1);
-		set_state (FINISHED_ERROR);
-
-	} catch (dcp::DCPReadError& e) {
+	} catch (dcp::ReadError& e) {
 
 		set_error (e.message(), e.detail().get_value_or(""));
 		set_progress (1);
@@ -514,7 +549,7 @@ Job::remaining_time () const
 void
 Job::cancel ()
 {
-	if (!_thread) {
+	if (!_thread.joinable()) {
 		return;
 	}
 
@@ -522,11 +557,8 @@ Job::cancel ()
 		resume ();
 	}
 
-	_thread->interrupt ();
-	DCPOMATIC_ASSERT (_thread->joinable ());
-	_thread->join ();
-	delete _thread;
-	_thread = 0;
+	_thread.interrupt ();
+	_thread.join ();
 }
 
 /** @return true if the job was paused, false if it was not running */