X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Ftools%2Fmakedcp.cc;h=0c639077162250cb31b11fa58e9a84f7b5f347d8;hb=bc83f9ba294697528cee2be41ec6aac905371f1f;hp=57814272d75a8ee84f400b7854ebafa67e7bbdce;hpb=e06f9e4dc4290b387eb08fea0c90460ef46654b4;p=dcpomatic.git

diff --git a/src/tools/makedcp.cc b/src/tools/makedcp.cc
index 57814272d..0c6390771 100644
--- a/src/tools/makedcp.cc
+++ b/src/tools/makedcp.cc
@@ -26,7 +26,6 @@
 #include "film.h"
 #include "filter.h"
 #include "transcode_job.h"
-#include "make_dcp_job.h"
 #include "job_manager.h"
 #include "ab_transcode_job.h"
 #include "util.h"
@@ -36,8 +35,13 @@
 #include "config.h"
 #include "log.h"
 
-using namespace std;
-using namespace boost;
+using std::string;
+using std::cerr;
+using std::cout;
+using std::vector;
+using std::pair;
+using std::list;
+using boost::shared_ptr;
 
 static void
 help (string n)
@@ -46,9 +50,9 @@ help (string n)
 	     << "  -v, --version      show DVD-o-matic version\n"
 	     << "  -h, --help         show this help\n"
 	     << "  -d, --deps         list DVD-o-matic dependency details and quit\n"
-	     << "  -c, --config       list configuration settings that affect output and quit\n"
 	     << "  -t, --test         run in test mode (repeatable UUID generation, timestamps etc.)\n"
 	     << "  -n, --no-progress  do not print progress to stdout\n"
+	     << "  -r, --no-remote    do not use any remote servers\n"
 	     << "\n"
 	     << "<FILM> is the film directory.\n";
 }
@@ -59,6 +63,7 @@ main (int argc, char* argv[])
 	string film_dir;
 	bool test_mode = false;
 	bool progress = true;
+	bool no_remote = false;
 	int log_level = 1;
 
 	int option_index = 0;
@@ -67,14 +72,14 @@ main (int argc, char* argv[])
 			{ "version", no_argument, 0, 'v'},
 			{ "help", no_argument, 0, 'h'},
 			{ "deps", no_argument, 0, 'd'},
-			{ "config", no_argument, 0, 'c'},
 			{ "test", no_argument, 0, 't'},
 			{ "no-progress", no_argument, 0, 'n'},
+			{ "no-remote", no_argument, 0, 'r'},
 			{ "log-level", required_argument, 0, 'l' },
 			{ 0, 0, 0, 0 }
 		};
 
-		int c = getopt_long (argc, argv, "vhdctnl:", long_options, &option_index);
+		int c = getopt_long (argc, argv, "vhdtnrl:", long_options, &option_index);
 
 		if (c == -1) {
 			break;
@@ -96,15 +101,9 @@ main (int argc, char* argv[])
 		case 'n':
 			progress = false;
 			break;
-		case 'c':
-			cout << "Colour LUT " << colour_lut_index_to_name (Config::instance()->colour_lut_index()) << "; "
-			     << "J2K bandwidth " << Config::instance()->j2k_bandwidth() << "; ";
-#ifdef DVDOMATIC_DEBUG
-			cout << "built in debug mode\n";
-#else
-			cout << "built in optimised mode\n";
-#endif			
-			exit (EXIT_SUCCESS);
+		case 'r':
+			no_remote = true;
+			break;
 		case 'l':
 			log_level = atoi (optarg);
 			break;
@@ -120,6 +119,10 @@ main (int argc, char* argv[])
 			
 	dvdomatic_setup ();
 
+	if (no_remote) {
+		Config::instance()->set_servers (vector<ServerDescription*> ());
+	}
+
 	cout << "DVD-o-matic " << dvdomatic_version << " git " << dvdomatic_git_commit;
 	char buf[256];
 	if (gethostname (buf, 256) == 0) {
@@ -132,9 +135,9 @@ main (int argc, char* argv[])
 		cout << dependency_version_summary() << "\n";
 	}
 
-	Film* film = 0;
+	shared_ptr<Film> film;
 	try {
-		film = new Film (film_dir, true);
+		film.reset (new Film (film_dir, true));
 	} catch (std::exception& e) {
 		cerr << argv[0] << ": error reading film `" << film_dir << "' (" << e.what() << ")\n";
 		exit (EXIT_FAILURE);
@@ -152,11 +155,12 @@ main (int argc, char* argv[])
 	pair<string, string> const f = Filter::ffmpeg_strings (film->filters ());
 	cout << "Filters: " << f.first << " " << f.second << "\n";
 
-	film->make_dcp (true);
+	film->make_dcp ();
 
-	bool all_done = false;
+	bool should_stop = false;
 	bool first = true;
-	while (!all_done) {
+	bool error = false;
+	while (!should_stop) {
 
 		dvdomatic_sleep (5);
 
@@ -168,8 +172,10 @@ main (int argc, char* argv[])
 		}
 
 		first = false;
-		
-		all_done = true;
+
+		int unfinished = 0;
+		int finished_in_error = 0;
+
 		for (list<shared_ptr<Job> >::iterator i = jobs.begin(); i != jobs.end(); ++i) {
 			if (progress) {
 				cout << (*i)->name() << ": ";
@@ -182,9 +188,14 @@ main (int argc, char* argv[])
 					cout << ": Running           \n";
 				}
 			}
-			
+
 			if (!(*i)->finished ()) {
-				all_done = false;
+				++unfinished;
+			}
+
+			if ((*i)->finished_in_error ()) {
+				++finished_in_error;
+				error = true;
 			}
 
 			if (!progress && (*i)->finished_in_error ()) {
@@ -194,9 +205,13 @@ main (int argc, char* argv[])
 				cout << (*i)->status() << "\n";
 			}
 		}
+
+		if (unfinished == 0 || finished_in_error != 0) {
+			should_stop = true;
+		}
 	}
 
-	return 0;
+	return error ? EXIT_FAILURE : EXIT_SUCCESS;
 }