X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Fwx%2Fconfig_dialog.cc;h=036172bb7eaa45f381e4b91b7e4ed7f22d1e4696;hb=e60bb3e51bd1508b149e6b8f6608f09b5196ae26;hp=8d8f44b4ecc6fa05366c05b6366ef7a925a11e30;hpb=cb990adba9c57e5107ef2aa9716cf0a26c1df83d;p=dcpomatic.git diff --git a/src/wx/config_dialog.cc b/src/wx/config_dialog.cc index 8d8f44b4e..036172bb7 100644 --- a/src/wx/config_dialog.cc +++ b/src/wx/config_dialog.cc @@ -1,5 +1,5 @@ /* - Copyright (C) 2012-2014 Carl Hetherington + Copyright (C) 2012-2015 Carl Hetherington This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -28,15 +28,12 @@ #include #include #include -#include #include #include #include "lib/config.h" #include "lib/ratio.h" -#include "lib/scaler.h" #include "lib/filter.h" #include "lib/dcp_content_type.h" -#include "lib/colour_conversion.h" #include "lib/log.h" #include "lib/util.h" #include "lib/cross.h" @@ -47,7 +44,6 @@ #include "filter_dialog.h" #include "dir_picker_ctrl.h" #include "isdcf_metadata_dialog.h" -#include "preset_colour_conversion_dialog.h" #include "server_dialog.h" #include "make_signer_chain_dialog.h" @@ -63,42 +59,100 @@ class Page { public: Page (wxSize panel_size, int border) - : _panel_size (panel_size) - , _border (border) - {} + : _border (border) + , _panel (0) + , _panel_size (panel_size) + , _window_exists (false) + { + _config_connection = Config::instance()->Changed.connect (boost::bind (&Page::config_changed_wrapper, this)); + } + + virtual ~Page () {} protected: - wxPanel* make_panel (wxWindow* parent) + wxWindow* create_window (wxWindow* parent) { - wxPanel* panel = new wxPanel (parent, wxID_ANY, wxDefaultPosition, _panel_size); + _panel = new wxPanel (parent, wxID_ANY, wxDefaultPosition, _panel_size); wxBoxSizer* s = new wxBoxSizer (wxVERTICAL); - panel->SetSizer (s); - return panel; + _panel->SetSizer (s); + + setup (); + _window_exists = true; + config_changed (); + + _panel->Bind (wxEVT_DESTROY, boost::bind (&Page::window_destroyed, this)); + + return _panel; } - - wxSize _panel_size; + int _border; + wxPanel* _panel; + +private: + virtual void config_changed () = 0; + virtual void setup () = 0; + + void config_changed_wrapper () + { + if (_window_exists) { + config_changed (); + } + } + + void window_destroyed () + { + _window_exists = false; + } + + wxSize _panel_size; + boost::signals2::scoped_connection _config_connection; + bool _window_exists; }; -class GeneralPage : public wxStockPreferencesPage, public Page +class StockPage : public wxStockPreferencesPage, public Page { public: - GeneralPage (wxSize panel_size, int border) - : wxStockPreferencesPage (Kind_General) + StockPage (Kind kind, wxSize panel_size, int border) + : wxStockPreferencesPage (kind) , Page (panel_size, border) {} wxWindow* CreateWindow (wxWindow* parent) { - wxPanel* panel = make_panel (parent); + return create_window (parent); + } +}; + +class StandardPage : public wxPreferencesPage, public Page +{ +public: + StandardPage (wxSize panel_size, int border) + : Page (panel_size, border) + {} + + wxWindow* CreateWindow (wxWindow* parent) + { + return create_window (parent); + } +}; +class GeneralPage : public StockPage +{ +public: + GeneralPage (wxSize panel_size, int border) + : StockPage (Kind_General, panel_size, border) + {} + +private: + void setup () + { wxFlexGridSizer* table = new wxFlexGridSizer (2, DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP); table->AddGrowableCol (1, 1); - panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); - - _set_language = new wxCheckBox (panel, wxID_ANY, _("Set language")); + _panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); + + _set_language = new wxCheckBox (_panel, wxID_ANY, _("Set language")); table->Add (_set_language, 1); - _language = new wxChoice (panel, wxID_ANY); + _language = new wxChoice (_panel, wxID_ANY); _language->Append (wxT ("Deutsch")); _language->Append (wxT ("English")); _language->Append (wxT ("Español")); @@ -106,31 +160,44 @@ public: _language->Append (wxT ("Italiano")); _language->Append (wxT ("Nederlands")); _language->Append (wxT ("Svenska")); + _language->Append (wxT ("Русский")); table->Add (_language); - - wxStaticText* restart = add_label_to_sizer (table, panel, _("(restart DCP-o-matic to see language changes)"), false); + + wxStaticText* restart = add_label_to_sizer (table, _panel, _("(restart DCP-o-matic to see language changes)"), false); wxFont font = restart->GetFont(); font.SetStyle (wxFONTSTYLE_ITALIC); font.SetPointSize (font.GetPointSize() - 1); restart->SetFont (font); table->AddSpacer (0); - - add_label_to_sizer (table, panel, _("Threads to use for encoding on this host"), true); - _num_local_encoding_threads = new wxSpinCtrl (panel); + + add_label_to_sizer (table, _panel, _("Threads to use for encoding on this host"), true); + _num_local_encoding_threads = new wxSpinCtrl (_panel); table->Add (_num_local_encoding_threads, 1); - _check_for_updates = new wxCheckBox (panel, wxID_ANY, _("Check for updates on startup")); + _check_for_updates = new wxCheckBox (_panel, wxID_ANY, _("Check for updates on startup")); table->Add (_check_for_updates, 1, wxEXPAND | wxALL); table->AddSpacer (0); - - _check_for_test_updates = new wxCheckBox (panel, wxID_ANY, _("Check for testing updates as well as stable ones")); + + _check_for_test_updates = new wxCheckBox (_panel, wxID_ANY, _("Check for testing updates as well as stable ones")); table->Add (_check_for_test_updates, 1, wxEXPAND | wxALL); table->AddSpacer (0); - + + _set_language->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&GeneralPage::set_language_changed, this)); + _language->Bind (wxEVT_COMMAND_CHOICE_SELECTED, boost::bind (&GeneralPage::language_changed, this)); + + _num_local_encoding_threads->SetRange (1, 128); + _num_local_encoding_threads->Bind (wxEVT_COMMAND_SPINCTRL_UPDATED, boost::bind (&GeneralPage::num_local_encoding_threads_changed, this)); + + _check_for_updates->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&GeneralPage::check_for_updates_changed, this)); + _check_for_test_updates->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&GeneralPage::check_for_test_updates_changed, this)); + } + + void config_changed () + { Config* config = Config::instance (); - - _set_language->SetValue (config->language ()); - + + checked_set (_set_language, config->language ()); + if (config->language().get_value_or ("") == "fr") { _language->SetSelection (3); } else if (config->language().get_value_or ("") == "it") { @@ -143,28 +210,19 @@ public: _language->SetSelection (0); } else if (config->language().get_value_or ("") == "nl") { _language->SetSelection (5); + } else if (config->language().get_value_or ("") == "ru") { + _language->SetSelection (7); } else { _language->SetSelection (1); } - + setup_language_sensitivity (); - - _set_language->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&GeneralPage::set_language_changed, this)); - _language->Bind (wxEVT_COMMAND_CHOICE_SELECTED, boost::bind (&GeneralPage::language_changed, this)); - - _num_local_encoding_threads->SetRange (1, 128); - _num_local_encoding_threads->SetValue (config->num_local_encoding_threads ()); - _num_local_encoding_threads->Bind (wxEVT_COMMAND_SPINCTRL_UPDATED, boost::bind (&GeneralPage::num_local_encoding_threads_changed, this)); - _check_for_updates->SetValue (config->check_for_updates ()); - _check_for_updates->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&GeneralPage::check_for_updates_changed, this)); - _check_for_test_updates->SetValue (config->check_for_test_updates ()); - _check_for_test_updates->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&GeneralPage::check_for_test_updates_changed, this)); - - return panel; + checked_set (_num_local_encoding_threads, config->num_local_encoding_threads ()); + checked_set (_check_for_updates, config->check_for_updates ()); + checked_set (_check_for_test_updates, config->check_for_test_updates ()); } -private: void setup_language_sensitivity () { _language->Enable (_set_language->GetValue ()); @@ -204,14 +262,17 @@ private: case 6: Config::instance()->set_language ("sv"); break; + case 7: + Config::instance()->set_language ("ru"); + break; } } - + void check_for_updates_changed () { Config::instance()->set_check_for_updates (_check_for_updates->GetValue ()); } - + void check_for_test_updates_changed () { Config::instance()->set_check_for_test_updates (_check_for_test_updates->GetValue ()); @@ -229,148 +290,144 @@ private: wxCheckBox* _check_for_test_updates; }; -class DefaultsPage : public wxPreferencesPage, public Page +class DefaultsPage : public StandardPage { public: DefaultsPage (wxSize panel_size, int border) - : Page (panel_size, border) + : StandardPage (panel_size, border) {} - + wxString GetName () const { return _("Defaults"); } -#ifdef DCPOMATIC_OSX +#ifdef DCPOMATIC_OSX wxBitmap GetLargeIcon () const { return wxBitmap ("defaults", wxBITMAP_TYPE_PNG_RESOURCE); } -#endif +#endif - wxWindow* CreateWindow (wxWindow* parent) +private: + void setup () { - wxPanel* panel = make_panel (parent); - wxFlexGridSizer* table = new wxFlexGridSizer (2, DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP); table->AddGrowableCol (1, 1); - panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); - + _panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); + { - add_label_to_sizer (table, panel, _("Default duration of still images"), true); + add_label_to_sizer (table, _panel, _("Default duration of still images"), true); wxBoxSizer* s = new wxBoxSizer (wxHORIZONTAL); - _still_length = new wxSpinCtrl (panel); + _still_length = new wxSpinCtrl (_panel); s->Add (_still_length); - add_label_to_sizer (s, panel, _("s"), false); + add_label_to_sizer (s, _panel, _("s"), false); table->Add (s, 1); } - - add_label_to_sizer (table, panel, _("Default directory for new films"), true); + + add_label_to_sizer (table, _panel, _("Default directory for new films"), true); #ifdef DCPOMATIC_USE_OWN_DIR_PICKER - _directory = new DirPickerCtrl (panel); -#else - _directory = new wxDirPickerCtrl (panel, wxDD_DIR_MUST_EXIST); + _directory = new DirPickerCtrl (_panel); +#else + _directory = new wxDirPickerCtrl (_panel, wxDD_DIR_MUST_EXIST); #endif table->Add (_directory, 1, wxEXPAND); - - add_label_to_sizer (table, panel, _("Default ISDCF name details"), true); - _isdcf_metadata_button = new wxButton (panel, wxID_ANY, _("Edit...")); + + add_label_to_sizer (table, _panel, _("Default ISDCF name details"), true); + _isdcf_metadata_button = new wxButton (_panel, wxID_ANY, _("Edit...")); table->Add (_isdcf_metadata_button); - add_label_to_sizer (table, panel, _("Default scale to"), true); - _scale = new wxChoice (panel, wxID_ANY); - table->Add (_scale); - - add_label_to_sizer (table, panel, _("Default container"), true); - _container = new wxChoice (panel, wxID_ANY); + add_label_to_sizer (table, _panel, _("Default container"), true); + _container = new wxChoice (_panel, wxID_ANY); table->Add (_container); - - add_label_to_sizer (table, panel, _("Default content type"), true); - _dcp_content_type = new wxChoice (panel, wxID_ANY); + + add_label_to_sizer (table, _panel, _("Default content type"), true); + _dcp_content_type = new wxChoice (_panel, wxID_ANY); table->Add (_dcp_content_type); - + { - add_label_to_sizer (table, panel, _("Default JPEG2000 bandwidth"), true); + add_label_to_sizer (table, _panel, _("Default JPEG2000 bandwidth"), true); wxBoxSizer* s = new wxBoxSizer (wxHORIZONTAL); - _j2k_bandwidth = new wxSpinCtrl (panel); + _j2k_bandwidth = new wxSpinCtrl (_panel); s->Add (_j2k_bandwidth); - add_label_to_sizer (s, panel, _("Mbit/s"), false); + add_label_to_sizer (s, _panel, _("Mbit/s"), false); table->Add (s, 1); } - + { - add_label_to_sizer (table, panel, _("Default audio delay"), true); + add_label_to_sizer (table, _panel, _("Default audio delay"), true); wxBoxSizer* s = new wxBoxSizer (wxHORIZONTAL); - _audio_delay = new wxSpinCtrl (panel); + _audio_delay = new wxSpinCtrl (_panel); s->Add (_audio_delay); - add_label_to_sizer (s, panel, _("ms"), false); + add_label_to_sizer (s, _panel, _("ms"), false); table->Add (s, 1); } - add_label_to_sizer (table, panel, _("Default issuer"), true); - _issuer = new wxTextCtrl (panel, wxID_ANY); + add_label_to_sizer (table, _panel, _("Default issuer"), true); + _issuer = new wxTextCtrl (_panel, wxID_ANY); table->Add (_issuer, 1, wxEXPAND); - Config* config = Config::instance (); - _still_length->SetRange (1, 3600); - _still_length->SetValue (config->default_still_length ()); _still_length->Bind (wxEVT_COMMAND_SPINCTRL_UPDATED, boost::bind (&DefaultsPage::still_length_changed, this)); - - _directory->SetPath (std_to_wx (config->default_directory_or (wx_to_std (wxStandardPaths::Get().GetDocumentsDir())).string ())); + _directory->Bind (wxEVT_COMMAND_DIRPICKER_CHANGED, boost::bind (&DefaultsPage::directory_changed, this)); - - _isdcf_metadata_button->Bind (wxEVT_COMMAND_BUTTON_CLICKED, boost::bind (&DefaultsPage::edit_isdcf_metadata_clicked, this, parent)); - - vector scales = VideoContentScale::all (); - for (size_t i = 0; i < scales.size(); ++i) { - _scale->Append (std_to_wx (scales[i].name ())); - if (scales[i] == config->default_scale ()) { - _scale->SetSelection (i); - } - } + + _isdcf_metadata_button->Bind (wxEVT_COMMAND_BUTTON_CLICKED, boost::bind (&DefaultsPage::edit_isdcf_metadata_clicked, this)); vector ratios = Ratio::all (); for (size_t i = 0; i < ratios.size(); ++i) { _container->Append (std_to_wx (ratios[i]->nickname ())); - if (ratios[i] == config->default_container ()) { - _container->SetSelection (i); - } } - - _scale->Bind (wxEVT_COMMAND_CHOICE_SELECTED, boost::bind (&DefaultsPage::scale_changed, this)); + _container->Bind (wxEVT_COMMAND_CHOICE_SELECTED, boost::bind (&DefaultsPage::container_changed, this)); - + vector const ct = DCPContentType::all (); for (size_t i = 0; i < ct.size(); ++i) { _dcp_content_type->Append (std_to_wx (ct[i]->pretty_name ())); - if (ct[i] == config->default_dcp_content_type ()) { - _dcp_content_type->SetSelection (i); - } } - + _dcp_content_type->Bind (wxEVT_COMMAND_CHOICE_SELECTED, boost::bind (&DefaultsPage::dcp_content_type_changed, this)); - + _j2k_bandwidth->SetRange (50, 250); - _j2k_bandwidth->SetValue (config->default_j2k_bandwidth() / 1000000); _j2k_bandwidth->Bind (wxEVT_COMMAND_SPINCTRL_UPDATED, boost::bind (&DefaultsPage::j2k_bandwidth_changed, this)); - + _audio_delay->SetRange (-1000, 1000); - _audio_delay->SetValue (config->default_audio_delay ()); _audio_delay->Bind (wxEVT_COMMAND_SPINCTRL_UPDATED, boost::bind (&DefaultsPage::audio_delay_changed, this)); - _issuer->SetValue (std_to_wx (config->dcp_issuer ())); _issuer->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&DefaultsPage::issuer_changed, this)); + } + + void config_changed () + { + Config* config = Config::instance (); + + vector ratios = Ratio::all (); + for (size_t i = 0; i < ratios.size(); ++i) { + if (ratios[i] == config->default_container ()) { + _container->SetSelection (i); + } + } + + vector const ct = DCPContentType::all (); + for (size_t i = 0; i < ct.size(); ++i) { + if (ct[i] == config->default_dcp_content_type ()) { + _dcp_content_type->SetSelection (i); + } + } - return panel; + checked_set (_still_length, config->default_still_length ()); + _directory->SetPath (std_to_wx (config->default_directory_or (wx_to_std (wxStandardPaths::Get().GetDocumentsDir())).string ())); + checked_set (_j2k_bandwidth, config->default_j2k_bandwidth() / 1000000); + _j2k_bandwidth->SetRange (50, config->maximum_j2k_bandwidth() / 1000000); + checked_set (_audio_delay, config->default_audio_delay ()); + checked_set (_issuer, config->dcp_issuer ()); } -private: void j2k_bandwidth_changed () { Config::instance()->set_default_j2k_bandwidth (_j2k_bandwidth->GetValue() * 1000000); } - + void audio_delay_changed () { Config::instance()->set_default_audio_delay (_audio_delay->GetValue()); @@ -381,9 +438,9 @@ private: Config::instance()->set_default_directory (wx_to_std (_directory->GetPath ())); } - void edit_isdcf_metadata_clicked (wxWindow* parent) + void edit_isdcf_metadata_clicked () { - ISDCFMetadataDialog* d = new ISDCFMetadataDialog (parent, Config::instance()->default_isdcf_metadata ()); + ISDCFMetadataDialog* d = new ISDCFMetadataDialog (_panel, Config::instance()->default_isdcf_metadata ()); d->ShowModal (); Config::instance()->set_default_isdcf_metadata (d->isdcf_metadata ()); d->Destroy (); @@ -394,18 +451,12 @@ private: Config::instance()->set_default_still_length (_still_length->GetValue ()); } - void scale_changed () - { - vector scale = VideoContentScale::all (); - Config::instance()->set_default_scale (scale[_scale->GetSelection()]); - } - void container_changed () { vector ratio = Ratio::all (); Config::instance()->set_default_container (ratio[_container->GetSelection()]); } - + void dcp_content_type_changed () { vector ct = DCPContentType::all (); @@ -416,7 +467,7 @@ private: { Config::instance()->set_dcp_issuer (wx_to_std (_issuer->GetValue ())); } - + wxSpinCtrl* _j2k_bandwidth; wxSpinCtrl* _audio_delay; wxButton* _isdcf_metadata_button; @@ -426,57 +477,56 @@ private: #else wxDirPickerCtrl* _directory; #endif - wxChoice* _scale; wxChoice* _container; wxChoice* _dcp_content_type; wxTextCtrl* _issuer; }; -class EncodingServersPage : public wxPreferencesPage, public Page +class EncodingServersPage : public StandardPage { public: EncodingServersPage (wxSize panel_size, int border) - : Page (panel_size, border) + : StandardPage (panel_size, border) {} - + wxString GetName () const { return _("Servers"); } -#ifdef DCPOMATIC_OSX +#ifdef DCPOMATIC_OSX wxBitmap GetLargeIcon () const { return wxBitmap ("servers", wxBITMAP_TYPE_PNG_RESOURCE); } -#endif +#endif - wxWindow* CreateWindow (wxWindow* parent) +private: + void setup () { - wxPanel* panel = make_panel (parent); - - _use_any_servers = new wxCheckBox (panel, wxID_ANY, _("Use all servers")); - panel->GetSizer()->Add (_use_any_servers, 0, wxALL, _border); - + _use_any_servers = new wxCheckBox (_panel, wxID_ANY, _("Use all servers")); + _panel->GetSizer()->Add (_use_any_servers, 0, wxALL, _border); + vector columns; columns.push_back (wx_to_std (_("IP address / host name"))); _servers_list = new EditableList ( - panel, + _panel, columns, boost::bind (&Config::servers, Config::instance()), boost::bind (&Config::set_servers, Config::instance(), _1), boost::bind (&EncodingServersPage::server_column, this, _1) ); - - panel->GetSizer()->Add (_servers_list, 1, wxEXPAND | wxALL, _border); - - _use_any_servers->SetValue (Config::instance()->use_any_servers ()); - _use_any_servers->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&EncodingServersPage::use_any_servers_changed, this)); - return panel; + _panel->GetSizer()->Add (_servers_list, 1, wxEXPAND | wxALL, _border); + + _use_any_servers->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&EncodingServersPage::use_any_servers_changed, this)); } -private: + void config_changed () + { + checked_set (_use_any_servers, Config::instance()->use_any_servers ()); + _servers_list->refresh (); + } void use_any_servers_changed () { @@ -492,55 +542,11 @@ private: EditableList* _servers_list; }; -class ColourConversionsPage : public wxPreferencesPage, public Page -{ -public: - ColourConversionsPage (wxSize panel_size, int border) - : Page (panel_size, border) - {} - - wxString GetName () const - { - return _("Colour Conversions"); - } - -#ifdef DCPOMATIC_OSX - wxBitmap GetLargeIcon () const - { - return wxBitmap ("colour_conversions", wxBITMAP_TYPE_PNG_RESOURCE); - } -#endif - wxWindow* CreateWindow (wxWindow* parent) - { - wxPanel* panel = make_panel (parent); - - vector columns; - columns.push_back (wx_to_std (_("Name"))); - wxPanel* list = new EditableList ( - panel, - columns, - boost::bind (&Config::colour_conversions, Config::instance()), - boost::bind (&Config::set_colour_conversions, Config::instance(), _1), - boost::bind (&ColourConversionsPage::colour_conversion_column, this, _1), - 300 - ); - - panel->GetSizer()->Add (list, 1, wxEXPAND | wxALL, _border); - return panel; - } - -private: - string colour_conversion_column (PresetColourConversion c) - { - return c.name; - } -}; - -class KeysPage : public wxPreferencesPage, public Page +class KeysPage : public StandardPage { public: KeysPage (wxSize panel_size, int border) - : Page (panel_size, border) + : StandardPage (panel_size, border) {} wxString GetName () const @@ -553,20 +559,17 @@ public: { return wxBitmap ("keys", wxBITMAP_TYPE_PNG_RESOURCE); } -#endif +#endif - wxWindow* CreateWindow (wxWindow* parent) +private: + void setup () { - _panel = new wxPanel (parent, wxID_ANY, wxDefaultPosition, _panel_size); - wxBoxSizer* overall_sizer = new wxBoxSizer (wxVERTICAL); - _panel->SetSizer (overall_sizer); - wxStaticText* m = new wxStaticText (_panel, wxID_ANY, _("Certificate chain for signing DCPs and KDMs:")); - overall_sizer->Add (m, 0, wxALL, _border); - + _panel->GetSizer()->Add (m, 0, wxALL, _border); + wxBoxSizer* certificates_sizer = new wxBoxSizer (wxHORIZONTAL); - overall_sizer->Add (certificates_sizer, 0, wxLEFT | wxRIGHT, _border); - + _panel->GetSizer()->Add (certificates_sizer, 0, wxLEFT | wxRIGHT, _border); + _certificates = new wxListCtrl (_panel, wxID_ANY, wxDefaultPosition, wxSize (400, 200), wxLC_REPORT | wxLC_SINGLE_SEL); { @@ -586,7 +589,7 @@ public: wxFont font = ip.GetFont (); font.SetFamily (wxFONTFAMILY_TELETYPE); ip.SetFont (font); - + _certificates->InsertColumn (1, ip); } @@ -601,57 +604,45 @@ public: certificates_sizer->Add (s, 0, wxLEFT, DCPOMATIC_SIZER_X_GAP); } - wxFlexGridSizer* table = new wxFlexGridSizer (2, DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP); - table->AddGrowableCol (1, 1); - overall_sizer->Add (table, 1, wxALL | wxEXPAND, _border); - - _remake_certificates = new wxButton (_panel, wxID_ANY, _("Re-make certificates...")); - table->Add (_remake_certificates, 0); - table->AddSpacer (0); - - add_label_to_sizer (table, _panel, _("Private key for leaf certificate"), true); - { - wxSizer* s = new wxBoxSizer (wxHORIZONTAL); - _signer_private_key = new wxStaticText (_panel, wxID_ANY, wxT ("")); - wxFont font = _signer_private_key->GetFont (); - font.SetFamily (wxFONTFAMILY_TELETYPE); - _signer_private_key->SetFont (font); - s->Add (_signer_private_key, 1, wxLEFT | wxRIGHT | wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_X_GAP); - _load_signer_private_key = new wxButton (_panel, wxID_ANY, _("Load...")); - s->Add (_load_signer_private_key, 0, wxLEFT, DCPOMATIC_SIZER_X_GAP); - table->Add (s, 0); - } + wxGridBagSizer* table = new wxGridBagSizer (DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP); + _panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); - add_label_to_sizer (table, _panel, _("Certificate for decrypting DCPs"), true); - { - wxSizer* s = new wxBoxSizer (wxHORIZONTAL); - _decryption_certificate = new wxStaticText (_panel, wxID_ANY, wxT ("")); - wxFont font = _decryption_certificate->GetFont (); - font.SetFamily (wxFONTFAMILY_TELETYPE); - _decryption_certificate->SetFont (font); - s->Add (_decryption_certificate, 1, wxLEFT | wxRIGHT | wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_X_GAP); - _load_decryption_certificate = new wxButton (_panel, wxID_ANY, _("Load...")); - s->Add (_load_decryption_certificate, 0, wxLEFT, DCPOMATIC_SIZER_X_GAP); - table->Add (s, 0); - } + int r = 0; - add_label_to_sizer (table, _panel, _("Private key for decrypting DCPs"), true); - { - wxSizer* s = new wxBoxSizer (wxHORIZONTAL); - _decryption_private_key = new wxStaticText (_panel, wxID_ANY, wxT ("")); - wxFont font = _decryption_private_key->GetFont (); - font.SetFamily (wxFONTFAMILY_TELETYPE); - _decryption_private_key->SetFont (font); - s->Add (_decryption_private_key, 1, wxLEFT | wxRIGHT | wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_X_GAP); - _load_decryption_private_key = new wxButton (_panel, wxID_ANY, _("Load...")); - s->Add (_load_decryption_private_key, 0, wxLEFT, DCPOMATIC_SIZER_X_GAP); - table->Add (s, 0); - } + _remake_certificates = new wxButton (_panel, wxID_ANY, _("Re-make certificates...")); + table->Add (_remake_certificates, wxGBPosition (r, 0), wxGBSpan (1, 3)); + ++r; + + add_label_to_grid_bag_sizer (table, _panel, _("Private key for leaf certificate"), true, wxGBPosition (r, 0)); + _signer_private_key = new wxStaticText (_panel, wxID_ANY, wxT ("")); + wxFont font = _signer_private_key->GetFont (); + font.SetFamily (wxFONTFAMILY_TELETYPE); + _signer_private_key->SetFont (font); + table->Add (_signer_private_key, wxGBPosition (r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL); + _load_signer_private_key = new wxButton (_panel, wxID_ANY, _("Load...")); + table->Add (_load_signer_private_key, wxGBPosition (r, 2)); + ++r; + + add_label_to_grid_bag_sizer (table, _panel, _("Certificate for decrypting DCPs"), true, wxGBPosition (r, 0)); + _decryption_certificate = new wxStaticText (_panel, wxID_ANY, wxT ("")); + _decryption_certificate->SetFont (font); + table->Add (_decryption_certificate, wxGBPosition (r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL); + _load_decryption_certificate = new wxButton (_panel, wxID_ANY, _("Load...")); + table->Add (_load_decryption_certificate, wxGBPosition (r, 2)); + ++r; + + add_label_to_grid_bag_sizer (table, _panel, _("Private key for decrypting DCPs"), true, wxGBPosition (r, 0)); + _decryption_private_key = new wxStaticText (_panel, wxID_ANY, wxT ("")); + _decryption_private_key->SetFont (font); + table->Add (_decryption_private_key, wxGBPosition (r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL); + _load_decryption_private_key = new wxButton (_panel, wxID_ANY, _("Load...")); + table->Add (_load_decryption_private_key, wxGBPosition (r, 2)); + ++r; _export_decryption_certificate = new wxButton (_panel, wxID_ANY, _("Export DCP decryption certificate...")); - table->Add (_export_decryption_certificate); - table->AddSpacer (0); - + table->Add (_export_decryption_certificate, wxGBPosition (r, 0), wxGBSpan (1, 3)); + ++r; + _add_certificate->Bind (wxEVT_COMMAND_BUTTON_CLICKED, boost::bind (&KeysPage::add_certificate, this)); _remove_certificate->Bind (wxEVT_COMMAND_BUTTON_CLICKED, boost::bind (&KeysPage::remove_certificate, this)); _certificates->Bind (wxEVT_COMMAND_LIST_ITEM_SELECTED, boost::bind (&KeysPage::update_sensitivity, this)); @@ -661,7 +652,10 @@ public: _load_decryption_certificate->Bind (wxEVT_COMMAND_BUTTON_CLICKED, boost::bind (&KeysPage::load_decryption_certificate, this)); _load_decryption_private_key->Bind (wxEVT_COMMAND_BUTTON_CLICKED, boost::bind (&KeysPage::load_decryption_private_key, this)); _export_decryption_certificate->Bind (wxEVT_COMMAND_BUTTON_CLICKED, boost::bind (&KeysPage::export_decryption_certificate, this)); + } + void config_changed () + { _signer.reset (new dcp::Signer (*Config::instance()->signer().get ())); update_certificate_list (); @@ -669,15 +663,12 @@ public: update_decryption_certificate (); update_decryption_private_key (); update_sensitivity (); - - return _panel; } -private: void add_certificate () { wxFileDialog* d = new wxFileDialog (_panel, _("Select Certificate File")); - + if (d->ShowModal() == wxID_OK) { try { dcp::Certificate c (dcp::file_to_string (wx_to_std (d->GetPath ()))); @@ -688,7 +679,7 @@ private: error_dialog (_panel, wxString::Format (_("Could not read certificate file (%s)"), e.what ())); } } - + d->Destroy (); update_sensitivity (); @@ -700,7 +691,7 @@ private: if (i == -1) { return; } - + _certificates->DeleteItem (i); _signer->certificates().remove (i); Config::instance()->set_signer (_signer); @@ -750,7 +741,7 @@ private: update_certificate_list (); update_signer_private_key (); } - + d->Destroy (); } @@ -761,8 +752,8 @@ private: void update_signer_private_key () { - _signer_private_key->SetLabel (std_to_wx (dcp::private_key_fingerprint (_signer->key ()))); - } + checked_set (_signer_private_key, dcp::private_key_fingerprint (_signer->key ())); + } void load_signer_private_key () { @@ -775,7 +766,7 @@ private: error_dialog (_panel, wxString::Format (_("Could not read key file (%s)"), std_to_wx (p.string ()))); return; } - + _signer->set_key (dcp::file_to_string (p)); Config::instance()->set_signer (_signer); update_signer_private_key (); @@ -783,7 +774,7 @@ private: error_dialog (_panel, wxString::Format (_("Could not read certificate file (%s)"), e.what ())); } } - + d->Destroy (); update_sensitivity (); @@ -793,7 +784,7 @@ private: void load_decryption_certificate () { wxFileDialog* d = new wxFileDialog (_panel, _("Select Certificate File")); - + if (d->ShowModal() == wxID_OK) { try { dcp::Certificate c (dcp::file_to_string (wx_to_std (d->GetPath ()))); @@ -803,13 +794,13 @@ private: error_dialog (_panel, wxString::Format (_("Could not read certificate file (%s)"), e.what ())); } } - + d->Destroy (); } void update_decryption_certificate () { - _decryption_certificate->SetLabel (std_to_wx (Config::instance()->decryption_certificate().thumbprint ())); + checked_set (_decryption_certificate, Config::instance()->decryption_certificate().thumbprint ()); } void load_decryption_private_key () @@ -825,13 +816,13 @@ private: error_dialog (_panel, wxString::Format (_("Could not read key file (%s)"), e.what ())); } } - + d->Destroy (); } void update_decryption_private_key () { - _decryption_private_key->SetLabel (std_to_wx (dcp::private_key_fingerprint (Config::instance()->decryption_private_key()))); + checked_set (_decryption_private_key, dcp::private_key_fingerprint (Config::instance()->decryption_private_key())); } void export_decryption_certificate () @@ -840,7 +831,7 @@ private: _panel, _("Select Certificate File"), wxEmptyString, wxEmptyString, wxT ("PEM files (*.pem)|*.pem"), wxFD_SAVE | wxFD_OVERWRITE_PROMPT ); - + if (d->ShowModal () == wxID_OK) { FILE* f = fopen_boost (wx_to_std (d->GetPath ()), "w"); if (!f) { @@ -854,7 +845,6 @@ private: d->Destroy (); } - wxPanel* _panel; wxListCtrl* _certificates; wxButton* _add_certificate; wxButton* _remove_certificate; @@ -869,11 +859,11 @@ private: shared_ptr _signer; }; -class TMSPage : public wxPreferencesPage, public Page +class TMSPage : public StandardPage { public: TMSPage (wxSize panel_size, int border) - : Page (panel_size, border) + : StandardPage (panel_size, border) {} wxString GetName () const @@ -881,67 +871,67 @@ public: return _("TMS"); } -#ifdef DCPOMATIC_OSX +#ifdef DCPOMATIC_OSX wxBitmap GetLargeIcon () const { return wxBitmap ("tms", wxBITMAP_TYPE_PNG_RESOURCE); } -#endif +#endif - wxWindow* CreateWindow (wxWindow* parent) +private: + void setup () { - wxPanel* panel = make_panel (parent); - wxFlexGridSizer* table = new wxFlexGridSizer (2, DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP); table->AddGrowableCol (1, 1); - panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); - - add_label_to_sizer (table, panel, _("IP address"), true); - _tms_ip = new wxTextCtrl (panel, wxID_ANY); + _panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); + + add_label_to_sizer (table, _panel, _("IP address"), true); + _tms_ip = new wxTextCtrl (_panel, wxID_ANY); table->Add (_tms_ip, 1, wxEXPAND); - - add_label_to_sizer (table, panel, _("Target path"), true); - _tms_path = new wxTextCtrl (panel, wxID_ANY); + + add_label_to_sizer (table, _panel, _("Target path"), true); + _tms_path = new wxTextCtrl (_panel, wxID_ANY); table->Add (_tms_path, 1, wxEXPAND); - - add_label_to_sizer (table, panel, _("User name"), true); - _tms_user = new wxTextCtrl (panel, wxID_ANY); + + add_label_to_sizer (table, _panel, _("User name"), true); + _tms_user = new wxTextCtrl (_panel, wxID_ANY); table->Add (_tms_user, 1, wxEXPAND); - - add_label_to_sizer (table, panel, _("Password"), true); - _tms_password = new wxTextCtrl (panel, wxID_ANY); + + add_label_to_sizer (table, _panel, _("Password"), true); + _tms_password = new wxTextCtrl (_panel, wxID_ANY); table->Add (_tms_password, 1, wxEXPAND); - - Config* config = Config::instance (); - - _tms_ip->SetValue (std_to_wx (config->tms_ip ())); + _tms_ip->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&TMSPage::tms_ip_changed, this)); - _tms_path->SetValue (std_to_wx (config->tms_path ())); _tms_path->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&TMSPage::tms_path_changed, this)); - _tms_user->SetValue (std_to_wx (config->tms_user ())); _tms_user->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&TMSPage::tms_user_changed, this)); - _tms_password->SetValue (std_to_wx (config->tms_password ())); _tms_password->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&TMSPage::tms_password_changed, this)); + } - return panel; + void config_changed () + { + Config* config = Config::instance (); + + checked_set (_tms_ip, config->tms_ip ()); + checked_set (_tms_path, config->tms_path ()); + checked_set (_tms_user, config->tms_user ()); + checked_set (_tms_password, config->tms_password ()); } -private: void tms_ip_changed () { Config::instance()->set_tms_ip (wx_to_std (_tms_ip->GetValue ())); } - + void tms_path_changed () { Config::instance()->set_tms_path (wx_to_std (_tms_path->GetValue ())); } - + void tms_user_changed () { Config::instance()->set_tms_user (wx_to_std (_tms_user->GetValue ())); } - + void tms_password_changed () { Config::instance()->set_tms_password (wx_to_std (_tms_password->GetValue ())); @@ -953,115 +943,114 @@ private: wxTextCtrl* _tms_password; }; -class KDMEmailPage : public wxPreferencesPage, public Page +class KDMEmailPage : public StandardPage { public: KDMEmailPage (wxSize panel_size, int border) - : Page (panel_size, border) +#ifdef DCPOMATIC_OSX + /* We have to force both width and height of this one */ + : StandardPage (wxSize (480, 128), border) +#else + : StandardPage (panel_size, border) +#endif {} - + wxString GetName () const { return _("KDM Email"); } -#ifdef DCPOMATIC_OSX +#ifdef DCPOMATIC_OSX wxBitmap GetLargeIcon () const { return wxBitmap ("kdm_email", wxBITMAP_TYPE_PNG_RESOURCE); } -#endif - - wxWindow* CreateWindow (wxWindow* parent) - { -#ifdef DCPOMATIC_OSX - /* We have to force both width and height of this one */ - wxPanel* panel = new wxPanel (parent, wxID_ANY, wxDefaultPosition, wxSize (480, 128)); -#else - wxPanel* panel = new wxPanel (parent); #endif - wxBoxSizer* s = new wxBoxSizer (wxVERTICAL); - panel->SetSizer (s); +private: + void setup () + { wxFlexGridSizer* table = new wxFlexGridSizer (2, DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP); table->AddGrowableCol (1, 1); - panel->GetSizer()->Add (table, 1, wxEXPAND | wxALL, _border); + _panel->GetSizer()->Add (table, 1, wxEXPAND | wxALL, _border); - add_label_to_sizer (table, panel, _("Outgoing mail server"), true); - _mail_server = new wxTextCtrl (panel, wxID_ANY); + add_label_to_sizer (table, _panel, _("Outgoing mail server"), true); + _mail_server = new wxTextCtrl (_panel, wxID_ANY); table->Add (_mail_server, 1, wxEXPAND | wxALL); - - add_label_to_sizer (table, panel, _("Mail user name"), true); - _mail_user = new wxTextCtrl (panel, wxID_ANY); + + add_label_to_sizer (table, _panel, _("Mail user name"), true); + _mail_user = new wxTextCtrl (_panel, wxID_ANY); table->Add (_mail_user, 1, wxEXPAND | wxALL); - - add_label_to_sizer (table, panel, _("Mail password"), true); - _mail_password = new wxTextCtrl (panel, wxID_ANY); + + add_label_to_sizer (table, _panel, _("Mail password"), true); + _mail_password = new wxTextCtrl (_panel, wxID_ANY); table->Add (_mail_password, 1, wxEXPAND | wxALL); - - wxStaticText* plain = add_label_to_sizer (table, panel, _("(password will be stored on disk in plaintext)"), false); + + wxStaticText* plain = add_label_to_sizer (table, _panel, _("(password will be stored on disk in plaintext)"), false); wxFont font = plain->GetFont(); font.SetStyle (wxFONTSTYLE_ITALIC); font.SetPointSize (font.GetPointSize() - 1); plain->SetFont (font); table->AddSpacer (0); - add_label_to_sizer (table, panel, _("Subject"), true); - _kdm_subject = new wxTextCtrl (panel, wxID_ANY); + add_label_to_sizer (table, _panel, _("Subject"), true); + _kdm_subject = new wxTextCtrl (_panel, wxID_ANY); table->Add (_kdm_subject, 1, wxEXPAND | wxALL); - - add_label_to_sizer (table, panel, _("From address"), true); - _kdm_from = new wxTextCtrl (panel, wxID_ANY); + + add_label_to_sizer (table, _panel, _("From address"), true); + _kdm_from = new wxTextCtrl (_panel, wxID_ANY); table->Add (_kdm_from, 1, wxEXPAND | wxALL); - add_label_to_sizer (table, panel, _("CC address"), true); - _kdm_cc = new wxTextCtrl (panel, wxID_ANY); + add_label_to_sizer (table, _panel, _("CC address"), true); + _kdm_cc = new wxTextCtrl (_panel, wxID_ANY); table->Add (_kdm_cc, 1, wxEXPAND | wxALL); - add_label_to_sizer (table, panel, _("BCC address"), true); - _kdm_bcc = new wxTextCtrl (panel, wxID_ANY); + add_label_to_sizer (table, _panel, _("BCC address"), true); + _kdm_bcc = new wxTextCtrl (_panel, wxID_ANY); table->Add (_kdm_bcc, 1, wxEXPAND | wxALL); - - _kdm_email = new wxTextCtrl (panel, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize (480, 128), wxTE_MULTILINE); - panel->GetSizer()->Add (_kdm_email, 1, wxEXPAND | wxALL, _border); - _reset_kdm_email = new wxButton (panel, wxID_ANY, _("Reset to default text")); - panel->GetSizer()->Add (_reset_kdm_email, 0, wxEXPAND | wxALL, _border); + _kdm_email = new wxTextCtrl (_panel, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize (480, 128), wxTE_MULTILINE); + _panel->GetSizer()->Add (_kdm_email, 1, wxEXPAND | wxALL, _border); + + _reset_kdm_email = new wxButton (_panel, wxID_ANY, _("Reset to default text")); + _panel->GetSizer()->Add (_reset_kdm_email, 0, wxEXPAND | wxALL, _border); - Config* config = Config::instance (); - _mail_server->SetValue (std_to_wx (config->mail_server ())); _mail_server->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&KDMEmailPage::mail_server_changed, this)); - _mail_user->SetValue (std_to_wx (config->mail_user ())); _mail_user->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&KDMEmailPage::mail_user_changed, this)); - _mail_password->SetValue (std_to_wx (config->mail_password ())); _mail_password->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&KDMEmailPage::mail_password_changed, this)); - _kdm_subject->SetValue (std_to_wx (config->kdm_subject ())); _kdm_subject->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&KDMEmailPage::kdm_subject_changed, this)); - _kdm_from->SetValue (std_to_wx (config->kdm_from ())); _kdm_from->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&KDMEmailPage::kdm_from_changed, this)); - _kdm_cc->SetValue (std_to_wx (config->kdm_cc ())); _kdm_cc->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&KDMEmailPage::kdm_cc_changed, this)); - _kdm_bcc->SetValue (std_to_wx (config->kdm_bcc ())); _kdm_bcc->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&KDMEmailPage::kdm_bcc_changed, this)); _kdm_email->Bind (wxEVT_COMMAND_TEXT_UPDATED, boost::bind (&KDMEmailPage::kdm_email_changed, this)); - _kdm_email->SetValue (std_to_wx (Config::instance()->kdm_email ())); _reset_kdm_email->Bind (wxEVT_COMMAND_BUTTON_CLICKED, boost::bind (&KDMEmailPage::reset_kdm_email, this)); + } + + void config_changed () + { + Config* config = Config::instance (); - return panel; + checked_set (_mail_server, config->mail_server ()); + checked_set (_mail_user, config->mail_user ()); + checked_set (_mail_password, config->mail_password ()); + checked_set (_kdm_subject, config->kdm_subject ()); + checked_set (_kdm_from, config->kdm_from ()); + checked_set (_kdm_cc, config->kdm_cc ()); + checked_set (_kdm_bcc, config->kdm_bcc ()); + checked_set (_kdm_email, Config::instance()->kdm_email ()); } -private: void mail_server_changed () { Config::instance()->set_mail_server (wx_to_std (_mail_server->GetValue ())); } - + void mail_user_changed () { Config::instance()->set_mail_user (wx_to_std (_mail_user->GetValue ())); } - + void mail_password_changed () { Config::instance()->set_mail_password (wx_to_std (_mail_password->GetValue ())); @@ -1071,7 +1060,7 @@ private: { Config::instance()->set_kdm_subject (wx_to_std (_kdm_subject->GetValue ())); } - + void kdm_from_changed () { Config::instance()->set_kdm_from (wx_to_std (_kdm_from->GetValue ())); @@ -1086,16 +1075,22 @@ private: { Config::instance()->set_kdm_bcc (wx_to_std (_kdm_bcc->GetValue ())); } - + void kdm_email_changed () { + if (_kdm_email->GetValue().IsEmpty ()) { + /* Sometimes we get sent an erroneous notification that the email + is empty; I don't know why. + */ + return; + } Config::instance()->set_kdm_email (wx_to_std (_kdm_email->GetValue ())); } void reset_kdm_email () { Config::instance()->reset_kdm_email (); - _kdm_email->SetValue (wx_to_std (Config::instance()->kdm_email ())); + checked_set (_kdm_email, Config::instance()->kdm_email ()); } wxTextCtrl* _mail_server; @@ -1112,87 +1107,92 @@ private: /** @class AdvancedPage * @brief Advanced page of the preferences dialog. */ -class AdvancedPage : public wxStockPreferencesPage, public Page +class AdvancedPage : public StockPage { public: - AdvancedPage (wxSize panel_size, int border) - : wxStockPreferencesPage (Kind_Advanced) - , Page (panel_size, border) + : StockPage (Kind_Advanced, panel_size, border) + , _maximum_j2k_bandwidth (0) + , _allow_any_dcp_frame_rate (0) + , _log_general (0) + , _log_warning (0) + , _log_error (0) + , _log_timing (0) {} - - wxWindow* CreateWindow (wxWindow* parent) - { - wxPanel* panel = make_panel (parent); +private: + void setup () + { wxFlexGridSizer* table = new wxFlexGridSizer (2, DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP); table->AddGrowableCol (1, 1); - panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); + _panel->GetSizer()->Add (table, 1, wxALL | wxEXPAND, _border); { - add_label_to_sizer (table, panel, _("Maximum JPEG2000 bandwidth"), true); + add_label_to_sizer (table, _panel, _("Maximum JPEG2000 bandwidth"), true); wxBoxSizer* s = new wxBoxSizer (wxHORIZONTAL); - _maximum_j2k_bandwidth = new wxSpinCtrl (panel); + _maximum_j2k_bandwidth = new wxSpinCtrl (_panel); s->Add (_maximum_j2k_bandwidth, 1); - add_label_to_sizer (s, panel, _("Mbit/s"), false); + add_label_to_sizer (s, _panel, _("Mbit/s"), false); table->Add (s, 1); } - _allow_any_dcp_frame_rate = new wxCheckBox (panel, wxID_ANY, _("Allow any DCP frame rate")); + _allow_any_dcp_frame_rate = new wxCheckBox (_panel, wxID_ANY, _("Allow any DCP frame rate")); table->Add (_allow_any_dcp_frame_rate, 1, wxEXPAND | wxALL); table->AddSpacer (0); #ifdef __WXOSX__ - wxStaticText* m = new wxStaticText (panel, wxID_ANY, _("Log:")); + wxStaticText* m = new wxStaticText (_panel, wxID_ANY, _("Log:")); table->Add (m, 0, wxALIGN_TOP | wxLEFT | wxRIGHT | wxEXPAND | wxALL | wxALIGN_RIGHT, 6); -#else - wxStaticText* m = new wxStaticText (panel, wxID_ANY, _("Log")); +#else + wxStaticText* m = new wxStaticText (_panel, wxID_ANY, _("Log")); table->Add (m, 0, wxALIGN_TOP | wxLEFT | wxRIGHT | wxEXPAND | wxALL, 6); -#endif - +#endif + { wxBoxSizer* t = new wxBoxSizer (wxVERTICAL); - _log_general = new wxCheckBox (panel, wxID_ANY, _("General")); + _log_general = new wxCheckBox (_panel, wxID_ANY, _("General")); t->Add (_log_general, 1, wxEXPAND | wxALL); - _log_warning = new wxCheckBox (panel, wxID_ANY, _("Warnings")); + _log_warning = new wxCheckBox (_panel, wxID_ANY, _("Warnings")); t->Add (_log_warning, 1, wxEXPAND | wxALL); - _log_error = new wxCheckBox (panel, wxID_ANY, _("Errors")); + _log_error = new wxCheckBox (_panel, wxID_ANY, _("Errors")); t->Add (_log_error, 1, wxEXPAND | wxALL); - _log_timing = new wxCheckBox (panel, wxID_ANY, S_("Config|Timing")); + _log_timing = new wxCheckBox (_panel, wxID_ANY, S_("Config|Timing")); t->Add (_log_timing, 1, wxEXPAND | wxALL); table->Add (t, 0, wxALL, 6); } -#ifdef DCPOMATIC_WINDOWS - _win32_console = new wxCheckBox (panel, wxID_ANY, _("Open console window")); +#ifdef DCPOMATIC_WINDOWS + _win32_console = new wxCheckBox (_panel, wxID_ANY, _("Open console window")); table->Add (_win32_console, 1, wxEXPAND | wxALL); table->AddSpacer (0); -#endif - - Config* config = Config::instance (); - - _maximum_j2k_bandwidth->SetRange (1, 500); - _maximum_j2k_bandwidth->SetValue (config->maximum_j2k_bandwidth() / 1000000); +#endif + + _maximum_j2k_bandwidth->SetRange (1, 1000); _maximum_j2k_bandwidth->Bind (wxEVT_COMMAND_SPINCTRL_UPDATED, boost::bind (&AdvancedPage::maximum_j2k_bandwidth_changed, this)); - _allow_any_dcp_frame_rate->SetValue (config->allow_any_dcp_frame_rate ()); _allow_any_dcp_frame_rate->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&AdvancedPage::allow_any_dcp_frame_rate_changed, this)); - _log_general->SetValue (config->log_types() & Log::TYPE_GENERAL); _log_general->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&AdvancedPage::log_changed, this)); - _log_warning->SetValue (config->log_types() & Log::TYPE_WARNING); _log_warning->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&AdvancedPage::log_changed, this)); - _log_error->SetValue (config->log_types() & Log::TYPE_ERROR); _log_error->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&AdvancedPage::log_changed, this)); - _log_timing->SetValue (config->log_types() & Log::TYPE_TIMING); _log_timing->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&AdvancedPage::log_changed, this)); #ifdef DCPOMATIC_WINDOWS - _win32_console->SetValue (config->win32_console()); _win32_console->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, boost::bind (&AdvancedPage::win32_console_changed, this)); -#endif - - return panel; +#endif } -private: + void config_changed () + { + Config* config = Config::instance (); + + checked_set (_maximum_j2k_bandwidth, config->maximum_j2k_bandwidth() / 1000000); + checked_set (_allow_any_dcp_frame_rate, config->allow_any_dcp_frame_rate ()); + checked_set (_log_general, config->log_types() & Log::TYPE_GENERAL); + checked_set (_log_warning, config->log_types() & Log::TYPE_WARNING); + checked_set (_log_error, config->log_types() & Log::TYPE_ERROR); + checked_set (_log_timing, config->log_types() & Log::TYPE_TIMING); +#ifdef DCPOMATIC_WINDOWS + checked_set (_win32_console, config->win32_console()); +#endif + } void maximum_j2k_bandwidth_changed () { @@ -1222,24 +1222,24 @@ private: Config::instance()->set_log_types (types); } -#ifdef DCPOMATIC_WINDOWS +#ifdef DCPOMATIC_WINDOWS void win32_console_changed () { Config::instance()->set_win32_console (_win32_console->GetValue ()); } -#endif - +#endif + wxSpinCtrl* _maximum_j2k_bandwidth; wxCheckBox* _allow_any_dcp_frame_rate; wxCheckBox* _log_general; wxCheckBox* _log_warning; wxCheckBox* _log_error; wxCheckBox* _log_timing; -#ifdef DCPOMATIC_WINDOWS +#ifdef DCPOMATIC_WINDOWS wxCheckBox* _win32_console; -#endif +#endif }; - + wxPreferencesEditor* create_config_dialog () { @@ -1256,11 +1256,10 @@ create_config_dialog () wxSize ps = wxSize (-1, -1); int const border = 8; #endif - + e->AddPage (new GeneralPage (ps, border)); e->AddPage (new DefaultsPage (ps, border)); e->AddPage (new EncodingServersPage (ps, border)); - e->AddPage (new ColourConversionsPage (ps, border)); e->AddPage (new KeysPage (ps, border)); e->AddPage (new TMSPage (ps, border)); e->AddPage (new KDMEmailPage (ps, border));