X-Git-Url: https://main.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Fwx%2Fjob_view.cc;h=b61da04f84da3ff1dd6dbba67f3c1e0187c1a7d5;hb=e0da7a310a9e7f05c7c75fa7b39f1fb110567d60;hp=43d6f2fedd9ca90f44d4ec3e191fb673af560f2f;hpb=f2dd76c91f1fd314df12d5dff3b736daf783b9b3;p=dcpomatic.git

diff --git a/src/wx/job_view.cc b/src/wx/job_view.cc
index 43d6f2fed..b61da04f8 100644
--- a/src/wx/job_view.cc
+++ b/src/wx/job_view.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2012-2018 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2019 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -20,6 +20,10 @@
 
 #include "job_view.h"
 #include "wx_util.h"
+#include "message_dialog.h"
+#include "static_text.h"
+#include "check_box.h"
+#include "dcpomatic_button.h"
 #include "lib/job.h"
 #include "lib/job_manager.h"
 #include "lib/compose.hpp"
@@ -28,6 +32,7 @@
 #include "lib/transcode_job.h"
 #include "lib/analyse_audio_job.h"
 #include <wx/wx.h>
+#include <boost/algorithm/string.hpp>
 
 using std::string;
 using std::min;
@@ -55,18 +60,18 @@ JobView::setup ()
 	/* This seems to be required to allow the gauge to shrink under OS X */
 	_gauge->SetMinSize (wxSize (0, -1));
 	_gauge_message->Add (_gauge, 0, wxEXPAND | wxLEFT | wxRIGHT);
-	_message = new wxStaticText (_container, wxID_ANY, wxT (" \n "), wxDefaultPosition, wxDefaultSize, wxST_ELLIPSIZE_MIDDLE);
+	_message = new StaticText (_container, wxT(" \n "), wxDefaultPosition, wxDefaultSize, wxST_ELLIPSIZE_MIDDLE);
 	_gauge_message->Add (_message, 1, wxEXPAND | wxALIGN_CENTER_VERTICAL | wxALL, 6);
 	_table->Insert (n, _gauge_message, 1, wxEXPAND | wxLEFT | wxRIGHT);
 	++n;
 
 	_buttons = new wxBoxSizer (wxHORIZONTAL);
 
-	_cancel = new wxButton (_container, wxID_ANY, _("Cancel"));
+	_cancel = new Button (_container, _("Cancel"));
 	_cancel->Bind (wxEVT_BUTTON, &JobView::cancel_clicked, this);
 	_buttons->Add (_cancel, 1, wxALIGN_CENTER_VERTICAL);
 
-	_details = new wxButton (_container, wxID_ANY, _("Details..."));
+	_details = new Button (_container, _("Details..."));
 	_details->Bind (wxEVT_BUTTON, &JobView::details_clicked, this);
 	_details->Enable (false);
 	_buttons->Add (_details, 1, wxALIGN_CENTER_VERTICAL);
@@ -75,7 +80,7 @@ JobView::setup ()
 
 	_controls = new wxBoxSizer (wxVERTICAL);
 	_controls->Add (_buttons);
-	_notify = new wxCheckBox (_container, wxID_ANY, _("Notify when complete"));
+	_notify = new CheckBox (_container, _("Notify when complete"));
 	_notify->Bind (wxEVT_CHECKBOX, bind (&JobView::notify_clicked, this));
 	_notify->SetValue (Config::instance()->default_notify());
 	_controls->Add (_notify);
@@ -105,7 +110,11 @@ JobView::progress ()
 	if (!_job->sub_name().empty ()) {
 		whole += _job->sub_name() + " ";
 	}
-	whole += _job->status ();
+	string s = _job->status ();
+	/* Watch out for < > in the error string */
+	boost::algorithm::replace_all (s, "<", "&lt;");
+	boost::algorithm::replace_all (s, ">", "&gt;");
+	whole += s;
 	if (whole != _last_message) {
 		_message->SetLabelMarkup (std_to_wx (whole));
 		/* This hack fixes the size of _message on OS X */
@@ -134,6 +143,12 @@ JobView::finished ()
 		_details->Enable (true);
 	}
 
+	if (_job->message()) {
+		MessageDialog* d = new MessageDialog (_parent, _job->name(), _job->message().get());
+		d->ShowModal ();
+		d->Destroy ();
+	}
+
 	if ((dynamic_pointer_cast<TranscodeJob>(_job) || dynamic_pointer_cast<AnalyseAudioJob>(_job)) && _notify->GetValue()) {
 		if (Config::instance()->notification(Config::MESSAGE_BOX)) {
 			wxMessageBox (std_to_wx(_job->name() + ": " + _job->status()), _("DCP-o-matic"), wxICON_INFORMATION);