dramatic change in logic and naming for operations related to adding a MIDI region...
authorPaul Davis <paul@linuxaudiosystems.com>
Sun, 13 Apr 2014 14:29:07 +0000 (10:29 -0400)
committerPaul Davis <paul@linuxaudiosystems.com>
Mon, 14 Apr 2014 06:17:30 +0000 (02:17 -0400)
commit343b06d8d3522d6b017d887ca754c91aec2430fd
tree81aa51fa0fea6826e62480314c1ac78b112b3a9a
parentd2a31ab6eed8b3e8f34dbc1caf2285bb64777f55
dramatic change in logic and naming for operations related to adding a MIDI region on demand and cloning/unlinking

Existing code would cause data loss due to creation of two Source objects referring the same path, one with removable flags and one without. Careful code review suggested a variety of thinkos, function naming problems and other confusion that caused this. I have tried ot extensively comment what is going on with these operations, because it is one key area in which MIDI differs from audio: with audio, capture is the only way to add a new audio region, but for MIDI there are GUI input events that can add a new region.
12 files changed:
gtk2_ardour/editor_ops.cc
gtk2_ardour/midi_time_axis.cc
libs/ardour/ardour/audiofilesource.h
libs/ardour/ardour/midi_region.h
libs/ardour/ardour/midi_source.h
libs/ardour/ardour/session.h
libs/ardour/ardour/smf_source.h
libs/ardour/file_source.cc
libs/ardour/midi_diskstream.cc
libs/ardour/midi_region.cc
libs/ardour/midi_source.cc
libs/ardour/session.cc