Reimplementation of large parts of the WaveView class
authorTim Mayberry <mojofunk@gmail.com>
Thu, 16 Mar 2017 04:12:05 +0000 (14:12 +1000)
committerTim Mayberry <mojofunk@gmail.com>
Sun, 25 Jun 2017 22:40:47 +0000 (08:40 +1000)
commit6e91ee071c23440827541adb4c057f8c55d4a2f2
tree1a4370e8db9eb8af7081e1af179f014cd6719961
parent5f30d87fd0127bb475894825c6e4acc01fcedb29
Reimplementation of large parts of the WaveView class

The drawing itself should be unchanged but much of the rest of the
implementation has changed. The WaveViewThreads and WaveViewDrawingThread
classes were added and allow multiple drawing threads.

The Item::prepare_for_render interface is implemented by WaveView to enable
queuing draw requests for the drawing threads to process as soon as the state
change occurs during Editor::visual_changer, which often means the images will
be finished by the time they are needed in WaveView::render. This can
significantly reduce total render time and also flickering caused by images not
being ready for display.

If the drawing thread/s cannot finish the request by the time it is required in
WaveView::render then cancel it and draw the WaveViewImage in the GUI thread if
it is likely it can be completed in the current render pass/frame.  This change
also helps reduce the flickering caused by images not being ready with threaded
rendering, but with several drawing threads, drawing in the GUI thread may not
often occur (unless explicitly requested).

Allow unfinished images to be returned from the cache in
WaveView::prepare_for_render so that new draw requests aren't queued for
duplicate images. This reduces the amount of drawing for instance in
compositions where there are many instances of the same sample/waveform
displayed on the canvas as only a single image should be drawn.

Use a random width within a certain range for
WaveView::optimal_image_width_samples so that image drawing is less likely to
occur at the same time (which will cause a spike in render/draw time and
increase the chance of flickering waveforms).

Move implementations of the private WaveView classes into wave_view_private.h
and wave_view_private.cc source files.

Incorporate a fix for limiting the waveview image size to the cairo image size
limit.

Should hopefully Resolve: #6478
libs/canvas/canvas/wave_view.h
libs/canvas/canvas/wave_view_private.h [new file with mode: 0644]
libs/canvas/wave_view.cc
libs/canvas/wave_view_private.cc [new file with mode: 0644]
libs/canvas/wscript