do NOT use Glib::ustring unless you know that the contents are UTF-8 AND that you...
authorPaul Davis <paul@linuxaudiosystems.com>
Sun, 24 Apr 2016 04:37:53 +0000 (00:37 -0400)
committerPaul Davis <paul@linuxaudiosystems.com>
Sun, 24 Apr 2016 04:38:05 +0000 (00:38 -0400)
commitc4c6c38dbde32fa9478977740864f5c141dff092
tree590d92dc4ccdb375f9b27988c2d9c710d77f62b4
parent4fe7d1ea08e364b3c0f69cae1a86c637e3cb1d77
do NOT use Glib::ustring unless you know that the contents are UTF-8 AND that you need to iterate glyph by glyph

This fixes a Glib::ConvertError that occured when using Glib::ustring::operator<<
inside a compose operation. This implicitly uses Glib::locale_from_utf8(), and if the string
is not legal UTF-8, an exception will be thrown.

std::string should be used EVERYWHERE unless glyph-by-glyph iteration is required. This is
very rare in the Ardour codebase, so you really shouldn't see Glib::ustring anywhere. The
main exception is handling user-input for a few specific cases.
gtk2_ardour/rc_option_editor.cc