Constrain variable scopen and avoid uninitialized values existing at all.

Note: dead assignments trigger scan-build dead code warnings, which
initializations do not.

diff --git a/libs/ardour/rb_effect.cc b/libs/ardour/rb_effect.cc
index 804b79f87df9e8a555adcbe56bb0a844279e5f8e..2749e18258585299c99afac82910677d2b6ea3d0 100644 (file)
--- a/libs/ardour/rb_effect.cc
+++ b/libs/ardour/rb_effect.cc
@@ -72,7 +72,6 @@ RBEffect::run (boost::shared_ptr<Region> r, Progress* progress)
        }
 
        SourceList nsrcs;
        }
 
        SourceList nsrcs;

-       framecnt_t done;

        int ret = -1;
        const framecnt_t bufsize = 256;
        gain_t* gain_buffer = 0;
        int ret = -1;
        const framecnt_t bufsize = 256;
        gain_t* gain_buffer = 0;


@@ -80,8 +79,6 @@ RBEffect::run (boost::shared_ptr<Region> r, Progress* progress)
        char suffix[32];
        string new_name;
        string::size_type at;
        char suffix[32];
        string new_name;
        string::size_type at;

-       framepos_t pos = 0;
-       framecnt_t avail = 0;

        boost::shared_ptr<AudioRegion> result;
 
        cerr << "RBEffect: source region: position = " << region->position()
        boost::shared_ptr<AudioRegion> result;
 
        cerr << "RBEffect: source region: position = " << region->position()


@@ -184,6 +181,10 @@ RBEffect::run (boost::shared_ptr<Region> r, Progress* progress)
 
        /* create new sources */
 
 
        /* create new sources */
 

+       framepos_t pos   = 0;
+       framecnt_t avail = 0;
+       framecnt_t done  = 0;
+

        if (make_new_sources (region, nsrcs, suffix)) {
                goto out;
        }
        if (make_new_sources (region, nsrcs, suffix)) {
                goto out;
        }


@@ -201,10 +202,6 @@ RBEffect::run (boost::shared_ptr<Region> r, Progress* progress)
 
        /* study first, process afterwards. */
 
 
        /* study first, process afterwards. */
 

-       pos = 0;
-       avail = 0;
-       done = 0;
-

        try {
                while (pos < read_duration && !tsr.cancel) {
 
        try {
                while (pos < read_duration && !tsr.cancel) {