fix crash when removing a TimeAxisView from the selection

diff --git a/gtk2_ardour/selection.cc b/gtk2_ardour/selection.cc
index 298889e329ab2daf9c8d9a0d638cbf88bc5e4580..6ed7a104347695974dc08247700752a00c60790a 100644 (file)
--- a/gtk2_ardour/selection.cc
+++ b/gtk2_ardour/selection.cc
@@ -648,8 +648,14 @@ Selection::remove (TimeAxisView* track)
 {
        list<TimeAxisView*>::iterator i;
        if ((i = find (tracks.begin(), tracks.end(), track)) != tracks.end()) {
-               track->set_selected (false);
+               /* erase first, because set_selected() will remove the track
+                  from the selection, invalidating the iterator.
+
+                  In fact, we don't really even need to do the erase, but this is
+                  a hangover of axis view selection being in the GUI.
+               */
                tracks.erase (i);
+               track->set_selected (false);
        }
 }