Remove PBD::to_string() function from pbd/convert.h

All uses of this function have now been replaced by PBD::to_string() from
pbd/string_convert.h

Remove this function so that it isn't mistakenly used to perform numeric to
string conversion when the result is being used for serialization as that only
works if the global C++ locale is set with LC_NUMERIC=C, which is the case
currently but may not be in the future.

diff --git a/libs/pbd/pbd/convert.h b/libs/pbd/pbd/convert.h
index af40446a81715d5482297021ce87efe77dabb90c..5adabe684da13a6a3ba533bb2705da565bf37f99 100644 (file)
--- a/libs/pbd/pbd/convert.h
+++ b/libs/pbd/pbd/convert.h
@@ -23,8 +23,7 @@
 #include <stdint.h>
 #include <string>
 #include <vector>
-#include <sstream>
-#include <iostream>
+
 #include <glibmm/ustring.h>
 
 #include "pbd/libpbd_visibility.h"
@@ -49,14 +48,6 @@ LIBPBD_API std::string length2string (const int64_t frames, const double sample_
 LIBPBD_API std::vector<std::string> internationalize (const char *, const char **);
 LIBPBD_API bool strings_equal_ignore_case (const std::string& a, const std::string& b);
 
-template <class T> std::string /*LIBPBD_API*/
-to_string (T t, std::ios_base & (*f)(std::ios_base&))
-{
-       std::ostringstream oss;
-       oss << f << t;
-       return oss.str();
-}
-
 LIBPBD_API const char* sgettext (const char *, const char *);
 
 } //namespace PBD