never show windows console.

If ardour is launched from a terminal, stdout/stderr works since
9988f661f. Further, the debug-version comes packaged with gdb and
a has a start-menu shortcut for it. There is no need to implicitly
always show a console even for debug builds.

diff --git a/gtk2_ardour/main.cc b/gtk2_ardour/main.cc
index 7e7d3a0c35e72dd083f5afe0021e5bd465c426b1..26331027d66dbd7dd792c7d908939bb5d90d01e0 100644 (file)
--- a/gtk2_ardour/main.cc
+++ b/gtk2_ardour/main.cc
@@ -148,7 +148,7 @@ sigpipe_handler (int /*signal*/)
 #endif
 
 
-#if (!defined COMPILER_MSVC && defined PLATFORM_WINDOWS && defined NDEBUG)
+#if (!defined COMPILER_MSVC && defined PLATFORM_WINDOWS)
 static bool IsAConsolePort (HANDLE handle)
 {
        DWORD mode;
@@ -192,7 +192,7 @@ int main (int argc, char *argv[])
        gtk_set_locale ();
 #endif
 
-#if (!defined COMPILER_MSVC && defined PLATFORM_WINDOWS && defined NDEBUG)
+#if (!defined COMPILER_MSVC && defined PLATFORM_WINDOWS)
        /* re-attach to the console so we can see 'printf()' output etc.
         * for MSVC see  gtk2_ardour/msvc/winmain.cc
         */
@@ -310,7 +310,7 @@ int main (int argc, char *argv[])
        ARDOUR::cleanup ();
        pthread_cancel_all ();
 
-#if (!defined COMPILER_MSVC && defined PLATFORM_WINDOWS && defined NDEBUG)
+#if (!defined COMPILER_MSVC && defined PLATFORM_WINDOWS)
        if (pStdOut) {
                fclose (pStdOut);
        }

diff --git a/gtk2_ardour/wscript b/gtk2_ardour/wscript
index 047e94358113e9456a5e1d64c24fc2c5fb684213..c9504d96d5ff3f70d27fdfe74c5212bfe27600ef 100644 (file)
--- a/gtk2_ardour/wscript
+++ b/gtk2_ardour/wscript
@@ -458,8 +458,7 @@ def build(bld):
     obj.includes += ['../libs']
 
     if bld.env['build_target'] == 'mingw':
-        if bld.env['DEBUG'] == False:
-            obj.linkflags = ['-mwindows']
+        obj.linkflags = ['-mwindows']
 
     if bld.is_defined('HAVE_SUIL'):
         obj.source += [ 'lv2_plugin_ui.cc' ]