Oh boy!
authorRobin Gareus <robin@gareus.org>
Sat, 18 Mar 2017 13:32:48 +0000 (14:32 +0100)
committerRobin Gareus <robin@gareus.org>
Sat, 18 Mar 2017 13:35:25 +0000 (14:35 +0100)
libs/ardour/export_handler.cc

index 34333b488b9c13af5772a8ed3993fac9391d67b5..1f10aaa2d37a2841136fce45e174df1a8459c84a 100644 (file)
@@ -454,6 +454,14 @@ ExportHandler::finish_timespan ()
                        delete (se);
                }
 
+               // XXX THIS IS IN REALTIME CONTEXT, CALLED FROM
+               // AudioEngine::process_callback()
+               // freewheeling, yes, but still uploading here is NOT
+               // a good idea.
+               //
+               // even less so, since SoundcloudProgress is using
+               // connect_same_thread() - GUI updates from the RT thread
+               // will cause crashes. http://pastebin.com/UJKYNGHR
                if (fmt->soundcloud_upload()) {
                        SoundcloudUploader *soundcloud_uploader = new SoundcloudUploader;
                        std::string token = soundcloud_uploader->Get_Auth_Token(soundcloud_username, soundcloud_password);