slight speed improvement on GhostEvent ctor.
authornick_m <mainsbridge@gmail.com>
Fri, 23 Dec 2016 11:20:08 +0000 (22:20 +1100)
committernick_m <mainsbridge@gmail.com>
Fri, 23 Dec 2016 11:20:08 +0000 (22:20 +1100)
gtk2_ardour/ghostregion.cc

index b9af45b6d49071ac645d99dd572cc056723e6a1f..d76abd6659614bea245754baa5115c1aa1603b6a 100644 (file)
@@ -215,11 +215,15 @@ MidiGhostRegion::~MidiGhostRegion()
 MidiGhostRegion::GhostEvent::GhostEvent (NoteBase* e, ArdourCanvas::Container* g)
        : event (e)
 {
-       Hit* hit = NULL;
+
        if (dynamic_cast<Note*>(e)) {
                item = new ArdourCanvas::Rectangle(
                        g, ArdourCanvas::Rect(e->x0(), e->y0(), e->x1(), e->y1()));
-       } else if ((hit = dynamic_cast<Hit*>(e))) {
+       } else {
+               Hit* hit = dynamic_cast<Hit*>(e);
+               if (!hit) {
+                       return;
+               }
                ArdourCanvas::Polygon* poly = new ArdourCanvas::Polygon(g);
                poly->set(Hit::points(e->y1() - e->y0()));
                poly->set_position(hit->position());