- Fixed a buffer size bug when ~/.ardour2 doesn't exist (can't load configuration...
authorDavid Robillard <d@drobilla.net>
Thu, 10 Aug 2006 03:04:13 +0000 (03:04 +0000)
committerDavid Robillard <d@drobilla.net>
Thu, 10 Aug 2006 03:04:13 +0000 (03:04 +0000)
- Removed useless workbuf/conversion_buffers (same thing), uneeded with libsndfile

git-svn-id: svn://localhost/ardour2/trunk@781 d708f5d6-7413-0410-9779-e7cbd77b26cf

29 files changed:
gtk2_ardour/analysis_window.cc
gtk2_ardour/editor_export_audio.cc
libs/ardour/ardour/audio_diskstream.h
libs/ardour/ardour/audio_track.h
libs/ardour/ardour/audioplaylist.h
libs/ardour/ardour/audioregion.h
libs/ardour/ardour/audiosource.h
libs/ardour/ardour/coreaudiosource.h
libs/ardour/ardour/crossfade.h
libs/ardour/ardour/destructive_filesource.h
libs/ardour/ardour/diskstream.h
libs/ardour/ardour/session.h
libs/ardour/ardour/sndfilesource.h
libs/ardour/audio_diskstream.cc
libs/ardour/audio_playlist.cc
libs/ardour/audio_track.cc
libs/ardour/audioregion.cc
libs/ardour/audiosource.cc
libs/ardour/configuration.cc
libs/ardour/coreaudiosource.cc
libs/ardour/crossfade.cc
libs/ardour/destructive_filesource.cc
libs/ardour/diskstream.cc
libs/ardour/import.cc
libs/ardour/reverse.cc
libs/ardour/session.cc
libs/ardour/session_state.cc
libs/ardour/session_timefx.cc
libs/ardour/sndfilesource.cc

index f742afd7274a9a66ee901236919c3962e75d198c..24c6cc4fb8ea3d070f4c36e8ea526825a3d0fcb9 100644 (file)
@@ -221,7 +221,6 @@ AnalysisWindow::analyze_data (Gtk::Button *button)
                Sample *buf    = (Sample *) malloc(sizeof(Sample) * fft_graph.windowSize());
                Sample *mixbuf = (Sample *) malloc(sizeof(Sample) * fft_graph.windowSize());
                float  *gain   = (float *)  malloc(sizeof(float) * fft_graph.windowSize());
-               char   *work   = (char *)   malloc(sizeof(char) * fft_graph.windowSize());
        
                Selection s = PublicEditor::instance().get_selection();
                TimeSelection ts = s.time;
@@ -261,7 +260,7 @@ AnalysisWindow::analyze_data (Gtk::Button *button)
                                                        n = (*j).length() - i;
                                                }
                                
-                                               n = pl->read(buf, mixbuf, gain, work, (*j).start + i, n);
+                                               n = pl->read(buf, mixbuf, gain, (*j).start + i, n);
        
                                                if ( n < fft_graph.windowSize()) {
                                                        for (int j = n; j < fft_graph.windowSize(); j++) {
@@ -301,7 +300,7 @@ AnalysisWindow::analyze_data (Gtk::Button *button)
                                                        n = arv->region().length() - i;
                                                }
 
-                                               n = arv->audio_region().read_at(buf, mixbuf, gain, work, arv->region().position() + i, n);
+                                               n = arv->audio_region().read_at(buf, mixbuf, gain, arv->region().position() + i, n);
        
                                                if ( n < fft_graph.windowSize()) {
                                                        for (int j = n; j < fft_graph.windowSize(); j++) {
@@ -331,7 +330,6 @@ AnalysisWindow::analyze_data (Gtk::Button *button)
        
                free(buf);
                free(mixbuf);
-               free(work);
 
                track_list_ready = true;
        } /* end lock */
index 46a704b435003603f35fde7ff0e72cd32caf89a8..865796a1edbc0b951f938ed5d7ffdff7e1ff4a20 100644 (file)
@@ -162,7 +162,6 @@ Editor::write_region (string path, AudioRegion& region)
        jack_nframes_t to_read;
        Sample buf[chunk_size];
        gain_t gain_buffer[chunk_size];
-       char   workbuf[chunk_size *4];
        jack_nframes_t pos;
        char s[PATH_MAX+1];
        uint32_t cnt;
@@ -234,11 +233,11 @@ Editor::write_region (string path, AudioRegion& region)
                        
                        fs = (*src);
 
-                       if (region.read_at (buf, buf, gain_buffer, workbuf, pos, this_time) != this_time) {
+                       if (region.read_at (buf, buf, gain_buffer, pos, this_time) != this_time) {
                                break;
                        }
                        
-                       if (fs->write (buf, this_time, workbuf) != this_time) {
+                       if (fs->write (buf, this_time) != this_time) {
                                error << "" << endmsg;
                                goto error_out;
                        }
@@ -309,7 +308,6 @@ Editor::write_audio_range (AudioPlaylist& playlist, uint32_t channels, list<Audi
        jack_nframes_t nframes;
        Sample buf[chunk_size];
        gain_t gain_buffer[chunk_size];
-       char   workbuf[chunk_size*4];
        jack_nframes_t pos;
        char s[PATH_MAX+1];
        uint32_t cnt;
@@ -367,11 +365,11 @@ Editor::write_audio_range (AudioPlaylist& playlist, uint32_t channels, list<Audi
 
                                fs = sources[n];
                                
-                               if (playlist.read (buf, buf, gain_buffer, workbuf, pos, this_time, n) != this_time) {
+                               if (playlist.read (buf, buf, gain_buffer, pos, this_time, n) != this_time) {
                                        break;
                                }
                                
-                               if (fs->write (buf, this_time, workbuf) != this_time) {
+                               if (fs->write (buf, this_time) != this_time) {
                                        goto error_out;
                                }
                        }
@@ -397,7 +395,7 @@ Editor::write_audio_range (AudioPlaylist& playlist, uint32_t channels, list<Audi
                                for (uint32_t n=0; n < channels; ++n) {
 
                                        fs = sources[n];
-                                       if (fs->write (buf, this_time, workbuf) != this_time) {
+                                       if (fs->write (buf, this_time) != this_time) {
                                                goto error_out;
                                        }
                                }
index e2dfc5fd0c92051300162059667ff37097cd9ab9..0cc2079d8e87e6a5ed93b2e80e942f33797d4029 100644 (file)
@@ -211,11 +211,11 @@ class AudioDiskstream : public Diskstream
 
        /* The two central butler operations */
        int do_flush (Session::RunContext context, bool force = false);
-       int do_refill () { return _do_refill(_mixdown_buffer, _gain_buffer, _conversion_buffer); }
+       int do_refill () { return _do_refill(_mixdown_buffer, _gain_buffer); }
        
        int do_refill_with_alloc();
 
-       int read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer, char * workbuf,
+       int read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer,
                jack_nframes_t& start, jack_nframes_t cnt, 
                ChannelInfo& channel_info, int channel, bool reversed);
 
@@ -251,10 +251,9 @@ class AudioDiskstream : public Diskstream
        static size_t  _working_buffers_size;
        static Sample* _mixdown_buffer;
        static gain_t* _gain_buffer;
-       static char*   _conversion_buffer;
 
-       // Uh, /really/ private?  (death to friend classes)
-       int _do_refill (Sample *mixdown_buffer, float *gain_buffer, char *workbuf);
+       // Uh, /really/ private? (there should probably be less friends of Diskstream)
+       int _do_refill (Sample *mixdown_buffer, float *gain_buffer);
        
        
        std::vector<AudioFileSource*> capturing_sources;
index 15b99297c883b42dd5e9de0de1d65f2c9ad4523c..9892179085cdcb39173e170165b7d23a69dec654 100644 (file)
@@ -51,7 +51,7 @@ class AudioTrack : public Track
        int use_diskstream (string name);
        int use_diskstream (const PBD::ID& id);
        
-       int export_stuff (vector<Sample*>& buffers, char * workbuf, uint32_t nbufs, jack_nframes_t nframes, jack_nframes_t end_frame);
+       int export_stuff (vector<Sample*>& buffers, uint32_t nbufs, jack_nframes_t nframes, jack_nframes_t end_frame);
 
        void freeze (InterThreadInfo&);
        void unfreeze ();
index 5a77067f8fd76f95b2d127bae9e120ffb9e9f127..bd76c3028976456eeaf82c93403062c8c3758f4f 100644 (file)
@@ -60,7 +60,7 @@ class AudioPlaylist : public ARDOUR::Playlist
 
        void clear (bool with_delete = false, bool with_save = true);
 
-        jack_nframes_t read (Sample *dst, Sample *mixdown, float *gain_buffer, char * workbuf, jack_nframes_t start, jack_nframes_t cnt, uint32_t chan_n=0);
+        jack_nframes_t read (Sample *dst, Sample *mixdown, float *gain_buffer, jack_nframes_t start, jack_nframes_t cnt, uint32_t chan_n=0);
 
        int set_state (const XMLNode&);
        UndoAction get_memento() const;
index 683e946713029d31ecd9986554e270f16c8dc7a3..0c0839232527a15f1a696775c5944b1bd09c3828 100644 (file)
@@ -106,13 +106,13 @@ class AudioRegion : public Region
                        uint32_t chan_n=0, double samples_per_unit= 1.0) const;
 
        virtual jack_nframes_t read_at (Sample *buf, Sample *mixdown_buf,
-                       float *gain_buf, char * workbuf, jack_nframes_t position, jack_nframes_t cnt, 
+                       float *gain_buf, jack_nframes_t position, jack_nframes_t cnt, 
                        uint32_t       chan_n      = 0,
                        jack_nframes_t read_frames = 0,
                        jack_nframes_t skip_frames = 0) const;
 
        jack_nframes_t master_read_at (Sample *buf, Sample *mixdown_buf, 
-                       float *gain_buf, char * workbuf,
+                       float *gain_buf,
                        jack_nframes_t position, jack_nframes_t cnt, uint32_t chan_n=0) const;
 
        XMLNode& state (bool);
@@ -177,7 +177,7 @@ class AudioRegion : public Region
        void recompute_gain_at_start ();
 
        jack_nframes_t _read_at (const SourceList&, Sample *buf, Sample *mixdown_buffer, 
-                                float *gain_buffer, char * workbuf, jack_nframes_t position, jack_nframes_t cnt, 
+                                float *gain_buffer, jack_nframes_t position, jack_nframes_t cnt, 
                                 uint32_t chan_n = 0,
                                 jack_nframes_t read_frames = 0,
                                 jack_nframes_t skip_frames = 0) const;
index 35158a24e7c1439d041d7e513f8f8a0d4d6369d7..786423d9f860a29139c65a6b4b4f1e723535f346 100644 (file)
@@ -66,8 +66,8 @@ class AudioSource : public Source
 
        virtual jack_nframes_t available_peaks (double zoom) const;
 
-       virtual jack_nframes_t read (Sample *dst, jack_nframes_t start, jack_nframes_t cnt, char * workbuf) const;
-       virtual jack_nframes_t write (Sample *src, jack_nframes_t cnt, char * workbuf);
+       virtual jack_nframes_t read (Sample *dst, jack_nframes_t start, jack_nframes_t cnt) const;
+       virtual jack_nframes_t write (Sample *src, jack_nframes_t cnt);
 
        virtual float sample_rate () const = 0;
 
@@ -124,8 +124,8 @@ class AudioSource : public Source
 
        int  do_build_peak (jack_nframes_t, jack_nframes_t);
 
-       virtual jack_nframes_t read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt, char * workbuf) const = 0;
-       virtual jack_nframes_t write_unlocked (Sample *dst, jack_nframes_t cnt, char * workbuf) = 0;
+       virtual jack_nframes_t read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt) const = 0;
+       virtual jack_nframes_t write_unlocked (Sample *dst, jack_nframes_t cnt) = 0;
        virtual string peak_path(string audio_path) = 0;
        virtual string old_peak_path(string audio_path) = 0;
        
index ba9f122fc9870536ef21721e804110dac07a7396..cf25c466eef501b9cb627b01d63f2eea506ac9de 100644 (file)
@@ -38,9 +38,9 @@ class CoreAudioSource : public AudioFileSource {
        void set_header_timeline_position () {};
 
   protected:
-       jack_nframes_t read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt, char * workbuf) const;
+       jack_nframes_t read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt) const;
        
-       jack_nframes_t write_unlocked (Sample *dst, jack_nframes_t cnt, char * workbuf
+       jack_nframes_t write_unlocked (Sample *dst, jack_nframes_t cnt) 
        { return 0; }
        
 
index ebafa0e8cc77ee6a062c0c7553588ecc267113e3..aea7b31852fb7c76821c5b6e49c865ea0601ca8e 100644 (file)
@@ -92,7 +92,7 @@ class Crossfade : public Stateful, public StateManager
        ARDOUR::AudioRegion& out() const { return *_out; }
        
        jack_nframes_t read_at (Sample *buf, Sample *mixdown_buffer, 
-                               float *gain_buffer, char * workbuf, jack_nframes_t position, jack_nframes_t cnt, 
+                               float *gain_buffer, jack_nframes_t position, jack_nframes_t cnt, 
                                uint32_t chan_n,
                                jack_nframes_t read_frames = 0,
                                jack_nframes_t skip_frames = 0);
index 5b773898c35c004de70ec2b820e2add008f3fc93..fb2a3be47b79e639471691d26774405571e01ed1 100644 (file)
@@ -49,7 +49,7 @@ class DestructiveFileSource : public SndFileSource {
        static void setup_standard_crossfades (jack_nframes_t sample_rate);
 
   protected:
-       jack_nframes_t write_unlocked (Sample *src, jack_nframes_t cnt, char * workbuf);
+       jack_nframes_t write_unlocked (Sample *src, jack_nframes_t cnt);
 
        virtual void handle_header_position_change ();
 
@@ -65,7 +65,7 @@ class DestructiveFileSource : public SndFileSource {
        Sample*        xfade_buf;
 
        void init ();
-       jack_nframes_t crossfade (Sample* data, jack_nframes_t cnt, int dir, char * workbuf);
+       jack_nframes_t crossfade (Sample* data, jack_nframes_t cnt, int dir);
        void set_timeline_position (jack_nframes_t);
 };
 
index ebce516d8b1b97ac48562dc42e0328321b6eb960..e0202a4fae448a96df7d3f31142366de1e75b412 100644 (file)
@@ -117,8 +117,8 @@ class Diskstream : public Stateful, public sigc::trackable
        
        uint32_t n_channels() { return _n_channels; }
 
-       static jack_nframes_t disk_io_frames()                      { return disk_io_chunk_frames; }
-       static void           set_disk_io_chunk_frames (uint32_t n) { disk_io_chunk_frames = n; }
+       static jack_nframes_t disk_io_frames() { return disk_io_chunk_frames; }
+       static void set_disk_io_chunk_frames (uint32_t n) { disk_io_chunk_frames = n; }
 
        /* Stateful */
        virtual XMLNode& get_state(void) = 0;
index 632e85eade05272c737557a0d267188047e107a9..ea096c7a3efb929fc3f0521a01144c0c502fe55d 100644 (file)
@@ -974,8 +974,6 @@ class Session : public sigc::trackable, public Stateful
                ExportContext
        };
        
-       char *  conversion_buffer(RunContext context) { return _conversion_buffers[context]; }
-       
        /* VST support */
 
        static long vst_callback (AEffect* effect,
@@ -1059,7 +1057,6 @@ class Session : public sigc::trackable, public Stateful
        vector<Sample *>        _passthru_buffers;
        vector<Sample *>        _silent_buffers;
        vector<Sample *>        _send_buffers;
-       map<RunContext,char*>   _conversion_buffers;
        jack_nframes_t           current_block_size;
        jack_nframes_t          _worst_output_latency;
        jack_nframes_t          _worst_input_latency;
index 476433945147f2d4cd8403c0f7f8048933ea75c8..ab3e61eb2963f470d072f3cce83101d2b7fd7326 100644 (file)
@@ -56,8 +56,8 @@ class SndFileSource : public AudioFileSource {
   protected:
        void set_header_timeline_position ();
 
-       jack_nframes_t read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt, char * workbuf) const;
-       jack_nframes_t write_unlocked (Sample *dst, jack_nframes_t cnt, char * workbuf);
+       jack_nframes_t read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt) const;
+       jack_nframes_t write_unlocked (Sample *dst, jack_nframes_t cnt);
 
        jack_nframes_t write_float (Sample* data, jack_nframes_t pos, jack_nframes_t cnt);
 
index 7d2a2103bb869aba8cd6f60297719a962ba210f0..9619f404fabd466b975ac748fbe9f87f900178ea 100644 (file)
@@ -58,7 +58,6 @@ using namespace PBD;
 size_t  AudioDiskstream::_working_buffers_size = 0;
 Sample* AudioDiskstream::_mixdown_buffer       = 0;
 gain_t* AudioDiskstream::_gain_buffer          = 0;
-char*   AudioDiskstream::_conversion_buffer    = 0;
 
 AudioDiskstream::AudioDiskstream (Session &sess, const string &name, Diskstream::Flag flag)
        : Diskstream(sess, name, flag)
@@ -188,7 +187,6 @@ AudioDiskstream::allocate_working_buffers()
        _working_buffers_size = disk_io_frames();
        _mixdown_buffer       = new Sample[_working_buffers_size];
        _gain_buffer          = new gain_t[_working_buffers_size];
-       _conversion_buffer    = new char[_working_buffers_size * 4];
 }
 
 void
@@ -196,11 +194,9 @@ AudioDiskstream::free_working_buffers()
 {
        delete _mixdown_buffer;
        delete _gain_buffer;
-       delete _conversion_buffer;
        _working_buffers_size = 0;
        _mixdown_buffer       = 0;
        _gain_buffer          = 0;
-       _conversion_buffer    = 0;
 }
 
 void
@@ -895,7 +891,6 @@ AudioDiskstream::overwrite_existing_buffers ()
 {
        Sample* mixdown_buffer;
        float* gain_buffer;
-       char * workbuf;
        int ret = -1;
        bool reversed = (_visible_speed * _session.transport_speed()) < 0.0f;
 
@@ -906,7 +901,6 @@ AudioDiskstream::overwrite_existing_buffers ()
        
        mixdown_buffer = new Sample[size];
        gain_buffer = new float[size];
-       workbuf = new char[size*4];
        
        /* reduce size so that we can fill the buffer correctly. */
        size--;
@@ -932,8 +926,7 @@ AudioDiskstream::overwrite_existing_buffers ()
                
                jack_nframes_t to_read = size - overwrite_offset;
 
-               if (read ((*chan).playback_buf->buffer() + overwrite_offset, mixdown_buffer, gain_buffer, workbuf,
-                         start, to_read, *chan, n, reversed)) {
+               if (read ((*chan).playback_buf->buffer() + overwrite_offset, mixdown_buffer, gain_buffer, start, to_read, *chan, n, reversed)) {
                        error << string_compose(_("AudioDiskstream %1: when refilling, cannot read %2 from playlist at frame %3"),
                                         _id, size, playback_sample) << endmsg;
                        goto out;
@@ -943,7 +936,7 @@ AudioDiskstream::overwrite_existing_buffers ()
 
                        cnt -= to_read;
                
-                       if (read ((*chan).playback_buf->buffer(), mixdown_buffer, gain_buffer, workbuf,
+                       if (read ((*chan).playback_buf->buffer(), mixdown_buffer, gain_buffer,
                                  start, cnt, *chan, n, reversed)) {
                                error << string_compose(_("AudioDiskstream %1: when refilling, cannot read %2 from playlist at frame %3"),
                                                 _id, size, playback_sample) << endmsg;
@@ -958,7 +951,6 @@ AudioDiskstream::overwrite_existing_buffers ()
        pending_overwrite = false;
        delete [] gain_buffer;
        delete [] mixdown_buffer;
-       delete [] workbuf;
        return ret;
 }
 
@@ -1022,7 +1014,7 @@ AudioDiskstream::internal_playback_seek (jack_nframes_t distance)
 }
 
 int
-AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer, char * workbuf, jack_nframes_t& start, jack_nframes_t cnt, 
+AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer, jack_nframes_t& start, jack_nframes_t cnt, 
                  ChannelInfo& channel_info, int channel, bool reversed)
 {
        jack_nframes_t this_read = 0;
@@ -1079,7 +1071,7 @@ AudioDiskstream::read (Sample* buf, Sample* mixdown_buffer, float* gain_buffer,
 
                this_read = min(cnt,this_read);
 
-               if (audio_playlist()->read (buf+offset, mixdown_buffer, gain_buffer, workbuf, start, this_read, channel) != this_read) {
+               if (audio_playlist()->read (buf+offset, mixdown_buffer, gain_buffer, start, this_read, channel) != this_read) {
                        error << string_compose(_("AudioDiskstream %1: cannot read %2 from playlist at frame %3"), _id, this_read, 
                                         start) << endmsg;
                        return -1;
@@ -1117,19 +1109,17 @@ AudioDiskstream::do_refill_with_alloc()
 {
        Sample* mix_buf  = new Sample[disk_io_chunk_frames];
        float*  gain_buf = new float[disk_io_chunk_frames];
-       char*   work_buf = new char[disk_io_chunk_frames * 4];
 
-       int ret = _do_refill(mix_buf, gain_buf, work_buf);
+       int ret = _do_refill(mix_buf, gain_buf);
        
        delete [] mix_buf;
        delete [] gain_buf;
-       delete [] work_buf;
 
        return ret;
 }
 
 int
-AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer, char * workbuf)
+AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer)
 {
        int32_t ret = 0;
        jack_nframes_t to_read;
@@ -1143,7 +1133,6 @@ AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer, char *
 
        assert(mixdown_buffer);
        assert(gain_buffer);
-       assert(workbuf);
 
        channels.front().playback_buf->get_write_vector (&vector);
        
@@ -1284,7 +1273,7 @@ AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer, char *
 
                if (to_read) {
 
-                       if (read (buf1, mixdown_buffer, gain_buffer, workbuf, file_frame_tmp, to_read, chan, chan_n, reversed)) {
+                       if (read (buf1, mixdown_buffer, gain_buffer, file_frame_tmp, to_read, chan, chan_n, reversed)) {
                                ret = -1;
                                goto out;
                        }
@@ -1302,7 +1291,7 @@ AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer, char *
                           so read some or all of vector.len[1] as well.
                        */
 
-                       if (read (buf2, mixdown_buffer, gain_buffer, workbuf, file_frame_tmp, to_read, chan, chan_n, reversed)) {
+                       if (read (buf2, mixdown_buffer, gain_buffer, file_frame_tmp, to_read, chan, chan_n, reversed)) {
                                ret = -1;
                                goto out;
                        }
@@ -1336,8 +1325,6 @@ AudioDiskstream::_do_refill (Sample* mixdown_buffer, float* gain_buffer, char *
 int
 AudioDiskstream::do_flush (Session::RunContext context, bool force_flush)
 {
-       char* workbuf = _session.conversion_buffer(context);
-
        uint32_t to_write;
        int32_t ret = 0;
        RingBufferNPT<Sample>::rw_vector vector;
@@ -1427,7 +1414,7 @@ AudioDiskstream::do_flush (Session::RunContext context, bool force_flush)
                        }
                }
 
-               if ((!(*chan).write_source) || (*chan).write_source->write (vector.buf[0], to_write, workbuf) != to_write) {
+               if ((!(*chan).write_source) || (*chan).write_source->write (vector.buf[0], to_write) != to_write) {
                        error << string_compose(_("AudioDiskstream %1: cannot write to disk"), _id) << endmsg;
                        return -1;
                }
@@ -1444,7 +1431,7 @@ AudioDiskstream::do_flush (Session::RunContext context, bool force_flush)
                
                        to_write = min ((jack_nframes_t)(disk_io_chunk_frames - to_write), (jack_nframes_t) vector.len[1]);
                
-                       if ((*chan).write_source->write (vector.buf[1], to_write, workbuf) != to_write) {
+                       if ((*chan).write_source->write (vector.buf[1], to_write) != to_write) {
                                error << string_compose(_("AudioDiskstream %1: cannot write to disk"), _id) << endmsg;
                                return -1;
                        }
index 93d380679d9e396ef43e961bdf7a099c9a6b1785..328c9b25f5e2b75c32ce79ff36add52f4e956d0e 100644 (file)
@@ -177,7 +177,7 @@ struct RegionSortByLayer {
 };
 
 jack_nframes_t
-AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, char * workbuf, jack_nframes_t start,
+AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, jack_nframes_t start,
                     jack_nframes_t cnt, unsigned chan_n)
 {
        jack_nframes_t ret = cnt;
@@ -250,12 +250,12 @@ AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, ch
                for (vector<Region*>::iterator i = r.begin(); i != r.end(); ++i) {
                        AudioRegion* const ar = dynamic_cast<AudioRegion*>(*i);
                        assert(ar);
-                       ar->read_at (buf, mixdown_buffer, gain_buffer, workbuf, start, cnt, chan_n, read_frames, skip_frames);
+                       ar->read_at (buf, mixdown_buffer, gain_buffer, start, cnt, chan_n, read_frames, skip_frames);
                        _read_data_count += ar->read_data_count();
                }
                
                for (vector<Crossfade*>::iterator i = x.begin(); i != x.end(); ++i) {
-                       (*i)->read_at (buf, mixdown_buffer, gain_buffer, workbuf, start, cnt, chan_n);
+                       (*i)->read_at (buf, mixdown_buffer, gain_buffer, start, cnt, chan_n);
 
                        /* don't JACK up _read_data_count, since its the same data as we just
                           read from the regions, and the OS should handle that for us.
index 78af23e3df8bf7cdea43b2f2ad91dc5fbe8b02ae..2f33012546efc1f509922fe22984508f67e500f0 100644 (file)
@@ -627,7 +627,7 @@ AudioTrack::silent_roll (jack_nframes_t nframes, jack_nframes_t start_frame, jac
 }
 
 int
-AudioTrack::export_stuff (vector<Sample*>& buffers, char * workbuf, uint32_t nbufs, jack_nframes_t start, jack_nframes_t nframes)
+AudioTrack::export_stuff (vector<Sample*>& buffers, uint32_t nbufs, jack_nframes_t start, jack_nframes_t nframes)
 {
        gain_t  gain_automation[nframes];
        gain_t  gain_buffer[nframes];
@@ -645,7 +645,7 @@ AudioTrack::export_stuff (vector<Sample*>& buffers, char * workbuf, uint32_t nbu
        AudioPlaylist* const apl = dynamic_cast<AudioPlaylist*>(diskstream.playlist());
        assert(apl);
 
-       if (apl->read (buffers[0], mix_buffer, gain_buffer, workbuf, start, nframes) != nframes) {
+       if (apl->read (buffers[0], mix_buffer, gain_buffer, start, nframes) != nframes) {
                return -1;
        }
 
@@ -655,7 +655,7 @@ AudioTrack::export_stuff (vector<Sample*>& buffers, char * workbuf, uint32_t nbu
        ++bi;
        for (; bi != buffers.end(); ++bi, ++n) {
                if (n < diskstream.n_channels()) {
-                       if (apl->read ((*bi), mix_buffer, gain_buffer, workbuf, start, nframes, n) != nframes) {
+                       if (apl->read ((*bi), mix_buffer, gain_buffer, start, nframes, n) != nframes) {
                                return -1;
                        }
                        b = (*bi);
index 20d1dbfbd62dd4756924dd33213c4bbc4bbf88c9..4b07599924317e1f4a27153332108fc24ec0a93c 100644 (file)
@@ -466,22 +466,22 @@ AudioRegion::read_peaks (PeakData *buf, jack_nframes_t npeaks, jack_nframes_t of
 }
 
 jack_nframes_t
-AudioRegion::read_at (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, char * workbuf, jack_nframes_t position, 
+AudioRegion::read_at (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, jack_nframes_t position, 
                      jack_nframes_t cnt, 
                      uint32_t chan_n, jack_nframes_t read_frames, jack_nframes_t skip_frames) const
 {
-       return _read_at (sources, buf, mixdown_buffer, gain_buffer, workbuf, position, cnt, chan_n, read_frames, skip_frames);
+       return _read_at (sources, buf, mixdown_buffer, gain_buffer, position, cnt, chan_n, read_frames, skip_frames);
 }
 
 jack_nframes_t
-AudioRegion::master_read_at (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, char * workbuf, jack_nframes_t position, 
+AudioRegion::master_read_at (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, jack_nframes_t position, 
                             jack_nframes_t cnt, uint32_t chan_n) const
 {
-       return _read_at (master_sources, buf, mixdown_buffer, gain_buffer, workbuf, position, cnt, chan_n, 0, 0);
+       return _read_at (master_sources, buf, mixdown_buffer, gain_buffer, position, cnt, chan_n, 0, 0);
 }
 
 jack_nframes_t
-AudioRegion::_read_at (const SourceList& srcs, Sample *buf, Sample *mixdown_buffer, float *gain_buffer, char * workbuf,
+AudioRegion::_read_at (const SourceList& srcs, Sample *buf, Sample *mixdown_buffer, float *gain_buffer,
                       jack_nframes_t position, jack_nframes_t cnt, 
                       uint32_t chan_n, jack_nframes_t read_frames, jack_nframes_t skip_frames) const
 {
@@ -526,7 +526,7 @@ AudioRegion::_read_at (const SourceList& srcs, Sample *buf, Sample *mixdown_buff
 
        _read_data_count = 0;
 
-       if (srcs[chan_n]->read (mixdown_buffer, _start + internal_offset, to_read, workbuf) != to_read) {
+       if (srcs[chan_n]->read (mixdown_buffer, _start + internal_offset, to_read) != to_read) {
                return 0; /* "read nothing" */
        }
 
@@ -1188,7 +1188,7 @@ AudioRegion::exportme (Session& session, AudioExportSpecification& spec)
                
                if (spec.channels == 1) {
 
-                       if (sources.front()->read (spec.dataF, _start + spec.pos, to_read, 0) != to_read) {
+                       if (sources.front()->read (spec.dataF, _start + spec.pos, to_read) != to_read) {
                                goto out;
                        }
 
@@ -1198,7 +1198,7 @@ AudioRegion::exportme (Session& session, AudioExportSpecification& spec)
 
                        for (uint32_t chan = 0; chan < spec.channels; ++chan) {
                                
-                               if (sources[chan]->read (buf, _start + spec.pos, to_read, 0) != to_read) {
+                               if (sources[chan]->read (buf, _start + spec.pos, to_read) != to_read) {
                                        goto out;
                                }
                                
@@ -1260,7 +1260,6 @@ AudioRegion::normalize_to (float target_dB)
 {
        const jack_nframes_t blocksize = 64 * 1024;
        Sample buf[blocksize];
-       char workbuf[blocksize * 4];
        jack_nframes_t fpos;
        jack_nframes_t fend;
        jack_nframes_t to_read;
@@ -1289,7 +1288,7 @@ AudioRegion::normalize_to (float target_dB)
 
                        /* read it in */
 
-                       if (source (n).read (buf, fpos, to_read, workbuf) != to_read) {
+                       if (source (n).read (buf, fpos, to_read) != to_read) {
                                return;
                        }
                        
index bf7a32c885a096d8ba575a0447d8f7f1a2527e3c..ab5ac437c384f29d489854e04df9b5ee4d14fa12 100644 (file)
@@ -379,17 +379,17 @@ AudioSource::initialize_peakfile (bool newfile, string audio_path)
 }
 
 jack_nframes_t
-AudioSource::read (Sample *dst, jack_nframes_t start, jack_nframes_t cnt, char * workbuf) const
+AudioSource::read (Sample *dst, jack_nframes_t start, jack_nframes_t cnt) const
 {
        Glib::Mutex::Lock lm (_lock);
-       return read_unlocked (dst, start, cnt, workbuf);
+       return read_unlocked (dst, start, cnt);
 }
 
 jack_nframes_t
-AudioSource::write (Sample *dst, jack_nframes_t cnt, char * workbuf)
+AudioSource::write (Sample *dst, jack_nframes_t cnt)
 {
        Glib::Mutex::Lock lm (_lock);
-       return write_unlocked (dst, cnt, workbuf);
+       return write_unlocked (dst, cnt);
 }
 
 int 
@@ -406,7 +406,6 @@ AudioSource::read_peaks (PeakData *peaks, jack_nframes_t npeaks, jack_nframes_t
        int ret = -1;
        PeakData* staging = 0;
        Sample* raw_staging = 0;
-       char * workbuf = 0;
        int peakfile = -1;
 
        expected_peaks = (cnt / (double) frames_per_peak);
@@ -445,9 +444,8 @@ AudioSource::read_peaks (PeakData *peaks, jack_nframes_t npeaks, jack_nframes_t
                */
 
                Sample* raw_staging = new Sample[cnt];
-               workbuf = new char[cnt*4];
                
-               if (read_unlocked (raw_staging, start, cnt, workbuf) != cnt) {
+               if (read_unlocked (raw_staging, start, cnt) != cnt) {
                        error << _("cannot read sample data for unscaled peak computation") << endmsg;
                        return -1;
                }
@@ -458,7 +456,6 @@ AudioSource::read_peaks (PeakData *peaks, jack_nframes_t npeaks, jack_nframes_t
                }
 
                delete [] raw_staging;
-               delete [] workbuf;
                return 0;
        }
 
@@ -624,7 +621,6 @@ AudioSource::read_peaks (PeakData *peaks, jack_nframes_t npeaks, jack_nframes_t
                jack_nframes_t nvisual_peaks = 0;
                jack_nframes_t chunksize = (jack_nframes_t) min (cnt, (jack_nframes_t) 4096);
                raw_staging = new Sample[chunksize];
-               workbuf = new char[chunksize *4];
                
                jack_nframes_t frame_pos = start;
                double pixel_pos = floor (frame_pos / samples_per_visual_peak);
@@ -640,7 +636,7 @@ AudioSource::read_peaks (PeakData *peaks, jack_nframes_t npeaks, jack_nframes_t
                                
                                to_read = min (chunksize, (_length - current_frame));
                                
-                               if ((frames_read = read_unlocked (raw_staging, current_frame, to_read, workbuf)) == 0) {
+                               if ((frames_read = read_unlocked (raw_staging, current_frame, to_read)) == 0) {
                                        error << string_compose(_("AudioSource[%1]: peak read - cannot read %2 samples at offset %3")
                                                         , _name, to_read, current_frame) 
                                              << endmsg;
@@ -688,10 +684,6 @@ AudioSource::read_peaks (PeakData *peaks, jack_nframes_t npeaks, jack_nframes_t
                delete [] raw_staging;
        }
 
-       if (workbuf) {
-               delete [] workbuf;
-       }
-       
        return ret;
 }
 
@@ -760,7 +752,6 @@ AudioSource::do_build_peak (jack_nframes_t first_frame, jack_nframes_t cnt)
        Sample xmin, xmax;
        uint32_t  peaki;
        PeakData* peakbuf;
-       char * workbuf = 0;
        jack_nframes_t frames_read;
        jack_nframes_t frames_to_read;
        off_t first_peak_byte;
@@ -781,8 +772,6 @@ AudioSource::do_build_peak (jack_nframes_t first_frame, jack_nframes_t cnt)
        peakbuf = new PeakData[(cnt/frames_per_peak)+1];
        peaki = 0;
 
-       workbuf = new char[max(frames_per_peak, cnt) * 4];
-       
        if ((peakfile = ::open (peakpath.c_str(), O_RDWR|O_CREAT, 0664)) < 0) {
                error << string_compose(_("AudioSource: cannot open peakpath \"%1\" (%2)"), peakpath, strerror (errno)) << endmsg;
                return -1;
@@ -794,7 +783,7 @@ AudioSource::do_build_peak (jack_nframes_t first_frame, jack_nframes_t cnt)
 
                /* lock for every read */
 
-               if ((frames_read = read (buf, current_frame, frames_to_read, workbuf)) != frames_to_read) {
+               if ((frames_read = read (buf, current_frame, frames_to_read)) != frames_to_read) {
                        error << string_compose(_("%1: could not write read raw data for peak computation (%2)"), _name, strerror (errno)) << endmsg;
                        goto out;
                }
@@ -831,8 +820,6 @@ AudioSource::do_build_peak (jack_nframes_t first_frame, jack_nframes_t cnt)
        if (peakfile >= 0) {
                close (peakfile);
        }
-       if (workbuf)
-               delete [] workbuf;
        return ret;
 }
 
index 58da77f933105fb26e03aae22472741df1e4f9f1..84c3e3a83444d9e1685d9b9f9daaeb07bdb93b93 100644 (file)
@@ -236,7 +236,7 @@ Configuration::set_state (const XMLNode& root)
                }
        }
 
-       AudioDiskstream::set_disk_io_chunk_frames (minimum_disk_io_bytes.get() / sizeof (Sample));
+       Diskstream::set_disk_io_chunk_frames (minimum_disk_io_bytes.get() / sizeof (Sample));
 
        return 0;
 }
index 5e9de225d450022ac39664bb0c09812287a9c503..f0fcac14e2fa312d61ece028c32dc9d19724b8f3 100644 (file)
@@ -153,7 +153,7 @@ CoreAudioSource::~CoreAudioSource ()
 }
 
 jack_nframes_t
-CoreAudioSource::read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt, char * workbuf) const
+CoreAudioSource::read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt) const
 {
        OSStatus err = noErr;
 
index dc4c074844dc7d2e7fddb1e59c7d0e4dd9332014..379c9333b04ff088e30022ace8259284a72e8a96 100644 (file)
@@ -402,7 +402,7 @@ Crossfade::compute (AudioRegion& a, AudioRegion& b, CrossfadeModel model)
 
 jack_nframes_t 
 Crossfade::read_at (Sample *buf, Sample *mixdown_buffer, 
-                   float *gain_buffer, char * workbuf, jack_nframes_t start, jack_nframes_t cnt, uint32_t chan_n,
+                   float *gain_buffer, jack_nframes_t start, jack_nframes_t cnt, uint32_t chan_n,
                    jack_nframes_t read_frames, jack_nframes_t skip_frames)
 {
        jack_nframes_t offset;
@@ -438,8 +438,8 @@ Crossfade::read_at (Sample *buf, Sample *mixdown_buffer,
 
        offset = start - _position;
 
-       _out->read_at (crossfade_buffer_out, mixdown_buffer, gain_buffer, workbuf, start, to_write, chan_n, read_frames, skip_frames);
-       _in->read_at (crossfade_buffer_in, mixdown_buffer, gain_buffer, workbuf, start, to_write, chan_n, read_frames, skip_frames);
+       _out->read_at (crossfade_buffer_out, mixdown_buffer, gain_buffer, start, to_write, chan_n, read_frames, skip_frames);
+       _in->read_at (crossfade_buffer_in, mixdown_buffer, gain_buffer, start, to_write, chan_n, read_frames, skip_frames);
 
        float* fiv = new float[to_write];
        float* fov = new float[to_write];
index 43fafff30a1ae0a30f289b7eb178c26786c37c26..65ca8dae673d3309763046b0f4285525b14d2f03 100644 (file)
@@ -158,7 +158,7 @@ DestructiveFileSource::clear_capture_marks ()
 }      
 
 jack_nframes_t
-DestructiveFileSource::crossfade (Sample* data, jack_nframes_t cnt, int fade_in, char * workbuf)
+DestructiveFileSource::crossfade (Sample* data, jack_nframes_t cnt, int fade_in)
 {
        jack_nframes_t xfade = min (xfade_frames, cnt);
        jack_nframes_t nofade = cnt - xfade;
@@ -272,7 +272,7 @@ DestructiveFileSource::crossfade (Sample* data, jack_nframes_t cnt, int fade_in,
 }
 
 jack_nframes_t
-DestructiveFileSource::write_unlocked (Sample* data, jack_nframes_t cnt, char * workbuf)
+DestructiveFileSource::write_unlocked (Sample* data, jack_nframes_t cnt)
 {
        jack_nframes_t old_file_pos;
 
@@ -297,7 +297,7 @@ DestructiveFileSource::write_unlocked (Sample* data, jack_nframes_t cnt, char *
                jack_nframes_t ofilepos = file_pos;
                
                // fade in
-               if (crossfade (data, subcnt, 1, workbuf) != subcnt) {
+               if (crossfade (data, subcnt, 1) != subcnt) {
                        return 0;
                }
                
@@ -306,7 +306,7 @@ DestructiveFileSource::write_unlocked (Sample* data, jack_nframes_t cnt, char *
                
                // fade out
                subcnt = cnt - subcnt;
-               if (crossfade (tmpdata, subcnt, 0, workbuf) != subcnt) {
+               if (crossfade (tmpdata, subcnt, 0) != subcnt) {
                        return 0;
                }
                
@@ -324,7 +324,7 @@ DestructiveFileSource::write_unlocked (Sample* data, jack_nframes_t cnt, char *
                /* move to the correct location place */
                file_pos = capture_start_frame;
                
-               if (crossfade (data, cnt, 1, workbuf) != cnt) {
+               if (crossfade (data, cnt, 1) != cnt) {
                        return 0;
                }
                
@@ -337,7 +337,7 @@ DestructiveFileSource::write_unlocked (Sample* data, jack_nframes_t cnt, char *
                _capture_start = false;
                _capture_end = false;
                
-               if (crossfade (data, cnt, 0, workbuf) != cnt) {
+               if (crossfade (data, cnt, 0) != cnt) {
                        return 0;
                }
 
index a9a5c6ce075ec9825d2655fd0fd001fa0a21d655..b2d481077f227da9fa94451e7663d51a572dfcc5 100644 (file)
@@ -56,7 +56,12 @@ using namespace std;
 using namespace ARDOUR;
 using namespace PBD;
 
-jack_nframes_t Diskstream::disk_io_chunk_frames = 0;
+/* XXX This goes uninitialized when there is no ~/.ardour2 directory.
+ * I can't figure out why, so this will do for now (just stole the
+ * default from configuration_vars.h).  0 is not a good value for
+ * allocating buffer sizes..
+ */
+jack_nframes_t Diskstream::disk_io_chunk_frames = 1024 * 256;
 
 sigc::signal<void,Diskstream*>    Diskstream::DiskstreamCreated;
 sigc::signal<void,list<Source*>*> Diskstream::DeleteSources;
index b70a7bbc9c0154e8af0ca4cb9f8c462f78fd8193..c68eb16aae6745c4a4ea6134d6f254300465319c 100644 (file)
@@ -57,7 +57,6 @@ Session::import_audiofile (import_status& status)
        SF_INFO info;
        float *data = 0;
        Sample **channel_data = 0;
-       char * workbuf = 0;
        long nfiles = 0;
        long n;
        string basepath;
@@ -156,7 +155,6 @@ Session::import_audiofile (import_status& status)
        
        data = new float[BLOCKSIZE * info.channels];
        channel_data = new Sample * [ info.channels ];
-       workbuf = new char[BLOCKSIZE * 4];
        
        for (n = 0; n < info.channels; ++n) {
                channel_data[n] = new Sample[BLOCKSIZE];
@@ -188,7 +186,7 @@ Session::import_audiofile (import_status& status)
                /* flush to disk */
 
                for (chn = 0; chn < info.channels; ++chn) {
-                       newfiles[chn]->write (channel_data[chn], nread, workbuf);
+                       newfiles[chn]->write (channel_data[chn], nread);
                }
 
                so_far += nread;
@@ -255,9 +253,6 @@ Session::import_audiofile (import_status& status)
        if (data) {
                delete [] data;
        }
-       if (workbuf) {
-               delete [] workbuf;
-       }
        
        if (channel_data) {
                for (n = 0; n < info.channels; ++n) {
index 13dd531bac5dafc1eb0c427020deb1e852cf1b9d..3fe6aaa6307d55382e27d19562b9cb52aef95caf 100644 (file)
@@ -49,7 +49,6 @@ Reverse::run (AudioRegion& region)
        AudioRegion::SourceList::iterator si;
        const jack_nframes_t blocksize = 256 * 1048;
        Sample buf[blocksize];
-       char * workbuf = 0;;
        jack_nframes_t fpos;
        jack_nframes_t fend;
        jack_nframes_t fstart;
@@ -62,8 +61,6 @@ Reverse::run (AudioRegion& region)
                goto out;
        }
 
-       workbuf = new char[blocksize * 4];
-       
        fend = region.start() + region.length();
        fstart = region.start();
 
@@ -85,7 +82,7 @@ Reverse::run (AudioRegion& region)
 
                        /* read it in */
                        
-                       if (region.source (n).read (buf, fpos, to_read, workbuf) != to_read) {
+                       if (region.source (n).read (buf, fpos, to_read) != to_read) {
                                goto out;
                        }
                        
@@ -97,7 +94,7 @@ Reverse::run (AudioRegion& region)
                        
                        /* write it out */
 
-                       if ((*si)->write (buf, to_read, workbuf) != to_read) {
+                       if ((*si)->write (buf, to_read) != to_read) {
                                goto out;
                        }
                }
@@ -123,9 +120,6 @@ Reverse::run (AudioRegion& region)
                        delete *si;
                }
        }
-       if (workbuf) {
-               delete [] workbuf;
-       }
        
        return ret;
 }
index 8a68e5a3b5ac6053f27b9e15f52c17a5a16addf9..6fd53abd02e96036497f0d8d996069ebcfd09137 100644 (file)
@@ -394,10 +394,6 @@ Session::~Session ()
                free(*i);
        }
 
-       for (map<RunContext,char*>::iterator i = _conversion_buffers.begin(); i != _conversion_buffers.end(); ++i) {
-               delete [] (i->second);
-       }
-       
        AudioDiskstream::free_working_buffers();
        
 #undef TRACK_DESTRUCTION
@@ -3594,7 +3590,6 @@ Session::write_one_audio_track (AudioTrack& track, jack_nframes_t start, jack_nf
        jack_nframes_t this_chunk;
        jack_nframes_t to_do;
        vector<Sample*> buffers;
-       char *  workbuf = 0;
 
        // any bigger than this seems to cause stack overflows in called functions
        const jack_nframes_t chunk_size = (128 * 1024)/4;
@@ -3664,13 +3659,11 @@ Session::write_one_audio_track (AudioTrack& track, jack_nframes_t start, jack_nf
                buffers.push_back (b);
        }
 
-       workbuf = new char[chunk_size * 4];
-       
        while (to_do && !itt.cancel) {
                
                this_chunk = min (to_do, chunk_size);
                
-               if (track.export_stuff (buffers, workbuf, nchans, start, this_chunk)) {
+               if (track.export_stuff (buffers, nchans, start, this_chunk)) {
                        goto out;
                }
 
@@ -3679,7 +3672,7 @@ Session::write_one_audio_track (AudioTrack& track, jack_nframes_t start, jack_nf
                        AudioFileSource* afs = dynamic_cast<AudioFileSource*>(*src);
 
                        if (afs) {
-                               if (afs->write (buffers[n], this_chunk, workbuf) != this_chunk) {
+                               if (afs->write (buffers[n], this_chunk) != this_chunk) {
                                        goto out;
                                }
                        }
@@ -3733,10 +3726,6 @@ Session::write_one_audio_track (AudioTrack& track, jack_nframes_t start, jack_nf
                free(*i);
        }
 
-       if (workbuf) {
-               delete [] workbuf;
-       }
-       
        g_atomic_int_set (&processing_prohibited, 0);
 
        itt.done = true;
index 2813cc72f09d785c12d6b217d9ecb83d7a96706e..bc1c0b5cc1497532afff2fbf8e227590a6e91c47 100644 (file)
@@ -191,9 +191,6 @@ Session::first_stage_init (string fullpath, string snapshot_name)
        xfade_model = ShortCrossfade;
        destructive_index = 0;
 
-       /* allocate conversion buffers */
-       _conversion_buffers[ButlerContext] = new char[AudioDiskstream::disk_io_frames() * 4];
-       _conversion_buffers[TransportContext] = new char[AudioDiskstream::disk_io_frames() * 4];
        AudioDiskstream::allocate_working_buffers();
        
        /* default short fade = 15ms */
index 7eec1e578ba2b2c6e50d8e4c105c7343b088615a..45733c75aedfd1007ca150bd4210206f24fe6545 100644 (file)
@@ -96,7 +96,6 @@ Session::tempoize_region (TimeStretchRequest& tsr)
                for (uint32_t i = 0; i < sources.size(); ++i) {
                        gain_t gain_buffer[bufsize];
                        Sample buffer[bufsize];
-                       char   workbuf[bufsize*4];
                        jack_nframes_t pos = 0;
                        jack_nframes_t this_read = 0;
 
@@ -110,7 +109,7 @@ Session::tempoize_region (TimeStretchRequest& tsr)
                                   not the ones currently in use, in case it's already been 
                                   subject to timefx.  */
 
-                               if ((this_read = tsr.region->master_read_at (buffer, buffer, gain_buffer, workbuf, pos + tsr.region->position(), this_time)) != this_time) {
+                               if ((this_read = tsr.region->master_read_at (buffer, buffer, gain_buffer, pos + tsr.region->position(), this_time)) != this_time) {
                                        error << string_compose (_("tempoize: error reading data from %1"), sources[i]->name()) << endmsg;
                                        goto out;
                                }
@@ -123,7 +122,7 @@ Session::tempoize_region (TimeStretchRequest& tsr)
                                st.putSamples (buffer, this_read);
                        
                                while ((this_read = st.receiveSamples (buffer, bufsize)) > 0 && tsr.running) {
-                                       if (sources[i]->write (buffer, this_read, workbuf) != this_read) {
+                                       if (sources[i]->write (buffer, this_read) != this_read) {
                                                error << string_compose (_("error writing tempo-adjusted data to %1"), sources[i]->name()) << endmsg;
                                                goto out;
                                        }
@@ -135,7 +134,7 @@ Session::tempoize_region (TimeStretchRequest& tsr)
                        }
                
                        while (tsr.running && (this_read = st.receiveSamples (buffer, bufsize)) > 0) {
-                               if (sources[i]->write (buffer, this_read, workbuf) != this_read) {
+                               if (sources[i]->write (buffer, this_read) != this_read) {
                                        error << string_compose (_("error writing tempo-adjusted data to %1"), sources[i]->name()) << endmsg;
                                        goto out;
                                }
index 5936f6257027eb77256e2ec2138f89b6dd88ca5b..b487d4e3a39e8efdf06685c5f550fe55d4bf0406 100644 (file)
@@ -292,7 +292,7 @@ SndFileSource::sample_rate () const
 }
 
 jack_nframes_t
-SndFileSource::read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt, char * workbuf) const
+SndFileSource::read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t cnt) const
 {
        int32_t nread;
        float *ptr;
@@ -367,7 +367,7 @@ SndFileSource::read_unlocked (Sample *dst, jack_nframes_t start, jack_nframes_t
 }
 
 jack_nframes_t 
-SndFileSource::write_unlocked (Sample *data, jack_nframes_t cnt, char * workbuf)
+SndFileSource::write_unlocked (Sample *data, jack_nframes_t cnt)
 {
        if (!writable()) {
                return 0;