From: Carl Hetherington <cth@carlh.net>
Date: Thu, 26 Mar 2020 20:45:14 +0000 (+0100)
Subject: Add a FIXME.
X-Git-Tag: v1.6.0~95
X-Git-Url: https://main.carlh.net/gitweb/?a=commitdiff_plain;ds=sidebyside;h=2f508609da978d20cdd5893ec91746a5167d1c7b;hp=d46747cc35b8eff53098b99c5a6f5b53d4ce2bf1;p=libsub.git

Add a FIXME.
---

diff --git a/src/stl_binary_reader.cc b/src/stl_binary_reader.cc
index 9a7a150..e8e8832 100644
--- a/src/stl_binary_reader.cc
+++ b/src/stl_binary_reader.cc
@@ -211,6 +211,9 @@ void STLBinaryReader::read (shared_ptr<InputReader> reader)
 			RawSubtitle sub;
 			sub.from = reader->get_timecode(5, frame_rate);
 			sub.to = reader->get_timecode(9, frame_rate);
+                        /* XXX: only the verticial position of the first TTI block should be used (says the spec),
+                           so using reader->get_int(13, 1) here is wrong if i > 0
+                         */
 			sub.vertical_position.line = reader->get_int(13, 1) + i;
 			sub.vertical_position.lines = maximum_rows;
 			sub.vertical_position.reference = TOP_OF_SCREEN;