From: Robin Gareus <robin@gareus.org>
Date: Sun, 24 Jul 2016 11:33:09 +0000 (+0200)
Subject: add a ToDo note for after string-freeze
X-Git-Tag: 5.0-rc1~32
X-Git-Url: https://main.carlh.net/gitweb/?a=commitdiff_plain;ds=sidebyside;h=ba815a903b679b002f48589e77032ca4a2799feb;p=ardour.git

add a ToDo note for after string-freeze
---

diff --git a/gtk2_ardour/processor_box.cc b/gtk2_ardour/processor_box.cc
index 4ba27f10a6..3590c280d6 100644
--- a/gtk2_ardour/processor_box.cc
+++ b/gtk2_ardour/processor_box.cc
@@ -2442,6 +2442,16 @@ ProcessorBox::use_plugins (const SelectedPlugins& plugins)
 void
 ProcessorBox::weird_plugin_dialog (Plugin& p, Route::ProcessorStreams streams)
 {
+	/* XXX this needs to be re-worked!
+	 *
+	 * With new pin-management "streams" is no longer correct.
+	 * p.get_info () is also incorrect for variable i/o plugins (always -1,-1).
+	 *
+	 * Since pin-management was added, this dialog will only show in a very rare
+	 * condition (non-replicated variable i/o configuration failed).
+	 *
+	 * TODO: simplify the message after the string-freeze is lifted.
+	 */
 	ArdourDialog dialog (_("Plugin Incompatibility"));
 	Label label;