From: Carl Hetherington <cth@carlh.net>
Date: Mon, 14 Jan 2019 15:32:58 +0000 (+0000)
Subject: Speculative removal of call to xmlSecKeySetName when signing, on
X-Git-Tag: v1.6.2~14^2
X-Git-Url: https://main.carlh.net/gitweb/?a=commitdiff_plain;h=0176ce02863f89315774cc2907f5beb33c21360f;hp=7e4e6be3628308b7b16c015e2f87b27e729258dc;p=libdcp.git

Speculative removal of call to xmlSecKeySetName when signing, on
the basis that I can't see what it's for and opendcp doesn't
do it.  Chasing Sony no-validate bug.
---

diff --git a/src/certificate_chain.cc b/src/certificate_chain.cc
index 0e032a85..6b4216b5 100644
--- a/src/certificate_chain.cc
+++ b/src/certificate_chain.cc
@@ -639,11 +639,6 @@ CertificateChain::add_signature_value (xmlpp::Node* parent, string ns) const
 		throw runtime_error ("could not read private key");
 	}
 
-	/* XXX: set key name to the PEM string: this can't be right! */
-	if (xmlSecKeySetName (signature_context->signKey, reinterpret_cast<const xmlChar *> (_key->c_str())) < 0) {
-		throw MiscError ("could not set key name");
-	}
-
 	int const r = xmlSecDSigCtxSign (signature_context, parent->cobj ());
 	if (r < 0) {
 		throw MiscError (String::compose ("could not sign (%1)", r));