From: Colin Fletcher <colin.m.fletcher@googlemail.com>
Date: Sun, 18 May 2014 19:49:58 +0000 (+0100)
Subject: SystemExec: copy last argument from command line to argv[]
X-Git-Tag: 4.0-rc1~1601^2~1224^2~4
X-Git-Url: https://main.carlh.net/gitweb/?a=commitdiff_plain;h=7c4259133d4ca965f7aed5cbb419d75125de6bef;p=ardour.git

SystemExec: copy last argument from command line to argv[]

Make sure to copy any part of the command line after the last delimiter
to argv[] when creating a SystemExec with an escaped command line.
---

diff --git a/libs/pbd/system_exec.cc b/libs/pbd/system_exec.cc
index f270364660..bf02fd7254 100644
--- a/libs/pbd/system_exec.cc
+++ b/libs/pbd/system_exec.cc
@@ -201,7 +201,7 @@ SystemExec::make_argp_escaped(std::string command, const std::map<char, std::str
 
 	argp = (char **) malloc(sizeof(char *));
 
-	for (i = 0; i < command.length(); i++) {
+	for (i = 0; i <= command.length(); i++) { // include terminating '\0'
 		char c = command.c_str()[i];
 		if (inquotes) {
 			if (c == '"') {
@@ -244,6 +244,7 @@ SystemExec::make_argp_escaped(std::string command, const std::map<char, std::str
 				break;
 			case ' ' :
 			case '\t':
+			case '\0':
 				if (arg.length() > 0) {
 					// if there wasn't already a space or tab, start a new parameter
 					argp = (char **) realloc(argp, (n + 2) * sizeof(char *));