From: Robin Gareus <robin@gareus.org>
Date: Wed, 1 Mar 2017 16:08:44 +0000 (+0100)
Subject: Don't display "channel-selector" for plugins only pretending to be instruments
X-Git-Tag: 5.9~701
X-Git-Url: https://main.carlh.net/gitweb/?a=commitdiff_plain;h=ab127d6e70aa12f68a149e9f146ed89805350374;p=ardour.git

Don't display "channel-selector" for plugins only pretending to be instruments

If a plugin has 0 audio-outputs, and has the meta-data "InstrumentPlugin",
Ardour would interpret is as "variable number of output synth.
---

diff --git a/libs/ardour/plugin_insert.cc b/libs/ardour/plugin_insert.cc
index daae15d3ad..b4152d81e1 100644
--- a/libs/ardour/plugin_insert.cc
+++ b/libs/ardour/plugin_insert.cc
@@ -430,6 +430,13 @@ PluginInsert::has_output_presets (ChanCount in, ChanCount out)
 			return false;
 		}
 	}
+
+	if (ppc.size () == 1 && ppc.find (0) != ppc.end () && !_plugins[0]->get_info ()->reconfigurable_io ()) {
+		// some midi-sequencer (e.g. QMidiArp) or other midi-out plugin
+		// pretending to be an "Instrument"
+		return false;
+	}
+
 	if (!is_instrument ()) {
 			return false;
 	}