From: Robin Gareus <robin@gareus.org>
Date: Wed, 10 May 2017 18:28:47 +0000 (+0200)
Subject: Fix another possible case of illegal use of reserved port-names
X-Git-Tag: 5.9~39
X-Git-Url: https://main.carlh.net/gitweb/?a=commitdiff_plain;h=c0b54e868fea0eb3b8a940e680aebc655486e5c3;p=ardour.git

Fix another possible case of illegal use of reserved port-names

Session::io_name_is_legal() is used for Routes and Processors:
Route::set_name(), ProcessorBox::rename_processor() and
and Route::ensure_track_or_route_name() -- it is not used for actual
I/O objects.
---

diff --git a/libs/ardour/session.cc b/libs/ardour/session.cc
index a69c69b27b..ffb0022729 100644
--- a/libs/ardour/session.cc
+++ b/libs/ardour/session.cc
@@ -4277,8 +4277,8 @@ Session::io_name_is_legal (const std::string& name) const
 	for (map<string,bool>::const_iterator reserved = reserved_io_names.begin(); reserved != reserved_io_names.end(); ++reserved) {
 		if (name == reserved->first) {
 			if (!route_by_name (reserved->first)) {
-				/* first instance of a reserved name is allowed */
-				return true;
+				/* first instance of a reserved name is allowed for some */
+				return reserved->second;
 			}
 			/* all other instances of a reserved name are not allowed */
 			return false;