From: Carl Hetherington <cth@carlh.net>
Date: Tue, 20 Feb 2024 21:57:01 +0000 (+0100)
Subject: Don't use -Wsuggest-override on gcc 7.5.0 (Ubuntu 18.04)
X-Git-Tag: v2.17.12~2
X-Git-Url: https://main.carlh.net/gitweb/?a=commitdiff_plain;h=feaa2ccf73153b0693c4b4a9b2468869ed0b9962;p=dcpomatic.git

Don't use -Wsuggest-override on gcc 7.5.0 (Ubuntu 18.04)

because turning it off with a pragma seems not to work.
---

diff --git a/wscript b/wscript
index 2ca54488e..8b96afd29 100644
--- a/wscript
+++ b/wscript
@@ -147,8 +147,10 @@ def configure(conf):
             conf.env.append_value('CXXFLAGS', ['-Wno-cast-function-type'])
         # Most gccs still give these warnings from boost::optional
         conf.env.append_value('CXXFLAGS', ['-Wno-maybe-uninitialized'])
-        if int(gcc[0]) > 4:
+        if int(gcc[0]) > 7:
             # gcc 4.8.5 on Centos 7 does not have this warning
+            # gcc 7.5.0 on Ubuntu 18.04 does, but I didn't manage to turn it
+            # back off again with a pragma
             conf.env.append_value('CXXFLAGS', ['-Wsuggest-override'])
 
     if conf.options.enable_debug: