Robin Gareus [Sat, 15 Oct 2016 19:16:57 +0000 (21:16 +0200)]
Source and AudioSource Lua bindings
nick_m [Sat, 15 Oct 2016 18:09:49 +0000 (05:09 +1100)]
BBT duration clock can only compare musical times.
nick_m [Sat, 15 Oct 2016 16:50:14 +0000 (03:50 +1100)]
Minor cleanup (don't set pulse twice in Region::set_position()).
nick_m [Sat, 15 Oct 2016 16:47:10 +0000 (03:47 +1100)]
Fix various snap issues when dragging control points (AutomationRegionView).
nick_m [Sat, 15 Oct 2016 16:41:58 +0000 (03:41 +1100)]
Fix incorrect musical position in NoteDrag::total_dx.
nick_m [Sat, 15 Oct 2016 16:26:30 +0000 (03:26 +1100)]
AudioClock: remove duplicated code. amends
3a0a628a7
nick_m [Sat, 15 Oct 2016 16:11:05 +0000 (03:11 +1100)]
Slightly improve note update performance, fix note resizing for non-4.0 meter divisors.
nick_m [Sat, 15 Oct 2016 15:33:49 +0000 (02:33 +1100)]
Rework duration clock and TempoMap::insert_time to include meter at offset.
- should fix 7072
- also fixes scroll behavior over multiple tempi.
nick_m [Sat, 15 Oct 2016 12:50:02 +0000 (23:50 +1100)]
Note selection state uses note event_id_t.
nick_m [Sat, 15 Oct 2016 12:17:19 +0000 (23:17 +1100)]
Ensure correct initial automation region view position.
Robin Gareus [Sat, 15 Oct 2016 02:13:30 +0000 (04:13 +0200)]
Editor up/down arrow keys: snap to track (not 60px)
Robin Gareus [Fri, 14 Oct 2016 23:41:40 +0000 (01:41 +0200)]
Include session-utils with OSX bundles
Robin Gareus [Fri, 14 Oct 2016 20:58:59 +0000 (22:58 +0200)]
mixer left/right: snap to track
Robin Gareus [Fri, 14 Oct 2016 16:33:16 +0000 (18:33 +0200)]
include session-utils with windows bundles
Paul Davis [Fri, 14 Oct 2016 15:50:27 +0000 (11:50 -0400)]
remove debug output
Paul Davis [Fri, 14 Oct 2016 15:42:35 +0000 (11:42 -0400)]
much simpler implementation of fix originally in
c104c9d4726f3: don't call Session::set_dirty() or emit Changed() unless AutomationControl actually changes value
Paul Davis [Fri, 14 Oct 2016 15:16:42 +0000 (11:16 -0400)]
Revert "change return type of AutomationControl::actually_set_value() from void to bool, to indicate if value was changed."
This reverts commit
c104c9d4726f3ba1ecd352d13b88a57f2f964510.
Robin Gareus [Fri, 14 Oct 2016 14:07:30 +0000 (16:07 +0200)]
GUI to allow aux-send feedback loops
Robin Gareus [Fri, 14 Oct 2016 13:06:49 +0000 (15:06 +0200)]
allow feedback (loops) from internal sends
This facilitates custom "Echo" chains:
Bus 1 [FX] [aux-send to Bus 2] -> master
Bus 2 [FX] -> Bus 2
Robin Gareus [Thu, 13 Oct 2016 21:41:49 +0000 (23:41 +0200)]
fix math ambiguity & OSX compilation
cc121.cc: In member function 'void ArdourSurface::CC121::encoder_handler(MIDI::Parser&, MIDI::EventTwoBytes*)':
cc121.cc:413: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
/usr/include/architecture/i386/math.h:343: note: candidate 1: double pow(double, double)
/usr/include/c++/4.2.1/cmath:357: note: candidate 2: float std::pow(float, float)
Paul Davis [Thu, 13 Oct 2016 21:18:42 +0000 (17:18 -0400)]
new scheme for managing port deletion
shared_ptr<Port> now uses a deleter functor which pushes Port* to a lock-free FIFO so that the Port is
always deleted (and thus unregistered with the PortEngine/backend) in a safe context w.r.t. various
callbacks in the host. Currently the auto_connect_thread in Session has been tasked with doing these
deletions.
Paul Davis [Thu, 13 Oct 2016 21:11:38 +0000 (17:11 -0400)]
stop using gkd_pango_context_get() in ArdourCanvas::Canvas and require concrete instances to supply a Pango::Context; do this for GtkCanvas and Push2Canvas
Robin Gareus [Thu, 13 Oct 2016 17:57:50 +0000 (19:57 +0200)]
fix panner reset when switching to aux-sends -- fixes #6893
W.P. van Paassen [Wed, 12 Oct 2016 18:58:40 +0000 (20:58 +0200)]
Small improvement and change to comply with coding standard
W.P. van Paassen [Tue, 11 Oct 2016 17:21:21 +0000 (19:21 +0200)]
Inital support for Steinberg's CC121 control surface
Michiel de Roo [Thu, 15 Sep 2016 17:05:18 +0000 (19:05 +0200)]
OSC added plugin activate/deactivate
Robin Gareus [Thu, 13 Oct 2016 16:07:18 +0000 (18:07 +0200)]
handle blink-rec-arm change without application restart
Nil Geisweiller [Wed, 28 Sep 2016 20:09:46 +0000 (23:09 +0300)]
Add region position to note start in the midi list editor
Robert Scott [Thu, 6 Oct 2016 22:15:57 +0000 (17:15 -0500)]
Don't reset the audio tracks name when changing the channel configuration.
cooltehno [Wed, 12 Oct 2016 22:11:39 +0000 (02:11 +0400)]
Update cubasish-ardour.colors
file:///home/cooltehno/DATA/ARDOUR_EXP/.темы/3_cubasish/cor_131016.jpg
This commit changes the clip indicator from white to red coloured (from "color 9" to "color 55"). Also the "color 55" is changing from orange (f85813) to maximum bright red color (ff0009)
Robin Gareus [Thu, 13 Oct 2016 14:04:28 +0000 (16:04 +0200)]
Allow a LV2 plugin to mark the session dirty
If some plugin-internal state changes (GUI <> Plugin e.g. load a sample)
no ports change and the host does not know that the plugin state has
changed. The session may be closed without save.
This is a prototype using an ardour.org URI, pending upstream lv2plug.in
nick_m [Thu, 13 Oct 2016 03:26:54 +0000 (14:26 +1100)]
Improve check in tempoAtPulseTest
nick_m [Thu, 13 Oct 2016 03:14:27 +0000 (14:14 +1100)]
Fix ramp test, add tempoAtPulseTest.
Robin Gareus [Thu, 13 Oct 2016 00:07:08 +0000 (02:07 +0200)]
Allow opening sessions with files embedded from removable drives
Otherwise Windows shows a critical error for files embedded from
removable devices.
Paul Davis [Wed, 12 Oct 2016 21:26:46 +0000 (17:26 -0400)]
change return type of AutomationControl::actually_set_value() from void to bool, to indicate if value was changed.
Don't call Session::set_dirty() when no change occurs
Paul Davis [Wed, 12 Oct 2016 19:50:30 +0000 (15:50 -0400)]
peak level numeric display now uses "clip indicator" for base color, not "bright indicator"
Should address #7010
Paul Davis [Wed, 12 Oct 2016 19:43:47 +0000 (15:43 -0400)]
add gtk_clip_indicator as a separate color from gtk_bright_indicator
Nathan Stewart [Sun, 9 Oct 2016 12:26:59 +0000 (08:26 -0400)]
Fixed array index out of bounds in Push2Menu::set_active()
Nathan Stewart [Tue, 11 Oct 2016 15:07:17 +0000 (11:07 -0400)]
Fixes minor memory leak found in color_theme_manager.cpp:326
Nathan Stewart [Wed, 12 Oct 2016 03:07:52 +0000 (23:07 -0400)]
map::clear() calls erase. Cleans up cpp check warning 'iterator used after element has been erased'
Robin Gareus [Wed, 12 Oct 2016 18:08:39 +0000 (20:08 +0200)]
Clarify documentation of Lua inter-processor communication
Robin Gareus [Tue, 11 Oct 2016 20:57:38 +0000 (22:57 +0200)]
cleaner version of
feed9648 -- fixes #7067
Robin Gareus [Tue, 11 Oct 2016 20:54:21 +0000 (22:54 +0200)]
Revert "Allow loading sessions with missing external files #7067"
This reverts commit
feed9648e19f5750b102a161a1028bb143ea16c5.
Robin Gareus [Tue, 11 Oct 2016 20:05:27 +0000 (22:05 +0200)]
Allow loading sessions with missing external files #7067
The issue was introduced in
dbf86a495b, forcing must_exist = true
for *all* files that have a absolute _origin, including stub
SilentFileSources.
If an external file is no longer available and a user chooses to
"ignore, skip" an SilentFile is created instead of the actual source,
The SilentFileSource has the same XML state which includes _origin.
ARDOUR::SilentFileSource::SilentFileSource () c'tor calls
AudioFileSource::AudioFileSource (,.., must_exit = false)
but since the file has an absolute _origin, the AudioFileSource c'tor sets
must_exist = true; throws and the session cannot be loaded.
Robin Gareus [Tue, 11 Oct 2016 17:55:35 +0000 (19:55 +0200)]
add missing symbol for windows compile
Robin Gareus [Tue, 11 Oct 2016 12:09:54 +0000 (14:09 +0200)]
cater for Note translations. e.g. "Ré ♯" UTF-8
Robin Gareus [Tue, 11 Oct 2016 00:20:26 +0000 (02:20 +0200)]
Bundle session-scripts for linux builds
Robin Gareus [Mon, 10 Oct 2016 22:29:56 +0000 (00:29 +0200)]
Hide Dummy backend from optimized release builds
Prepare to bundle session-utils with releases.
Session-utils use libardour which needs an Engine. "Dummy" is the only
engine that always works
Robin Gareus [Mon, 10 Oct 2016 22:05:08 +0000 (00:05 +0200)]
skip Push2 unit-test for now:
The test segfaults due to missing screen and prevents other libardour
unit tests from running.
Robin Gareus [Mon, 10 Oct 2016 22:03:18 +0000 (00:03 +0200)]
allow to run single tests from ./artest
Robin Gareus [Mon, 10 Oct 2016 22:01:27 +0000 (00:01 +0200)]
make raw-midi script pass unit-tests (no midi port on track)
Robin Gareus [Mon, 10 Oct 2016 22:00:52 +0000 (00:00 +0200)]
Unit-tests to check Lua session+DSP scripts
Robin Gareus [Mon, 10 Oct 2016 21:49:19 +0000 (23:49 +0200)]
add const'ness (allowing LuaScriptList::const_iterator)
Robin Gareus [Mon, 10 Oct 2016 15:30:51 +0000 (17:30 +0200)]
Example Lua script for inter-plugin communication
Robin Gareus [Mon, 10 Oct 2016 15:03:31 +0000 (17:03 +0200)]
Add Lua-bindings for inter-processor communication
Robin Gareus [Mon, 10 Oct 2016 14:58:38 +0000 (16:58 +0200)]
Forward "owner" from Processor to Plugin
Robin Gareus [Mon, 10 Oct 2016 14:57:20 +0000 (16:57 +0200)]
Allow to get a route reference from SessionObject*
The motivation is to allow a Processor (here Lua) to get a pointer
to the owning Route without resorting to iterative lookup.
John Emmas [Mon, 10 Oct 2016 13:10:39 +0000 (14:10 +0100)]
Wrong iterator used with IDSortedList
Robin Gareus [Mon, 10 Oct 2016 12:37:03 +0000 (14:37 +0200)]
add missing #include
Robin Gareus [Mon, 10 Oct 2016 12:04:23 +0000 (14:04 +0200)]
convert VST parameter names to UTF8
Another fix for "µ-iness" (
ec8cf4e4f58a,
d121e6bf15cbf6f,
57b9dab27cb05d)
this time for Windows.
Tim Mayberry [Mon, 3 Oct 2016 02:41:42 +0000 (12:41 +1000)]
Fix order of Playlist XML nodes changing on Session save, bug #7053
Playlists in SessionPlaylists are sorted by pointer/address which means the
order they are written in the Session XML file usually changes the first time
the Session is re-saved.
Sort the Playlists by PBD::ID before iterating and writing XML so that
playlists are always written in the same order.
Tim Mayberry [Mon, 3 Oct 2016 01:24:34 +0000 (11:24 +1000)]
Fix indentation in SessionPlaylists::add_state()
Tim Mayberry [Fri, 23 Sep 2016 13:01:18 +0000 (23:01 +1000)]
Use std::vector::reserve to improve performance of adding properties
The number of properties per node roughly corresponds to the number of members
of the class the node is representing and should be fairly low.
Use std::vector::reserve to prevent reallocation on insert for most node types,
there are exceptions like Region(~40 properties).
This seems worth it as part(maybe 1/10th of the total time) of saving a Session
is a combination of what occurs in "Create" and "Write" in this test.
Perf results before changes:
XMLTest::testPerfMediumXMLDocumentTiming
Create : Count: 10 Min: 30610 Max: 42656 Total: 376672 Avg: 37667 (37 msecs)
Write : Count: 10 Min: 42804 Max: 54277 Total: 460455 Avg: 46045 (46 msecs)
Read : Count: 10 Min: 70364 Max: 85484 Total: 750909 Avg: 75090 (75 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
Create : Count: 10 Min: 164360 Max: 356995 Total:
3064482 Avg: 306448 (306 msecs)
Write : Count: 10 Min: 308655 Max: 372953 Total:
3226707 Avg: 322670 (322 msecs)
Read : Count: 10 Min: 517243 Max: 541839 Total:
5289950 Avg: 528995 (528 msecs)
Perf results after changes:
XMLTest::testPerfMediumXMLDocumentTiming
Create : Count: 10 Min: 30375 Max: 48253 Total: 431727 Avg: 43172 (43 msecs)
Write : Count: 10 Min: 42553 Max: 49163 Total: 453353 Avg: 45335 (45 msecs)
Read : Count: 10 Min: 70307 Max: 75987 Total: 734923 Avg: 73492 (73 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
Create : Count: 10 Min: 154486 Max: 307856 Total:
2678989 Avg: 267898 (267 msecs)
Write : Count: 10 Min: 304273 Max: 343274 Total:
3169158 Avg: 316915 (316 msecs)
Read : Count: 10 Min: 496920 Max: 541394 Total:
5260410 Avg: 526041 (526 msecs)
Tim Mayberry [Fri, 23 Sep 2016 12:56:36 +0000 (22:56 +1000)]
Remove PropertyMap from XMLNode class
It appears that there is no performance benefit from storing properties in a
map for faster lookup or it is counteracted by the penalty of storing and
maintaining the additional data structure.
Timing results before changes with an optimized build:
XMLTest::testPerfMediumXMLDocumentTiming
Create : Count: 10 Min: 41293 Max: 63746 Total: 564448 Avg: 56444 (56 msecs)
Write : Count: 10 Min: 42932 Max: 49221 Total: 453955 Avg: 45395 (45 msecs)
Read : Count: 10 Min: 80160 Max: 84678 Total: 824506 Avg: 82450 (82 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
Create : Count: 10 Min: 228759 Max: 420236 Total:
3587597 Avg: 358759 (358 msecs)
Write : Count: 10 Min: 307095 Max: 348767 Total:
3205704 Avg: 320570 (320 msecs)
Read : Count: 10 Min: 572400 Max: 657219 Total:
5959630 Avg: 595963 (595 msecs)
Perf results after changes:
XMLTest::testPerfMediumXMLDocumentTiming
Create : Count: 10 Min: 30610 Max: 42656 Total: 376672 Avg: 37667 (37 msecs)
Write : Count: 10 Min: 42804 Max: 54277 Total: 460455 Avg: 46045 (46 msecs)
Read : Count: 10 Min: 70364 Max: 85484 Total: 750909 Avg: 75090 (75 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
Create : Count: 10 Min: 164360 Max: 356995 Total:
3064482 Avg: 306448 (306 msecs)
Write : Count: 10 Min: 308655 Max: 372953 Total:
3226707 Avg: 322670 (322 msecs)
Read : Count: 10 Min: 517243 Max: 541839 Total:
5289950 Avg: 528995 (528 msecs)
Tim Mayberry [Thu, 22 Sep 2016 12:38:12 +0000 (22:38 +1000)]
Use references rather than copying containers in libpbd xml code
It is slightly surprising but there seems to be little difference to
performance with these changes. Possibly a slight improvement in "Create" test
with a large xml document(~5%).
Timing results before these changes with an optimized build using new XML perf tests:
XMLTest::testPerfMediumXMLDocumentTiming
Create : Count: 10 Min: 38656 Max: 63827 Total: 571228 Avg: 57122 (57 msecs)
Write : Count: 10 Min: 43594 Max: 49279 Total: 459907 Avg: 45990 (45 msecs)
Read : Count: 10 Min: 80247 Max: 84912 Total: 827207 Avg: 82720 (82 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
Create : Count: 10 Min: 230706 Max: 456054 Total:
3850998 Avg: 385099 (385 msecs)
Write : Count: 10 Min: 312322 Max: 353789 Total:
3264211 Avg: 326421 (326 msecs)
Read : Count: 10 Min: 573556 Max: 610865 Total:
5951908 Avg: 595190 (595 msecs)
Timing results after these changes:
XMLTest::testPerfMediumXMLDocumentTiming
Create : Count: 10 Min: 41293 Max: 63746 Total: 564448 Avg: 56444 (56 msecs)
Write : Count: 10 Min: 42932 Max: 49221 Total: 453955 Avg: 45395 (45 msecs)
Read : Count: 10 Min: 80160 Max: 84678 Total: 824506 Avg: 82450 (82 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
Create : Count: 10 Min: 228759 Max: 420236 Total:
3587597 Avg: 358759 (358 msecs)
Write : Count: 10 Min: 307095 Max: 348767 Total:
3205704 Avg: 320570 (320 msecs)
Read : Count: 10 Min: 572400 Max: 657219 Total:
5959630 Avg: 595963 (595 msecs)
Tim Mayberry [Fri, 23 Sep 2016 22:31:20 +0000 (08:31 +1000)]
Add test of pbd/xml++.h API performance with three file sizes
Generate, write and then read three Session like XML files to test the
performance of changes made to pbd/xml++.h API
Tim Mayberry [Mon, 26 Sep 2016 02:16:01 +0000 (12:16 +1000)]
Add XMLNode::operator==/!=() for comparing XMLNode instances
Implemented to be able to test that when writing an XML document via XMLTree
and then reading back into another XMLTree the structure is equivalent as a
general API test of pbd/xml++.h to check for breakage when changing
implementation.
Tim Mayberry [Mon, 26 Sep 2016 02:35:27 +0000 (12:35 +1000)]
Change position of average in PBD::timing_summary and add msecs
Tim Mayberry [Sun, 25 Sep 2016 04:32:14 +0000 (14:32 +1000)]
Add PBD::Timing::elapsed_msecs() as convenience API
nick_m [Sun, 9 Oct 2016 16:39:57 +0000 (03:39 +1100)]
Interpret start & length_beats properties as double rather than Evoral::Beats.
- Evoral::Beats operator!= would prevent an increment
of start_beats by intervals of less than a tick,
so its possible that other subtle problems
existed due to this kind of thing.
Robin Gareus [Sun, 9 Oct 2016 14:42:47 +0000 (16:42 +0200)]
Audio->MIDI script: properly handle MIDI-region start-offset
Robin Gareus [Sun, 9 Oct 2016 14:33:09 +0000 (16:33 +0200)]
Add some more midi-region BBT lua-bindings
nick_m [Sun, 9 Oct 2016 12:40:54 +0000 (23:40 +1100)]
Ensure midi region start trim always sets _start_beats.
- Property::set() requires that new_val != current for a change
to occur, but Beats::operator!= has tick resolution.
i think this is pretty good evidence that _start/_length_beats
should actually be double rather than Evoral::Beats
(adjusting a region by increments of less than a tick
is desirable).
nick_m [Sat, 8 Oct 2016 16:46:50 +0000 (03:46 +1100)]
TempoSection methods deal in beats rather than pulses per minute.
- removes note type from curve function for a slightly more
accurate result.
nick_m [Sat, 8 Oct 2016 16:34:13 +0000 (03:34 +1100)]
Ensure we have a region _beat for legacy sessions, set _pulse unconditionally when loading from xml.
nick_m [Sat, 8 Oct 2016 16:31:21 +0000 (03:31 +1100)]
Fix logic fail when setting midi region position, rework midi region start trimming.
nick_m [Sat, 8 Oct 2016 16:24:14 +0000 (03:24 +1100)]
Use double comparison in MidiRegionView::note_in_region_range().
Robin Gareus [Sat, 8 Oct 2016 15:04:49 +0000 (17:04 +0200)]
libqm-dsp is now a static library
Robin Gareus [Fri, 7 Oct 2016 21:52:44 +0000 (23:52 +0200)]
prepare for proper VST synth categorization
Robin Gareus [Fri, 7 Oct 2016 18:55:21 +0000 (20:55 +0200)]
Clean up is_instrument vs needs-midi-in API
The latter is only really relevant for Audio Units.
This fixes an issue with vocoders or audio-plugins that simply have
a MIDI input for other purposes to be wrongly categorized as Instruments..
.. and thereby override strict-i/o rules (prefer stereo)
Robin Gareus [Fri, 7 Oct 2016 18:01:04 +0000 (20:01 +0200)]
fix namespace inconsistency
Nathan Stewart [Fri, 7 Oct 2016 16:38:00 +0000 (12:38 -0400)]
Clean up cppcheck warnings about handling of allocated memory in SysEx class
Robin Gareus [Fri, 7 Oct 2016 17:07:15 +0000 (19:07 +0200)]
proper C++ const API (possible fix for MSVC builds)
John Emmas [Fri, 7 Oct 2016 16:56:42 +0000 (17:56 +0100)]
Allow 'qm-dsp' to build again with MSVC
Robin Gareus [Fri, 7 Oct 2016 14:33:50 +0000 (16:33 +0200)]
add BBT offsets to Audio->MIDI script
Robin Gareus [Fri, 7 Oct 2016 12:54:54 +0000 (14:54 +0200)]
Arrrgh Ardour starts counting at 1 :(
Robin Gareus [Fri, 7 Oct 2016 12:42:11 +0000 (14:42 +0200)]
fix script now that block + step size are set correctly
Robin Gareus [Fri, 7 Oct 2016 12:37:09 +0000 (14:37 +0200)]
honor Vamp Plugin preferred step+block sizes.
Robin Gareus [Fri, 7 Oct 2016 12:28:36 +0000 (14:28 +0200)]
Build qm-dsp & kissfft as static lib w/hidden symbols
...as precaution for plugins which may potentially use a different
version of the library.
Robin Gareus [Fri, 7 Oct 2016 11:54:20 +0000 (13:54 +0200)]
Robin Gareus [Fri, 7 Oct 2016 11:52:25 +0000 (13:52 +0200)]
avoid more C++11 - fixes OSX/PPC & MSVC builds
Robin Gareus [Fri, 7 Oct 2016 11:51:58 +0000 (13:51 +0200)]
remove cruft
Robin Gareus [Fri, 7 Oct 2016 01:59:38 +0000 (03:59 +0200)]
Document version of bundled qm-dsp library
Robin Gareus [Fri, 7 Oct 2016 01:45:59 +0000 (03:45 +0200)]
prototype polyphonic audio to midi script
Robin Gareus [Fri, 7 Oct 2016 01:39:22 +0000 (03:39 +0200)]
Lua binding for std::map<>::at()
Robin Gareus [Fri, 7 Oct 2016 00:38:56 +0000 (02:38 +0200)]
Add tempo-map Lua bindings
Robin Gareus [Thu, 6 Oct 2016 22:42:36 +0000 (00:42 +0200)]
avoid C++11 - fixes OSX/PPC builds
Robin Gareus [Thu, 6 Oct 2016 22:23:33 +0000 (00:23 +0200)]
Add Lua bindings for basic MIDI model editing
Robin Gareus [Thu, 6 Oct 2016 16:49:46 +0000 (18:49 +0200)]
Lua Script Example for Audio to Midi Transcription (work in progress)
Robin Gareus [Thu, 6 Oct 2016 16:35:29 +0000 (18:35 +0200)]
update LuaWindow output on-the-go (allow progress print)