ardour.git
9 years agofurther updated monitor-modes doc:
Robin Gareus [Wed, 22 Apr 2015 18:06:40 +0000 (20:06 +0200)]
further updated monitor-modes doc:

* separate heading
* clarify “silence/passthough” with hardware mon.

9 years agomon-modes doc: clarify table-headings and renice.
Robin Gareus [Wed, 22 Apr 2015 15:17:23 +0000 (17:17 +0200)]
mon-modes doc: clarify table-headings and renice.

Thanks to Chris!

9 years agoAdd some newly introduced sources to our MSVC project (gtk2_ardour)
John Emmas [Wed, 22 Apr 2015 09:48:08 +0000 (10:48 +0100)]
Add some newly introduced sources to our MSVC project (gtk2_ardour)

9 years agoRemove a 'no longer needed' source from our MSVC project (libpbd)
John Emmas [Wed, 22 Apr 2015 09:44:23 +0000 (10:44 +0100)]
Remove a 'no longer needed' source from our MSVC project (libpbd)

(FPU functionality was recently merged into a single source file)

9 years agocoefficients are floating-point.
Robin Gareus [Tue, 21 Apr 2015 22:31:03 +0000 (00:31 +0200)]
coefficients are floating-point.

fixes use of overloaded operator '==' is ambiguous (with operand types 'MPControl<gain_t>' and 'double') in previous commit.

9 years agoInitial Gain Coefficient tweaks
Ben Loftis [Wed, 25 Mar 2015 21:47:25 +0000 (16:47 -0500)]
Initial Gain Coefficient tweaks
1)  Disambiguate 1.0 to GAIN_COEFF_UNITY, and 0.0 to GAIN_COEFF_ZERO
2)  Add GAIN_COEFF_SMALL which replaces SMALL_SIGNAL (-140dB)
3)  GAIN_COEFF_SMALL can used to avoid interpolating towards -inf on a db scale
4)  GAIN_COEFF_SMALL is used to detect very small (denormal?) gains and memset to zero

9 years agomore windows related SSE build fixes
Paul Davis [Tue, 21 Apr 2015 17:28:17 +0000 (13:28 -0400)]
more windows related SSE build fixes

9 years agotypo
Paul Davis [Tue, 21 Apr 2015 17:04:22 +0000 (13:04 -0400)]
typo

9 years agouse compiler target to determine whether to use 64 bit windows assembler, not the...
Paul Davis [Tue, 21 Apr 2015 17:01:54 +0000 (13:01 -0400)]
use compiler target to determine whether to use 64 bit windows assembler, not the build host CPU type

9 years agoRevert "as an experiment, try original asm on windows."
Paul Davis [Tue, 21 Apr 2015 16:34:14 +0000 (12:34 -0400)]
Revert "as an experiment, try original asm on windows."

This reverts commit c37dc461b349c804736f9bcb09290745ccf1e4ab.

9 years agoas an experiment, try original asm on windows.
Paul Davis [Tue, 21 Apr 2015 16:32:59 +0000 (12:32 -0400)]
as an experiment, try original asm on windows.

Grygorii's new intel-syntax code didn't work on first try

9 years ago<intrin.h> is for windows only
Paul Davis [Tue, 21 Apr 2015 16:31:02 +0000 (12:31 -0400)]
<intrin.h> is for windows only

9 years agoadd required header for windows compile of FPU code
Paul Davis [Tue, 21 Apr 2015 16:25:21 +0000 (12:25 -0400)]
add required header for windows compile of FPU code

9 years agofix another recent error in wscript for windows
Paul Davis [Tue, 21 Apr 2015 16:21:57 +0000 (12:21 -0400)]
fix another recent error in wscript for windows

9 years agofix recent error in wscript for windows
Paul Davis [Tue, 21 Apr 2015 16:18:51 +0000 (12:18 -0400)]
fix recent error in wscript for windows

9 years agoRemove filename extension for chapter mark file
Johannes Mueller [Wed, 15 Apr 2015 17:55:48 +0000 (19:55 +0200)]
Remove filename extension for chapter mark file

The tool mp4chaps by the following command

$ mp4chaps -i test.mp4

looks for the file "test.chapters.txt" to read the chapter marks
from. So removing the original file name extension (e.g. wav or flac)
makes it slightly more convenient for the user.

9 years agoPut an Intro chapter at position 00:00:00.000
Johannes Mueller [Wed, 15 Apr 2015 16:03:39 +0000 (18:03 +0200)]
Put an Intro chapter at position 00:00:00.000

Players like vlc seem to stumble, if there es no chapter at the zero
position. As Ardour wouldn't let us put a track mark at the zero
position we can just use our header_func to put some kind of dummy intro
chapter. If a future version of Ardour allows track marks at zero, we
need to do a bit more work.

9 years agoAdded support for exporting mp4 chapter marks
Johannes Mueller [Sun, 12 Apr 2015 12:26:39 +0000 (14:26 +0200)]
Added support for exporting mp4 chapter marks

The mp4 file format supports chapter marks using the so called
mp4chaps format to enable chapter wise navigation in an mp4 file. The
format is like

hh:mm:ss.sss Chapter Title

This commit adds the ability to export those kind of chapter marks
along with TOC and CUE marks. The filename extension for the chapter
mark file is "chapters.txt". The format specification description is
"MP4ch".

9 years agofix build of FPU code on OS X by reverting to use of _LP64 to identify 32/64 bit...
Paul Davis [Tue, 21 Apr 2015 16:13:00 +0000 (12:13 -0400)]
fix build of FPU code on OS X by reverting to use of _LP64 to identify 32/64 bit situation

9 years agomerge all mingw and msvc specific code for FPU information into libs/pbd/fpu.cc and...
Paul Davis [Tue, 21 Apr 2015 15:39:19 +0000 (11:39 -0400)]
merge all mingw and msvc specific code for FPU information into libs/pbd/fpu.cc and remove msvc-specific version

9 years agoimprove logic flow
Paul Davis [Tue, 21 Apr 2015 15:38:34 +0000 (11:38 -0400)]
improve logic flow

9 years agoUpdate editor_rulers.cc
ahellquist [Fri, 17 Apr 2015 22:17:15 +0000 (00:17 +0200)]
Update editor_rulers.cc

Change ruler context actions from "Make Loop range" to "New Loop range"
change ruler context actions from "Make Punch range" to "New Loop range"

This to make it consistent with other ruler context actions eg. "New....."

9 years agoupdate some calls to use new get_preferred_edit_position; needs testing
Ben Loftis [Tue, 21 Apr 2015 15:16:00 +0000 (10:16 -0500)]
update some calls to use new get_preferred_edit_position; needs testing

9 years agominor tweaks to Cut Time dialog. Use an enum to tell preferred_edit_location what...
ben [Sun, 20 Oct 2013 21:02:56 +0000 (16:02 -0500)]
minor tweaks to Cut Time dialog.  Use an enum to tell preferred_edit_location what to ignore, so cut and insert dialogs will never use mouse location.

9 years agoPort 'Cut time' code from Mixbus
Colin Fletcher [Wed, 16 Oct 2013 21:25:35 +0000 (22:25 +0100)]
Port 'Cut time' code from Mixbus

Copy the 'Cut time' code from Mixbus, making a few obvious fixes to work in
A3 (e.g. nframes_t => framepos_t / framecnt_t).

Seems to work to move & remove markers, tempo & meter markers, and regions on
selected tracks.

Still TODO:
 - use existing A3 'Insert time' dialogue
 - make it respect 'No selection = all tracks'
 - rename the command to something like 'Remove time' or 'Delete time': 'Cut'
   sounds to me as if the removed range should end up on the clipboard ready
   to be pasted somewhere, which of course it doesn't.

9 years ago[Summary] Fixed bug in Ardour SSE assembler function. Wrong register was decreased...
Greg Zharun [Thu, 16 Apr 2015 09:18:31 +0000 (12:18 +0300)]
[Summary] Fixed bug in Ardour SSE assembler function. Wrong register was decreased in LP_SSE: block of float x86_sse_compute_peak function
[Details] This bug does not show up when buffers are 16 byte aligned, but when they are not - this bug will lead to crash.
I tested all these functions with non-aligned buffers as well as long they do handle the situation with unaligned buffers.
[To be reviewed by] Paul Davis

9 years ago[Summary] Added SSE sound processing functions support for Windows. Version 1.
Greg Zharun [Wed, 8 Apr 2015 13:29:33 +0000 (16:29 +0300)]
[Summary] Added SSE sound processing functions support for Windows. Version 1.

Conflicts:
wscript

9 years agoMonitor section - init _output_selector to 0.
nick_m [Tue, 21 Apr 2015 14:17:17 +0000 (00:17 +1000)]
Monitor section - init _output_selector to 0.

9 years agoanother merge fix
Ben Loftis [Tue, 21 Apr 2015 13:37:54 +0000 (08:37 -0500)]
another merge fix

9 years agomerge fix for tempo branch
Ben Loftis [Tue, 21 Apr 2015 13:35:20 +0000 (08:35 -0500)]
merge fix for tempo branch

9 years agomerge monitor_section branch
Ben Loftis [Tue, 21 Apr 2015 13:18:10 +0000 (08:18 -0500)]
merge monitor_section branch

9 years agoMerge branch 'master' into saveas
Paul Davis [Tue, 21 Apr 2015 04:19:29 +0000 (00:19 -0400)]
Merge branch 'master' into saveas

9 years agodo not reset paths for sources that are still outside the session after save-as
Paul Davis [Tue, 21 Apr 2015 04:18:49 +0000 (00:18 -0400)]
do not reset paths for sources that are still outside the session after save-as

9 years agoallow coreaudio backend to build on OS X Lion
Paul Davis [Tue, 21 Apr 2015 03:12:35 +0000 (23:12 -0400)]
allow coreaudio backend to build on OS X Lion

9 years agotuning the save-as dialog
Paul Davis [Tue, 21 Apr 2015 02:46:54 +0000 (22:46 -0400)]
tuning the save-as dialog

9 years agoSMF::end_write() is a no-op if there is no _smf structure
Paul Davis [Tue, 21 Apr 2015 02:46:39 +0000 (22:46 -0400)]
SMF::end_write() is a no-op if there is no _smf structure

9 years agonew attempt at scaling indicator LED
Robin Gareus [Tue, 21 Apr 2015 01:04:34 +0000 (03:04 +0200)]
new attempt at scaling indicator LED

9 years agoadjust default meter font-size (same as it was before)
Robin Gareus [Tue, 21 Apr 2015 00:12:43 +0000 (02:12 +0200)]
adjust default meter font-size (same as it was before)

9 years agouse save as dialog in ArdourUI
Paul Davis [Mon, 20 Apr 2015 21:49:41 +0000 (17:49 -0400)]
use save as dialog in ArdourUI

9 years agoadd save_as dialog to build system
Paul Davis [Mon, 20 Apr 2015 21:49:29 +0000 (17:49 -0400)]
add save_as dialog to build system

9 years agoinitial version of save-as dialog
Paul Davis [Mon, 20 Apr 2015 21:32:54 +0000 (17:32 -0400)]
initial version of save-as dialog

9 years agoadd a pure virtual FileSource::close() method so that FileSource::set_path() can...
Paul Davis [Mon, 20 Apr 2015 20:31:06 +0000 (16:31 -0400)]
add a pure virtual FileSource::close() method so that FileSource::set_path() can ensure we no longer have a handle open

9 years agoremove _file_path member from Evoral::SMF
Paul Davis [Mon, 20 Apr 2015 19:44:20 +0000 (15:44 -0400)]
remove _file_path member from Evoral::SMF

9 years agotowards fixing #6265
Robin Gareus [Mon, 20 Apr 2015 19:39:25 +0000 (21:39 +0200)]
towards fixing #6265

9 years agoMerge branch 'master' into saveas
Paul Davis [Mon, 20 Apr 2015 19:10:41 +0000 (15:10 -0400)]
Merge branch 'master' into saveas

Conflicts:
gtk2_ardour/ardour.menus.in
libs/ardour/session_state.cc

9 years agoclarify GUI scaling
Robin Gareus [Mon, 20 Apr 2015 18:51:33 +0000 (20:51 +0200)]
clarify GUI scaling

9 years agoscalable panners
Robin Gareus [Mon, 20 Apr 2015 18:45:14 +0000 (20:45 +0200)]
scalable panners

9 years agotowards scaleable meter and mixer UI
Robin Gareus [Mon, 20 Apr 2015 03:35:23 +0000 (05:35 +0200)]
towards scaleable meter and mixer UI

somewhat hacky solution, but there's no good central point to
control this and get integer rounding/summing, is there?

9 years agoupdate russian translation
Paul Davis [Sun, 19 Apr 2015 17:56:58 +0000 (13:56 -0400)]
update russian translation

9 years agoattempt to fix the strip club
Robin Gareus [Sun, 19 Apr 2015 14:21:28 +0000 (16:21 +0200)]
attempt to fix the strip club

9 years agotransport button HiDPI scaling
Robin Gareus [Sat, 18 Apr 2015 17:42:00 +0000 (19:42 +0200)]
transport button HiDPI scaling

9 years agoHiDPI button tweaks
Robin Gareus [Sat, 18 Apr 2015 17:30:08 +0000 (19:30 +0200)]
HiDPI button tweaks

9 years agofix mingw build 4.0
Paul Davis [Fri, 17 Apr 2015 22:23:10 +0000 (18:23 -0400)]
fix mingw build

9 years agofix typo after localedir change
Paul Davis [Fri, 17 Apr 2015 15:55:17 +0000 (11:55 -0400)]
fix typo after localedir change

9 years agoDon't modify a RouteUISelection that we've just erased
John Emmas [Fri, 17 Apr 2015 15:12:48 +0000 (16:12 +0100)]
Don't modify a RouteUISelection that we've just erased

9 years agoDummy: fix sine/square frequency sweep
Robin Gareus [Fri, 17 Apr 2015 15:08:52 +0000 (17:08 +0200)]
Dummy: fix sine/square frequency sweep

9 years agofix novice-level mistake that causes localedir to point to random, reusable (typicall...
Paul Davis [Fri, 17 Apr 2015 15:00:33 +0000 (11:00 -0400)]
fix novice-level mistake that causes localedir to point to random, reusable (typically stack) memory

9 years agoAmend ac1f7e0b
nick_m [Thu, 16 Apr 2015 19:36:13 +0000 (05:36 +1000)]
Amend ac1f7e0b

9 years agoIndicate all clips on rectified view.
nick_m [Thu, 16 Apr 2015 19:26:57 +0000 (05:26 +1000)]
Indicate all clips on rectified view.

9 years agoImprove waveview height and scaling.
nick_m [Thu, 16 Apr 2015 19:03:51 +0000 (05:03 +1000)]
Improve waveview height and scaling.

The top line of the selection rect is arguably 1 px too low, but
waveviews seem centered on the area properly.

9 years agoVST: fix a copy/paste typo and possible segfault
Robin Gareus [Thu, 16 Apr 2015 16:27:19 +0000 (18:27 +0200)]
VST: fix a copy/paste typo and possible segfault

fix by Drumfix.

9 years agoput all of the Mackie control surface code into the ArdourSurface namespace
Paul Davis [Thu, 16 Apr 2015 00:37:20 +0000 (20:37 -0400)]
put all of the Mackie control surface code into the ArdourSurface namespace

9 years agoupdate german translation
Paul Davis [Thu, 16 Apr 2015 00:19:18 +0000 (20:19 -0400)]
update german translation

9 years agoupdate russian translation
Paul Davis [Thu, 16 Apr 2015 00:18:26 +0000 (20:18 -0400)]
update russian translation

9 years agoadd ArdourSurface to OSC class to help reduce global namespace pollution
Paul Davis [Wed, 15 Apr 2015 21:21:47 +0000 (17:21 -0400)]
add ArdourSurface to OSC class to help reduce global namespace pollution

9 years agodisable -rdynamic by default
Robin Gareus [Wed, 15 Apr 2015 18:31:27 +0000 (20:31 +0200)]
disable -rdynamic by default

see man 3 dlopen. Ideally we’d use RTLD_DEEPBIND,
but it’s neither portable and rather new (glibc 2.3.4).

This fixes issues with symbol conflicts in plugins
e.g. http://pastebin.com/FkFkf3Mm  (plugin expects
its own OSC[illator?] class but gets ardour’s
OpenSoundControl instead).

9 years agofix for memory overrun during read_peaks(), from sebastian reichelt
Paul Davis [Wed, 15 Apr 2015 17:32:34 +0000 (13:32 -0400)]
fix for memory overrun during read_peaks(), from sebastian reichelt

9 years agoReplace control list locks with RWLocks 4.0-rc4
Robin Gareus [Wed, 15 Apr 2015 16:13:56 +0000 (18:13 +0200)]
Replace control list locks with RWLocks

towards fixing #6238 and #6096.

GUI thread:
#2  Glib::Threads::Mutex::Lock::Lock
#3  Evoral::ControlList::eval
#4  Evoral::Control::get_double
#5  ARDOUR::AutomationControl::get_value
#6  ProcessorEntry::Control::control_changed
..
#15 PBD::Timer::timeout_handler

at the same time: Audio Thread (try-lock, fails)

#0  Evoral::Curve::rt_safe_get_vector
#1  ARDOUR::Amp::setup_gain_automation
#2  ARDOUR::Route::process_output_buffers

Due to the failed try-lock.. AMP::_apply_gain_automation
is false. and Amp::run() uses a different gain factor.
-> click.

9 years agoportaudio backend: allow Pa_GetDeviceInfo to fail.
Robin Gareus [Wed, 15 Apr 2015 01:04:19 +0000 (03:04 +0200)]
portaudio backend: allow Pa_GetDeviceInfo to fail.

9 years agoWhen running on Windows, hide the Engine dialog before calling 'push_state_to_backend()'
John Emmas [Tue, 14 Apr 2015 10:18:50 +0000 (11:18 +0100)]
When running on Windows, hide the Engine dialog before calling 'push_state_to_backend()'

For some reason we don't understand 'push_state_to_backend()' can interfere with hiding the dialog (causing a partially hidden dialog to remain on screen). It's most likely a timing issue with the Windows version of GTK. Fortunately, reversing the calling order seems to fix it - BUT...

If there's no session loaded yet, the user can be left with a very long wait while nothing seems to be happening. The next thing the user would normally see would be the splash image. So let's display it slightly early (so the user can at least see that something's happening).

Sadly, it's all very kludgy - but a lot better than what we had before...  :)

9 years agosimplify coaxing clock value out of ardour
Robin Gareus [Tue, 14 Apr 2015 09:55:39 +0000 (11:55 +0200)]
simplify coaxing clock value out of ardour

9 years agowhen building context menu for click on mixer strip, ensure clicked-on strip sets...
Paul Davis [Tue, 14 Apr 2015 02:43:22 +0000 (22:43 -0400)]
when building context menu for click on mixer strip, ensure clicked-on strip sets selection appropriately

9 years agoadd braces
Paul Davis [Tue, 14 Apr 2015 02:25:55 +0000 (22:25 -0400)]
add braces

9 years agonow that there is only 1 effective selection, adjust add-new-track-or-bus option...
Paul Davis [Tue, 14 Apr 2015 02:24:10 +0000 (22:24 -0400)]
now that there is only 1 effective selection, adjust add-new-track-or-bus option for after/before selection

9 years agoremove UI configuration variable link-editor-and-mixer-selection, and make behaviour...
Paul Davis [Tue, 14 Apr 2015 01:55:17 +0000 (21:55 -0400)]
remove UI configuration variable link-editor-and-mixer-selection, and make behaviour be equivalent to this option always being true

9 years agoallow to set/change loop-range via OSC
Robin Gareus [Mon, 13 Apr 2015 14:20:40 +0000 (16:20 +0200)]
allow to set/change loop-range via OSC

9 years agofix issue with logic controlling rude isolate button
Paul Davis [Mon, 13 Apr 2015 13:02:25 +0000 (09:02 -0400)]
fix issue with logic controlling rude isolate button

9 years agoremove unused local variable
Paul Davis [Sat, 11 Apr 2015 14:57:42 +0000 (10:57 -0400)]
remove unused local variable

9 years agogtk2_ardour code should use translation domain "gtk2_ardour[MAJOR_VERSION]" not gtk2_...
Paul Davis [Sat, 11 Apr 2015 14:35:28 +0000 (10:35 -0400)]
gtk2_ardour code should use translation domain "gtk2_ardour[MAJOR_VERSION]" not gtk2_ardour3

9 years agodisable LED-style meters by default
Robin Gareus [Sat, 11 Apr 2015 09:06:09 +0000 (11:06 +0200)]
disable LED-style meters by default

9 years agoRemove unused pointer to nothing.
nick_m [Fri, 10 Apr 2015 19:36:05 +0000 (05:36 +1000)]
Remove unused pointer to nothing.

9 years agoFix dangling location on new location -> undo.
nick_m [Fri, 10 Apr 2015 18:45:45 +0000 (04:45 +1000)]
Fix dangling location on new location -> undo.

9 years agoMerge branch 'uk-english'
Colin Fletcher [Fri, 10 Apr 2015 17:25:58 +0000 (18:25 +0100)]
Merge branch 'uk-english'

Merge the UK English localisation.

9 years agoallow MIDI bindings for boolean automation
Robin Gareus [Fri, 10 Apr 2015 15:14:11 +0000 (17:14 +0200)]
allow MIDI bindings for boolean automation

9 years agobump copyright duration
Paul Davis [Thu, 9 Apr 2015 20:57:44 +0000 (16:57 -0400)]
bump copyright duration

9 years agoPosition (and size) canvas tooltips such that they better resemble Gtk tooltips
John Emmas [Thu, 9 Apr 2015 14:46:12 +0000 (15:46 +0100)]
Position (and size) canvas tooltips such that they better resemble Gtk tooltips

Mixbus in particular uses both types of tooltip so we might as well make them look the same.

N.B. The appearance is fine now on Windows but needs to be tested on the other platforms (i.e. some tweaking might be necessary).

9 years agoDelete a canvas tooltip after we've finished with it
John Emmas [Thu, 9 Apr 2015 14:42:00 +0000 (15:42 +0100)]
Delete a canvas tooltip after we've finished with it

All canvas objects share just one tooltip object which is based around Gtk::Label. The Label expands if the current tooltip text is wider than the previous text. However, it doesn't shrink again if the next tooltip has shorter text. Eventually, this results in some very strange looking tooltips (especially in Mixbus where they're used quite extensively).

Deleting the object after use will force a new object to get generated next time (at the correct size). There's still only ever one object per canvas but it's no longer persistent.

9 years agoredraw playhead only if pixel position changed. 4.0-rc3
Robin Gareus [Wed, 8 Apr 2015 10:31:44 +0000 (12:31 +0200)]
redraw playhead only if pixel position changed.

9 years agorenice transport icons
Robin Gareus [Wed, 8 Apr 2015 09:29:55 +0000 (11:29 +0200)]
renice transport icons

9 years agoNOOP, cleanup & comments
Robin Gareus [Wed, 8 Apr 2015 08:18:39 +0000 (10:18 +0200)]
NOOP, cleanup & comments

9 years agoconstruct a metronom
Robin Gareus [Tue, 7 Apr 2015 23:28:52 +0000 (01:28 +0200)]
construct a metronom

9 years agomore transport button caironizing.
Robin Gareus [Tue, 7 Apr 2015 21:58:59 +0000 (23:58 +0200)]
more transport button caironizing.

9 years agofix de7d6a7 (too narrow bar)
Robin Gareus [Tue, 7 Apr 2015 20:39:42 +0000 (22:39 +0200)]
fix de7d6a7  (too narrow bar)

9 years agorenice transport buttons (part one)
Robin Gareus [Tue, 7 Apr 2015 20:33:43 +0000 (22:33 +0200)]
renice transport buttons (part one)

9 years agoupdate ArdourButton Icon API
Robin Gareus [Tue, 7 Apr 2015 19:47:04 +0000 (21:47 +0200)]
update ArdourButton Icon API

9 years agoupdate german translation
Paul Davis [Tue, 7 Apr 2015 19:37:34 +0000 (15:37 -0400)]
update german translation

9 years agoand 2c89ec5, keep backend running.
Robin Gareus [Tue, 7 Apr 2015 13:23:24 +0000 (15:23 +0200)]
and 2c89ec5, keep backend running.

9 years agoRevert "prevent double declicks (click after RecStop)"
Robin Gareus [Tue, 7 Apr 2015 13:05:00 +0000 (15:05 +0200)]
Revert "prevent double declicks (click after RecStop)"

This reverts commit 6ba555c2f57fb793431aef0cedfbacf11d643a2b.
which does not yet take monitoring states into account.

Ideally the case handled here should not happen in the
first place, It should be fixed in session_transport
transport_sub_state.

9 years agowindows can’t rename open files.
Robin Gareus [Tue, 7 Apr 2015 03:20:06 +0000 (05:20 +0200)]
windows can’t rename open files.

This needs a better solution after 4.0.

9 years agoprevent double declicks (click after RecStop)
Robin Gareus [Tue, 7 Apr 2015 03:19:28 +0000 (05:19 +0200)]
prevent double declicks (click after RecStop)

If there's port-latency > period-size, there is a
split cycle with (this_event->action_frame - _transport_frame).
Yet Session::check_declick_out() keeps PendingDeclickOut if
StopPendingCapture is set. The route declick’ed twice:
Once with the period-size and one with the remaining frames,
which resulted in a click.