ardour.git
10 years agofix PixFader size allocation
Robin Gareus [Sat, 4 Jan 2014 04:29:06 +0000 (05:29 +0100)]
fix PixFader size allocation

previously faders in the processor box were only sized correctly
after the 2nd iteration: allocate -> request -> allocate

10 years agopre-select reasonable-synth as Instrument
Robin Gareus [Fri, 3 Jan 2014 19:24:23 +0000 (20:24 +0100)]
pre-select reasonable-synth as Instrument

10 years agodon't split process cycle at end
Robin Gareus [Fri, 3 Jan 2014 17:36:00 +0000 (18:36 +0100)]
don't split process cycle at end

Keep in mind: While this is the correct thing to do,
it hides another another bug under the hood, related to
_global_port_buffer_offset in MidiPort::flush_buffers.
For debugging the latter issue, revert this.

10 years agoimprove clarity of logic parentheses
Paul Davis [Fri, 3 Jan 2014 17:19:18 +0000 (12:19 -0500)]
improve clarity of logic parentheses

10 years agoMerge branch 'master' of https://github.com/derAbgang/ardour
Paul Davis [Fri, 3 Jan 2014 17:18:36 +0000 (12:18 -0500)]
Merge branch 'master' of https://github.com/derAbgang/ardour

10 years agodon't declare hilight variable twice
Nils Philippsen [Thu, 2 Jan 2014 14:27:15 +0000 (15:27 +0100)]
don't declare hilight variable twice

10 years agoget rid of const warnings
Nils Philippsen [Thu, 2 Jan 2014 13:15:18 +0000 (14:15 +0100)]
get rid of const warnings

10 years agomantis 0005805
derAbgang [Thu, 2 Jan 2014 22:13:14 +0000 (17:13 -0500)]
mantis 0005805

10 years agoFix tests compilation after Control API changes
Julien de Kozak [Thu, 2 Jan 2014 08:01:30 +0000 (09:01 +0100)]
Fix tests compilation after Control API changes

10 years agoavoid GTK packing warning when using >1 backend
Paul Davis [Thu, 26 Dec 2013 16:29:26 +0000 (11:29 -0500)]
avoid GTK packing warning when using >1 backend

10 years agovisualize port connections in mixer/processor when in < out
Robin Gareus [Wed, 1 Jan 2014 14:34:06 +0000 (15:34 +0100)]
visualize port connections in mixer/processor when in < out

10 years agodebug message: print uint8 channel as integer not char
Robin Gareus [Tue, 31 Dec 2013 10:44:19 +0000 (11:44 +0100)]
debug message: print uint8 channel as integer not char

10 years agoimprove debug message
Robin Gareus [Mon, 30 Dec 2013 15:58:46 +0000 (16:58 +0100)]
improve debug message

10 years agoremove cruft
Robin Gareus [Mon, 30 Dec 2013 15:58:28 +0000 (16:58 +0100)]
remove cruft

10 years agofix assert for non-existing MIDI patch-names
Robin Gareus [Mon, 30 Dec 2013 15:24:27 +0000 (16:24 +0100)]
fix assert for non-existing MIDI patch-names

typename boost::detail::sp_member_access<T>::type boost::shared_ptr<T>::operator->() const [with T = MIDI::Name::ChannelNameSet; typename boost::detail::sp_member_access<T>::type = MIDI::Name::ChannelNameSet*]: Assertion `px != 0' failed.

10 years agovisualize # of channels in processor-box splitting icon
Robin Gareus [Mon, 30 Dec 2013 14:55:17 +0000 (15:55 +0100)]
visualize # of channels in processor-box splitting icon

10 years agooptimize peak calculation of silent buffers
Robin Gareus [Mon, 30 Dec 2013 13:26:09 +0000 (14:26 +0100)]
optimize peak calculation of silent buffers

10 years agoNOOP. remove trailing whitespace
Robin Gareus [Mon, 30 Dec 2013 13:21:09 +0000 (14:21 +0100)]
NOOP. remove trailing whitespace

10 years agomake meters request constant buffers
Robin Gareus [Mon, 30 Dec 2013 13:20:02 +0000 (14:20 +0100)]
make meters request constant buffers

10 years agouse buffer APIs instead of raw memcpy, fix plugin bypass
Robin Gareus [Sun, 29 Dec 2013 20:48:14 +0000 (21:48 +0100)]
use buffer APIs instead of raw memcpy, fix plugin bypass

10 years agofix replicate_missing_region_channels option
Robin Gareus [Sat, 28 Dec 2013 20:12:57 +0000 (21:12 +0100)]
fix replicate_missing_region_channels option

10 years agoprevent 0-pointer dereference in editor_routes.cc - fixes #5794
Robin Gareus [Sat, 28 Dec 2013 15:15:00 +0000 (16:15 +0100)]
prevent 0-pointer dereference in editor_routes.cc - fixes #5794

10 years agoremove unused API to explicitly set/unset buffer silent flag
Robin Gareus [Sat, 28 Dec 2013 12:37:09 +0000 (13:37 +0100)]
remove unused API to explicitly set/unset buffer silent flag

10 years agocentralize buffer silent-flag
Robin Gareus [Sat, 28 Dec 2013 12:43:44 +0000 (13:43 +0100)]
centralize buffer silent-flag

fixes possible x-talk 1 in, >= 2 out tracks:

Previously, only the first route-buffer of the input buffers
were marked as non-silent in Route::process_output_buffers().
Other buffers in the set (e.g. post-panner) would
contain audio but not marked as non-silent.

10 years agoadd support for old compilers w/o implicit stdbool
Robin Gareus [Fri, 27 Dec 2013 13:53:30 +0000 (14:53 +0100)]
add support for old compilers w/o implicit stdbool

10 years agoinitialize some uninitialized variables
Robin Gareus [Fri, 27 Dec 2013 13:04:49 +0000 (14:04 +0100)]
initialize some uninitialized variables

10 years agoFix export format dialog tagging state inconsistency
Sakari Bergen [Mon, 23 Dec 2013 18:47:37 +0000 (20:47 +0200)]
Fix export format dialog tagging state inconsistency

The state of a checkbox was used before the UI was properly initialized.
This always unset the tagging option in the format object.

10 years agoRe-enable export file tagging. No idea why this code has dropped out at some stage...
Sakari Bergen [Mon, 23 Dec 2013 18:26:51 +0000 (20:26 +0200)]
Re-enable export file tagging. No idea why this code has dropped out at some stage...

10 years agovtl: do not lock audio [to video] when extracting audio-only.
Robin Gareus [Mon, 23 Dec 2013 09:28:32 +0000 (10:28 +0100)]
vtl: do not lock audio [to video] when extracting audio-only.

10 years agobetter, probably working fix for windows-vst-on-linux build 3.5.143
Paul Davis [Sun, 22 Dec 2013 18:39:57 +0000 (13:39 -0500)]
better, probably working fix for windows-vst-on-linux build

10 years agoattempt to fix build with --windows-vst due to a bad merge of the external libs changes
Paul Davis [Sun, 22 Dec 2013 18:13:47 +0000 (13:13 -0500)]
attempt to fix build with --windows-vst due to a bad merge of the external libs changes

10 years agoadd K12/RMS meter type
Robin Gareus [Sun, 22 Dec 2013 08:25:33 +0000 (09:25 +0100)]
add K12/RMS meter type

10 years agofix up OSC support to conform to new CP API and pay attention to feedback setting...
Paul Davis [Sat, 21 Dec 2013 20:31:08 +0000 (15:31 -0500)]
fix up OSC support to conform to new CP API and pay attention to feedback setting, even though feedback does nothing right now

10 years agoconform to new CP API
Paul Davis [Sat, 21 Dec 2013 20:30:43 +0000 (15:30 -0500)]
conform to new CP API

10 years agoconform to new CP API
Paul Davis [Sat, 21 Dec 2013 20:30:34 +0000 (15:30 -0500)]
conform to new CP API

10 years agonew CP API and fix several egregious bugs with port handling when switching devices...
Paul Davis [Sat, 21 Dec 2013 20:30:07 +0000 (15:30 -0500)]
new CP API and fix several egregious bugs with port handling when switching devices, setting state etc.

10 years agoremove debug output
Paul Davis [Sat, 21 Dec 2013 20:29:30 +0000 (15:29 -0500)]
remove debug output

10 years agoconform to new CP API design
Paul Davis [Sat, 21 Dec 2013 20:28:47 +0000 (15:28 -0500)]
conform to new CP API design

10 years agoconform to new CP API design
Paul Davis [Sat, 21 Dec 2013 20:28:34 +0000 (15:28 -0500)]
conform to new CP API design

10 years agoclean up aspects of ControlProtocol API
Paul Davis [Sat, 21 Dec 2013 20:28:05 +0000 (15:28 -0500)]
clean up aspects of ControlProtocol API

10 years agoclean up aspects of ControlProtocol API
Paul Davis [Sat, 21 Dec 2013 20:27:57 +0000 (15:27 -0500)]
clean up aspects of ControlProtocol API

10 years agonew ControlProtocolManager API, and proper handling of view/model changes in the...
Paul Davis [Sat, 21 Dec 2013 20:26:35 +0000 (15:26 -0500)]
new ControlProtocolManager API, and proper handling of view/model changes in the RC options (prefs) editor

10 years agolonger text description
Paul Davis [Sat, 21 Dec 2013 20:25:27 +0000 (15:25 -0500)]
longer text description

10 years agomidi_clock_slave: fix bandwidth to 2/60 for best results
Hans Baier [Wed, 18 Dec 2013 22:42:52 +0000 (05:42 +0700)]
midi_clock_slave: fix bandwidth to 2/60 for best results

10 years agointerpolation_test: add some necessary assertions
Hans Baier [Wed, 18 Dec 2013 22:31:39 +0000 (05:31 +0700)]
interpolation_test: add some necessary assertions

10 years agomidi_clock_slave: fix wrong calculation of loop error
Hans Baier [Wed, 18 Dec 2013 02:55:15 +0000 (09:55 +0700)]
midi_clock_slave: fix wrong calculation of loop error

since transport_frame refers to cycle start, the should be position has
to account for position of the midi clock event.

10 years agomidi_clock_slave.cc: Better debug messages
Hans Baier [Wed, 18 Dec 2013 01:26:43 +0000 (08:26 +0700)]
midi_clock_slave.cc: Better debug messages

10 years agomidi clock slave: make bandwidth variable according to period size
Hans Baier [Tue, 17 Dec 2013 23:19:21 +0000 (06:19 +0700)]
midi clock slave: make bandwidth variable according to period size

10 years agomnemonic PDF: margin, URL, and (C)year updates
Robin Gareus [Sun, 15 Dec 2013 17:31:17 +0000 (18:31 +0100)]
mnemonic PDF: margin, URL, and (C)year updates

10 years agofix a crash caused by not checking if MackieControlProtocol::_surfaces_state exists
Paul Davis [Sat, 14 Dec 2013 15:35:18 +0000 (10:35 -0500)]
fix a crash caused by not checking if MackieControlProtocol::_surfaces_state exists

I forgot to add this check when i changed the member variable to a pointer.

10 years agorsynth.lv2: fix note off+on follow up:
Robin Gareus [Sat, 14 Dec 2013 03:28:14 +0000 (04:28 +0100)]
rsynth.lv2: fix note off+on follow up:

special case if the same note is turned off and on in the
same [internal] synth cycle (64samples). x-fade to ADSR attack.

10 years agochange Generic MIDI control so that it handles a SendFeedback request synchronously...
Paul Davis [Fri, 13 Dec 2013 21:56:34 +0000 (16:56 -0500)]
change Generic MIDI control so that it handles a SendFeedback request synchronously within a process callback

10 years agomake MIDI UI in libardour handle CallSlot requests like it used to (and like it should)
Paul Davis [Fri, 13 Dec 2013 21:55:57 +0000 (16:55 -0500)]
make MIDI UI in libardour handle CallSlot requests like it used to (and like it should)

10 years agoMackie Control support now saves & restores port connections for devices not using...
Paul Davis [Fri, 13 Dec 2013 21:00:08 +0000 (16:00 -0500)]
Mackie Control support now saves & restores port connections for devices not using ipMIDI (not required for ipMIDI anyway)

10 years agoremove some unused code from mackie support
Paul Davis [Fri, 13 Dec 2013 16:56:12 +0000 (11:56 -0500)]
remove some unused code from mackie support

10 years agofix reasonable synth octave
Robin Gareus [Fri, 13 Dec 2013 19:59:08 +0000 (20:59 +0100)]
fix reasonable synth octave

10 years agoxmas-egg
Robin Gareus [Fri, 13 Dec 2013 19:26:30 +0000 (20:26 +0100)]
xmas-egg

10 years agofix logic for display of transport bar meters
Paul Davis [Fri, 13 Dec 2013 15:52:15 +0000 (10:52 -0500)]
fix logic for display of transport bar meters

Always remove from parent (if there is one), then repack if necessary.

10 years agoadjust LV2 ringbuffer size according to LV2:resize-port
Robin Gareus [Thu, 12 Dec 2013 13:40:45 +0000 (14:40 +0100)]
adjust LV2 ringbuffer size according to LV2:resize-port

The message-size itself is part of the message which
stored in the ringbuffer. If the rinbuffer overflows
the message is misinterpreted -> segfault.

Choose a more conservative ring-buffer size and take
the requested LV2 size into account.

10 years agofix const-ness of names array
Nils Philippsen [Tue, 10 Dec 2013 22:06:27 +0000 (23:06 +0100)]
fix const-ness of names array

10 years agocompare plugin/creator/category names UTF8-aware
Nils Philippsen [Tue, 10 Dec 2013 20:31:57 +0000 (21:31 +0100)]
compare plugin/creator/category names UTF8-aware

10 years agoadd cmp_nocase_utf8()
Nils Philippsen [Tue, 10 Dec 2013 20:29:24 +0000 (21:29 +0100)]
add cmp_nocase_utf8()

This is like cmp_nocase(), only that it doesn't use toupper(), tolower()
and therefore is agnostic of the current locale, and attempts to compare
strings in a UTF8-aware way (or falls back to ASCII if one of the
strings isn't UTF8-encoded).

10 years agodon't use deprecated g_strcasecmp()
Nils Philippsen [Tue, 10 Dec 2013 20:20:56 +0000 (21:20 +0100)]
don't use deprecated g_strcasecmp()

It's dependent on the current locale and deprecated, use
g_ascii_strcasecmp() instead.

10 years agocompare region names case-sensitively
Nils Philippsen [Tue, 10 Dec 2013 20:17:04 +0000 (21:17 +0100)]
compare region names case-sensitively

10 years agouse correct argument order with memset()
Nils Philippsen [Tue, 10 Dec 2013 15:52:37 +0000 (16:52 +0100)]
use correct argument order with memset()

10 years agouse std::fill_n to fill gain buffer with samples
Nils Philippsen [Tue, 10 Dec 2013 15:50:35 +0000 (16:50 +0100)]
use std::fill_n to fill gain buffer with samples

Using memset fills the buffer with whatever 1.0 as a double or float has
in its LSB.

10 years agoMerge branch 'master--ignore-JackTransportNetStarting' of https://github.com/nphilipp...
Paul Davis [Tue, 10 Dec 2013 16:49:18 +0000 (11:49 -0500)]
Merge branch 'master--ignore-JackTransportNetStarting' of https://github.com/nphilipp/ardour

10 years agoignore "unofficial" states in jack_sync_callback()
Nils Philippsen [Mon, 9 Dec 2013 16:54:34 +0000 (17:54 +0100)]
ignore "unofficial" states in jack_sync_callback()

10 years agodon't overwrite necessary compiler flags
Nils Philippsen [Mon, 9 Dec 2013 16:33:45 +0000 (17:33 +0100)]
don't overwrite necessary compiler flags

Distinguish flags influencing optimization (overridable) from those
necessary for building (e.g. for using SSE).

10 years agoimprove architecture detection
Nils Philippsen [Sat, 9 Nov 2013 09:54:47 +0000 (10:54 +0100)]
improve architecture detection

Recognize ppc64, ppc, s390x, s390 CPUs, default to 'none' instead of
i686 (which tries to build with SSE and fails on non-x86 architectures).

10 years agoprint a warning for every VST >=2.4 plugin
Robin Gareus [Sat, 7 Dec 2013 17:45:40 +0000 (18:45 +0100)]
print a warning for every VST >=2.4 plugin

17:29 < rgareus> las: ok. I'll make this translatable, but this warning will show up every time ardour starts (and scans for plugins) which can be annoying.
17:30 < las> rgareus: yeah, well we need to do black/whitelisting of plugins anyway so ...

10 years agodetect VST >= 2.4 plugins.
Robin Gareus [Sat, 7 Dec 2013 17:04:31 +0000 (18:04 +0100)]
detect VST >= 2.4 plugins.

10 years agochange "cpu" in cpu load backend functions
Paul Davis [Wed, 4 Dec 2013 16:45:53 +0000 (11:45 -0500)]
change "cpu" in cpu load backend functions

10 years agominor tweaks to MIDI clock support, including delivery of position events/messages...
Paul Davis [Tue, 3 Dec 2013 04:34:12 +0000 (23:34 -0500)]
minor tweaks to MIDI clock support, including delivery of position events/messages when stopped

10 years agodon't run MIDI clock "tick" if session is silent (e.g. due to a locate)
Paul Davis [Tue, 3 Dec 2013 04:33:33 +0000 (23:33 -0500)]
don't run MIDI clock "tick" if session is silent (e.g. due to a locate)

10 years agofix continuous send of MIDI start/position/stop messages introduced by mistake
Paul Davis [Sun, 1 Dec 2013 17:18:57 +0000 (12:18 -0500)]
fix continuous send of MIDI start/position/stop messages introduced by mistake

10 years agofix up a bunch of confusion regarding the size/capacity/allocation of audio & midi...
Paul Davis [Sat, 30 Nov 2013 03:26:33 +0000 (22:26 -0500)]
fix up a bunch of confusion regarding the size/capacity/allocation of audio & midi buffers

10 years agodrop capacity argument from Buffer constructor, since the abstract class cannot ...
Paul Davis [Sat, 30 Nov 2013 03:25:36 +0000 (22:25 -0500)]
drop capacity argument from Buffer constructor, since the abstract class cannot (and should not) do anything with it

10 years agofix indentation
Paul Davis [Sat, 30 Nov 2013 03:24:59 +0000 (22:24 -0500)]
fix indentation

10 years agoadd explicit linkage to libtimecode
Paul Davis [Sat, 30 Nov 2013 03:24:37 +0000 (22:24 -0500)]
add explicit linkage to libtimecode

10 years agomake JACK backend return the right set of values when asked for buffer sizes or sampl...
Paul Davis [Wed, 27 Nov 2013 22:41:54 +0000 (17:41 -0500)]
make JACK backend return the right set of values when asked for buffer sizes or sample rate of a device other than the one in use

10 years agodo not push new state to backend from audio/MIDI setup until OK or Apply are clicked...
Paul Davis [Wed, 27 Nov 2013 22:41:22 +0000 (17:41 -0500)]
do not push new state to backend from audio/MIDI setup until OK or Apply are clicked (i.e. do not do this when device is changed)

10 years agoadd 0.5 second sleep after closing JACK connection so that next startup/connect is...
Paul Davis [Wed, 27 Nov 2013 20:25:10 +0000 (15:25 -0500)]
add 0.5 second sleep after closing JACK connection so that next startup/connect is likely to work (allowing JACK time to shutdown). Ugh

10 years agoadd error check to call to PortManager::reestablish_ports
Paul Davis [Wed, 27 Nov 2013 20:24:24 +0000 (15:24 -0500)]
add error check to call to PortManager::reestablish_ports

10 years agomove AudioBackend::_start() into protected, and expand a bit on documenting ::start...
Paul Davis [Wed, 27 Nov 2013 19:27:27 +0000 (14:27 -0500)]
move AudioBackend::_start() into protected, and expand a bit on documenting ::start() vs ::_start()

10 years agoadd yet more missing parts of previous commit re: libmidi++ and JACK (files not saved...
Paul Davis [Wed, 27 Nov 2013 19:08:22 +0000 (14:08 -0500)]
add yet more missing parts of previous commit re: libmidi++ and JACK (files not saved in emacs, sigh)

10 years agoadd missing parts of previous commit re: libmidi++ and JACK (files not saved in emacs...
Paul Davis [Wed, 27 Nov 2013 18:53:58 +0000 (13:53 -0500)]
add missing parts of previous commit re: libmidi++ and JACK (files not saved in emacs, sigh)

10 years agoremove unintended linkage between libmidipp and jack
Paul Davis [Wed, 27 Nov 2013 17:44:23 +0000 (12:44 -0500)]
remove unintended linkage between libmidipp and jack

10 years agoHande export initialization exceptions gracefully
Sakari Bergen [Sat, 23 Nov 2013 17:11:31 +0000 (19:11 +0200)]
Hande export initialization exceptions gracefully

10 years agoFix invalid assertions in AudioGrapher SampleFormatConverter
Sakari Bergen [Sat, 23 Nov 2013 16:42:14 +0000 (18:42 +0200)]
Fix invalid assertions in AudioGrapher SampleFormatConverter

This fixes an export crash with e.g. 8-bit export

10 years agofix for toolbar master-meter w/o master bus and/or detached toolbar
Robin Gareus [Sat, 23 Nov 2013 15:48:26 +0000 (16:48 +0100)]
fix for toolbar master-meter w/o master bus and/or detached toolbar

10 years agofix crash @ session-restore of plugins windows
Robin Gareus [Fri, 22 Nov 2013 17:22:55 +0000 (18:22 +0100)]
fix crash @ session-restore of plugins windows

The question is: why is _owner not set [yet], when the
window is restored. This rather smells like a race condition.

10 years agoreset time-axis peak when meter-point changes - fixes #5771
Robin Gareus [Wed, 20 Nov 2013 17:54:34 +0000 (18:54 +0100)]
reset time-axis peak when meter-point changes - fixes #5771

10 years agoDistinguish Save-as and Snapshot dialog window
Robin Gareus [Tue, 19 Nov 2013 14:51:27 +0000 (15:51 +0100)]
Distinguish Save-as and Snapshot dialog window

10 years agolv2: increase scratch buffer size to request port minimum size
Robin Gareus [Sat, 16 Nov 2013 23:33:32 +0000 (00:33 +0100)]
lv2: increase scratch buffer size to request port minimum size

10 years agofix audio-clock sample entry, handle empty entry as NOOP
Robin Gareus [Mon, 11 Nov 2013 01:33:57 +0000 (02:33 +0100)]
fix audio-clock sample entry, handle empty entry as NOOP

10 years agocorrect information on waf updates
Paul Davis [Sun, 10 Nov 2013 22:44:15 +0000 (17:44 -0500)]
correct information on waf updates

10 years agoallow to include In/Disk button on Meterbridge
Robin Gareus [Sat, 9 Nov 2013 12:16:08 +0000 (13:16 +0100)]
allow to include In/Disk button on Meterbridge

10 years agoreally no reason to support ARDOUR_EN anymore ... we have a preference dialog item... 3.5.74
Paul Davis [Tue, 5 Nov 2013 19:20:03 +0000 (14:20 -0500)]
really no reason to support ARDOUR_EN anymore ... we have a preference dialog item to enable/disable translation

10 years agoon OS X 10.7 at least, LANG is set by the system, so do not bail out of language...
Paul Davis [Tue, 5 Nov 2013 18:43:25 +0000 (13:43 -0500)]
on OS X 10.7 at least, LANG is set by the system, so do not bail out of language stuff early just because it is set