Robin Gareus [Thu, 23 Nov 2017 10:29:07 +0000 (11:29 +0100)]
Make static analysis happy..
If the copy c'tor of ProcessorSelection was actually used,
assigning the XMLProcessorSelection
processors = other.processors;
would lead to duplicate free() of the XMLNode*
XMLProcessorSelection would need a dedicated copy c'tor that
duplicates allocates a new XMLNode.
see also #10 at https://www.viva64.com/en/b/0540/
Anyway, the copy c'tor and assignment is never used. This commit makes
this explicit.
Robin Gareus [Thu, 23 Nov 2017 09:51:20 +0000 (10:51 +0100)]
Remove unreachable code.
if (working_on_selection) {
...
} else {
if (working_on_selection) { .. never reached .. }
}
Found by PVS: https://www.viva64.com/en/b/0540/
Robin Gareus [Thu, 23 Nov 2017 09:46:44 +0000 (10:46 +0100)]
NO-OP: cleaner syntax
Robin Gareus [Thu, 23 Nov 2017 09:45:04 +0000 (10:45 +0100)]
Consistent default argument for virtual fn.
Robin Gareus [Thu, 23 Nov 2017 09:38:52 +0000 (10:38 +0100)]
Catch exceptions by const reference
Robin Gareus [Thu, 23 Nov 2017 09:38:05 +0000 (10:38 +0100)]
Fix a potential(?) nullptr dereference
Robin Gareus [Thu, 23 Nov 2017 09:23:54 +0000 (10:23 +0100)]
fix call to std::unique; to actually erase dups.
Robin Gareus [Thu, 23 Nov 2017 09:12:34 +0000 (10:12 +0100)]
Fix potentially ambiguous printf()
Not a real issue, since it's just supposed to be some unique number.
but still.
Reported by PVS-Studio - https://www.viva64.com/en/b/0540/
Robin Gareus [Thu, 23 Nov 2017 09:10:32 +0000 (10:10 +0100)]
No need for memset to clear a byte.
Robin Gareus [Thu, 23 Nov 2017 08:56:57 +0000 (09:56 +0100)]
remove useless test, fgets() already ensures MAX_STRING_LEN
Found by PVS-Studio - https://www.viva64.com/en/b/0540/
Robin Gareus [Thu, 23 Nov 2017 08:53:50 +0000 (09:53 +0100)]
Fix another duplicate if from session/system config consolidation
Found by PVS-Studio - https://www.viva64.com/en/b/0540/
Robin Gareus [Thu, 23 Nov 2017 08:53:09 +0000 (09:53 +0100)]
Fix size-request call
use Requisition Gtk::Widget::size_request () const;
and not deprecated
void Gtk::Widget::size_request (const Requisition&);
Found by PVS-Studio - https://www.viva64.com/en/b/0540/
Robin Gareus [Thu, 23 Nov 2017 08:22:21 +0000 (09:22 +0100)]
Fix duplicate if(A) else if (A) condition
Issue came to be from consolidating Session and UI configuration.
Found by PVS-Studio - https://www.viva64.com/en/b/0540/
Robin Gareus [Wed, 22 Nov 2017 23:10:54 +0000 (00:10 +0100)]
Robin Gareus [Wed, 22 Nov 2017 23:10:36 +0000 (00:10 +0100)]
GUI to set clock-origin marker
Robin Gareus [Wed, 22 Nov 2017 21:10:37 +0000 (22:10 +0100)]
Implement clock delta modes
* use new config variable
* update GUI to select delta-modes
* delegate delta-calculation to MainClock
* save offset to calculate absolute-time
Robin Gareus [Wed, 22 Nov 2017 21:09:17 +0000 (22:09 +0100)]
Add clock-delta mode enum
Robin Gareus [Wed, 22 Nov 2017 21:08:40 +0000 (22:08 +0100)]
Introduce a dedicated "Clock Origin" Marker
Robin Gareus [Wed, 22 Nov 2017 19:36:58 +0000 (20:36 +0100)]
Fix switch statements in ExportTimespanSelector
Robin Gareus [Wed, 22 Nov 2017 19:36:28 +0000 (20:36 +0100)]
Add seconds as clock-unit
Robin Gareus [Mon, 13 Nov 2017 22:31:12 +0000 (23:31 +0100)]
Release (debug) lock before emitting signal
Damien Zammit [Sat, 18 Nov 2017 04:27:37 +0000 (15:27 +1100)]
Revert "editor_pt_import: Process wav indexes once only"
This reverts commit
7422ffe6920deba396debb670c713849a64be43b.
Len Ovens [Tue, 14 Nov 2017 01:18:33 +0000 (17:18 -0800)]
OSC: only reset cue sends that do not have a new send
Len Ovens [Mon, 13 Nov 2017 17:32:24 +0000 (09:32 -0800)]
OSC: /cue/previous_aux should always refresh
Len Ovens [Sun, 12 Nov 2017 21:52:18 +0000 (13:52 -0800)]
OSC: cue buttons can accept float or int
Robin Gareus [Mon, 13 Nov 2017 22:31:39 +0000 (23:31 +0100)]
Fix typo (missing quote) in patch-change window title
Robin Gareus [Fri, 10 Nov 2017 21:52:10 +0000 (22:52 +0100)]
Add API to allow buffer offsets when applying gain
Robin Gareus [Sat, 11 Nov 2017 21:47:47 +0000 (22:47 +0100)]
Add a noise generator (Lua DSP)
Damien Zammit [Sat, 11 Nov 2017 13:16:44 +0000 (00:16 +1100)]
a-comp: Fix typo with previous patch
Damien Zammit [Sat, 11 Nov 2017 02:59:41 +0000 (13:59 +1100)]
a-comp: Fix noise floor - asymptotics
Len Ovens [Fri, 10 Nov 2017 16:38:08 +0000 (08:38 -0800)]
OSC link: make whole link set follow strip_types
strip should not run periodic when blank - crash fix
Len Ovens [Wed, 8 Nov 2017 17:36:32 +0000 (09:36 -0800)]
OSC: set_surface sets linkset, linkid
/set_surface/* deals with linked surfaces
Len Ovens [Wed, 8 Nov 2017 04:18:23 +0000 (20:18 -0800)]
OSC: catch bad commands on /cue/* created crash on exit
Robin Gareus [Wed, 8 Nov 2017 00:37:50 +0000 (01:37 +0100)]
Fix a-reverb bypass/enable
Len Ovens [Tue, 7 Nov 2017 17:31:14 +0000 (09:31 -0800)]
OSC link: Clean up link not ready and surface refresh
Len Ovens [Mon, 6 Nov 2017 21:37:37 +0000 (13:37 -0800)]
OSC link: make selection work correctly
Robin Gareus [Sun, 5 Nov 2017 23:13:14 +0000 (00:13 +0100)]
Optimize zresampler for no re-sampling case.
Robin Gareus [Sun, 5 Nov 2017 23:12:32 +0000 (00:12 +0100)]
Some further notes (and experiments) on optimizations
Robin Gareus [Sat, 4 Nov 2017 16:11:10 +0000 (17:11 +0100)]
Add some notes for future optimizations (and prepare API)
Robin Gareus [Sat, 4 Nov 2017 15:39:08 +0000 (16:39 +0100)]
Change Delayline to use power-of-two size and bitmasking
Robin Gareus [Sat, 4 Nov 2017 15:24:09 +0000 (16:24 +0100)]
[Re]-Implement Delayline flush.
Also don't automatically flush the delayline at transport or monitor-
changes anymore.
With full-graph latency compensation, delaylines are before the
disk-reader, aligning input (disk uses read-ahead to align).
Flushing the delayline should only happen when input-monitoring
is disengaged. It's best degated to the Route or object using the
Delayline (potentially latency-aligned delayed flush).
Robin Gareus [Sat, 4 Nov 2017 04:20:14 +0000 (05:20 +0100)]
Optimize Delaylines: block-process (not one sample at a time)
This also tweaks fade behavior when the latency changes to prefer a
x-fade when possible.
This new variant does not support concurrent re-allocation and
execution. Hence the auto-connect thread needs to take a lock before
updating latencies (actually there's no need for an explicit update with
built-in backends, so this case remains to be updated further)
Robin Gareus [Fri, 3 Nov 2017 18:26:44 +0000 (19:26 +0100)]
Clean up delayline API: don't use 'get_' for accessor method-name
Len Ovens [Fri, 3 Nov 2017 19:35:19 +0000 (12:35 -0700)]
OSC link: first working commit for linking two surfaces as one
Robin Gareus [Fri, 3 Nov 2017 14:55:33 +0000 (15:55 +0100)]
Fix scroll-wheel on mixer-sliders
74c986534b changes the semantics of fader-flags:
NoVerticalScroll was "ignore vertical scroll for horizontal faders".
Now the flag ignores all vertical scrolling.
Robin Gareus [Fri, 3 Nov 2017 03:26:33 +0000 (04:26 +0100)]
Auditioner, silence buffer at end.
Robin Gareus [Fri, 3 Nov 2017 03:14:23 +0000 (04:14 +0100)]
Don't crash when auditioning empty .mid files.
Robin Gareus [Fri, 3 Nov 2017 02:05:54 +0000 (03:05 +0100)]
Fix polarity-control size (and crash during audition)
Also initialize new polarity-invert with gain 1.0, not inverted.
Don't fade-in.
John Emmas [Thu, 2 Nov 2017 10:16:24 +0000 (10:16 +0000)]
Accommodate newly added/removed source(s) in our MSVC project (libardour)
Robin Gareus [Wed, 1 Nov 2017 14:46:23 +0000 (15:46 +0100)]
Wrap automation on loop-position, split plugin processing
Robin Gareus [Tue, 31 Oct 2017 21:21:12 +0000 (22:21 +0100)]
Click-free polarity inversion, also use accelerated (AVX, SSE) Amp
Robin Gareus [Tue, 31 Oct 2017 21:01:46 +0000 (22:01 +0100)]
Fix samples-moved (and invalid use of not initialized CubicInterpolation)
Robin Gareus [Tue, 31 Oct 2017 21:01:04 +0000 (22:01 +0100)]
Interpolation phase[] is initially empty
Robin Gareus [Tue, 31 Oct 2017 21:00:22 +0000 (22:00 +0100)]
Fix set_loop() return value (amend 00a4ad)
Robin Gareus [Tue, 31 Oct 2017 18:54:08 +0000 (19:54 +0100)]
Relax assertion to allow rolling backwards into 0.
Robin Gareus [Tue, 31 Oct 2017 17:32:26 +0000 (18:32 +0100)]
Move Loop Location to Processors
The processors will becomes responsible to know about loop-positions
and map latency-compensated start_sample, end_sample into the loop-range
as needed.
Robin Gareus [Tue, 31 Oct 2017 14:26:29 +0000 (15:26 +0100)]
Fix NSM for distro-builds (waf install)
Robin Gareus [Tue, 31 Oct 2017 02:51:08 +0000 (03:51 +0100)]
Small steps towards rolling backwards..
Robin Gareus [Tue, 31 Oct 2017 02:18:59 +0000 (03:18 +0100)]
Migrate to Polarity-inversion processor & fix proc positions
* invert polarity after disk i/o proc or return
* fix position of export-proc (after polarity)
* fix input-meter (before disk-writer or after return)
Robin Gareus [Tue, 31 Oct 2017 02:15:43 +0000 (03:15 +0100)]
Add polarity-invert processor
Robin Gareus [Mon, 30 Oct 2017 21:24:21 +0000 (22:24 +0100)]
Fix importing tempo-maps for non-integer pulsed time-signatures
Robin Gareus [Mon, 30 Oct 2017 18:43:32 +0000 (19:43 +0100)]
Use new externally_connected API
Robin Gareus [Mon, 30 Oct 2017 18:43:18 +0000 (19:43 +0100)]
NO-OP: whitespace
Robin Gareus [Mon, 30 Oct 2017 18:41:42 +0000 (19:41 +0100)]
Add & implement PortEngine::externally_connected() API
Robin Gareus [Mon, 30 Oct 2017 18:39:42 +0000 (19:39 +0100)]
Add missing header (-Wmissing-prototypes)
Robin Gareus [Mon, 30 Oct 2017 18:39:10 +0000 (19:39 +0100)]
Add weak linked symbol for "jack_port_is_mine"
Robin Gareus [Mon, 30 Oct 2017 16:27:13 +0000 (17:27 +0100)]
Fix fade-out at quit.
Robin Gareus [Mon, 30 Oct 2017 15:28:24 +0000 (16:28 +0100)]
Always optimize zita-resampler, nothing to debug here
Robin Gareus [Mon, 30 Oct 2017 15:23:21 +0000 (16:23 +0100)]
remove non rt-safe debug messages
Robin Gareus [Mon, 30 Oct 2017 14:58:36 +0000 (15:58 +0100)]
Parallel execution of cycle-start/end
Robin Gareus [Mon, 30 Oct 2017 04:52:18 +0000 (05:52 +0100)]
Add a RT-Tasklist
Robin Gareus [Mon, 30 Oct 2017 14:57:39 +0000 (15:57 +0100)]
Move coreaudio_set_realtime_policy into libpbd
John Emmas [Mon, 30 Oct 2017 13:55:51 +0000 (13:55 +0000)]
Add MSVC support for building the 'zita-resampler' library (which is now needed by libardour)
John Emmas [Mon, 30 Oct 2017 12:44:44 +0000 (12:44 +0000)]
Accommodate the change from libtimecode to libtemporal (gtk2_ardour)
John Emmas [Mon, 30 Oct 2017 11:01:19 +0000 (11:01 +0000)]
Accommodate the change from libtimecode to libtemporal
Robin Gareus [Sun, 29 Oct 2017 17:44:06 +0000 (18:44 +0100)]
Remove unused per-port buffer offset
Robin Gareus [Sun, 29 Oct 2017 17:36:32 +0000 (18:36 +0100)]
NO-OP: whitespace
Robin Gareus [Sun, 29 Oct 2017 17:32:27 +0000 (18:32 +0100)]
Quick hack to test engine vari-speed (2/2)
Robin Gareus [Sun, 29 Oct 2017 17:32:17 +0000 (18:32 +0100)]
Quick hack to test engine vari-speed (1/2)
Robin Gareus [Sun, 29 Oct 2017 17:30:18 +0000 (18:30 +0100)]
Move vari-speed into backend (resample ports)
Previously Ardour used a /local/ per track vari-speed mechanism.
Now that the disk-reader is a latency-compensated processor, the speed
of each disk-reader would need to be maintained locally, offset by each
disk-reader's output latency. Furthermore each disk-reader may
produce a different number of samples, depending on its global alignment.
This commit introduces port-data resampling directly at the engine-level:
Up/down-sample all input ports at the beginning, and down/up-sample output
port-data using the inverse ratio at the end of the session's process
cycle.
The session itself is unaware of the speed-change, and only needs to
handle transport speeds {-1, 0, +1}.
This also allows for aligned cue-monitoring and vari-speed recording,
and also pitch-shifts synthesized MIDI along.
Robin Gareus [Sun, 29 Oct 2017 14:06:40 +0000 (15:06 +0100)]
Add a dedicated mono variable resampler version
Robin Gareus [Sun, 29 Oct 2017 19:03:24 +0000 (20:03 +0100)]
Fix/update alsa backend build recipe (statically link zresampler)
Robin Gareus [Sun, 29 Oct 2017 17:32:49 +0000 (18:32 +0100)]
Update Lua Bindings, fix inconsistencies.
Robin Gareus [Sun, 29 Oct 2017 16:55:57 +0000 (17:55 +0100)]
Revert "relax zita-resampler's relative ratio"
This reverts commit
d1b5a9ed3deb3045971bd16f6613ef328e49b7e8.
Robin Gareus [Sat, 28 Oct 2017 13:44:39 +0000 (15:44 +0200)]
Fix loading sessions w/new tempo-map.
Newly constructed sessions don't save "Tempo-start" property.
If there's no "start" node, _legacy_bbt is never explicitly set and
the default c'tor is used, which sets bar = 1.
The test for legacy session checks bar != 0.
All new sessions were processed with fix_legacy_session(), which breaks
the tempo-map and makes the session not loadable (duplicate Tempo).
Robin Gareus [Sat, 28 Oct 2017 13:35:58 +0000 (15:35 +0200)]
Fix initial cycle noise with dummy-loopback
Robin Gareus [Tue, 3 Oct 2017 16:02:35 +0000 (18:02 +0200)]
relax zita-resampler's relative ratio
John Emmas [Fri, 27 Oct 2017 12:08:32 +0000 (13:08 +0100)]
Accommodate newly added/removed source(s) in our MSVC project (libpbd)
Robin Gareus [Thu, 26 Oct 2017 20:33:11 +0000 (22:33 +0200)]
Add a RAII SpinLock (using boost's spinlock)
Paul Davis [Thu, 26 Oct 2017 19:46:00 +0000 (15:46 -0400)]
NO-OP: whitespace cleanup
Paul Davis [Thu, 26 Oct 2017 19:45:16 +0000 (15:45 -0400)]
move mixbus-only variable declaration
Paul Davis [Thu, 26 Oct 2017 19:44:32 +0000 (15:44 -0400)]
remove unused variable
Paul Davis [Thu, 26 Oct 2017 19:44:09 +0000 (15:44 -0400)]
fix preprocessor error on some/many systems
Paul Davis [Thu, 26 Oct 2017 19:43:49 +0000 (15:43 -0400)]
switch from std::auto_ptr<> (deprecated) to boost::scoped_ptr<>
Paul Davis [Thu, 26 Oct 2017 19:43:31 +0000 (15:43 -0400)]
remove unused variable
Paul Davis [Thu, 26 Oct 2017 19:43:08 +0000 (15:43 -0400)]
switch from std::auto_ptr<> (deprecated) to boost::scoped_ptr<>
Paul Davis [Thu, 26 Oct 2017 19:41:47 +0000 (15:41 -0400)]
switch from std::auto_ptr<> (deprecated) to boost::scoped_ptr<>
Paul Davis [Thu, 26 Oct 2017 19:41:11 +0000 (15:41 -0400)]
remove unused variables
Paul Davis [Thu, 26 Oct 2017 19:41:01 +0000 (15:41 -0400)]
remove unused variable
Paul Davis [Thu, 26 Oct 2017 19:15:05 +0000 (15:15 -0400)]
optimization for track with zero audio channels should not short-circuit MIDI disk reading