Paul Davis [Sat, 21 Jun 2014 15:43:42 +0000 (11:43 -0400)]
refactor Canvas so that all Items have children; add Container abstract base class; rename Group as "Layout" and retain only drawing semantics
Paul Davis [Sat, 21 Jun 2014 01:51:59 +0000 (21:51 -0400)]
fix some confusion when redrawing editor/mixer track/strip displays after track/bus deletion
The code relied on the idea that the order-key resync that occurs after deletion would change the order keys and thus cause
a redisplay. But since both the editor and mixer can initiate an order-key resync, the other window's resync will actually
do nothing (the order keys will already be correct). This led to the incorrect placement of material in the tracks canvas,
because the first resync triggered a redisplay while the route still existed, and then the second resync didn't cause a
redisplay (repositioning) but the canvas elements representing the track went away.
Fixed by forcing a redisplay in both editor and mixer if a route deletion is believed to be triggering a row deletion
in their underlying data models.
Paul Davis [Thu, 19 Jun 2014 19:06:48 +0000 (15:06 -0400)]
ensure that all waveviews have ALL their colors set accurately before first render
Avoids occasional bright red zero line drawn because the color(s) had not been reset correctly
Paul Davis [Thu, 19 Jun 2014 17:47:53 +0000 (13:47 -0400)]
explanatory comment
Paul Davis [Thu, 19 Jun 2014 17:45:05 +0000 (13:45 -0400)]
correct conversion of drop y-position into trackview for drag-n-drop of external files
Robin Gareus [Thu, 19 Jun 2014 17:43:13 +0000 (19:43 +0200)]
no more stack smashing, renice debug messages
Robin Gareus [Thu, 19 Jun 2014 17:42:59 +0000 (19:42 +0200)]
latency measurement dialog updates:
* distinguish errors: no ports and no engine.
* fix "No measurement results yet" message at successful end
* stop update callback
Robin Gareus [Thu, 19 Jun 2014 17:42:46 +0000 (19:42 +0200)]
engine-dialog: properly restore previous active state
Robin Gareus [Thu, 19 Jun 2014 17:42:19 +0000 (19:42 +0200)]
rework raw-midi drain strategy (workaround for sync devices)
Robin Gareus [Wed, 18 Jun 2014 18:53:43 +0000 (20:53 +0200)]
fix port-unregister (on failed latency measurement)
Paul Davis [Thu, 19 Jun 2014 17:18:42 +0000 (13:18 -0400)]
fix non-working cmd-Q on OS X. For some reason the shenanigans related to removing it from various menus as part of OS X standards breaks the accel system
Paul Davis [Thu, 19 Jun 2014 15:18:37 +0000 (11:18 -0400)]
change the way font specifications are used in UI config files
If no font family is specified, enforce use of Sans to match GTK behaviour (which we inadvertently relied on, it appears)
Paul Davis [Thu, 19 Jun 2014 15:16:27 +0000 (11:16 -0400)]
modifications to region drag implementation
(1) if we're dragging over the drop zone, then x-axis motion is irrelevant for threshold-of-move
(2) store original time axis view of a dragged region so that if we create a new track with the region drag, it can be the same height
Paul Davis [Thu, 19 Jun 2014 03:49:07 +0000 (23:49 -0400)]
various fixes for places that used get_font_for_style() ... converted to use UIConfiguration::get_canvasvar_*Font()
Paul Davis [Thu, 19 Jun 2014 03:48:13 +0000 (23:48 -0400)]
add bold monospace font specs to canvas_vars/ardour3_ui_default.conf
Paul Davis [Thu, 19 Jun 2014 13:25:49 +0000 (09:25 -0400)]
use new canvas cursor API to manage cursors while embedding audio
Paul Davis [Thu, 19 Jun 2014 13:25:24 +0000 (09:25 -0400)]
fix potential crash in Editor::set_canvas_cursor() if inadvertently passed a null cursor (semantics are different on OS X vs. X Window)
John Emmas [Thu, 19 Jun 2014 10:49:51 +0000 (11:49 +0100)]
Remove (no longer needed) sources from an MSVC project
John Emmas [Thu, 19 Jun 2014 10:47:49 +0000 (11:47 +0100)]
Move the definition for 'strtok_r' (to avoid clashing with a different definition in pthread_win32)
Paul Davis [Thu, 19 Jun 2014 02:48:24 +0000 (22:48 -0400)]
change verbose cursor font selection to use canvas variable mechanism, plus a few developing comment edits
Paul Davis [Thu, 19 Jun 2014 01:03:25 +0000 (21:03 -0400)]
more work on cursor tracking state
Paul Davis [Thu, 19 Jun 2014 01:03:11 +0000 (21:03 -0400)]
explanatory comment
Paul Davis [Thu, 19 Jun 2014 01:02:51 +0000 (21:02 -0400)]
fix naming of selection rect-related items
Paul Davis [Thu, 19 Jun 2014 01:02:30 +0000 (21:02 -0400)]
if we're not going to notify parents of bbox changes while an item is hidden, we need to remind it when the item is hidden or shown
nick_m [Wed, 18 Jun 2014 15:52:21 +0000 (01:52 +1000)]
Summary changes :
* Use correct image format for background image
* Construct thr ImageSurface as per cairo docs
* Place start/end markers in background image
Tempo bars :
* adjust beats display threshold to (hopefully) coincide with BBT ruler better.
Paul Davis [Wed, 18 Jun 2014 15:20:10 +0000 (11:20 -0400)]
Merge branch 'canvas_tweaks' of https://github.com/nmains/ardour into cairocanvas
Paul Davis [Wed, 18 Jun 2014 14:24:59 +0000 (10:24 -0400)]
a whole slew of changes related to centralizing and rationalizing cursor management.
Debugging output left in place to help address the reports that will come in as people test this more
nick_m [Wed, 18 Jun 2014 14:06:32 +0000 (00:06 +1000)]
Canvas tweaks.
* Only queue a draw for changed items that are set visible and in-window.
Paul Davis [Tue, 17 Jun 2014 15:35:13 +0000 (11:35 -0400)]
Merge branch 'cache_fixes' of https://github.com/nmains/ardour into cairocanvas
Paul Davis [Tue, 17 Jun 2014 15:34:47 +0000 (11:34 -0400)]
a set of 3 fixes that cure Canvas::Text leaving dirty pixels when being dragged. or might not - testing is non-deterministic, which is alarming
Paul Davis [Tue, 17 Jun 2014 15:34:10 +0000 (11:34 -0400)]
use a different approach for indicating expose rects (from robin gareus). #ifdef'd out by default
Robin Gareus [Tue, 17 Jun 2014 14:15:16 +0000 (16:15 +0200)]
prepare midi-latency measurement using sysex messages
Robin Gareus [Tue, 17 Jun 2014 13:51:49 +0000 (15:51 +0200)]
highlight send-panner
nick_m [Tue, 17 Jun 2014 14:16:51 +0000 (00:16 +1000)]
Cache entries are now region colour aware.
Paul Davis [Tue, 17 Jun 2014 12:09:00 +0000 (08:09 -0400)]
Merge branch 'pathscanner-refactor' of https://github.com/mojofunk/ardour into cairocanvas
Paul Davis [Tue, 17 Jun 2014 12:08:44 +0000 (08:08 -0400)]
Merge branch 'summary_background' of https://github.com/nmains/ardour into cairocanvas
Paul Davis [Tue, 17 Jun 2014 12:08:07 +0000 (08:08 -0400)]
a set of inter-related subtle changes to get vertical autoscrolling to work, or at least work better.
nick_m [Tue, 17 Jun 2014 11:44:36 +0000 (21:44 +1000)]
Render tracks and regions to a background image in the editor summary.
Connect to editor's SelectionChanged signal to display corresponding region colour change.
Tim Mayberry [Tue, 17 Jun 2014 03:29:31 +0000 (13:29 +1000)]
Remove PathScanner class from libpbd
Tim Mayberry [Tue, 17 Jun 2014 11:41:29 +0000 (21:41 +1000)]
Replace all use of PathScanner with equivalent functions from pbd/file_utils.h
Tim Mayberry [Tue, 17 Jun 2014 02:53:12 +0000 (12:53 +1000)]
Remove unused header includes
Tim Mayberry [Tue, 17 Jun 2014 02:37:43 +0000 (12:37 +1000)]
Add default arguments to match those in PathScanner::operator()
Tim Mayberry [Tue, 17 Jun 2014 02:16:37 +0000 (12:16 +1000)]
Move member functions from PathScanner to functions in pbd/file_utils.h
This allows us to remove PathScanner source file and keep PathScanner class
as header only until it is removed
Tim Mayberry [Tue, 17 Jun 2014 01:48:46 +0000 (11:48 +1000)]
Move PathScanner::operator() into header
Tim Mayberry [Tue, 17 Jun 2014 01:39:04 +0000 (11:39 +1000)]
Remove unused methods in PathScanner
Now that these methods are only a few lines it doesn't make much sense
to keep them seeing as they are unused. There are also functions with
near identical functionality in pbd/file_utils.h
Tim Mayberry [Tue, 17 Jun 2014 01:32:51 +0000 (11:32 +1000)]
Rename PathScanner::run_scan_internal to PathScanner::find_files_matching_filter
Tim Mayberry [Tue, 17 Jun 2014 01:22:52 +0000 (11:22 +1000)]
Remove PathScanner::run_scan and use PathScanner::run_scan_internal directly
Tim Mayberry [Tue, 17 Jun 2014 01:15:10 +0000 (11:15 +1000)]
Add PathScanner::find_files_matching_regex and move regexp usage to one place
Tim Mayberry [Tue, 17 Jun 2014 00:44:36 +0000 (10:44 +1000)]
Remove member filter argument from PathScanner methods and use normal filter for regex
Also use regfree to free memory of compiled patterns
Tim Mayberry [Mon, 16 Jun 2014 10:39:45 +0000 (20:39 +1000)]
Change PBD::PathScanner API to return results by value to avoid inadvertent memory leaks
Robin Gareus [Mon, 16 Jun 2014 21:58:52 +0000 (23:58 +0200)]
remove debug output
Robin Gareus [Mon, 16 Jun 2014 21:36:29 +0000 (23:36 +0200)]
hide "turn down volume" label for midi-latency measurement
Robin Gareus [Mon, 16 Jun 2014 20:08:52 +0000 (22:08 +0200)]
more alsa-midi debugging
Robin Gareus [Mon, 16 Jun 2014 18:22:31 +0000 (20:22 +0200)]
more midi latency detection debugging
Robin Gareus [Mon, 16 Jun 2014 17:44:23 +0000 (19:44 +0200)]
debug alsa midi latency measurement
Robin Gareus [Mon, 16 Jun 2014 15:56:52 +0000 (17:56 +0200)]
fix pango font style (prev commit)
Robin Gareus [Mon, 16 Jun 2014 15:30:22 +0000 (17:30 +0200)]
no more red latency messages
Robin Gareus [Sun, 15 Jun 2014 22:55:26 +0000 (00:55 +0200)]
fix typo in comment of prev. commit
Robin Gareus [Sun, 15 Jun 2014 22:51:45 +0000 (00:51 +0200)]
fix region un/combine, based on a patch by Tom Brand
Robin Gareus [Sun, 15 Jun 2014 18:46:06 +0000 (20:46 +0200)]
another edge-case, don't crash on invalid files with zero channels
Robin Gareus [Sun, 15 Jun 2014 18:42:34 +0000 (20:42 +0200)]
fix edge case - handle error in device owner request
Robin Gareus [Sun, 15 Jun 2014 18:41:20 +0000 (20:41 +0200)]
ARD: proper cleanup
Paul Davis [Sun, 15 Jun 2014 16:18:47 +0000 (12:18 -0400)]
comment correction regarding Canvas::visible_area()
Paul Davis [Sun, 15 Jun 2014 16:17:03 +0000 (12:17 -0400)]
initialize _scroll_parent in Canvas::item
Robin Gareus [Sun, 15 Jun 2014 14:36:13 +0000 (16:36 +0200)]
optimize midi delayline.
Robin Gareus [Sun, 15 Jun 2014 14:21:09 +0000 (16:21 +0200)]
offset automation by latency
Robin Gareus [Sun, 15 Jun 2014 14:12:50 +0000 (16:12 +0200)]
offset automation by processor latency for bouncing/freezing
the same remains to be done for general route processing
Robin Gareus [Sun, 15 Jun 2014 11:04:47 +0000 (13:04 +0200)]
plug some leaks
Robin Gareus [Sun, 15 Jun 2014 11:01:49 +0000 (13:01 +0200)]
update valgrind suppression file (ignore system-wide libs)
Robin Gareus [Sun, 15 Jun 2014 10:59:27 +0000 (12:59 +0200)]
reset latency dialog every time.
Robin Gareus [Sun, 15 Jun 2014 02:54:39 +0000 (04:54 +0200)]
be smart, use boost::shared_ptr
Robin Gareus [Sun, 15 Jun 2014 01:08:40 +0000 (03:08 +0200)]
clear engine device combo when no devices are available
Robin Gareus [Sun, 15 Jun 2014 00:31:47 +0000 (02:31 +0200)]
initialize uninitialized variable
Robin Gareus [Sun, 15 Jun 2014 00:31:28 +0000 (02:31 +0200)]
tweak ArdourButton focus outline
Robin Gareus [Sun, 15 Jun 2014 00:10:03 +0000 (02:10 +0200)]
remove debug output
Robin Gareus [Sun, 15 Jun 2014 02:09:48 +0000 (04:09 +0200)]
fix pathscanner / stl_vector related memory leaks
John Emmas [Sun, 15 Jun 2014 08:56:49 +0000 (09:56 +0100)]
Add newly introduced sources to our MSVC projects
John Emmas [Sun, 15 Jun 2014 08:55:34 +0000 (09:55 +0100)]
Remove no longer needed sources from MSVC projects
Robin Gareus [Sat, 14 Jun 2014 14:45:55 +0000 (16:45 +0200)]
strtok() is the root of all evil.
Robin Gareus [Sat, 14 Jun 2014 14:38:47 +0000 (16:38 +0200)]
tracking down concurrency issus is fun.
Robin Gareus [Sat, 14 Jun 2014 14:26:14 +0000 (16:26 +0200)]
if we don't have control over the device/backend, allow to proceed.
Robin Gareus [Sat, 14 Jun 2014 14:25:18 +0000 (16:25 +0200)]
simply future debugging of exit at start.
Robin Gareus [Sat, 14 Jun 2014 14:01:46 +0000 (16:01 +0200)]
fix initialization of audio-engine dialog
Paul Davis [Fri, 13 Jun 2014 22:45:12 +0000 (18:45 -0400)]
new anchored trim cursors (for now, just copies of the normal ones)
Paul Davis [Fri, 13 Jun 2014 22:43:16 +0000 (18:43 -0400)]
fix erroneous start of autoscroll when mouse pointer is left or above the left/upper scrolling boundary but we're already scrolled to zero on the relevant axes
Paul Davis [Fri, 13 Jun 2014 21:15:23 +0000 (17:15 -0400)]
do most of the work related to adding new anchored trim cursors (but debugging/analysis continues)
Robin Gareus [Fri, 13 Jun 2014 22:06:52 +0000 (00:06 +0200)]
enable ArdourButton focus in EngineDialog
Robin Gareus [Fri, 13 Jun 2014 21:50:07 +0000 (23:50 +0200)]
allow ardour button to handle focused keyboard events
Robin Gareus [Fri, 13 Jun 2014 20:18:10 +0000 (22:18 +0200)]
fix keyboard shorcuts in dialogs.
actually, for most dialogs, key-presses should never
be relayed. a get_modal() check might be the appropriate.
Paul Davis [Fri, 13 Jun 2014 19:48:30 +0000 (15:48 -0400)]
disambiguate another use of Rect on OS X
Paul Davis [Fri, 13 Jun 2014 18:27:59 +0000 (14:27 -0400)]
fix scrolling behaviour in track headers (event was stolen by rulers because event coordinates made it look as if the event happened there)
Paul Davis [Fri, 13 Jun 2014 16:51:46 +0000 (12:51 -0400)]
add all the fonts, and use the right name for the rulers as a result
Paul Davis [Fri, 13 Jun 2014 16:38:29 +0000 (12:38 -0400)]
no need to specify sans for ruler font
Paul Davis [Fri, 13 Jun 2014 16:22:32 +0000 (12:22 -0400)]
use canvas ruler font specification rather than get_font_for_style()
Paul Davis [Fri, 13 Jun 2014 16:22:06 +0000 (12:22 -0400)]
define ruler font style (to be subst'ed) in ardour3_ui_default.conf.in
Paul Davis [Fri, 13 Jun 2014 16:21:33 +0000 (12:21 -0400)]
add first canvas string variable to canvas_vars.h - the ruler font
Paul Davis [Fri, 13 Jun 2014 16:21:10 +0000 (12:21 -0400)]
correct CANVAS_STRING_VARIABLE macro in UIConfiguration constructor
Paul Davis [Fri, 13 Jun 2014 16:20:33 +0000 (12:20 -0400)]
build ardour3_ui_default.conf at build time, to allow font substitutions to be done (which are platform dependent)
Paul Davis [Fri, 13 Jun 2014 14:57:07 +0000 (10:57 -0400)]
missing part of ColorVariable commit
Paul Davis [Fri, 13 Jun 2014 14:56:46 +0000 (10:56 -0400)]
rationalize and coordinate handle of region (time axis view item) opacity.
There are still some bugs with this because of the waveview image cache - fixes coming soon.