ardour.git
9 years agoactively recording track-arm button is red, not pink
Ben Loftis [Wed, 3 Sep 2014 19:50:10 +0000 (14:50 -0500)]
actively recording track-arm button is red, not pink

9 years agoamend a99bd289 (button x-axis padding)
Robin Gareus [Wed, 3 Sep 2014 20:17:25 +0000 (22:17 +0200)]
amend a99bd289 (button x-axis padding)

9 years agouse close/cross button
Robin Gareus [Wed, 3 Sep 2014 20:07:46 +0000 (22:07 +0200)]
use close/cross button

9 years agoadd "close/cross" special button
Robin Gareus [Wed, 3 Sep 2014 20:07:25 +0000 (22:07 +0200)]
add "close/cross" special button

9 years agotweak button size request
Robin Gareus [Wed, 3 Sep 2014 20:06:45 +0000 (22:06 +0200)]
tweak button size request

9 years agoclean up rec-en circle math and limit the max radius of it
Robin Gareus [Wed, 3 Sep 2014 20:05:53 +0000 (22:05 +0200)]
clean up rec-en circle math and limit the max radius of it

9 years agoproper automation header indenting
Robin Gareus [Wed, 3 Sep 2014 18:48:06 +0000 (20:48 +0200)]
proper automation header indenting

9 years agorevert pixfader to sane state (reverts parts of bb70d426)
Robin Gareus [Wed, 3 Sep 2014 18:01:11 +0000 (20:01 +0200)]
revert pixfader to sane state (reverts parts of bb70d426)

9 years agocont'd work on automation-track headers (amend ba53af1c5)
Robin Gareus [Wed, 3 Sep 2014 17:58:33 +0000 (19:58 +0200)]
cont'd work on automation-track headers (amend ba53af1c5)

now that the separator line is at the top,
offset region-contents y0 by 1px.

9 years agoask TAV buttons to have square proportions
Ben Loftis [Wed, 3 Sep 2014 16:56:31 +0000 (11:56 -0500)]
ask TAV buttons to have square proportions

9 years agofix Play Loop from range context menu
Ben Loftis [Tue, 2 Sep 2014 22:17:24 +0000 (17:17 -0500)]
fix Play Loop from range context menu

9 years agoselecting a track in the mixer, with synced selection, will now clear any objects...
Ben Loftis [Tue, 2 Sep 2014 21:08:29 +0000 (16:08 -0500)]
selecting a track in the mixer, with synced selection, will now clear any objects selected

9 years agobring back old pixfader outline radius to demonstrate its issues
Robin Gareus [Wed, 3 Sep 2014 13:35:11 +0000 (15:35 +0200)]
bring back old pixfader outline radius to demonstrate its issues

9 years agoamend prev commit (Ardour button radii)
Robin Gareus [Wed, 3 Sep 2014 13:26:54 +0000 (15:26 +0200)]
amend prev commit (Ardour button radii)

9 years agoUpdate Ardour Button radii.
Robin Gareus [Wed, 3 Sep 2014 13:21:19 +0000 (15:21 +0200)]
Update Ardour Button radii.

This is effectively a noop. Decrease default radius,
only add to radius (for outline), never subtract to avioid
negative numbers.

9 years agorevert pixfader radius to default
Robin Gareus [Wed, 3 Sep 2014 13:09:54 +0000 (15:09 +0200)]
revert pixfader radius to default

9 years agoquick mockup of indented automation-track headers
Robin Gareus [Wed, 3 Sep 2014 13:03:35 +0000 (15:03 +0200)]
quick mockup of indented automation-track headers

XXX: If we keep this approach, TimeAxisView::show_at()
needs to be fixed.
TimeAxisView::_canvas_display should draw the separator
line at the top, and regions inside moved down 1px.

9 years agorobin needs a new keyboard with unstttttuck tt.
Robin Gareus [Wed, 3 Sep 2014 03:18:45 +0000 (05:18 +0200)]
robin needs a new keyboard with unstttttuck tt.

9 years agorelease shared route pointer kept by InternalSend when dropping refs.
Robin Gareus [Wed, 3 Sep 2014 03:17:16 +0000 (05:17 +0200)]
release shared route pointer kept by InternalSend when dropping refs.

fixes "SessionHandleRef exists across session deletion"
when using AuxSends

9 years agoallow to set gtk style for BarController's pixfader.
Robin Gareus [Wed, 3 Sep 2014 00:38:18 +0000 (02:38 +0200)]
allow to set gtk style for BarController's pixfader.

9 years agofix some compiler warnings
Robin Gareus [Wed, 3 Sep 2014 00:37:10 +0000 (02:37 +0200)]
fix some compiler warnings

9 years agouse tape-track rec-enable icon throughout.
Robin Gareus [Wed, 3 Sep 2014 00:35:42 +0000 (02:35 +0200)]
use tape-track rec-enable icon throughout.

9 years agouse new tape rec-en
Robin Gareus [Tue, 2 Sep 2014 23:07:27 +0000 (01:07 +0200)]
use new tape rec-en

9 years agoupdate rec-en circle drawing, add tape-mode
Robin Gareus [Tue, 2 Sep 2014 23:55:57 +0000 (01:55 +0200)]
update rec-en circle drawing, add tape-mode

9 years agopixfader bg has reverse gradient from fg
Ben Loftis [Tue, 2 Sep 2014 20:58:55 +0000 (15:58 -0500)]
pixfader bg has reverse gradient from fg

9 years agostroke black circle on top of rec circle
Ben Loftis [Tue, 2 Sep 2014 20:57:08 +0000 (15:57 -0500)]
stroke black circle on top of rec circle

9 years agomicro tweaks to ArdourButton corners
Ben Loftis [Tue, 2 Sep 2014 20:16:37 +0000 (15:16 -0500)]
micro tweaks to ArdourButton corners

9 years agouse new 'special' rec-en button
Robin Gareus [Tue, 2 Sep 2014 18:43:27 +0000 (20:43 +0200)]
use new 'special' rec-en button

9 years agoone off, special case rec-en button for now. (circle may need tweaking)
Robin Gareus [Tue, 2 Sep 2014 18:43:15 +0000 (20:43 +0200)]
one off, special case rec-en button for now. (circle may need tweaking)

In the long run we want a class hierarchy:
CairoWidget
-> ArdourWidget
-> ArdourLabel
-> ArdourButton
-> SpecialArdourButton(s)

9 years agocompact meter+fader for > 6 channel tracks
Robin Gareus [Tue, 2 Sep 2014 17:33:58 +0000 (19:33 +0200)]
compact meter+fader for > 6 channel tracks

9 years agonumber-label: use pixel-width for given font
Robin Gareus [Tue, 2 Sep 2014 17:27:40 +0000 (19:27 +0200)]
number-label: use pixel-width for given font

9 years agoArdourButton: prepare for [em] based padding
Robin Gareus [Tue, 2 Sep 2014 17:23:18 +0000 (19:23 +0200)]
ArdourButton: prepare for [em] based padding

9 years agostatic global definition for track-header width
Robin Gareus [Tue, 2 Sep 2014 16:12:39 +0000 (18:12 +0200)]
static global definition for track-header width

the track-header minimum width is defined by
the name-label (IFF the 2nd row fader is not visible,
but the fader is rather small by default and and grows)

track-header width in almost all cases is:
   name-label width
 + width of three button (1 char each)
 + max size of all meters (if visible)
 + width of MIDI scroomer (if visible)
 + 2px table cellspacing (per column)

9 years agoget rid of a compiler warning
Robin Gareus [Tue, 2 Sep 2014 14:17:42 +0000 (16:17 +0200)]
get rid of a compiler warning

9 years agodramatically speed up track-number show/hide toggle
Robin Gareus [Tue, 2 Sep 2014 14:17:20 +0000 (16:17 +0200)]
dramatically speed up track-number show/hide toggle

9 years agoadd a special bool option that prevents redrawing
Robin Gareus [Tue, 2 Sep 2014 14:16:36 +0000 (16:16 +0200)]
add a special bool option that prevents redrawing

9 years agodon't show 'unity-line' (default value) for barcontrollers
Robin Gareus [Tue, 2 Sep 2014 14:05:54 +0000 (16:05 +0200)]
don't show 'unity-line' (default value) for barcontrollers

9 years agoBarcontroller: no double expose when text chages
Robin Gareus [Tue, 2 Sep 2014 14:05:21 +0000 (16:05 +0200)]
Barcontroller: no double expose when text chages

9 years agotweak pixfader:
Robin Gareus [Tue, 2 Sep 2014 14:00:24 +0000 (16:00 +0200)]
tweak pixfader:

* update reserve so that round corners don't overlap
* draw complete 1px outline
* add API to hide/show the unity line
* don't show unity line at either end
* allow to shrink when the font-scaling changes

9 years agofix static initialization of Gtk::SizeGroup
Robin Gareus [Tue, 2 Sep 2014 03:08:13 +0000 (05:08 +0200)]
fix static initialization of Gtk::SizeGroup

9 years agoadd style for BarController SpinButton
Robin Gareus [Tue, 2 Sep 2014 03:07:41 +0000 (05:07 +0200)]
add style for BarController SpinButton

9 years agounify BarController with Slider/Pixfader.
Robin Gareus [Tue, 2 Sep 2014 03:09:51 +0000 (05:09 +0200)]
unify BarController with Slider/Pixfader.

9 years agoclean up pixfader API, prepare for merge w/BarController
Robin Gareus [Tue, 2 Sep 2014 02:46:34 +0000 (04:46 +0200)]
clean up pixfader API, prepare for merge w/BarController

9 years agoremove cruft from SliderController
Robin Gareus [Tue, 2 Sep 2014 03:14:06 +0000 (05:14 +0200)]
remove cruft from SliderController

9 years agoprepare Slider API cleanup
Robin Gareus [Tue, 2 Sep 2014 00:53:05 +0000 (02:53 +0200)]
prepare Slider API cleanup

9 years agoEngine Dialog: focus OK button (press enter to cont w/previous settings)
Robin Gareus [Mon, 1 Sep 2014 20:06:45 +0000 (22:06 +0200)]
Engine Dialog: focus OK button (press enter to cont w/previous settings)

9 years agorework pixfader:
Robin Gareus [Mon, 1 Sep 2014 20:02:51 +0000 (22:02 +0200)]
rework pixfader:

* re-introduce static pattern cache
  (cairo's cache is not nearly large enough for A3 + plugins)
* only use cairo_clip on rectangles (not arbitrary paths
  -> major performance boost
* re-add fader pixel reserve
* fix mouse + scroll interaction
* fix unity line display (1px wider, brighten by 150%)
* cache text size
* fix various other issues and consistent whitespace

This reverts large parts of commit d439e93b1e71e84452bf52ddc69ff0be6aa04ef5.

9 years agoMatch canvas outline to rectangle
Robin Gareus [Mon, 1 Sep 2014 16:05:09 +0000 (18:05 +0200)]
Match canvas outline to rectangle

It looks like we're currently [consistently] off by 1px
everywhere. The width-1 is compensated by
TimeAxisViewItem::RIGHT_EDGE_SHIFT = 1

9 years agoFix crash when changing automation mode for MIDI track control automation.
David Robillard [Sun, 31 Aug 2014 22:52:37 +0000 (18:52 -0400)]
Fix crash when changing automation mode for MIDI track control automation.

Also some work towards tolerating automation controls with no automation list,
towards actually doing something for these cases, though not required just to
fix this crash (MidiTrack::set_parameter_automation_state() avoids those
paths).

9 years agoretain track-header width regardless of number-label.
Robin Gareus [Sun, 31 Aug 2014 22:00:01 +0000 (00:00 +0200)]
retain track-header width regardless of number-label.

9 years agoBring back control slider on MIDI controller "tracks".
David Robillard [Sun, 31 Aug 2014 21:52:09 +0000 (17:52 -0400)]
Bring back control slider on MIDI controller "tracks".

9 years agoRemove unused variables (fix warnings).
David Robillard [Sun, 31 Aug 2014 21:45:20 +0000 (17:45 -0400)]
Remove unused variables (fix warnings).

9 years agoFix mismatched initialisation order.
David Robillard [Sun, 31 Aug 2014 21:44:42 +0000 (17:44 -0400)]
Fix mismatched initialisation order.

9 years agothe story of 0
Robin Gareus [Sun, 31 Aug 2014 21:38:25 +0000 (23:38 +0200)]
the story of 0

9 years agorework track inset (amend 7d7b787 and bf13bf63):
Robin Gareus [Sun, 31 Aug 2014 21:36:38 +0000 (23:36 +0200)]
rework track inset (amend 7d7b787 and bf13bf63):

Only inset red-selection rectangle (top & bottom).
Do not draw duplicate borders (waste pixels) for regular regions.

9 years agoupdate track-header width when removing track(s).
Robin Gareus [Sun, 31 Aug 2014 20:54:43 +0000 (22:54 +0200)]
update track-header width when removing track(s).

9 years agoinset regions into track (don't share edges)
Robin Gareus [Sun, 31 Aug 2014 20:24:44 +0000 (22:24 +0200)]
inset regions into track (don't share edges)

9 years agofix track-header hide/show
Robin Gareus [Sun, 31 Aug 2014 20:24:26 +0000 (22:24 +0200)]
fix track-header hide/show

9 years agotrack-header fader tweaks:
Robin Gareus [Sun, 31 Aug 2014 19:32:22 +0000 (21:32 +0200)]
track-header fader tweaks:

* align height to button-height.
* align width to label text-entry
* increase min width

9 years agoproper 1px track separator
Robin Gareus [Sun, 31 Aug 2014 18:08:38 +0000 (20:08 +0200)]
proper 1px track separator

9 years agoshadow-less Frame: explicitly draw background colored border.
Robin Gareus [Sun, 31 Aug 2014 18:07:17 +0000 (20:07 +0200)]
shadow-less Frame: explicitly draw background colored border.

9 years agothe return of the time_axis_vbox
Robin Gareus [Sun, 31 Aug 2014 17:43:32 +0000 (19:43 +0200)]
the return of the time_axis_vbox

9 years agoremove frame from barcontroller
Robin Gareus [Sun, 31 Aug 2014 17:36:41 +0000 (19:36 +0200)]
remove frame from barcontroller

9 years agoset initial TAV style
Robin Gareus [Sun, 31 Aug 2014 16:51:04 +0000 (18:51 +0200)]
set initial TAV style

9 years agoupdate track-header width when changing show-track-meters
Robin Gareus [Sun, 31 Aug 2014 14:46:11 +0000 (16:46 +0200)]
update track-header width when changing show-track-meters

9 years agomove midi scroomer to right of meter and fix alignment
Robin Gareus [Sun, 31 Aug 2014 14:15:52 +0000 (16:15 +0200)]
move midi scroomer to right of meter and fix alignment

9 years agoright side track-header control buttons (for non mixbus profile)
Robin Gareus [Sun, 31 Aug 2014 14:12:43 +0000 (16:12 +0200)]
right side track-header control buttons (for non mixbus profile)

9 years agoproper round corners on focused TextEntry
Robin Gareus [Sun, 31 Aug 2014 10:46:45 +0000 (12:46 +0200)]
proper round corners on focused TextEntry

IFF [xy]thickness is set > 2 for given Entry.

It seems gtk draws a base-color rectangle on
top, after clearlooks_draw_entry() is called.
This fills the complete area and voids previous
rounded rectangles in clearlooks_draw_entry().
setting [xy]thickness decreases the size of the
base rectangle.

9 years agoproper round corners for peak&gain display
Robin Gareus [Sun, 31 Aug 2014 10:08:39 +0000 (12:08 +0200)]
proper round corners for peak&gain display

9 years agoexperiment with track-selection box shadow
Robin Gareus [Sun, 31 Aug 2014 06:08:36 +0000 (08:08 +0200)]
experiment with track-selection box shadow

9 years agofix [potential] double clock connection:
Robin Gareus [Sun, 31 Aug 2014 05:54:59 +0000 (07:54 +0200)]
fix [potential] double clock connection:

ARDOUR_UI::set_session() starts clocking for a given session.
make sure ARDOUR_UI::parameter_changed() does not connect
before the session is active.

9 years agoprepare for clang static analysis of RT-functions:
Robin Gareus [Sun, 31 Aug 2014 05:50:17 +0000 (07:50 +0200)]
prepare for clang static analysis of RT-functions:

see: https://github.com/fundamental/stoat
eventually more functions should be annotated, and
a common header file should be used to
  #define REALTIME __attribute__((annotate("realtime")))

9 years agodistinguish global peak-reset button from meters:
Robin Gareus [Sun, 31 Aug 2014 05:43:21 +0000 (07:43 +0200)]
distinguish global peak-reset button from meters:

With > 2 channels, the editor toolbar meters are
otherwise very similar to the reset-button.

9 years agonew min. height for midi controls
Robin Gareus [Sun, 31 Aug 2014 05:12:41 +0000 (07:12 +0200)]
new min. height for midi controls

9 years agoupdate track-header width when track-number visibility is toggled
Robin Gareus [Sun, 31 Aug 2014 05:12:21 +0000 (07:12 +0200)]
update track-header width when track-number visibility is toggled

9 years agoremove (unused) separator, update TAV height calc.
Robin Gareus [Sun, 31 Aug 2014 05:12:00 +0000 (07:12 +0200)]
remove (unused) separator, update TAV height calc.

9 years agosimplify time-axis packing: consistent table layout
Robin Gareus [Sun, 31 Aug 2014 05:11:24 +0000 (07:11 +0200)]
simplify time-axis packing: consistent table layout

9 years agorevert parts of bf13bf63, change track-header color on selection
Robin Gareus [Sat, 30 Aug 2014 18:55:18 +0000 (20:55 +0200)]
revert parts of bf13bf63, change track-header color on selection

9 years agoNOOP, re-indent, fix whitespace
Robin Gareus [Sat, 30 Aug 2014 18:56:31 +0000 (20:56 +0200)]
NOOP, re-indent, fix whitespace

9 years agodisconnect pixfader style-change signal in dtor (amend 5a688b672)
Robin Gareus [Sat, 30 Aug 2014 18:58:03 +0000 (20:58 +0200)]
disconnect pixfader style-change signal in dtor (amend 5a688b672)

9 years agoupdate clocks and video-frames at FPS
Robin Gareus [Sat, 30 Aug 2014 18:48:37 +0000 (20:48 +0200)]
update clocks and video-frames at FPS

9 years agoadd an idle callback at FPS
Robin Gareus [Sat, 30 Aug 2014 18:57:22 +0000 (20:57 +0200)]
add an idle callback at FPS

9 years agoredraw clock(s) only when needed.
Robin Gareus [Sat, 30 Aug 2014 18:17:34 +0000 (20:17 +0200)]
redraw clock(s) only when needed.

9 years agovideo-pullup and timecode-format are session options
Robin Gareus [Sat, 30 Aug 2014 18:11:07 +0000 (20:11 +0200)]
video-pullup and timecode-format are session options

9 years agoupdate dropdown triangle
Robin Gareus [Sat, 30 Aug 2014 16:26:03 +0000 (18:26 +0200)]
update dropdown triangle

9 years agofader+meter: update numeric display bg on style change
Robin Gareus [Sat, 30 Aug 2014 02:17:10 +0000 (04:17 +0200)]
fader+meter: update numeric display bg on style change

9 years agopixfader: use parent's background color
Robin Gareus [Sat, 30 Aug 2014 02:16:18 +0000 (04:16 +0200)]
pixfader: use parent's background color

9 years agofix some compiler warnings
Robin Gareus [Sat, 30 Aug 2014 00:26:36 +0000 (02:26 +0200)]
fix some compiler warnings

9 years agofix cairo widget background
Robin Gareus [Fri, 29 Aug 2014 23:42:37 +0000 (01:42 +0200)]
fix cairo widget background

9 years agoremove cruft
Robin Gareus [Fri, 29 Aug 2014 23:40:16 +0000 (01:40 +0200)]
remove cruft

9 years agoArdourButton align text to full pixels
Robin Gareus [Fri, 29 Aug 2014 22:43:24 +0000 (00:43 +0200)]
ArdourButton align text to full pixels

9 years agored-border selection for tracks, regions, and processors. requesting comments
Ben Loftis [Fri, 29 Aug 2014 22:16:32 +0000 (17:16 -0500)]
red-border selection for tracks, regions, and processors. requesting comments

9 years agotry a different method of text display on automation bars
Ben Loftis [Thu, 28 Aug 2014 21:42:02 +0000 (16:42 -0500)]
try a different method of text display on automation bars

9 years agoArdour button, proper cairo fill+stroke px alignments
Robin Gareus [Fri, 29 Aug 2014 21:02:35 +0000 (23:02 +0200)]
Ardour button, proper cairo fill+stroke px alignments

rounded rectangles are cairo_arc() path,
for line strokes, offset by .5.

This patch also includes two small related style tweaks:
* Gtkmm2ext::Selected line color & thickness
* 'grabbed' line color & thickness

9 years agomark "Label Buttons" as inactive
Robin Gareus [Fri, 29 Aug 2014 19:10:20 +0000 (21:10 +0200)]
mark "Label Buttons" as inactive

9 years agoexplicit Button inactive state.
Robin Gareus [Fri, 29 Aug 2014 19:08:49 +0000 (21:08 +0200)]
explicit Button inactive state.

Ideally large parts of ArdourButton would become ArdourLabel,
which in turn is used by ArdourButton

9 years agoArdourButton: suppress visible response if no action is defined.
Robin Gareus [Fri, 29 Aug 2014 18:20:37 +0000 (20:20 +0200)]
ArdourButton: suppress visible response if no action is defined.

This fixes issues where the button is used as Label
(currently track-numbers and meterbridge track-name)

9 years agoamend 7be3c88a, update rec-en color
Robin Gareus [Fri, 29 Aug 2014 17:55:25 +0000 (19:55 +0200)]
amend 7be3c88a, update rec-en color

9 years agoexperiment with unicode circle for rec-en
Robin Gareus [Thu, 28 Aug 2014 23:13:49 +0000 (01:13 +0200)]
experiment with unicode circle for rec-en

fixes button-area width mismatch on track-headers
except for tape-tracks (which till use old fixed size icon)

9 years agouse 2 digit width as minium for track number labels
Robin Gareus [Thu, 28 Aug 2014 20:36:53 +0000 (22:36 +0200)]
use 2 digit width as minium for track number labels