ardour.git
4 years agoShow (# outs) in instrument-selector menu when the instrument is multi-out.
Ben Loftis [Sun, 13 Oct 2019 18:26:44 +0000 (13:26 -0500)]
Show (# outs) in instrument-selector menu when the instrument is multi-out.

4 years agoRemove unused API declaration (removed in 789f08891b)
Robin Gareus [Sun, 13 Oct 2019 02:12:02 +0000 (04:12 +0200)]
Remove unused API declaration (removed in 789f08891b)

4 years agoPrototype categorized preset browser
Robin Gareus [Sun, 13 Oct 2019 02:09:35 +0000 (04:09 +0200)]
Prototype categorized preset browser

4 years agoremove Session::AudioMidiSetupRequired signal (no longer necessary)
Paul Davis [Sat, 12 Oct 2019 18:45:27 +0000 (12:45 -0600)]
remove Session::AudioMidiSetupRequired signal (no longer necessary)

4 years agoremove Session::AudioMidiSetupRequired signal (no longer necessary)
Paul Davis [Sat, 12 Oct 2019 18:45:18 +0000 (12:45 -0600)]
remove Session::AudioMidiSetupRequired signal (no longer necessary)

4 years agoremove Session::AudioMidiSetupRequired signal (no longer necessary)
Paul Davis [Sat, 12 Oct 2019 18:45:13 +0000 (12:45 -0600)]
remove Session::AudioMidiSetupRequired signal (no longer necessary)

4 years agoreintroduce code that can automatically connect to JACK under the right conditions
Paul Davis [Sat, 12 Oct 2019 18:10:10 +0000 (12:10 -0600)]
reintroduce code that can automatically connect to JACK under the right conditions

4 years agointerface range generated by internal_to_interface() may not span 0..1, so remove...
Paul Davis [Fri, 11 Oct 2019 23:09:39 +0000 (17:09 -0600)]
interface range generated by internal_to_interface() may not span 0..1, so remove asserts

4 years agoadd missing case
Paul Davis [Fri, 11 Oct 2019 23:03:50 +0000 (17:03 -0600)]
add missing case

4 years agodo not accidentally re-create splash
Paul Davis [Fri, 11 Oct 2019 20:44:30 +0000 (14:44 -0600)]
do not accidentally re-create splash

4 years agoenforce singleton nature of Splash a little more rigorously, and slightly rationalize...
Paul Davis [Fri, 11 Oct 2019 20:29:55 +0000 (14:29 -0600)]
enforce singleton nature of Splash a little more rigorously, and slightly rationalize it's use

4 years agocall parent ::on_response()
Paul Davis [Fri, 11 Oct 2019 19:53:48 +0000 (13:53 -0600)]
call parent ::on_response()

4 years agoremove responsibility for starting AudioEngine from Session
Paul Davis [Fri, 11 Oct 2019 16:25:08 +0000 (10:25 -0600)]
remove responsibility for starting AudioEngine from Session

4 years agoTheme-ing: Use sensible names instead of color 1..N
Ben Loftis [Thu, 10 Oct 2019 23:24:57 +0000 (18:24 -0500)]
Theme-ing: Use sensible names instead of color 1..N

Colors are assigned one of 6 major groups:

*Alert colors: Typically mute/solo/feedback/selections etc ... these should follow Ardour convention, only the saturation should change with themes.

*BG colors (empty spaces...)

*Contrast colors: Should contrast nicely against BG. Typically clocks, markers, panners and such.

*Black/White/Grays:  you can expect these to work with "any" BG.  Good for borders, separators, etc.

*Meter colors:  Typically green->yellow->red or similar.  Should follow Ardour conventions.

*Widget colors:  slight variations of the BG color.  This is where the creative choices are made.

NOTE to theme-ers:  Widgets should choose one of the colors based on FUNCTION.  If you want a red widget, choose "widget red",  not "alert red" or "meter color9"

4 years agoAdd/rename source(s) in our MSVC project (gtk2_ardour)
John Emmas [Fri, 11 Oct 2019 10:19:24 +0000 (11:19 +0100)]
Add/rename source(s) in our MSVC project (gtk2_ardour)

4 years agogoto preferred over reentrancy
Paul Davis [Fri, 11 Oct 2019 03:47:17 +0000 (21:47 -0600)]
goto preferred over reentrancy

4 years agofix error in startup sequence when command line argument is given and pre-release...
Paul Davis [Fri, 11 Oct 2019 03:37:50 +0000 (21:37 -0600)]
fix error in startup sequence when command line argument is given and pre-release dialog is shown

4 years agomove pre-release dialog into StartupFSM (and enlarge font sizing)
Paul Davis [Fri, 11 Oct 2019 03:24:52 +0000 (21:24 -0600)]
move pre-release dialog into StartupFSM (and enlarge font sizing)

4 years agocenter all(?) early-startup dialogs
Paul Davis [Fri, 11 Oct 2019 01:54:33 +0000 (19:54 -0600)]
center all(?) early-startup dialogs

4 years agofix up handling of audio/MIDI setup dialog and remove debug output
Paul Davis [Thu, 10 Oct 2019 22:51:51 +0000 (16:51 -0600)]
fix up handling of audio/MIDI setup dialog and remove debug output

4 years agomake error message very slightly more indicative of what might be happening when...
Paul Davis [Thu, 10 Oct 2019 22:51:28 +0000 (16:51 -0600)]
make error message very slightly more indicative of what might be happening when audioengine backend fails to start

4 years agomake EngineDialog behavior more appropriate for use in both startup and non-startup...
Paul Davis [Thu, 10 Oct 2019 22:50:57 +0000 (16:50 -0600)]
make EngineDialog behavior more appropriate for use in both startup and non-startup conditions

4 years agochanges to get startupFSM working (more) correctly
Paul Davis [Thu, 10 Oct 2019 21:25:30 +0000 (15:25 -0600)]
changes to get startupFSM working (more) correctly

4 years agoremove unused label and simplify return value/return path
Paul Davis [Thu, 10 Oct 2019 21:25:13 +0000 (15:25 -0600)]
remove unused label and simplify return value/return path

4 years agoNOOP: move brace
Paul Davis [Thu, 10 Oct 2019 21:24:49 +0000 (15:24 -0600)]
NOOP: move brace

4 years agomake ARDOUR_UI::load_session_from_startup_fsm() return a value, and use it
Paul Davis [Thu, 10 Oct 2019 21:24:20 +0000 (15:24 -0600)]
make ARDOUR_UI::load_session_from_startup_fsm() return a value, and use it

4 years agofix decl of method with const arg
Paul Davis [Thu, 10 Oct 2019 21:23:23 +0000 (15:23 -0600)]
fix decl of method with const arg

4 years agoadd StartupFSM::end() (empty for now) and remove unused states
Paul Davis [Thu, 10 Oct 2019 21:22:44 +0000 (15:22 -0600)]
add StartupFSM::end() (empty for now) and remove unused states

4 years agouse const argument when calling ::build_session()
Paul Davis [Thu, 10 Oct 2019 21:21:20 +0000 (15:21 -0600)]
use const argument when calling ::build_session()

4 years agoremove unused assignment
Paul Davis [Thu, 10 Oct 2019 20:35:03 +0000 (14:35 -0600)]
remove unused assignment

4 years agoremove two unused variables
Paul Davis [Thu, 10 Oct 2019 20:34:46 +0000 (14:34 -0600)]
remove two unused variables

4 years agomake BusProfile argument to new Session constructor be const (and in associated call...
Paul Davis [Thu, 10 Oct 2019 20:34:20 +0000 (14:34 -0600)]
make BusProfile argument to new Session constructor be const (and in associated call tree)

4 years agoNSM startup needs to call a different method due to API changes
Paul Davis [Thu, 10 Oct 2019 02:53:03 +0000 (20:53 -0600)]
NSM startup needs to call a different method due to API changes

4 years agomove copying demo sessions into NewUserWizard
Paul Davis [Thu, 10 Oct 2019 02:52:46 +0000 (20:52 -0600)]
move copying demo sessions into NewUserWizard

4 years agochanges to ARDOUR_UI to reflect new startupFSM and non-modal SessionDialog handling
Paul Davis [Thu, 10 Oct 2019 02:52:26 +0000 (20:52 -0600)]
changes to ARDOUR_UI to reflect new startupFSM and non-modal SessionDialog handling

4 years agomodify API of SessionDialog to reflect that it is never used with command line parame...
Paul Davis [Thu, 10 Oct 2019 02:51:14 +0000 (20:51 -0600)]
modify API of SessionDialog to reflect that it is never used with command line parameters anymore

4 years agoadd initial version of StartupFSM along with its owners/users
Paul Davis [Thu, 10 Oct 2019 02:50:34 +0000 (20:50 -0600)]
add initial version of StartupFSM along with its owners/users

4 years agoremove unnecessary template methods (replicated in libs/gtkmm2ext/doi.h
Paul Davis [Thu, 10 Oct 2019 02:32:46 +0000 (20:32 -0600)]
remove unnecessary template methods (replicated in libs/gtkmm2ext/doi.h

4 years agoadd SessionDialog::clear_name()
Paul Davis [Wed, 9 Oct 2019 03:48:11 +0000 (21:48 -0600)]
add SessionDialog::clear_name()

4 years agochange SessionDialog::meta_master_bus_profile() to be a static method
Paul Davis [Wed, 9 Oct 2019 03:40:14 +0000 (21:40 -0600)]
change SessionDialog::meta_master_bus_profile() to be a static method

4 years agoengine dialog should emit response and handle it, not just call its own response...
Paul Davis [Wed, 9 Oct 2019 03:30:00 +0000 (21:30 -0600)]
engine dialog should emit response and handle it, not just call its own response dialog

4 years agorename ArdourStartup to NewUserWizard and rename source file(s)
Paul Davis [Wed, 9 Oct 2019 03:29:47 +0000 (21:29 -0600)]
rename ArdourStartup to NewUserWizard and rename source file(s)

4 years agoprovide ArdourStartup with a Gtk::Dialog-like signal_response()
Paul Davis [Tue, 8 Oct 2019 17:39:16 +0000 (11:39 -0600)]
provide ArdourStartup with a Gtk::Dialog-like signal_response()

It is not a Dialog (instead, an Assistant which IS-A Window), but
we want to be able to interact with it as if it is.

Also remove unused singleton and session info cruft

4 years agoShow preset-browser button if annoted presets are available
Robin Gareus [Thu, 10 Oct 2019 22:13:07 +0000 (00:13 +0200)]
Show preset-browser button if annoted presets are available

4 years agoAdd a plugin-preset browser window
Robin Gareus [Thu, 10 Oct 2019 22:03:41 +0000 (00:03 +0200)]
Add a plugin-preset browser window

Previously preset-browser was only used instead of "generic control"
display if a plugin does not have any controls (but presets).

This allows for showing a dedicated window..

4 years agoPreset-Browser: highlight only unmodified presets
Robin Gareus [Thu, 10 Oct 2019 21:59:55 +0000 (23:59 +0200)]
Preset-Browser: highlight only unmodified presets

4 years agoNO-OP: whitespace
Robin Gareus [Thu, 10 Oct 2019 21:59:05 +0000 (23:59 +0200)]
NO-OP: whitespace

4 years agoAdd "List/Browse" vector icon
Robin Gareus [Thu, 10 Oct 2019 21:58:49 +0000 (23:58 +0200)]
Add "List/Browse" vector icon

4 years agoAdd API to check for plugin-presets with description
Robin Gareus [Thu, 10 Oct 2019 20:31:19 +0000 (22:31 +0200)]
Add API to check for plugin-presets with description

4 years agoadd constructor
Paul Davis [Tue, 8 Oct 2019 02:49:53 +0000 (20:49 -0600)]
add constructor

4 years agofix compiler warning about possible buffer size issue
Paul Davis [Tue, 8 Oct 2019 02:49:35 +0000 (20:49 -0600)]
fix compiler warning about possible buffer size issue

4 years agoStem-export: pre-select selected tracks/busses
Robin Gareus [Mon, 7 Oct 2019 13:19:36 +0000 (15:19 +0200)]
Stem-export: pre-select selected tracks/busses

4 years agoFix a translation issue (default value session-archive dropdown)
Robin Gareus [Mon, 7 Oct 2019 03:11:58 +0000 (05:11 +0200)]
Fix a translation issue (default value session-archive dropdown)

4 years agoSpecial case horizontal faders (pan to right)
Robin Gareus [Mon, 7 Oct 2019 03:11:33 +0000 (05:11 +0200)]
Special case horizontal faders (pan to right)

4 years agoInvert Pan-Azimuth (up means left)
Robin Gareus [Mon, 7 Oct 2019 03:07:55 +0000 (05:07 +0200)]
Invert Pan-Azimuth (up means left)

It's a well established convention that pan y-axis automation,
or vertical uses (top) +1 for left.

This special cases rotary knobs (and horizontal sliders) to retain
a clockwise movement (or movement to the right) for panning to the
right.

4 years agoConfigure UI scale as first start step
Robin Gareus [Sun, 6 Oct 2019 18:56:34 +0000 (20:56 +0200)]
Configure UI scale as first start step

This also includes some simple heuristic to guess initial scaling
depending on the largest screen's geometry.

4 years agoCleanup unused includes
Robin Gareus [Sun, 6 Oct 2019 16:39:53 +0000 (18:39 +0200)]
Cleanup unused includes

4 years agofactor out NSM startup code
Paul Davis [Thu, 3 Oct 2019 23:23:57 +0000 (17:23 -0600)]
factor out NSM startup code

4 years agochanges required to get build-stack to run on a Mojave VM.
Paul Davis [Thu, 3 Oct 2019 00:00:59 +0000 (18:00 -0600)]
changes required to get build-stack to run on a Mojave VM.

4 years agoremove all use of NO_PLUGIN_STATE #ifdef
Paul Davis [Sun, 29 Sep 2019 16:00:23 +0000 (10:00 -0600)]
remove all use of NO_PLUGIN_STATE #ifdef

We determined several years that we should never ever do this,
and changed the basis for the free/demo copy because of that.

4 years agoPrefer portable (MSVC?) getenv (amend 5ea54be)
Robin Gareus [Wed, 2 Oct 2019 21:14:58 +0000 (23:14 +0200)]
Prefer portable (MSVC?) getenv (amend 5ea54be)

4 years agoAllow ARDOUR_AVG_DSP_LOAD for non-debug builds
Robin Gareus [Wed, 2 Oct 2019 20:55:55 +0000 (22:55 +0200)]
Allow ARDOUR_AVG_DSP_LOAD for non-debug builds

4 years agoAmend 903c3ec5a API rename
Robin Gareus [Wed, 2 Oct 2019 19:28:13 +0000 (21:28 +0200)]
Amend 903c3ec5a API rename

4 years agoPlugin type lookup does not change PI
Robin Gareus [Wed, 2 Oct 2019 17:35:03 +0000 (19:35 +0200)]
Plugin type lookup does not change PI

4 years agoRemove unused API (and some MIXBUS specifics)
Robin Gareus [Wed, 2 Oct 2019 17:29:52 +0000 (19:29 +0200)]
Remove unused API (and some MIXBUS specifics)

4 years agoOptimize default case: no delay
Robin Gareus [Tue, 1 Oct 2019 23:54:08 +0000 (01:54 +0200)]
Optimize default case: no delay

4 years agoFix thinko in cd5f70e69a (delayline buffer resize)
Robin Gareus [Tue, 1 Oct 2019 11:42:34 +0000 (13:42 +0200)]
Fix thinko in cd5f70e69a (delayline buffer resize)

The delay-time itself can change arbitrarily, but the buffer-size
never shrinks.

If the buffersize grows it means that the new delay is longer than
the current one (or at least as large as any pending, not yet
active delay).

This is important for the mechanism that adjusts the read-pointer
to the new buffer-size.

4 years agoUpdate Fluidsynth to v2.0.7
Robin Gareus [Mon, 30 Sep 2019 21:10:33 +0000 (23:10 +0200)]
Update Fluidsynth to v2.0.7

4 years agoadded an Ardour-focused smartphone layout for Touch OSC
Sunil Chopra [Mon, 3 Jun 2019 02:15:05 +0000 (21:15 -0500)]
added an Ardour-focused smartphone layout for Touch OSC

4 years agoFix remaining doxygen warnings (!)
Robin Gareus [Mon, 30 Sep 2019 19:00:29 +0000 (21:00 +0200)]
Fix remaining doxygen warnings (!)

4 years agoAdd LTC frame doc image
Robin Gareus [Mon, 30 Sep 2019 19:02:49 +0000 (21:02 +0200)]
Add LTC frame doc image

4 years agoNO-OP: whitespace, indent
Robin Gareus [Mon, 30 Sep 2019 17:06:00 +0000 (19:06 +0200)]
NO-OP: whitespace, indent

4 years agoNo more doxygen warnings for gtk2_arodur/*
Robin Gareus [Mon, 30 Sep 2019 16:20:15 +0000 (18:20 +0200)]
No more doxygen warnings for gtk2_arodur/*

That's with doxgen 1.8.13.

4 years agoFix use of doxygen documented parameters in running text
Robin Gareus [Mon, 30 Sep 2019 04:27:24 +0000 (06:27 +0200)]
Fix use of doxygen documented parameters in running text

4 years agoFix some UI doxygen warnings
Robin Gareus [Mon, 30 Sep 2019 03:34:06 +0000 (05:34 +0200)]
Fix some UI doxygen warnings

4 years agoFix some more doxygen warnings
Robin Gareus [Mon, 30 Sep 2019 03:33:44 +0000 (05:33 +0200)]
Fix some more doxygen warnings

4 years agoNO-OP: whitespace (use tab to indent)
Robin Gareus [Mon, 30 Sep 2019 02:52:20 +0000 (04:52 +0200)]
NO-OP: whitespace (use tab to indent)

4 years agoFix a few hundred doxygen warnings..
Robin Gareus [Mon, 30 Sep 2019 02:45:59 +0000 (04:45 +0200)]
Fix a few hundred doxygen warnings..

There are still over a hundred left, but this addresses many already.
In particular @param references to undocumented parameters.
Most notably in audio_backend.h

4 years agoUpdate Doxygen config:
Robin Gareus [Mon, 30 Sep 2019 02:39:37 +0000 (04:39 +0200)]
Update Doxygen config:

* process only header files (API is supposed to be documented there)
  (this resolves various inheritance and ambiguities, as well)
* Set pre-processor defines as a normal Ardour compile would
* Expand Macros (fixes issues with visibility defines)

4 years agoFix a duplicate layout parent issue
Robin Gareus [Sun, 29 Sep 2019 20:42:02 +0000 (22:42 +0200)]
Fix a duplicate layout parent issue

4 years agoNO-OP: whitespace
Robin Gareus [Sun, 29 Sep 2019 19:22:30 +0000 (21:22 +0200)]
NO-OP: whitespace

4 years agoFix External Send GUI
Robin Gareus [Sun, 29 Sep 2019 19:03:27 +0000 (21:03 +0200)]
Fix External Send GUI

panners.set_panner() was inadvertently removed in 31815b5f2

4 years agoFix gtk-table-packing error (redundant packing)
Ben Loftis [Sun, 29 Sep 2019 16:30:18 +0000 (11:30 -0500)]
Fix gtk-table-packing error (redundant packing)

4 years agoArdour::IO is not latent by itself
Robin Gareus [Sun, 29 Sep 2019 16:24:54 +0000 (18:24 +0200)]
Ardour::IO is not latent by itself

4 years agoRemove unused modal LatencyGUI Dialog
Robin Gareus [Sun, 29 Sep 2019 16:23:18 +0000 (18:23 +0200)]
Remove unused modal LatencyGUI Dialog

4 years agoRemove defunct Route "Adjust Latency" GUI
Robin Gareus [Sun, 29 Sep 2019 16:22:55 +0000 (18:22 +0200)]
Remove defunct Route "Adjust Latency" GUI

This was based on Ardour-5 style "set custom latency of the IO", and
inform, override JACK-port latency compensation.

Ardour6: IO itself is no longer in control. This is abstracted by
IOProcessor.

In any case, this is to be superseded by bundling a-virtual-latency,
and allowing track playback offset (that has no additional
thru-latency for cue-monitoring).

4 years agoFix port-insert default latency
Robin Gareus [Sun, 29 Sep 2019 16:16:01 +0000 (18:16 +0200)]
Fix port-insert default latency

4 years agoShow pre-release dialog also for source-tree self-builds
Robin Gareus [Sun, 29 Sep 2019 16:10:39 +0000 (18:10 +0200)]
Show pre-release dialog also for source-tree self-builds

4 years agoNew region opacity rules. (final part of 973e9a)
Ben Loftis [Sun, 29 Sep 2019 15:58:53 +0000 (10:58 -0500)]
New region opacity rules.  (final part of 973e9a)

4 years agoAllow the Cut tool to appear in Mixbus.
Ben Loftis [Sun, 29 Sep 2019 15:11:43 +0000 (10:11 -0500)]
Allow the Cut tool to appear in Mixbus.

4 years agoAmend 4f41367836: fix show/hide latency label
Robin Gareus [Sun, 29 Sep 2019 14:59:18 +0000 (16:59 +0200)]
Amend 4f41367836: fix show/hide latency label

4 years agoFix issues when delay-buffers are re-allocated
Robin Gareus [Sun, 29 Sep 2019 14:10:51 +0000 (16:10 +0200)]
Fix issues when delay-buffers are re-allocated

Previously buffers were dropped, and data was not copied to
newly allocated buffers. As side-effect the read-offset was not
adjusted either.

The distance between read and write-pointer needs to be maintained
(delay does not change). This needs to be accounted for, when the
buffer increases while read->write wraps around the old (smaller)
buffer. Previously this triggered an assert (in line 180)

4 years agoFix Region-list column layout.
Ben Loftis [Sun, 29 Sep 2019 14:14:09 +0000 (09:14 -0500)]
Fix Region-list column layout.

4 years agoTheme latency-disable-button
Robin Gareus [Sat, 28 Sep 2019 23:57:15 +0000 (01:57 +0200)]
Theme latency-disable-button

4 years agoAdd Latency Control Toolbar Widgets
Robin Gareus [Sat, 28 Sep 2019 23:23:48 +0000 (01:23 +0200)]
Add Latency Control Toolbar Widgets

4 years agoUse samples_as_time_string API
Robin Gareus [Sun, 29 Sep 2019 00:43:06 +0000 (02:43 +0200)]
Use samples_as_time_string API

4 years agoHelper function to format sample-count as duration
Robin Gareus [Sat, 28 Sep 2019 23:24:23 +0000 (01:24 +0200)]
Helper function to format sample-count as duration

4 years agoEmit signal when session latency was updated
Robin Gareus [Sat, 28 Sep 2019 20:29:50 +0000 (22:29 +0200)]
Emit signal when session latency was updated

4 years agoAdd Lua bindings related to latency compensation
Robin Gareus [Sat, 28 Sep 2019 19:02:45 +0000 (21:02 +0200)]
Add Lua bindings related to latency compensation

4 years agoAdd Signal to indicate global delay compensation status
Robin Gareus [Sat, 28 Sep 2019 18:53:50 +0000 (20:53 +0200)]
Add Signal to indicate global delay compensation status