ardour.git
8 years agoFix snap modifier logic (again).
nick_m [Tue, 13 Oct 2015 17:09:23 +0000 (04:09 +1100)]
Fix snap modifier logic (again).

8 years agoRc option editor - alter restart message for user interaction tab.
nick_m [Wed, 7 Oct 2015 18:59:09 +0000 (05:59 +1100)]
Rc option editor - alter restart message for user interaction tab.

8 years agoNo-op - rename variable.
nick_m [Wed, 7 Oct 2015 18:41:41 +0000 (05:41 +1100)]
No-op - rename variable.

8 years agoAdd tooltips to user config preferences. clean up combo ordering.
nick_m [Wed, 7 Oct 2015 18:32:31 +0000 (05:32 +1100)]
Add tooltips to user config preferences. clean up combo ordering.

8 years agoArdourKeyboard - fix snap / delta logic for triple modifier combinations.
nick_m [Wed, 7 Oct 2015 14:46:52 +0000 (01:46 +1100)]
ArdourKeyboard - fix snap / delta logic for triple modifier combinations.

8 years agoClick on a selected note unique selects it (as per regions, control points).
nick_m [Wed, 7 Oct 2015 13:48:03 +0000 (00:48 +1100)]
Click on a selected note unique selects it (as per regions, control points).

8 years agoAllow Alt-Shift-Windows modifier (nice for control point fine adjust).
nick_m [Sun, 4 Oct 2015 17:36:13 +0000 (04:36 +1100)]
Allow Alt-Shift-Windows modifier (nice for control point fine adjust).

- OSX equivalent to be decided.

8 years agoDon't snap if fine adjust modifier used.
nick_m [Sun, 4 Oct 2015 17:32:03 +0000 (04:32 +1100)]
Don't snap if fine adjust modifier used.

- permits non-alt modifier for fine adjust.

8 years agoUpdate ContrilList debug output.
nick_m [Sun, 4 Oct 2015 15:58:03 +0000 (02:58 +1100)]
Update ContrilList debug output.

8 years agoSelect the control point about to be deleted when using shift + right click.
nick_m [Sun, 4 Oct 2015 15:56:56 +0000 (02:56 +1100)]
Select the control point about to be deleted when using shift + right click.

- fixes incorrect selection changes when doing this.

8 years agoFix incorrect snap when adding region gain points.
nick_m [Sun, 4 Oct 2015 15:54:18 +0000 (02:54 +1100)]
Fix incorrect snap when adding region gain points.

8 years agoDon't use the all_route_group() in Editor::set_selected_track_as_side_effect ().
nick_m [Sun, 4 Oct 2015 13:42:09 +0000 (00:42 +1100)]
Don't use the all_route_group() in Editor::set_selected_track_as_side_effect ().

- we don't appear to actually use it.

8 years agoAllow adding / toggling rubber band selection of automation control points.
nick_m [Sun, 4 Oct 2015 13:39:24 +0000 (00:39 +1100)]
Allow adding / toggling rubber band selection of automation control points.

8 years agoShow verbose cursor control point values in MouseContent mode as well.
nick_m [Sat, 3 Oct 2015 18:29:45 +0000 (05:29 +1100)]
Show verbose cursor control point values in MouseContent mode as well.

8 years agoFix for fine adjust overriding snap modifiers.
nick_m [Sat, 3 Oct 2015 18:05:56 +0000 (05:05 +1100)]
Fix for fine adjust overriding snap modifiers.

8 years agoAdd error check to region gain control point selection undo.
nick_m [Sat, 3 Oct 2015 16:44:27 +0000 (03:44 +1100)]
Add error check to region gain control point selection undo.

8 years agoAdd missing diff to last commit.
nick_m [Sat, 3 Oct 2015 16:33:37 +0000 (03:33 +1100)]
Add missing diff to last commit.

8 years agoRegion gain point selection behaves as per track automation.
nick_m [Sat, 3 Oct 2015 16:29:16 +0000 (03:29 +1100)]
Region gain point selection behaves as per track automation.

8 years agoAdd region gain point selection undo.
nick_m [Sat, 3 Oct 2015 15:19:38 +0000 (01:19 +1000)]
Add region gain point selection undo.

8 years agoAmend last connit - don't use a bool to represent a double.
nick_m [Sat, 3 Oct 2015 13:55:26 +0000 (23:55 +1000)]
Amend last connit - don't use a bool to represent a double.

8 years agoFix incorrect initial point when recording toggled automation.
nick_m [Sat, 3 Oct 2015 13:47:52 +0000 (23:47 +1000)]
Fix incorrect initial point when recording toggled automation.

8 years agoAutomation - more toggled controller twiddling.
nick_m [Fri, 2 Oct 2015 19:08:26 +0000 (05:08 +1000)]
Automation - more toggled controller twiddling.

8 years agoAutomation - fix occasional inverted bool state after write.
nick_m [Fri, 2 Oct 2015 15:18:59 +0000 (01:18 +1000)]
Automation - fix occasional inverted bool state after write.

8 years agoFix redo action sensitivity for non-editor undo stack changes.
nick_m [Sat, 26 Sep 2015 14:59:44 +0000 (00:59 +1000)]
Fix redo action sensitivity for non-editor undo stack changes.

8 years agoMake automation record undo per pass rather than per touch.
nick_m [Sat, 26 Sep 2015 14:57:52 +0000 (00:57 +1000)]
Make automation record undo per pass rather than per touch.

8 years agoToggled automation fixes.
nick_m [Mon, 21 Sep 2015 17:20:39 +0000 (03:20 +1000)]
Toggled automation fixes.

- don't attempt to insert two points on toggle.
- remove forced touch->write mode change on toggle
- initial state still wrong, but works much better overall.

8 years agoAmend last commit.
nick_m [Sun, 13 Sep 2015 19:46:02 +0000 (05:46 +1000)]
Amend last commit.

8 years agoMake control point selection more consistent.
nick_m [Sun, 13 Sep 2015 19:24:28 +0000 (05:24 +1000)]
Make control point selection more consistent.

- disallow simultaneous events via ControlList::editor_add ()
- clicking on an automation line selects the points that define it.
- don't 'flash' a region selection when using mousedraw mode.
- cp click selection resembles region selection.
- region gain points respect snap modifier (a la automation points).

8 years agoremove cruft
Robin Gareus [Mon, 19 Oct 2015 13:44:46 +0000 (15:44 +0200)]
remove cruft

8 years agoAdd Audio Tracks and Busses too.
Len Ovens [Mon, 19 Oct 2015 02:55:56 +0000 (19:55 -0700)]
Add Audio Tracks and Busses too.

8 years agoAdded Midi Tracks View mode.
Len Ovens [Mon, 19 Oct 2015 01:13:16 +0000 (18:13 -0700)]
Added Midi Tracks View mode.

8 years agoone less deprecated API
Robin Gareus [Sun, 18 Oct 2015 21:29:58 +0000 (23:29 +0200)]
one less deprecated API

8 years agofix OS X system detection (amend 66704ee)
Robin Gareus [Sun, 18 Oct 2015 21:19:52 +0000 (23:19 +0200)]
fix OS X system detection (amend 66704ee)

8 years agoGUI changes use new AppleUtility Library
Robin Gareus [Sun, 18 Oct 2015 20:17:31 +0000 (22:17 +0200)]
GUI changes use new AppleUtility Library

8 years agolibs/* changes use new AppleUtility Library
Paul Davis [Sun, 18 Oct 2015 01:37:33 +0000 (21:37 -0400)]
libs/* changes use new AppleUtility Library

8 years agoalternative new version of the AppleUtility library
Paul Davis [Sun, 18 Oct 2015 00:46:58 +0000 (20:46 -0400)]
alternative new version of the AppleUtility library

8 years agoOnly display Trim for tracks that have Trim. On the way:
Len Ovens [Sun, 18 Oct 2015 14:38:40 +0000 (07:38 -0700)]
Only display Trim for tracks that have Trim. On the way:
-fixed flip mode.
-fixed no controlable for vpot or fader

8 years agoamend prev commit.
Robin Gareus [Sun, 18 Oct 2015 12:31:04 +0000 (14:31 +0200)]
amend prev commit.

8 years agofix additive linkflags
Robin Gareus [Sun, 18 Oct 2015 12:22:55 +0000 (14:22 +0200)]
fix additive linkflags

8 years agoReplace static PBD::Signal in NoteBase with direct call to MidiRegionView
Tim Mayberry [Wed, 14 Oct 2015 10:37:07 +0000 (20:37 +1000)]
Replace static PBD::Signal in NoteBase with direct call to MidiRegionView

NoteBaseDeleted signal is static so each MidiRegionView(MRV) gets notified
about the deletion of each NodeBase instance even if it is contained in another
MRV

The NoteBase and MRV classes are currently coupled anyway, so this change uses
the reference to the MRV parent to directly call the parent when the NoteBase
is deleted. This is all in the GUI thread so I'm not sure why a PBD::Signal was
being used?

If the MRV class is the only reference holder to the NoteBase class
then I'm not sure if a callback is needed, perhaps the MRV should just remove
the note from the selection before deleting it but I'm not that familiar with
the code.

Signal emission/calls static NoteBaseDeleted signal vs direct with 10540
NoteBase instances.

static:

After Load Session: 6360638
After Unload Session: 12221026(5860388)

direct:

After load Session: 10540
After unload Session: 21080

Session Load/Unload time in master, debug/release with ~10000 Notes(seconds)

Load Debug: 32, 26
Unload Debug: 83
Load Release 32, 20, 42
Unload Release 26, 25

Session Load/Unload time with direct call debug/release(seconds)

Load Debug: 21.7, 18.1
Unload Debug: 69.4, 71
Load Release: 22.6, 13.4, 17.7
Unload Release: 24, 23.5

This is not a large Session, 1500 regions, 10000 notes so there is probably
some other funky stuff going on that needs fixing.

8 years agoMerge branch 'chaot4-fix_midi_menu_consistency_new'
Paul Davis [Sun, 18 Oct 2015 02:13:04 +0000 (22:13 -0400)]
Merge branch 'chaot4-fix_midi_menu_consistency_new'

8 years agoRemove all the now unused functions in the MidiModel class.
André Nusser [Thu, 15 Oct 2015 13:49:41 +0000 (15:49 +0200)]
Remove all the now unused functions in the MidiModel class.

8 years agoIntroduce "Transpose..." also in the context menu of selected notes.
André Nusser [Thu, 15 Oct 2015 13:44:09 +0000 (15:44 +0200)]
Introduce "Transpose..." also in the context menu of selected notes.

8 years agoAdd Transpose class that can be used by apply_midi_note_edit_op.
André Nusser [Thu, 15 Oct 2015 13:41:11 +0000 (15:41 +0200)]
Add Transpose class that can be used by apply_midi_note_edit_op.

8 years agoSplit transpose in MidiModel into two functions.
André Nusser [Thu, 15 Oct 2015 13:36:17 +0000 (15:36 +0200)]
Split transpose in MidiModel into two functions.

8 years agoFix tiny memory leak.
André Nusser [Thu, 15 Oct 2015 13:24:46 +0000 (15:24 +0200)]
Fix tiny memory leak.

8 years agoInclude "Transform..." into MIDI region menu.
André Nusser [Mon, 12 Oct 2015 16:04:52 +0000 (18:04 +0200)]
Include "Transform..." into MIDI region menu.

Everything has already been done except the including.

8 years agofftw-3.3.5/windows .dll includes threads lib
Robin Gareus [Sun, 18 Oct 2015 00:44:26 +0000 (02:44 +0200)]
fftw-3.3.5/windows .dll includes threads lib

8 years agodisable follow-edits with external sync #6577
Robin Gareus [Sun, 18 Oct 2015 00:01:45 +0000 (02:01 +0200)]
disable follow-edits with external sync #6577

8 years agodisable auto-return with external sync #6577
Robin Gareus [Sat, 17 Oct 2015 23:59:01 +0000 (01:59 +0200)]
disable auto-return with external sync #6577

8 years agoAssign Global view to get back to Mixer.
Len Ovens [Sat, 17 Oct 2015 23:23:46 +0000 (16:23 -0700)]
Assign Global view to get back to Mixer.

8 years agoand another "f"
Robin Gareus [Sat, 17 Oct 2015 18:51:21 +0000 (20:51 +0200)]
and another "f"

8 years agofour f* f's.
Robin Gareus [Sat, 17 Oct 2015 18:30:24 +0000 (20:30 +0200)]
four f* f's.

8 years agothread-safe fftw (needs fftw-3.3.5)
Robin Gareus [Sat, 17 Oct 2015 17:23:39 +0000 (19:23 +0200)]
thread-safe fftw (needs fftw-3.3.5)

see https://github.com/FFTW/fftw3/issues/16

8 years agolinux wrapper script: load session with spaces - #6395
Robin Gareus [Sat, 17 Oct 2015 00:01:02 +0000 (02:01 +0200)]
linux wrapper script: load session with spaces - #6395

8 years agofix #6640 (snapshot clears "dirty" flag)
Robin Gareus [Fri, 16 Oct 2015 19:10:21 +0000 (21:10 +0200)]
fix #6640 (snapshot clears "dirty" flag)

empty name indicates current-session name.

8 years agoextend session-save dirty-flag logic
Robin Gareus [Fri, 16 Oct 2015 18:54:15 +0000 (20:54 +0200)]
extend session-save dirty-flag logic

Snapshot and continue working on current session incorrectly marks
the session as clean.

8 years agouse API to add system-specific volumes - #6643
Robin Gareus [Fri, 16 Oct 2015 17:07:25 +0000 (19:07 +0200)]
use API to add system-specific volumes - #6643

8 years agoAPI to add system-specific file chooser shortcuts
Robin Gareus [Fri, 16 Oct 2015 17:06:21 +0000 (19:06 +0200)]
API to add system-specific file chooser shortcuts

8 years agodon't deploy gcc-abi test tool
Robin Gareus [Fri, 16 Oct 2015 14:26:43 +0000 (16:26 +0200)]
don't deploy gcc-abi test tool

8 years agostrip silence: report analysis progress
Robin Gareus [Fri, 16 Oct 2015 12:53:21 +0000 (14:53 +0200)]
strip silence: report analysis progress

8 years agostrip silence: wait for analysis to complete
Robin Gareus [Thu, 15 Oct 2015 22:13:02 +0000 (00:13 +0200)]
strip silence: wait for analysis to complete

"apply"ing strip-silence while analysis is still running will at best
only process regions that have already been analyzed and at worst crash.

8 years agore-enable engine sensitive actions..
Robin Gareus [Thu, 15 Oct 2015 19:50:01 +0000 (21:50 +0200)]
re-enable engine sensitive actions..

..after an engine stop/start cycle.
e.g "New Insert", "New External Send"

8 years agofix crash when creating subgroup-bus - fixes #6642
Robin Gareus [Thu, 15 Oct 2015 15:39:24 +0000 (17:39 +0200)]
fix crash when creating subgroup-bus - fixes #6642

the actual issues is in the connection management:
bundle.cc:323: void ARDOUR::Bundle::connect(): Assertion `N == other->nchannels().n_total()' failed.

That could be resolved. However, combining tracks without panners will
almost never do what the user really wants, so this case has been
disabled for now.

8 years agoadd safety checking when setting up DEBUG bits 4.4
Paul Davis [Thu, 15 Oct 2015 12:59:11 +0000 (08:59 -0400)]
add safety checking when setting up DEBUG bits

8 years agofix deadlock when removing subgroup bus w/sends.
Robin Gareus [Thu, 15 Oct 2015 11:49:35 +0000 (13:49 +0200)]
fix deadlock when removing subgroup bus w/sends.

...and potentially other route removals that involve
processor changes.

8 years agorework 8b80fe0, use std::string, not char*
Robin Gareus [Thu, 15 Oct 2015 09:24:15 +0000 (11:24 +0200)]
rework 8b80fe0, use std::string, not char*

8 years agoprepare better solution of Glib's << operator
Robin Gareus [Thu, 15 Oct 2015 09:22:25 +0000 (11:22 +0200)]
prepare better solution of Glib's << operator

8 years agoAvoid calls to Glib::ustring << operator at all cost.
Robin Gareus [Wed, 14 Oct 2015 20:39:46 +0000 (22:39 +0200)]
Avoid calls to Glib::ustring << operator at all cost.

Glib::operator<<(std::ostream&, Glib::ustring const&) involves
loadlocale which is not thread-safe on OSX.

This fixes various seemingly random crashes on OSX.

8 years agoupdate AU GUI positioning and resizing.
Robin Gareus [Wed, 14 Oct 2015 20:26:22 +0000 (22:26 +0200)]
update AU GUI positioning and resizing.

8 years agoFix a problem where VST automation data wasn't getting written (if the adjustments... 4.3
John Emmas [Wed, 14 Oct 2015 13:54:27 +0000 (14:54 +0100)]
Fix a problem where VST automation data wasn't getting written (if the adjustments were made from the plugin's own controls)

8 years agoReduced delay in last commit/10
Len Ovens [Wed, 14 Oct 2015 12:55:10 +0000 (05:55 -0700)]
Reduced delay in last commit/10

8 years agofix MCP ports hang on device change and multi-surface device reconnect.
Len Ovens [Wed, 14 Oct 2015 05:19:36 +0000 (22:19 -0700)]
fix MCP ports hang on device change and multi-surface device reconnect.

8 years agomackie support omnibus patch
Paul Davis [Tue, 13 Oct 2015 19:34:53 +0000 (15:34 -0400)]
mackie support omnibus patch

Fixes all kinds of miscellaneous issues with MCP. Also removes several theoretical pan modes, replace "Tracks"
pan mode with "Trim", and takes a tiny step towards view modes

8 years agofix registration of automation type enums
Paul Davis [Tue, 13 Oct 2015 19:33:39 +0000 (15:33 -0400)]
fix registration of automation type enums

8 years agointroduce separate-meters concept for Mackie.
Paul Davis [Tue, 13 Oct 2015 14:04:58 +0000 (10:04 -0400)]
introduce separate-meters concept for Mackie.

Devices like the SSL Nucleus have meters displayed separately from their 55x2 display

8 years agofix the design of Mackie XML state management
Paul Davis [Tue, 13 Oct 2015 11:33:20 +0000 (07:33 -0400)]
fix the design of Mackie XML state management

8 years agomore corrections for mackie GUI layout
Paul Davis [Tue, 13 Oct 2015 11:32:56 +0000 (07:32 -0400)]
more corrections for mackie GUI layout

8 years agomove incorrectly packed touch sensitivity slider for Mackie GUI
Paul Davis [Tue, 13 Oct 2015 10:48:00 +0000 (06:48 -0400)]
move incorrectly packed touch sensitivity slider for Mackie GUI

8 years agoremove last ofstream
Robin Gareus [Tue, 13 Oct 2015 07:50:38 +0000 (09:50 +0200)]
remove last ofstream

8 years agoOnly flip if not already in desired state. Fixes fader jerk on banking.
Len Ovens [Mon, 12 Oct 2015 20:52:10 +0000 (13:52 -0700)]
Only flip if not already in desired state. Fixes fader jerk on banking.

8 years agoexpose terminal, rather than just physical, MIDI ports in Mackie GUI
Paul Davis [Mon, 12 Oct 2015 18:42:49 +0000 (14:42 -0400)]
expose terminal, rather than just physical, MIDI ports in Mackie GUI

8 years agomake MCP port buttons work
Paul Davis [Mon, 12 Oct 2015 17:36:22 +0000 (13:36 -0400)]
make MCP port buttons work

8 years agono need for ugly cast constructors, just add a second argument
Paul Davis [Mon, 12 Oct 2015 17:34:00 +0000 (13:34 -0400)]
no need for ugly cast constructors, just add a second argument

8 years agoCorrect wrong value on LCD strip when fader is touched (fixs #6619 from Petr Vejsada)
Len Ovens [Mon, 12 Oct 2015 06:24:14 +0000 (23:24 -0700)]
Correct wrong value on LCD strip when fader is touched (fixs #6619 from Petr Vejsada)

8 years agoDon't use old session connections on MCP device change, Solves crash on device change.
Len Ovens [Mon, 12 Oct 2015 05:27:13 +0000 (22:27 -0700)]
Don't use old session connections on MCP device change, Solves crash on device change.

8 years agoFix MCP extension number and get master on right surface.
Len Ovens [Mon, 12 Oct 2015 04:37:04 +0000 (21:37 -0700)]
Fix MCP extension number and get master on right surface.

8 years agofix crashes due to glib ignored EDEADLK.
Robin Gareus [Sun, 11 Oct 2015 23:54:44 +0000 (01:54 +0200)]
fix crashes due to glib ignored EDEADLK.

Taking a readlock after a writelock in the same thread should result
in a deadlock, yet pthread on Linux returns EDEADLK and continues.
glib-2.42.0 ignores EDEADLK and assumes the lock was taken. Releasing
the lock later causes issues: "Calling g_rw_lock_writer_unlock() on a
lock that is not held by the current thread leads to undefined behaviour."

The issue at hand:
 AudioStreamView::redisplay_track()
 -> foreach_region()                       #<< WriteLock
 -> add_region_view()
 ...
 -> AudioRegionView::create_one_wave()
 -> RegionView::update_coverage_frames
 -> Playlist::top_unmuted_region_at()      #<< ReadLock

All current users of Playlist::foreach_region() are in the GUI
and AFAICT read-only (display regions, update visuals)

8 years agorevert 7e0055; the original text better reflected reality
Ben Loftis [Sun, 11 Oct 2015 16:37:52 +0000 (11:37 -0500)]
revert 7e0055;  the original text better reflected reality

8 years agoSeveral changes to Mackie support. Breaks existing Mackie state on disk but not
Paul Davis [Sun, 11 Oct 2015 15:58:00 +0000 (11:58 -0400)]
Several changes to Mackie support. Breaks existing Mackie state on disk but not
in any way that causes problems, just loss of pre-existing connectivity.

1. retain state of current device (and serialize to disk) when switching
devices, and restore that state when switching back to it.
2. fix port and surfacenaming.
3. fix bundle assembly so that all ports (for multi-surface combos) work.
4. rationalize master position numbering
5. add small sleep before starting device handshake after reconnection. This
is ugly but seems to be necessary, unfortunately.

8 years agoForce Flip normal before Bank (fixes #6630)
Len Ovens [Sun, 11 Oct 2015 02:59:29 +0000 (19:59 -0700)]
Force Flip normal before Bank (fixes #6630)

8 years agoDisplay parameter that matches mode.
Len Ovens [Sun, 11 Oct 2015 02:40:28 +0000 (19:40 -0700)]
Display parameter that matches mode.

8 years agonumerous changes to Mackie support, generally offering better robustness
Paul Davis [Sat, 10 Oct 2015 21:13:04 +0000 (17:13 -0400)]
numerous changes to Mackie support, generally offering better robustness

8 years agocoreaudio: reset freewheeling after export
Robin Gareus [Sat, 10 Oct 2015 00:42:13 +0000 (02:42 +0200)]
coreaudio: reset freewheeling after export

fixes lively with session-fadeout

8 years agovaried and wide changes to get input and output combos closer to working
Paul Davis [Fri, 9 Oct 2015 18:01:22 +0000 (14:01 -0400)]
varied and wide changes to get input and output combos closer to working

8 years agomove location where port handling stops during Mackie::Surface destructor
Paul Davis [Fri, 9 Oct 2015 15:12:28 +0000 (11:12 -0400)]
move location where port handling stops during Mackie::Surface destructor

8 years agoNOOP: whitespace/indent fix
Paul Davis [Fri, 9 Oct 2015 15:11:36 +0000 (11:11 -0400)]
NOOP: whitespace/indent fix

8 years agoadd TrimAutomation to list of possible pot parameters for routes
Paul Davis [Fri, 9 Oct 2015 15:11:15 +0000 (11:11 -0400)]
add TrimAutomation to list of possible pot parameters for routes

8 years agoremove unused and useless stuff relating to bundles inside Mackie::Strip
Paul Davis [Fri, 9 Oct 2015 15:10:44 +0000 (11:10 -0400)]
remove unused and useless stuff relating to bundles inside Mackie::Strip

What was someone (Paul? John ?) thinking?

8 years agoset up control_by_parameter map in a Mackie::Strip so that subsequent array-syntax...
Paul Davis [Fri, 9 Oct 2015 15:09:47 +0000 (11:09 -0400)]
set up control_by_parameter map in a Mackie::Strip so that subsequent array-syntax lookup does not crash