From 5382d3e0e587b1882ea39be146bbd9dd5700c3bb Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Sun, 13 Dec 2020 21:22:15 +0100 Subject: [PATCH] Raise an exception to head off a weird asdcplib error with empty JPEG2000 comments. --- src/j2k.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/j2k.cc b/src/j2k.cc index 032c7caa..654146ca 100644 --- a/src/j2k.cc +++ b/src/j2k.cc @@ -283,6 +283,11 @@ dcp::compress_j2k (shared_ptr xyz, int bandwidth, int frame throw MiscError ("could not create JPEG2000 encoder"); } + if (comment.empty()) { + /* asdcplib complains with "Illegal data size" when reading frames encoded with an empty comment */ + throw MiscError("compress_j2k comment can not be an empty string"); + } + opj_set_error_handler (encoder, compress_error_callback, 0); /* Set encoding parameters to default values */ -- 2.30.2