From 2da3ac05bc5c610ab621d26c6e7ff01ccccea57d Mon Sep 17 00:00:00 2001
From: Carl Hetherington <cth@carlh.net>
Date: Sun, 24 Sep 2023 12:02:19 +0200
Subject: [PATCH] Explicitly set up Grok logger rather than relying on a static
 variable.

---
 src/lib/grok/context.h            | 7 -------
 src/lib/j2k_encoder.cc            | 2 --
 src/tools/dcpomatic.cc            | 3 +++
 src/tools/dcpomatic_batch.cc      | 3 +++
 src/tools/dcpomatic_server.cc     | 3 +++
 src/tools/dcpomatic_server_cli.cc | 3 +++
 6 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/src/lib/grok/context.h b/src/lib/grok/context.h
index 8e03c1d54..2513f8863 100644
--- a/src/lib/grok/context.h
+++ b/src/lib/grok/context.h
@@ -59,13 +59,6 @@ struct GrokLogger : public MessengerLogger {
 	}
 };
 
-struct GrokInitializer {
-	GrokInitializer(void) {
-		setMessengerLogger(new GrokLogger("[GROK] "));
-	}
-	~GrokInitializer()  = default;
-};
-
 struct FrameProxy {
 	FrameProxy(int index, Eyes eyes, DCPVideo dcpv) : index_(index), eyes_(eyes), vf(dcpv)
 	{}
diff --git a/src/lib/j2k_encoder.cc b/src/lib/j2k_encoder.cc
index 8c7a1ef1b..c023e4bf3 100644
--- a/src/lib/j2k_encoder.cc
+++ b/src/lib/j2k_encoder.cc
@@ -58,8 +58,6 @@ using dcp::Data;
 using namespace dcpomatic;
 
 
-static grk_plugin::GrokInitializer grokInitializer;
-
 /** @param film Film that we are encoding.
  *  @param writer Writer that we are using.
  */
diff --git a/src/tools/dcpomatic.cc b/src/tools/dcpomatic.cc
index 7d1d7a665..90ae920ee 100644
--- a/src/tools/dcpomatic.cc
+++ b/src/tools/dcpomatic.cc
@@ -75,6 +75,7 @@
 #include "lib/ffmpeg_encoder.h"
 #include "lib/film.h"
 #include "lib/font_config.h"
+#include "lib/grok/context.h"
 #include "lib/hints.h"
 #include "lib/job_manager.h"
 #include "lib/kdm_with_metadata.h"
@@ -1721,6 +1722,8 @@ private:
 				notes.Centre();
 				notes.ShowModal();
 			}
+
+			grk_plugin::setMessengerLogger(new grk_plugin::GrokLogger("[GROK] "));
 		}
 		catch (exception& e)
 		{
diff --git a/src/tools/dcpomatic_batch.cc b/src/tools/dcpomatic_batch.cc
index e39a71529..590ddafd5 100644
--- a/src/tools/dcpomatic_batch.cc
+++ b/src/tools/dcpomatic_batch.cc
@@ -31,6 +31,7 @@
 #include "lib/config.h"
 #include "lib/dcpomatic_socket.h"
 #include "lib/film.h"
+#include "lib/grok/context.h"
 #include "lib/job.h"
 #include "lib/job_manager.h"
 #include "lib/make_dcp.h"
@@ -498,6 +499,8 @@ class App : public wxApp
 			}
 		}
 
+		grk_plugin::setMessengerLogger(new grk_plugin::GrokLogger("[GROK] "));
+
 		return true;
 	}
 
diff --git a/src/tools/dcpomatic_server.cc b/src/tools/dcpomatic_server.cc
index e5e3a7e5a..528af8858 100644
--- a/src/tools/dcpomatic_server.cc
+++ b/src/tools/dcpomatic_server.cc
@@ -25,6 +25,7 @@
 #include "lib/encoded_log_entry.h"
 #include "lib/encode_server.h"
 #include "lib/config.h"
+#include "lib/grok/context.h"
 #include "lib/log.h"
 #include "lib/signaller.h"
 #include "lib/cross.h"
@@ -326,6 +327,8 @@ private:
 
 		SetExitOnFrameDelete (false);
 
+		grk_plugin::setMessengerLogger(new grk_plugin::GrokLogger("[GROK] "));
+
 		return true;
 	}
 
diff --git a/src/tools/dcpomatic_server_cli.cc b/src/tools/dcpomatic_server_cli.cc
index 6d7f6aba7..30f119a5e 100644
--- a/src/tools/dcpomatic_server_cli.cc
+++ b/src/tools/dcpomatic_server_cli.cc
@@ -25,6 +25,7 @@
 #include "lib/config.h"
 #include "lib/image.h"
 #include "lib/file_log.h"
+#include "lib/grok/context.h"
 #include "lib/null_log.h"
 #include "lib/version.h"
 #include "lib/encode_server.h"
@@ -109,6 +110,8 @@ main (int argc, char* argv[])
 		dcpomatic_log.reset (new FileLog("dcpomatic_server_cli.log"));
 	}
 
+	setMessengerLogger(new grk_plugin::GrokLogger("[GROK] "));
+
 	EncodeServer server (verbose, num_threads);
 
 	try {
-- 
2.30.2