From 3d4b1d324e93b5d7c0aa6acf1a1c5d82f4975688 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Thu, 27 Nov 2014 04:15:30 -0500 Subject: [PATCH] Fix calculation using uninitialized value. Implicit "this" is the devil. --- libs/canvas/colors.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/canvas/colors.cc b/libs/canvas/colors.cc index be55d2b7e2..b053e2d1de 100644 --- a/libs/canvas/colors.cc +++ b/libs/canvas/colors.cc @@ -409,15 +409,15 @@ HSV::distance (const HSV& other) const double sL, sA, sB; double oL, oA, oB; - double r, g, b, a; + double r, g, b, alpha; // Careful, "a" is a field of this Color c; c = hsva_to_color (h, s, v, a); - color_to_rgba (c, r, g, b, a); + color_to_rgba (c, r, g, b, alpha); Rgb2Lab (&sL, &sA, &sB, r, g, b); c = hsva_to_color (other.h, other.s, other.v, other.a); - color_to_rgba (c, r, g, b, a); + color_to_rgba (c, r, g, b, alpha); Rgb2Lab (&oL, &oA, &oB, r, g, b); // Weighting factors depending on the application (1 = default) -- 2.30.2