From 7852047dca6312a668edb1ba3fd0d315b3f83ac8 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Fri, 1 Nov 2019 15:39:44 +0100 Subject: [PATCH] Fix XML-writer edge-case (empty content) --- libs/pbd/xml++.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libs/pbd/xml++.cc b/libs/pbd/xml++.cc index 6548852917..95fb370b04 100644 --- a/libs/pbd/xml++.cc +++ b/libs/pbd/xml++.cc @@ -482,6 +482,12 @@ XMLNode::attribute_value() XMLNode* XMLNode::add_content(const string& c) { + if (c.empty ()) { + /* this would add a "" child, leading to invalid XML. + * Also in XML, empty string content is equivalent to no content. + */ + return NULL; + } return add_child_copy(XMLNode (string(), c)); } -- 2.30.2