From a6163fcbce6c7e69074a3420099111aee6cee1ad Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Sun, 27 Feb 2022 23:45:46 +0100 Subject: [PATCH] Don't write a tag with an empty (#2191). I can't see the problem with this, but apparently Dolby CineInspect complains about it. We could fix this in libdcp but I think that would make more sense if this were related to a definite standard violation, instead of just some tinkering to hide a possibly-incorrect warning. --- src/lib/writer.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/writer.cc b/src/lib/writer.cc index 6ce0b1f3e..d775fde54 100644 --- a/src/lib/writer.cc +++ b/src/lib/writer.cc @@ -628,6 +628,9 @@ Writer::finish (boost::filesystem::path output_dcp) for (auto i: film()->content_versions()) { cv.push_back (dcp::ContentVersion(i)); } + if (cv.empty()) { + cv = { dcp::ContentVersion("1") }; + } cpl->set_content_versions (cv); cpl->set_full_content_title_text (film()->name()); -- 2.30.2