From b95b521c63233aa08d42026098429cae4633c95a Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Fri, 20 Jan 2023 22:37:18 +0100 Subject: [PATCH] Cleanup: use an early return. --- src/lib/analyse_subtitles_job.cc | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/lib/analyse_subtitles_job.cc b/src/lib/analyse_subtitles_job.cc index 7f1b8ad04..f0dacf36b 100644 --- a/src/lib/analyse_subtitles_job.cc +++ b/src/lib/analyse_subtitles_job.cc @@ -106,19 +106,21 @@ AnalyseSubtitlesJob::analyse (PlayerText text, TextType type) } } - if (!text.string.empty()) { - /* We can provide dummy values for time and frame rate here as they are only used to calculate fades */ - dcp::Size const frame = _film->frame_size(); - for (auto i: render_text(text.string, frame, dcpomatic::DCPTime(), 24)) { - dcpomatic::Rect rect ( - double(i.position.x) / frame.width, double(i.position.y) / frame.height, - double(i.image->size().width) / frame.width, double(i.image->size().height) / frame.height - ); - if (!_bounding_box) { - _bounding_box = rect; - } else { - _bounding_box->extend (rect); - } + if (text.string.empty()) { + return; + } + + /* We can provide dummy values for time and frame rate here as they are only used to calculate fades */ + dcp::Size const frame = _film->frame_size(); + for (auto i: render_text(text.string, frame, dcpomatic::DCPTime(), 24)) { + dcpomatic::Rect rect ( + double(i.position.x) / frame.width, double(i.position.y) / frame.height, + double(i.image->size().width) / frame.width, double(i.image->size().height) / frame.height + ); + if (!_bounding_box) { + _bounding_box = rect; + } else { + _bounding_box->extend (rect); } } } -- 2.30.2