enough with umpteen "i18n.h" files. Consolidate on pbd/i18n.h
[ardour.git] / gtk2_ardour / editor_mouse.cc
index 83ade5c02e9859f74733e5c5349695fedbe343f3..8a8a9518cf02b9ee912a2cbcf744dd97cda600f8 100644 (file)
@@ -34,7 +34,6 @@
 
 #include "gtkmm2ext/bindings.h"
 #include "gtkmm2ext/utils.h"
-#include "gtkmm2ext/tearoff.h"
 
 #include "canvas/canvas.h"
 
@@ -47,7 +46,6 @@
 #include "ardour/session.h"
 #include "ardour/types.h"
 
-#include "ardour_ui.h"
 #include "actions.h"
 #include "editor.h"
 #include "time_axis_view.h"
@@ -73,7 +71,7 @@
 #include "verbose_cursor.h"
 #include "note.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace std;
 using namespace ARDOUR;
@@ -86,7 +84,7 @@ bool
 Editor::mouse_frame (framepos_t& where, bool& in_track_canvas) const
 {
         /* gdk_window_get_pointer() has X11's XQueryPointer semantics in that it only
-           pays attentions to subwindows. this means that menu windows are ignored, and 
+           pays attentions to subwindows. this means that menu windows are ignored, and
            if the pointer is in a menu, the return window from the call will be the
            the regular subwindow *under* the menu.
 
@@ -208,19 +206,37 @@ void
 Editor::mouse_mode_object_range_toggled()
 {
        MouseMode m = mouse_mode;
-       
+
        Glib::RefPtr<Action> act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-range"));
        assert (act);
        Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic (act);
        assert (tact);
 
-       if (tact->get_active()) {
-               m = MouseObject;  //Smart mode turned to ON, force editing to Object mode
-       }
-
        set_mouse_mode(m, true);  //call this so the button styles can get updated
 }
 
+static Glib::RefPtr<Action>
+get_mouse_mode_action(MouseMode m)
+{
+       switch (m) {
+       case MouseRange:
+               return ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-range"));
+       case MouseObject:
+               return ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-object"));
+       case MouseCut:
+               return ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-cut"));
+       case MouseDraw:
+               return ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-draw"));
+       case MouseTimeFX:
+               return ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-timefx"));
+       case MouseContent:
+               return ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-content"));
+       case MouseAudition:
+               return ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-audition"));
+       }
+       return Glib::RefPtr<Action>();
+}
+
 void
 Editor::set_mouse_mode (MouseMode m, bool force)
 {
@@ -236,38 +252,8 @@ Editor::set_mouse_mode (MouseMode m, bool force)
                if ( m == MouseCut) m = MouseObject;
        }
 
-       Glib::RefPtr<Action> act;
-
-       switch (m) {
-       case MouseRange:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-range"));
-               break;
-
-       case MouseCut:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-cut"));
-               break;
-
-       case MouseObject:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-object"));
-               break;
-
-       case MouseDraw:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-draw"));
-               break;
-
-       case MouseTimeFX:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-timefx"));
-               break;
-
-       case MouseAudition:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-audition"));
-               break;
-       }
-
-       assert (act);
-
-       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic (act);
-       assert (tact);
+       Glib::RefPtr<Action>       act  = get_mouse_mode_action(m);
+       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
 
        /* go there and back to ensure that the toggled handler is called to set up mouse_mode */
        tact->set_active (false);
@@ -279,43 +265,12 @@ Editor::set_mouse_mode (MouseMode m, bool force)
 void
 Editor::mouse_mode_toggled (MouseMode m)
 {
-       Glib::RefPtr<Action> act;
-       Glib::RefPtr<ToggleAction> tact;
-
        if (ARDOUR::Profile->get_mixbus()) {
                if ( m == MouseCut)  m = MouseObject;
        }
 
-       switch (m) {
-       case MouseRange:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-range"));
-               break;
-
-       case MouseObject:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-object"));
-               break;
-
-       case MouseCut:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-cut"));
-               break;
-
-       case MouseDraw:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-draw"));
-               break;
-
-       case MouseTimeFX:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-timefx"));
-               break;
-
-       case MouseAudition:
-               act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-audition"));
-               break;
-       }
-
-       assert (act);
-
-       tact = Glib::RefPtr<ToggleAction>::cast_dynamic (act);
-       assert (tact);
+       Glib::RefPtr<Action>       act  = get_mouse_mode_action(m);
+       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic(act);
 
        if (!tact->get_active()) {
                /* this was just the notification that the old mode has been
@@ -331,8 +286,21 @@ Editor::mouse_mode_toggled (MouseMode m)
                _session->request_transport_speed (0.0, true);
        }
 
+       const bool was_internal = internal_editing();
+
        mouse_mode = m;
 
+       /* Switch snap type/mode if we're moving to/from an internal tool.  Note
+          this must toggle the actions and not call set_snap_*() directly,
+          otherwise things get out of sync and the combo box stops working. */
+       if (!was_internal && internal_editing()) {
+               snap_type_action(internal_snap_type)->set_active(true);
+               snap_mode_action(internal_snap_mode)->set_active(true);
+       } else if (was_internal && !internal_editing()) {
+               snap_type_action(pre_internal_snap_type)->set_active(true);
+               snap_mode_action(pre_internal_snap_mode)->set_active(true);
+       }
+
        instant_save ();
 
        /* this should generate a new enter event which will
@@ -344,21 +312,75 @@ Editor::mouse_mode_toggled (MouseMode m)
        }
 
        set_gain_envelope_visibility ();
-       
+
        update_time_selection_display ();
 
+       update_all_enter_cursors ();
+
        MouseModeChanged (); /* EMIT SIGNAL */
 }
 
+bool
+Editor::internal_editing() const
+{
+       return mouse_mode == Editing::MouseContent || mouse_mode == Editing::MouseDraw;
+}
+
 void
 Editor::update_time_selection_display ()
 {
        switch (mouse_mode) {
        case MouseRange:
                selection->clear_objects ();
+               selection->clear_midi_notes ();
+               break;
+       case MouseObject:
+               selection->clear_time ();
+               selection->clear_tracks ();
+               selection->clear_midi_notes ();
+               break;
+       case MouseDraw:
+               /* Clear regions, but not time or tracks, since that
+                would destroy the range selection rectangle, which we need to stick
+                around for AutomationRangeDrag. */
+               selection->clear_regions ();
+               selection->clear_playlists ();
+               break;
+       case MouseContent:
+               /* This handles internal edit.
+                  Clear everything except points and notes.
+               */
+               selection->clear_regions();
+               selection->clear_lines();
+               selection->clear_playlists ();
+
+               selection->clear_time ();
+               selection->clear_tracks ();
+               break;
+
+       case MouseTimeFX:
+               /* We probably want to keep region selection */
+               selection->clear_points ();
+               selection->clear_lines();
+               selection->clear_playlists ();
+
+               selection->clear_time ();
+               selection->clear_tracks ();
                break;
+
+       case MouseAudition:
+               /*Don't lose lines or points if no action in this mode */
+               selection->clear_regions ();
+               selection->clear_playlists ();
+               selection->clear_time ();
+               selection->clear_tracks ();
+               break;
+
        default:
+               /*Clear everything */
+               selection->clear_objects();
                selection->clear_time ();
+               selection->clear_tracks ();
                break;
        }
 }
@@ -366,7 +388,7 @@ Editor::update_time_selection_display ()
 void
 Editor::step_mouse_mode (bool next)
 {
-       const int n_mouse_modes = (int)MouseDraw + 1;
+       const int n_mouse_modes = (int)MouseContent + 1;
        int       current       = (int)current_mouse_mode();
        if (next) {
                set_mouse_mode((MouseMode)((current + 1) % n_mouse_modes));
@@ -375,25 +397,10 @@ Editor::step_mouse_mode (bool next)
        }
 }
 
-bool
-Editor::toggle_internal_editing_from_double_click (GdkEvent* event)
-{
-       if (_drags->active()) {
-               _drags->end_grab (event);
-       } 
-
-       ActionManager::do_action ("MouseMode", "toggle-internal-edit");
-
-       /* prevent reversion of edit cursor on button release */
-       
-       pre_press_cursor = 0;
-
-       return true;
-}
-
 void
-Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemType item_type)
+Editor::button_selection (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_type)
 {
+
        /* in object/audition/timefx/gain-automation mode,
           any button press sets the selection if the object
           can be selected. this is a bit of hack, because
@@ -438,10 +445,9 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
        if (((mouse_mode != MouseObject) &&
             (mouse_mode != MouseAudition || item_type != RegionItem) &&
             (mouse_mode != MouseTimeFX || item_type != RegionItem) &&
-            (mouse_mode != MouseDraw)) ||
-           ((event->type != GDK_BUTTON_PRESS && event->type != GDK_BUTTON_RELEASE) || event->button.button > 3) ||
-           (internal_editing() && mouse_mode != MouseTimeFX)) {
-
+            (mouse_mode != MouseDraw) &&
+            (mouse_mode != MouseContent || item_type == RegionItem)) ||
+           ((event->type != GDK_BUTTON_PRESS && event->type != GDK_BUTTON_RELEASE) || event->button.button > 3)) {
                return;
        }
 
@@ -451,7 +457,9 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
 
                        /* almost no selection action on modified button-2 or button-3 events */
 
-                       if (item_type != RegionItem && event->button.button != 2) {
+                       if ((item_type != RegionItem && event->button.button != 2)
+                           /* for selection of control points prior to delete (shift-right click) */
+                           && !(item_type == ControlPointItem && event->button.button == 3 && event->type == GDK_BUTTON_PRESS)) {
                                return;
                        }
                }
@@ -460,11 +468,18 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
        Selection::Operation op = ArdourKeyboard::selection_type (event->button.state);
        bool press = (event->type == GDK_BUTTON_PRESS);
 
+       if (press) {
+               _mouse_changed_selection = false;
+       }
+
        switch (item_type) {
        case RegionItem:
+               if (eff_mouse_mode == MouseDraw) {
+                       break;
+               }
                if (press) {
                        if (eff_mouse_mode != MouseRange) {
-                               set_selected_regionview_from_click (press, op);
+                               _mouse_changed_selection = set_selected_regionview_from_click (press, op);
                        } else {
                                /* don't change the selection unless the
                                   clicked track is not currently selected. if
@@ -477,7 +492,7 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
                        }
                } else {
                        if (eff_mouse_mode != MouseRange) {
-                               set_selected_regionview_from_click (press, op);
+                               _mouse_changed_selection |= set_selected_regionview_from_click (press, op);
                        }
                }
                break;
@@ -495,16 +510,104 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
        case StartCrossFadeItem:
        case EndCrossFadeItem:
                if (get_smart_mode() || eff_mouse_mode != MouseRange) {
-                       set_selected_regionview_from_click (press, op);
+                       _mouse_changed_selection |= set_selected_regionview_from_click (press, op);
                } else if (event->type == GDK_BUTTON_PRESS) {
                        set_selected_track_as_side_effect (op);
                }
                break;
 
        case ControlPointItem:
-               set_selected_track_as_side_effect (op);
+               /* for object/track exclusivity, we don't call set_selected_track_as_side_effect (op); */
+
+               if (eff_mouse_mode != MouseRange) {
+                       if (event->button.button != 3) {
+                               _mouse_changed_selection |= set_selected_control_point_from_click (press, op);
+                       } else {
+                               _mouse_changed_selection |= set_selected_control_point_from_click (press, Selection::Set);
+                       }
+               }
+               break;
+
+       case GainLineItem:
+               if (eff_mouse_mode != MouseRange) {
+                       AutomationLine* argl = reinterpret_cast<AutomationLine*> (item->get_data ("line"));
+
+                       std::list<Selectable*> selectables;
+                       uint32_t before, after;
+                       framecnt_t const  where = (framecnt_t) floor (event->button.x * samples_per_pixel) - clicked_regionview->region ()->position ();
+
+                       if (!argl || !argl->control_points_adjacent (where, before, after)) {
+                               break;
+                       }
+
+                       selectables.push_back (argl->nth (before));
+                       selectables.push_back (argl->nth (after));
+
+                       switch (op) {
+                       case Selection::Set:
+                               if (press) {
+                                       selection->set (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+                       case Selection::Add:
+                               if (press) {
+                                       selection->add (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+                       case Selection::Toggle:
+                               if (press) {
+                                       selection->toggle (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+
+                       case Selection::Extend:
+                               /* XXX */
+                               break;
+                       }
+               }
+               break;
+
+       case AutomationLineItem:
                if (eff_mouse_mode != MouseRange) {
-                       set_selected_control_point_from_click (press, op);
+                       AutomationLine* al = reinterpret_cast<AutomationLine*> (item->get_data ("line"));
+                       std::list<Selectable*> selectables;
+                       uint32_t before, after;
+                       framecnt_t const  where = (framecnt_t) floor (event->button.x * samples_per_pixel);
+
+                       if (!al || !al->control_points_adjacent (where, before, after)) {
+                               break;
+                       }
+
+                       selectables.push_back (al->nth (before));
+                       selectables.push_back (al->nth (after));
+
+                       switch (op) {
+                       case Selection::Set:
+                               if (press) {
+                                       selection->set (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+                       case Selection::Add:
+                               if (press) {
+                                       selection->add (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+                       case Selection::Toggle:
+                               if (press) {
+                                       selection->toggle (selectables);
+                                       _mouse_changed_selection = true;
+                               }
+                               break;
+
+                       case Selection::Extend:
+                               /* XXX */
+                               break;
+                       }
                }
                break;
 
@@ -513,16 +616,42 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
                if (event->button.button == 3) {
                        selection->clear_tracks ();
                        set_selected_track_as_side_effect (op);
+
+                       /* We won't get a release.*/
+                       begin_reversible_selection_op (X_("Button 3 Menu Select"));
+                       commit_reversible_selection_op ();
                }
                break;
 
        case AutomationTrackItem:
-               set_selected_track_as_side_effect (op);
+               if (eff_mouse_mode != MouseDraw && op == Selection::Set) {
+                       set_selected_track_as_side_effect (op);
+               }
+               break;
+
+       case NoteItem:
+               if (press && event->button.button == 3) {
+                       NoteBase* cnote = reinterpret_cast<NoteBase*> (item->get_data ("notebase"));
+                       assert (cnote);
+                       if (cnote->region_view().selection_size() == 0 || !cnote->selected()) {
+                               selection->clear_points();
+                               cnote->region_view().unique_select (cnote);
+                               /* we won't get the release, so store the selection change now */
+                               begin_reversible_selection_op (X_("Button 3 Note Selection"));
+                               commit_reversible_selection_op ();
+                       }
+               }
                break;
 
        default:
                break;
        }
+
+       if ((!press) && _mouse_changed_selection) {
+               begin_reversible_selection_op (X_("Button Selection"));
+               commit_reversible_selection_op ();
+               _mouse_changed_selection = false;
+       }
 }
 
 bool
@@ -534,6 +663,8 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
           them to be modeless.
        */
 
+       NoteBase* note = NULL;
+
        switch (item_type) {
        case PlayheadCursorItem:
                _drags->set (new CursorDrag (this, *playhead_cursor, true), event);
@@ -549,13 +680,11 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        case TempoMarkerItem:
        {
-               TempoMarker* m = reinterpret_cast<TempoMarker*> (item->get_data ("marker"));
-               assert (m);
                _drags->set (
                        new TempoMarkerDrag (
                                this,
                                item,
-                               Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)
+                               Keyboard::modifier_state_equals (event->button.state, Keyboard::CopyModifier)
                                ),
                        event
                        );
@@ -564,13 +693,11 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        case MeterMarkerItem:
        {
-               MeterMarker* m = reinterpret_cast<MeterMarker*> (item->get_data ("marker"));
-               assert (m);
                _drags->set (
                        new MeterMarkerDrag (
                                this,
                                item,
-                               Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)
+                               Keyboard::modifier_state_equals (event->button.state, Keyboard::CopyModifier)
                                ),
                        event
                        );
@@ -584,13 +711,17 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        case MarkerBarItem:
        case TempoBarItem:
+       case TempoCurveItem:
        case MeterBarItem:
        case TimecodeRulerItem:
        case SamplesRulerItem:
        case MinsecRulerItem:
        case BBTRulerItem:
-               if (!Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier)) {
+               if (!Keyboard::modifier_state_equals (event->button.state, Keyboard::PrimaryModifier)
+                       && !Keyboard::modifier_state_contains (event->button.state, ArdourKeyboard::constraint_modifier())) {
                        _drags->set (new CursorDrag (this, *playhead_cursor, false), event);
+               } else if (Keyboard::modifier_state_contains (event->button.state, ArdourKeyboard::constraint_modifier())) {
+                       _drags->set (new BBTRulerDrag (this, item), event);
                }
                return true;
                break;
@@ -646,7 +777,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
        Editing::MouseMode eff = effective_mouse_mode ();
 
        /* special case: allow drag of region fade in/out in object mode with join object/range enabled */
-       if (get_smart_mode()) { 
+       if (get_smart_mode()) {
                switch (item_type) {
                  case FadeInHandleItem:
                  case FadeInTrimHandleItem:
@@ -659,11 +790,6 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                }
        }
 
-       /* there is no Range mode when in internal edit mode */
-       if (eff == MouseRange && internal_editing()) {
-               eff = MouseObject;
-       }
-
        switch (eff) {
        case MouseRange:
                switch (item_type) {
@@ -690,19 +816,12 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        break;
 
                case StreamItem:
-                       if (internal_editing()) {
-                               if (dynamic_cast<MidiTimeAxisView*> (clicked_axisview)) {
-                                       _drags->set (new RegionCreateDrag (this, item, clicked_axisview), event);
-                                       return true;
-                               } 
+                       if (Keyboard::modifier_state_equals (event->button.state, Keyboard::RangeSelectModifier)) {
+                               _drags->set (new SelectionDrag (this, item, SelectionDrag::SelectionExtend), event);
                        } else {
-                               if (Keyboard::modifier_state_equals (event->button.state, Keyboard::RangeSelectModifier)) {
-                                       _drags->set (new SelectionDrag (this, item, SelectionDrag::SelectionExtend), event);
-                               } else {
-                                       _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
-                               }
-                               return true;
+                               _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
                        }
+                       return true;
                        break;
 
                case RegionViewNameHighlight:
@@ -713,12 +832,10 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        break;
 
                default:
-                       if (!internal_editing()) {
-                               if (Keyboard::modifier_state_equals (event->button.state, Keyboard::RangeSelectModifier)) {
-                                       _drags->set (new SelectionDrag (this, item, SelectionDrag::SelectionExtend), event);
-                               } else {
-                                       _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
-                               }
+                       if (Keyboard::modifier_state_equals (event->button.state, Keyboard::RangeSelectModifier)) {
+                               _drags->set (new SelectionDrag (this, item, SelectionDrag::SelectionExtend), event);
+                       } else {
+                               _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
                        }
                }
                return true;
@@ -736,7 +853,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                case RegionViewName:
                case StreamItem:
                case AutomationTrackItem:
-                       _drags->set (new RegionCutDrag (this, item, canvas_event_sample (event)), event, current_canvas_cursor);
+                       _drags->set (new RegionCutDrag (this, item, canvas_event_sample (event)), event, get_canvas_cursor());
                        return true;
                        break;
                default:
@@ -744,18 +861,48 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                }
                break;
 
-       case MouseObject:
+       case MouseContent:
                switch (item_type) {
                case NoteItem:
                        /* Existing note: allow trimming/motion */
-                       if (internal_editing()) {
-                               NoteBase* cn = reinterpret_cast<NoteBase*> (item->get_data ("notebase"));
-                               assert (cn);
-                               if (cn->big_enough_to_trim() && cn->mouse_near_ends()) {
-                                       _drags->set (new NoteResizeDrag (this, item), event, current_canvas_cursor);
+                       if ((note = reinterpret_cast<NoteBase*> (item->get_data ("notebase")))) {
+                               if (note->big_enough_to_trim() && note->mouse_near_ends()) {
+                                       _drags->set (new NoteResizeDrag (this, item), event, get_canvas_cursor());
                                } else {
                                        _drags->set (new NoteDrag (this, item), event);
                                }
+                       }
+                       return true;
+
+               case GainLineItem:
+                       _drags->set (new LineDrag (this, item), event);
+                       return true;
+                       break;
+
+               case ControlPointItem:
+                       _drags->set (new ControlPointDrag (this, item), event);
+                       return true;
+                       break;
+
+               case AutomationLineItem:
+                       _drags->set (new LineDrag (this, item), event);
+                       return true;
+                       break;
+
+               case StreamItem:
+                       //in the past, we created a new midi region here, but perhaps that is best left to the Draw mode
+                       break;
+
+               case AutomationTrackItem:
+                       /* rubberband drag to select automation points */
+                       _drags->set (new EditorRubberbandSelectDrag (this, item), event);
+                       return true;
+                       break;
+
+               case RegionItem:
+                       if (dynamic_cast<AutomationRegionView*>(clicked_regionview)) {
+                               /* rubberband drag to select automation points */
+                               _drags->set (new EditorRubberbandSelectDrag (this, item), event);
                                return true;
                        }
                        break;
@@ -763,7 +910,9 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                default:
                        break;
                }
+               break;
 
+       case MouseObject:
                if (Keyboard::modifier_state_contains (event->button.state, Keyboard::ModifierMask(Keyboard::PrimaryModifier|Keyboard::SecondaryModifier)) &&
                    event->type == GDK_BUTTON_PRESS) {
 
@@ -786,7 +935,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                        case StartCrossFadeItem:
                        case EndCrossFadeItem:
-                               /* we might allow user to grab inside the fade to trim a region with preserve_fade_anchor.  for not this is not fully implemented */ 
+                               /* we might allow user to grab inside the fade to trim a region with preserve_fade_anchor.  for not this is not fully implemented */
 //                             if (!clicked_regionview->region()->locked()) {
 //                                     _drags->set (new TrimDrag (this, item, clicked_regionview, selection->regions.by_layer(), true), event);
 //                                     return true;
@@ -813,10 +962,6 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                        break;
                                }
 
-                               if (internal_editing ()) {
-                                       break;
-                               }
-
                                /* click on a normal region view */
                                if (Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)) {
                                        add_region_copy_drag (item, event, clicked_regionview);
@@ -827,10 +972,6 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                }
 
 
-//                             if (!internal_editing() && (_join_object_range_state == JOIN_OBJECT_RANGE_RANGE && !selection->regions.empty())) {
-//                                     _drags->add (new SelectionDrag (this, clicked_axisview->get_selection_rect (clicked_selection)->rect, SelectionDrag::SelectionMove));
-//                             }
-
                                _drags->start_grab (event);
                                return true;
                                break;
@@ -873,15 +1014,8 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                break;
 
                        case StreamItem:
-                               if (internal_editing()) {
-                                       if (dynamic_cast<MidiTimeAxisView*> (clicked_axisview)) {
-                                               _drags->set (new RegionCreateDrag (this, item, clicked_axisview), event);
-                                       }
-                                       return true;
-                               } else {
-                                       _drags->set (new EditorRubberbandSelectDrag (this, item), event);
-                               }
-                               break;
+                               _drags->set (new EditorRubberbandSelectDrag (this, item), event);
+                               return true;
 
                        case AutomationTrackItem:
                        {
@@ -903,7 +1037,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                                if (!prev) {
                                                        _drags->set (new RegionCreateDrag (this, item, parent), event);
                                                } else {
-                                                       prev->set_length (t - prev->position ());
+                                                       prev->set_length (t - prev->position (), get_grid_music_divisions (event->button.state));
                                                }
                                        }
                                } else {
@@ -942,12 +1076,13 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                case SelectionItem:
                {
-                       AudioRegionView* arv = dynamic_cast<AudioRegionView *> (clicked_regionview);
-                       if (arv) {
-                               _drags->set (new AutomationRangeDrag (this, arv, selection->time), event, _cursors->up_down);
+                       if (dynamic_cast<AudioRegionView*>(clicked_regionview) ||
+                           dynamic_cast<AutomationRegionView*>(clicked_regionview)) {
+                               _drags->set (new AutomationRangeDrag (this, clicked_regionview, selection->time),
+                                            event, _cursors->up_down);
                        } else {
                                double const y = event->button.y;
-                               pair<TimeAxisView*, int> tvp = trackview_by_y_position (y);
+                               pair<TimeAxisView*, int> tvp = trackview_by_y_position (y, false);
                                if (tvp.first) {
                                        AutomationTimeAxisView* atv = dynamic_cast<AutomationTimeAxisView*> (tvp.first);
                                        if ( atv) {
@@ -965,28 +1100,23 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        break;
 
                case NoteItem:
-                       /* Existing note: allow trimming/motion */
-                       if (internal_editing()) {
-                               /* trim notes if we're in internal edit mode and near the ends of the note */
-                               NoteBase* cn = reinterpret_cast<NoteBase*>(item->get_data ("notebase"));
-                               assert (cn);
-                               if (cn->big_enough_to_trim() && cn->mouse_near_ends()) {
-                                       _drags->set (new NoteResizeDrag (this, item), event, current_canvas_cursor);
+                       if ((note = reinterpret_cast<NoteBase*>(item->get_data ("notebase")))) {
+                               if (note->big_enough_to_trim() && note->mouse_near_ends()) {
+                                       /* Note is big and pointer is near the end, trim */
+                                       _drags->set (new NoteResizeDrag (this, item), event, get_canvas_cursor());
                                } else {
+                                       /* Drag note */
                                        _drags->set (new NoteDrag (this, item), event);
                                }
                                return true;
                        }
-                       break;
+                       return true;
 
                case StreamItem:
-                       if (internal_editing()) {
-                               if (dynamic_cast<MidiTimeAxisView*> (clicked_axisview)) {
-                                       _drags->set (new RegionCreateDrag (this, item, clicked_axisview), event);
-                               }
-                               return true;
+                       if (dynamic_cast<MidiTimeAxisView*> (clicked_axisview)) {
+                               _drags->set (new RegionCreateDrag (this, item, clicked_axisview), event);
                        }
-                       break;
+                       return true;
 
                default:
                        break;
@@ -995,12 +1125,12 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                break;
 
        case MouseTimeFX:
-               if (internal_editing() && item_type == NoteItem ) {
-                       /* drag notes if we're in internal edit mode */
-                       NoteBase* cn = reinterpret_cast<NoteBase*>(item->get_data ("notebase"));
-                       assert (cn);
-                       if (cn->big_enough_to_trim()) {
-                               _drags->set (new NoteResizeDrag (this, item), event, current_canvas_cursor);
+               if (item_type == NoteItem) {
+                       /* resize-drag notes */
+                       if ((note = reinterpret_cast<NoteBase*>(item->get_data ("notebase")))) {
+                               if (note->big_enough_to_trim()) {
+                                       _drags->set (new NoteResizeDrag (this, item), event, get_canvas_cursor());
+                               }
                        }
                        return true;
                } else if (clicked_regionview) {
@@ -1011,12 +1141,11 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                break;
 
        case MouseAudition:
-               _drags->set (new ScrubDrag (this, item), event);
+               _drags->set (new ScrubDrag (this, item), event, _cursors->transparent);
                scrub_reversals = 0;
                scrub_reverse_distance = 0;
                last_scrub_x = event->button.x;
                scrubbing_direction = 0;
-               push_canvas_cursor (_cursors->transparent);
                return true;
                break;
 
@@ -1035,11 +1164,6 @@ Editor::button_press_handler_2 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
        case MouseObject:
                switch (item_type) {
                case RegionItem:
-                       if (internal_editing ()) {
-                               /* no region drags in internal edit mode */
-                               return false;
-                       }
-
                        if (Keyboard::modifier_state_contains (event->button.state, Keyboard::CopyModifier)) {
                                add_region_copy_drag (item, event, clicked_regionview);
                        } else {
@@ -1065,9 +1189,7 @@ Editor::button_press_handler_2 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                case LeftFrameHandle:
                case RightFrameHandle:
-                       if (!internal_editing ()) {
-                               _drags->set (new TrimDrag (this, item, clicked_regionview, selection->regions.by_layer()), event);
-                       }
+                       _drags->set (new TrimDrag (this, item, clicked_regionview, selection->regions.by_layer()), event);
                        return true;
                        break;
 
@@ -1096,7 +1218,7 @@ Editor::button_press_handler_2 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
        return false;
 }
-   
+
 bool
 Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_type)
 {
@@ -1110,56 +1232,12 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
                return false;
        }
 
-        pre_press_cursor = current_canvas_cursor;
-
        _track_canvas->grab_focus();
 
        if (_session && _session->actively_recording()) {
                return true;
        }
 
-       if (internal_editing()) {
-               bool leave_internal_edit_mode = false;
-
-               switch (item_type) {
-               case NoteItem:
-                       break;
-
-               case RegionItem:
-                       if (!dynamic_cast<MidiRegionView*> (clicked_regionview) && !dynamic_cast<AutomationRegionView*> (clicked_regionview)) {
-                               leave_internal_edit_mode = true;
-                       }
-                       break;
-
-               case PlayheadCursorItem:
-               case MarkerItem:
-               case TempoMarkerItem:
-               case MeterMarkerItem:
-               case MarkerBarItem:
-               case TempoBarItem:
-               case MeterBarItem:
-               case RangeMarkerBarItem:
-               case CdMarkerBarItem:
-               case TransportMarkerBarItem:
-               case StreamItem:
-               case TimecodeRulerItem:
-               case SamplesRulerItem:
-               case MinsecRulerItem:
-               case BBTRulerItem:
-                       /* button press on these items never does anything to
-                          change the editing mode.
-                       */
-                       break;
-
-               default:
-                       break;
-               }
-               
-               if (leave_internal_edit_mode) {
-                       ActionManager::do_action ("MouseMode", "toggle-internal-edit");
-               }
-       }
-
        button_selection (item, event, item_type);
 
        if (!_drags->active () &&
@@ -1172,7 +1250,7 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
        }
 
        //not rolling, range mode click + join_play_range :  locate the PH here
-       if ( !_drags->active () && !_session->transport_rolling() && ( effective_mouse_mode() == MouseRange ) && Config->get_follow_edits() ) {
+       if ( !_drags->active () && _session && !_session->transport_rolling() && ( effective_mouse_mode() == MouseRange ) && UIConfiguration::instance().get_follow_edits() && !_session->config.get_external_sync() ) {
                framepos_t where = canvas_event_sample (event);
                snap_to(where);
                _session->request_locate (where, false);
@@ -1225,10 +1303,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
        framepos_t where = canvas_event_sample (event);
        AutomationTimeAxisView* atv = 0;
 
-        if (pre_press_cursor) {
-                set_canvas_cursor (pre_press_cursor);
-                pre_press_cursor = 0;
-        }
+       _press_cursor_ctx.reset();
 
        /* no action if we're recording */
 
@@ -1236,20 +1311,24 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                return true;
        }
 
-       /* see if we're finishing a drag */
+        bool were_dragging = false;
 
-       bool were_dragging = false;
-       if (_drags->active ()) {
-               bool const r = _drags->end_grab (event);
-               if (r) {
-                       /* grab dragged, so do nothing else */
-                       return true;
-               }
+       if (!Keyboard::is_context_menu_event (&event->button)) {
 
-               were_dragging = true;
-       }
+                /* see if we're finishing a drag */
+
+                if (_drags->active ()) {
+                        bool const r = _drags->end_grab (event);
+                        if (r) {
+                                /* grab dragged, so do nothing else */
+                                return true;
+                        }
 
-       update_region_layering_order_editor ();
+                        were_dragging = true;
+                }
+
+                update_region_layering_order_editor ();
+        }
 
        /* edit events get handled here */
 
@@ -1258,34 +1337,33 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                case RegionItem:
                        show_region_properties ();
                        break;
-
                case TempoMarkerItem: {
-                       Marker* marker;
+                       ArdourMarker* marker;
                        TempoMarker* tempo_marker;
-                       
-                       if ((marker = reinterpret_cast<Marker *> (item->get_data ("marker"))) == 0) {
+
+                       if ((marker = reinterpret_cast<ArdourMarker *> (item->get_data ("marker"))) == 0) {
                                fatal << _("programming error: tempo marker canvas item has no marker object pointer!") << endmsg;
                                abort(); /*NOTREACHED*/
                        }
-                       
+
                        if ((tempo_marker = dynamic_cast<TempoMarker*> (marker)) == 0) {
                                fatal << _("programming error: marker for tempo is not a tempo marker!") << endmsg;
                                abort(); /*NOTREACHED*/
                        }
-                       
+
                        edit_tempo_marker (*tempo_marker);
                        break;
                }
 
                case MeterMarkerItem: {
-                       Marker* marker;
+                       ArdourMarker* marker;
                        MeterMarker* meter_marker;
-                       
-                       if ((marker = reinterpret_cast<Marker *> (item->get_data ("marker"))) == 0) {
+
+                       if ((marker = reinterpret_cast<ArdourMarker *> (item->get_data ("marker"))) == 0) {
                                fatal << _("programming error: tempo marker canvas item has no marker object pointer!") << endmsg;
                                abort(); /*NOTREACHED*/
                        }
-                       
+
                        if ((meter_marker = dynamic_cast<MeterMarker*> (marker)) == 0) {
                                fatal << _("programming error: marker for meter is not a meter marker!") << endmsg;
                                abort(); /*NOTREACHED*/
@@ -1353,7 +1431,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        case SelectionItem:
                                popup_track_context_menu (1, event->button.time, item_type, true);
                                break;
-                               
+
                        case AutomationTrackItem:
                                popup_track_context_menu (1, event->button.time, item_type, false);
                                break;
@@ -1363,6 +1441,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        case TransportMarkerBarItem:
                        case CdMarkerBarItem:
                        case TempoBarItem:
+                       case TempoCurveItem:
                        case MeterBarItem:
                        case VideoBarItem:
                        case TimecodeRulerItem:
@@ -1392,6 +1471,12 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                popup_control_point_context_menu (item, event);
                                break;
 
+                       case NoteItem:
+                               if (internal_editing()) {
+                                       popup_note_context_menu (item, event);
+                               }
+                               break;
+
                        default:
                                break;
                        }
@@ -1466,8 +1551,8 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                mouse_add_new_marker (where, true);
                        }
                        return true;
-
                case TempoBarItem:
+               case TempoCurveItem:
                        if (!_dragging_playhead) {
                                snap_to_with_modifier (where, event);
                                mouse_add_new_tempo_event (where);
@@ -1525,7 +1610,6 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        break;
 
                case MouseAudition:
-                       pop_canvas_cursor ();
                        if (scrubbing_direction == 0) {
                                /* no drag, just a click */
                                switch (item_type) {
@@ -1535,7 +1619,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                default:
                                        break;
                                }
-                       } else {
+                       } else if (_session) {
                                /* make sure we stop */
                                _session->request_transport_speed (0.0);
                        }
@@ -1547,7 +1631,8 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                }
 
                 /* do any (de)selection operations that should occur on button release */
-                button_selection (item, event, item_type);
+               button_selection (item, event, item_type);
+
                return true;
                break;
 
@@ -1576,7 +1661,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                case MouseDraw:
                        return true;
-                       
+
                case MouseRange:
                        // x_style_paste (where, 1.0);
                        return true;
@@ -1602,22 +1687,22 @@ bool
 Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_type)
 {
        ControlPoint* cp;
-       Marker * marker;
+       ArdourMarker * marker;
        double fraction;
         bool ret = true;
 
        /* by the time we reach here, entered_regionview and entered trackview
-        * will have already been set as appropriate. Things are done this 
+        * will have already been set as appropriate. Things are done this
         * way because this method isn't passed a pointer to a variable type of
         * thing that is entered (which may or may not be canvas item).
         * (e.g. the actual entered regionview)
         */
 
-       choose_canvas_cursor_on_entry (&event->crossing, item_type);
+       choose_canvas_cursor_on_entry (item_type);
 
        switch (item_type) {
        case ControlPointItem:
-               if (mouse_mode == MouseDraw || mouse_mode == MouseObject) {
+               if (mouse_mode == MouseDraw || mouse_mode == MouseObject || mouse_mode == MouseContent) {
                        cp = static_cast<ControlPoint*>(item->get_data ("control_point"));
                        cp->show ();
 
@@ -1632,7 +1717,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                if (mouse_mode == MouseDraw) {
                        ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
                        if (line) {
-                               line->set_outline_color (ARDOUR_UI::config()->color ("entered gain line"));
+                               line->set_outline_color (UIConfiguration::instance().color ("entered gain line"));
                        }
                }
                break;
@@ -1641,7 +1726,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                if (mouse_mode == MouseDraw || mouse_mode == MouseObject) {
                        ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
                        if (line) {
-                               line->set_outline_color (ARDOUR_UI::config()->color ("entered automation line"));
+                               line->set_outline_color (UIConfiguration::instance().color ("entered automation line"));
                        }
                }
                break;
@@ -1655,11 +1740,11 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                break;
 
        case MarkerItem:
-               if ((marker = static_cast<Marker *> (item->get_data ("marker"))) == 0) {
+               if ((marker = static_cast<ArdourMarker *> (item->get_data ("marker"))) == 0) {
                        break;
                }
                entered_marker = marker;
-               marker->set_color_rgba (ARDOUR_UI::config()->color ("entered marker"));
+               marker->set_color_rgba (UIConfiguration::instance().color ("entered marker"));
                // fall through
        case MeterMarkerItem:
        case TempoMarkerItem:
@@ -1667,7 +1752,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
 
        case FadeInHandleItem:
        case FadeInTrimHandleItem:
-               if (mouse_mode == MouseObject && !internal_editing()) {
+               if (mouse_mode == MouseObject) {
                        ArdourCanvas::Rectangle *rect = dynamic_cast<ArdourCanvas::Rectangle *> (item);
                        if (rect) {
                                RegionView* rv = static_cast<RegionView*>(item->get_data ("regionview"));
@@ -1678,7 +1763,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
 
        case FadeOutHandleItem:
        case FadeOutTrimHandleItem:
-               if (mouse_mode == MouseObject && !internal_editing()) {
+               if (mouse_mode == MouseObject) {
                        ArdourCanvas::Rectangle *rect = dynamic_cast<ArdourCanvas::Rectangle *> (item);
                        if (rect) {
                                RegionView* rv = static_cast<RegionView*>(item->get_data ("regionview"));
@@ -1697,6 +1782,14 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
        case SelectionItem:
                break;
 
+       case WaveItem:
+       {
+               if (entered_regionview) {
+                       entered_regionview->entered();
+               }
+       }
+       break;
+
        default:
                break;
        }
@@ -1728,16 +1821,18 @@ bool
 Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
 {
        AutomationLine* al;
-       Marker *marker;
+       ArdourMarker *marker;
        Location *loc;
        bool is_start;
        bool ret = true;
 
-       reset_canvas_cursor ();
+       if (!_enter_stack.empty()) {
+               _enter_stack.pop_back();
+       }
 
        switch (item_type) {
        case ControlPointItem:
-               _verbose_cursor->hide (); 
+               _verbose_cursor->hide ();
                break;
 
        case GainLineItem:
@@ -1752,7 +1847,7 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
                break;
 
        case MarkerItem:
-               if ((marker = static_cast<Marker *> (item->get_data ("marker"))) == 0) {
+               if ((marker = static_cast<ArdourMarker *> (item->get_data ("marker"))) == 0) {
                        break;
                }
                entered_marker = 0;
@@ -1771,7 +1866,7 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
        {
                ArdourCanvas::Rectangle *rect = dynamic_cast<ArdourCanvas::Rectangle *> (item);
                if (rect) {
-                       rect->set_fill_color (ARDOUR_UI::config()->color ("inactive fade handle"));
+                       rect->set_fill_color (UIConfiguration::instance().color ("inactive fade handle"));
                }
        }
        break;
@@ -1782,7 +1877,7 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
        case FeatureLineItem:
        {
                ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
-               line->set_outline_color (ARDOUR_UI::config()->color ("zero line"));
+               line->set_outline_color (UIConfiguration::instance().color ("zero line"));
        }
        break;
 
@@ -1897,14 +1992,14 @@ Editor::motion_handler (ArdourCanvas::Item* /*item*/, GdkEvent* event, bool from
                current_stepping_trackview = 0;
                step_timeout.disconnect ();
        }
-       
+
        if (_session && _session->actively_recording()) {
                /* Sorry. no dragging stuff around while we record */
                return true;
        }
-       
+
        update_join_object_range_location (event->motion.y);
-       
+
        if (_drags->active ()) {
                return _drags->motion_handler (event, from_autoscroll);
        }
@@ -1961,7 +2056,6 @@ Editor::edit_control_point (ArdourCanvas::Item* item)
        }
 
        ControlPointDialog d (p);
-       ensure_float (d);
 
        if (d.run () != RESPONSE_ACCEPT) {
                return;
@@ -1971,23 +2065,16 @@ Editor::edit_control_point (ArdourCanvas::Item* item)
 }
 
 void
-Editor::edit_notes (TimeAxisViewItem& tavi)
+Editor::edit_notes (MidiRegionView* mrv)
 {
-       MidiRegionView* mrv = dynamic_cast<MidiRegionView*>(&tavi);
-
-       if (!mrv) {
-               return;
-       }
-
        MidiRegionView::Selection const & s = mrv->selection();
 
        if (s.empty ()) {
                return;
        }
 
-       EditNoteDialog* d = new EditNoteDialog (&(*s.begin())->region_view(), s);
+       EditNoteDialog* d = new EditNoteDialog (mrv, s);
        d->show_all ();
-       ensure_float (*d);
 
        d->signal_response().connect (sigc::bind (sigc::mem_fun (*this, &Editor::note_edit_done), d));
 }
@@ -1995,8 +2082,12 @@ Editor::edit_notes (TimeAxisViewItem& tavi)
 void
 Editor::note_edit_done (int r, EditNoteDialog* d)
 {
+       begin_reversible_command (_("edit note(s)"));
+
        d->done (r);
        delete d;
+
+       commit_reversible_command();
 }
 
 void
@@ -2009,7 +2100,7 @@ Editor::visible_order_range (int* low, int* high) const
 
                RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*> (*i);
 
-               if (!rtv->hidden()) {
+               if (rtv && !rtv->hidden()) {
 
                        if (*high < rtv->order()) {
                                *high = rtv->order ();
@@ -2089,7 +2180,7 @@ Editor::cancel_time_selection ()
        }
        selection->time.clear ();
        clicked_selection = 0;
-}      
+}
 
 void
 Editor::point_trim (GdkEvent* event, framepos_t new_bound)
@@ -2124,7 +2215,7 @@ Editor::point_trim (GdkEvent* event, framepos_t new_bound)
 
                break;
        case 2:
-               begin_reversible_command (_("End point trim"));
+               begin_reversible_command (_("end point trim"));
 
                if (selection->selected (rv)) {
 
@@ -2157,10 +2248,10 @@ Editor::point_trim (GdkEvent* event, framepos_t new_bound)
 void
 Editor::hide_marker (ArdourCanvas::Item* item, GdkEvent* /*event*/)
 {
-       Marker* marker;
+       ArdourMarker* marker;
        bool is_start;
 
-       if ((marker = static_cast<Marker *> (item->get_data ("marker"))) == 0) {
+       if ((marker = static_cast<ArdourMarker *> (item->get_data ("marker"))) == 0) {
                fatal << _("programming error: marker canvas item has no marker object pointer!") << endmsg;
                abort(); /*NOTREACHED*/
        }
@@ -2222,7 +2313,7 @@ Editor::mouse_brush_insert_region (RegionView* rv, framepos_t pos)
 
        RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*>(&rv->get_time_axis_view());
 
-       if (rtv == 0 || !rtv->is_track()) {
+       if (!rtv || !rtv->is_track()) {
                return;
        }
 
@@ -2236,7 +2327,7 @@ Editor::mouse_brush_insert_region (RegionView* rv, framepos_t pos)
 
        // playlist is frozen, so we have to update manually XXX this is disgusting
 
-       playlist->RegionAdded (new_region); /* EMIT SIGNAL */
+       //playlist->RegionAdded (new_region); /* EMIT SIGNAL */
 }
 
 gint
@@ -2298,8 +2389,6 @@ Editor::add_region_brush_drag (ArdourCanvas::Item* item, GdkEvent*, RegionView*
        }
 
        _drags->add (new RegionMoveDrag (this, item, region_view, selection->regions.by_layer(), true, false));
-
-       begin_reversible_command (Operations::drag_region_brush);
 }
 
 /** Start a grab where a time range is selected, track(s) are selected, and the
@@ -2339,7 +2428,6 @@ Editor::start_selection_grab (ArdourCanvas::Item* /*item*/, GdkEvent* event)
        /* A selection grab currently creates two undo/redo operations, one for
           creating the new region and another for moving it.
        */
-
        begin_reversible_command (Operations::selection_grab);
 
        boost::shared_ptr<Playlist> playlist = clicked_axisview->playlist();
@@ -2348,20 +2436,22 @@ Editor::start_selection_grab (ArdourCanvas::Item* /*item*/, GdkEvent* event)
        clicked_routeview->playlist()->add_region (region, selection->time[clicked_selection].start);
        _session->add_command(new StatefulDiffCommand (playlist));
 
-       commit_reversible_command ();
-
        c.disconnect ();
 
        if (latest_regionviews.empty()) {
                /* something went wrong */
+               abort_reversible_command ();
                return;
        }
 
        /* we need to deselect all other regionviews, and select this one
           i'm ignoring undo stuff, because the region creation will take care of it
        */
+
        selection->set (latest_regionviews);
 
+       commit_reversible_command ();
+
        _drags->set (new RegionMoveDrag (this, latest_regionviews.front()->get_canvas_group(), latest_regionviews.front(), latest_regionviews, false, false), event);
 }
 
@@ -2374,45 +2464,7 @@ Editor::escape ()
                selection->clear ();
        }
 
-       reset_focus ();
-}
-
-void
-Editor::set_internal_edit (bool yn)
-{
-       if (_internal_editing == yn) {
-               return;
-       }
-
-       _internal_editing = yn;
-
-       if (yn) {
-               pre_internal_mouse_mode = mouse_mode;
-               pre_internal_snap_type = _snap_type;
-               pre_internal_snap_mode = _snap_mode;
-
-               for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
-                       (*i)->enter_internal_edit_mode ();
-               }
-
-               set_snap_to (internal_snap_type);
-               set_snap_mode (internal_snap_mode);
-
-       } else {
-
-               internal_snap_mode = _snap_mode;
-               internal_snap_type = _snap_type;
-
-               for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
-                       (*i)->leave_internal_edit_mode ();
-               }
-
-               set_snap_to (pre_internal_snap_type);
-               set_snap_mode (pre_internal_snap_mode);
-       }
-
-       reset_canvas_cursor ();
-       MouseModeChanged ();
+       reset_focus (&contents());
 }
 
 /** Update _join_object_range_state which indicate whether we are over the top
@@ -2422,7 +2474,7 @@ Editor::set_internal_edit (bool yn)
 void
 Editor::update_join_object_range_location (double y)
 {
-       if (_internal_editing || !get_smart_mode()) {
+       if (!get_smart_mode()) {
                _join_object_range_state = JOIN_OBJECT_RANGE_NONE;
                return;
        }
@@ -2439,17 +2491,18 @@ Editor::update_join_object_range_location (double y)
 
                ArdourCanvas::Duple const item_space = entered_regionview->get_canvas_group()->canvas_to_item (ArdourCanvas::Duple (0, y));
                double const c = item_space.y / entered_regionview->height();
-                       
+
                _join_object_range_state = c <= 0.5 ? JOIN_OBJECT_RANGE_RANGE : JOIN_OBJECT_RANGE_OBJECT;
-               
-               if (_join_object_range_state != old) {
-                       set_canvas_cursor (which_track_cursor ());
+
+               Editor::EnterContext* ctx = get_enter_context(RegionItem);
+               if (_join_object_range_state != old && ctx) {
+                       ctx->cursor_ctx->change(which_track_cursor());
                }
 
        } else if (entered_track) {
 
                RouteTimeAxisView* entered_route_view = dynamic_cast<RouteTimeAxisView*> (entered_track);
-               
+
                if (entered_route_view) {
 
                        double cx = 0;
@@ -2458,7 +2511,7 @@ Editor::update_join_object_range_location (double y)
                        entered_route_view->canvas_display()->canvas_to_item (cx, cy);
 
                        double track_height = entered_route_view->view()->child_height();
-                       if (Config->get_show_name_highlight()) {
+                       if (UIConfiguration::instance().get_show_name_highlight()) {
                                track_height -= TimeAxisViewItem::NAME_HIGHLIGHT_SIZE;
                        }
                        double const c = cy / track_height;
@@ -2475,8 +2528,9 @@ Editor::update_join_object_range_location (double y)
                        _join_object_range_state = JOIN_OBJECT_RANGE_OBJECT;
                }
 
-               if (_join_object_range_state != old) {
-                       set_canvas_cursor (which_track_cursor ());
+               Editor::EnterContext* ctx = get_enter_context(StreamItem);
+               if (_join_object_range_state != old && ctx) {
+                       ctx->cursor_ctx->change(which_track_cursor());
                }
        }
 }