fix crash when copy'ing latent plugins

[ardour.git] / gtk2_ardour / keyeditor.cc

diff --git a/gtk2_ardour/keyeditor.cc b/gtk2_ardour/keyeditor.cc
index fc69d89e2867d171de432ef11da384e764c909c2..b19b6d5fc009611b321026bac56e61bf0d1aecfe 100644 (file)
--- a/gtk2_ardour/keyeditor.cc
+++ b/gtk2_ardour/keyeditor.cc
@@ -23,9 +23,13 @@
 
 #include <map>
 #include <fstream>
+#include <sstream>
 
 #include <boost/algorithm/string.hpp>
 
+#include <glib.h>
+#include <glib/gstdio.h>
+
 #include <gtkmm/stock.h>
 #include <gtkmm/label.h>
 #include <gtkmm/accelkey.h>
@@ -35,6 +39,8 @@
 #include "gtkmm2ext/bindings.h"
 #include "gtkmm2ext/utils.h"
 
+#include "pbd/error.h"
+#include "pbd/openuri.h"
 #include "pbd/strsplit.h"
 
 #include "ardour/filesystem_paths.h"
@@ -44,7 +50,7 @@
 #include "keyboard.h"
 #include "keyeditor.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace std;
 using namespace Gtk;
@@ -88,7 +94,7 @@ KeyEditor::KeyEditor ()
        filter_entry.signal_search_string_updated ().connect (sigc::mem_fun (*this, &KeyEditor::search_string_updated));
        vpacker.pack_start (filter_entry, false, false);
 
-       Label* hint = manage (new Label (_("Select an action, then press the key(s) to (re)set its shortcut")));
+       Label* hint = manage (new Label (_("To remove a shortcut select an action then press this: ")));
        hint->show ();
        unbind_box.set_spacing (6);
        unbind_box.pack_start (*hint, false, true);
@@ -520,16 +526,47 @@ KeyEditor::search_string_updated (const std::string& filter)
 void
 KeyEditor::print () const
 {
-       char templ[14];
+       stringstream sstr;
+       Bindings::save_all_bindings_as_html (sstr);
 
-       snprintf (templ, sizeof (templ), "akprintXXXXXX");
+       if (sstr.str().empty()) {
+               return;
+       }
 
-       int fd = mkstemp (templ);
-       ofstream f;
-       //f.open (fd);
 
-       Bindings::save_all_bindings_as_html (cerr);
+       gchar* file_name;
+       GError *err = NULL;
+       gint fd;
+
+       if ((fd = g_file_open_tmp ("akprintXXXXXX.html", &file_name, &err)) < 0) {
+               if (err) {
+                       error << string_compose (_("Could not open temporary file to print bindings (%1)"), err->message) << endmsg;
+                       g_error_free (err);
+               }
+               return;
+       }
+
+#ifdef PLATFORM_WINDOWS
+       ::close (fd);
+#endif
+
+       err = NULL;
+
+       if (!g_file_set_contents (file_name, sstr.str().c_str(), sstr.str().size(), &err)) {
+#ifndef PLATFORM_WINDOWS
+               ::close (fd);
+#endif
+               g_unlink (file_name);
+               if (err) {
+                       error << string_compose (_("Could not save bindings to file (%1)"), err->message) << endmsg;
+                       g_error_free (err);
+               }
+               return;
+       }
+
+#ifndef PLATFORM_WINDOWS
+       ::close (fd);
+#endif
 
-       f.close ();
-       close (fd);
+       PBD::open_uri (string_compose ("file:///%1", file_name));
 }