fix crash when copy'ing latent plugins

[ardour.git] / gtk2_ardour / mixer_group_tabs.cc

diff --git a/gtk2_ardour/mixer_group_tabs.cc b/gtk2_ardour/mixer_group_tabs.cc
index 290cc30b2a94a9d2fa942e6a61b46ad0a1b3a1e9..63bb1a091f5f6cda414a797d3056977a3438c38d 100644 (file)
--- a/gtk2_ardour/mixer_group_tabs.cc
+++ b/gtk2_ardour/mixer_group_tabs.cc
@@ -25,15 +25,15 @@
 
 #include "canvas/colors.h"
 
-#include "ardour_ui.h"
 #include "mixer_group_tabs.h"
 #include "mixer_strip.h"
 #include "mixer_ui.h"
 #include "rgb_macros.h"
 #include "route_group_dialog.h"
+#include "ui_config.h"
 #include "utils.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace std;
 using namespace Gtk;
@@ -61,7 +61,12 @@ MixerGroupTabs::compute_tabs () const
        TreeModel::Children rows = _mixer->track_model->children ();
        for (TreeModel::Children::iterator i = rows.begin(); i != rows.end(); ++i) {
 
-               MixerStrip* s = (*i)[_mixer->track_columns.strip];
+               AxisView* av = (*i)[_mixer->stripable_columns.strip];
+               MixerStrip* s = dynamic_cast<MixerStrip*> (av);
+
+               if (!s) {
+                       continue;
+               }
 
                if (s->route()->is_master() || s->route()->is_monitor() || !s->marked_for_display()) {
                        continue;
@@ -83,7 +88,9 @@ MixerGroupTabs::compute_tabs () const
                        }
                }
 
-               x += s->get_width ();
+               int ww = 0, wh = 0;
+               s->get_size_request (ww, wh); // widget may not be realized, get_width() is invalid.
+               x += ww;
        }
 
        if (tab.group) {
@@ -99,13 +106,13 @@ MixerGroupTabs::draw_tab (cairo_t* cr, Tab const & tab) const
 {
        double const arc_radius = get_height();
        double r, g, b, a;
-       
+
        if (tab.group && tab.group->is_active()) {
                ArdourCanvas::color_to_rgba (tab.color, r, g, b, a);
        } else {
-               ArdourCanvas::color_to_rgba (ARDOUR_UI::config()->color ("InactiveGroupTab"), r, g, b, a);
+               ArdourCanvas::color_to_rgba (UIConfiguration::instance().color ("inactive group tab"), r, g, b, a);
        }
-       
+
        a = 1.0;
 
        cairo_set_source_rgba (cr, r, g, b, a);
@@ -120,7 +127,7 @@ MixerGroupTabs::draw_tab (cairo_t* cr, Tab const & tab) const
 
                cairo_text_extents_t ext;
                cairo_text_extents (cr, tab.group->name().c_str(), &ext);
-               
+
                ArdourCanvas::Color c = ArdourCanvas::contrasting_text_color (ArdourCanvas::rgba_to_color (r, g, b, a));
                ArdourCanvas::color_to_rgba (c, r, g, b, a);
 
@@ -147,11 +154,16 @@ MixerGroupTabs::routes_for_tab (Tab const * t) const
        TreeModel::Children rows = _mixer->track_model->children ();
        for (TreeModel::Children::iterator i = rows.begin(); i != rows.end(); ++i) {
 
-               MixerStrip* s = (*i)[_mixer->track_columns.strip];
+               AxisView* av = (*i)[_mixer->stripable_columns.strip];
+               MixerStrip* s = dynamic_cast<MixerStrip*> (av);
 
-               if (s->route()->is_master() || s->route()->is_monitor() || !s->marked_for_display()) {
-                       continue;
-               }
+               if (!s) {
+                       continue;
+               }
+
+               if (s->route()->is_master() || s->route()->is_monitor() || !s->marked_for_display()) {
+                       continue;
+               }
 
                if (x >= t->to) {
                        /* tab finishes before this track starts */
@@ -170,26 +182,12 @@ MixerGroupTabs::routes_for_tab (Tab const * t) const
        return routes;
 }
 
-PropertyList
-MixerGroupTabs::default_properties () const
-{
-       PropertyList plist;
-
-       plist.add (Properties::active, true);
-       plist.add (Properties::mute, true);
-       plist.add (Properties::solo, true);
-       plist.add (Properties::gain, true);
-       plist.add (Properties::recenable, true);
-
-       return plist;
-}
-
 RouteList
 MixerGroupTabs::selected_routes () const
 {
        RouteList rl;
-       BOOST_FOREACH (RouteUI* r, _mixer->selection().routes) {
-               boost::shared_ptr<Route> rp = r->route();
+       BOOST_FOREACH (AxisView* r, _mixer->selection().axes) {
+               boost::shared_ptr<Route> rp = boost::dynamic_pointer_cast<Route> (r->stripable());
                if (rp) {
                        rl.push_back (rp);
                }
@@ -197,8 +195,3 @@ MixerGroupTabs::selected_routes () const
        return rl;
 }
 
-void
-MixerGroupTabs::sync_order_keys ()
-{
-       _mixer->sync_order_keys_from_treeview ();
-}