Better choice for ports on external send creation
[ardour.git] / gtk2_ardour / processor_box.cc
index 1c94d0c054fe96c9f862beff8bf44fe26b4d82fe..852acf230f1de0323bf61909ccf2c3005aeb7041 100644 (file)
@@ -86,7 +86,7 @@
 #include "tooltips.h"
 #include "new_plugin_preset_dialog.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 #ifdef AUDIOUNIT_SUPPORT
 class AUPluginUI;
@@ -109,6 +109,7 @@ RefPtr<Action> ProcessorBox::cut_action;
 RefPtr<Action> ProcessorBox::copy_action;
 RefPtr<Action> ProcessorBox::rename_action;
 RefPtr<Action> ProcessorBox::delete_action;
+RefPtr<Action> ProcessorBox::backspace_action;
 RefPtr<Action> ProcessorBox::manage_pins_action;
 RefPtr<Action> ProcessorBox::edit_action;
 RefPtr<Action> ProcessorBox::edit_generic_action;
@@ -168,7 +169,7 @@ ProcessorEntry::ProcessorEntry (ProcessorBox* parent, boost::shared_ptr<Processo
        }
        {
                boost::shared_ptr<PluginInsert> pi = boost::dynamic_pointer_cast<PluginInsert> (_processor);
-               if (pi && pi->plugin() && pi->plugin()->get_info()->type != ARDOUR::Lua) {
+               if (pi && pi->plugin()) {
                        _plugin_preset_pointer = PluginPresetPtr (new PluginPreset (pi->plugin()->get_info()));
                }
        }
@@ -181,11 +182,11 @@ ProcessorEntry::ProcessorEntry (ProcessorBox* parent, boost::shared_ptr<Processo
                boost::shared_ptr<PluginInsert> pi = boost::dynamic_pointer_cast<PluginInsert> (_processor);
                if (pi && pi->plugin() && pi->plugin()->has_inline_display()) {
                        if (pi->plugin()->get_info()->type != ARDOUR::Lua) {
-                               _plugin_display = new PluginDisplay (pi->plugin(),
+                               _plugin_display = new PluginDisplay (*this, pi->plugin(),
                                                std::max (60.f, rintf(112.f * UIConfiguration::instance().get_ui_scale())));
                        } else {
                                assert (boost::dynamic_pointer_cast<LuaProc>(pi->plugin()));
-                               _plugin_display = new LuaPluginDisplay (boost::dynamic_pointer_cast<LuaProc>(pi->plugin()),
+                               _plugin_display = new LuaPluginDisplay (*this, boost::dynamic_pointer_cast<LuaProc>(pi->plugin()),
                                                std::max (60.f, rintf(112.f * UIConfiguration::instance().get_ui_scale())));
                        }
                        _vbox.pack_start (*_plugin_display);
@@ -197,7 +198,7 @@ ProcessorEntry::ProcessorEntry (ProcessorBox* parent, boost::shared_ptr<Processo
                _vbox.pack_end (output_routing_icon);
                _vbox.pack_end (output_icon);
 
-               _button.set_active (_processor->active());
+               _button.set_active (_processor->enabled ());
 
                input_icon.set_no_show_all(true);
                routing_icon.set_no_show_all(true);
@@ -439,11 +440,11 @@ ProcessorEntry::led_clicked(GdkEventButton *ev)
                                _parent->all_visible_processors_active(false);
 
                                if (_position == Fader) {
-                                       _processor->deactivate ();
+                                       _processor->enable (false);
                                }
                        }
                        else {
-                               _processor->deactivate ();
+                               _processor->enable (false);
                        }
 
                } else {
@@ -451,11 +452,11 @@ ProcessorEntry::led_clicked(GdkEventButton *ev)
                                _parent->all_visible_processors_active(true);
 
                                if (_position == Fader) {
-                                       _processor->activate ();
+                                       _processor->enable (true);
                                }
                        }
                        else {
-                               _processor->activate ();
+                               _processor->enable (true);
                        }
                }
        }
@@ -465,7 +466,7 @@ void
 ProcessorEntry::processor_active_changed ()
 {
        if (_processor) {
-               _button.set_active (_processor->active());
+               _button.set_active (_processor->enabled ());
        }
 }
 
@@ -657,7 +658,7 @@ ProcessorEntry::set_control_state (XMLNode const * node)
 
        if (_plugin_display) {
                XMLNode* n = GUIObjectState::get_node (node, X_("InlineDisplay"));
-               XMLProperty* p = n ? n->property (X_("visible")) : NULL;
+               XMLProperty const * p = n ? n->property (X_("visible")) : NULL;
                if (p) {
                        if (string_is_affirmative (p->value ())) {
                                _plugin_display->show();
@@ -947,7 +948,7 @@ ProcessorEntry::Control::set_state (XMLNode const * node)
 {
        XMLNode* n = GUIObjectState::get_node (node, state_id ());
        if (n) {
-               XMLProperty* p = n->property (X_("visible"));
+               XMLProperty const * p = n->property (X_("visible"));
                set_visible (p && string_is_affirmative (p->value ()));
        } else {
                set_visible (false);
@@ -1124,6 +1125,9 @@ ProcessorEntry::RoutingIcon::can_coalesce () const {
        if (_fed_by && _f_out != _f_sources) {
                return false;
        }
+       if (_fed_by && !_f_out_map.is_identity () && !_in_map.is_identity ()) {
+               return false;
+       }
        if (_input && _sinks == _in && (!_fed_by || _f_out == _in)) {
                return true;
        }
@@ -1209,7 +1213,7 @@ ProcessorEntry::RoutingIcon::draw_sidechain (cairo_t* cr, double x0, double y0,
 void
 ProcessorEntry::RoutingIcon::draw_thru_src (cairo_t* cr, double x0, double y0, double height, bool midi)
 {
-       const double rad = 2;
+       const double rad = 1;
        const double y1 = height - rad - 1.5;
 
        cairo_arc (cr, x0, y0 + y1, rad, 0, 2. * M_PI);
@@ -1223,7 +1227,7 @@ ProcessorEntry::RoutingIcon::draw_thru_src (cairo_t* cr, double x0, double y0, d
 void
 ProcessorEntry::RoutingIcon::draw_thru_sink (cairo_t* cr, double x0, double y0, double height, bool midi)
 {
-       const double rad = 2;
+       const double rad = 1;
        const double y1 = rad + 1;
 
        cairo_arc (cr, x0, y0 + y1, rad, 0, 2. * M_PI);
@@ -1421,7 +1425,9 @@ ProcessorEntry::RoutingIcon::expose_output_map (cairo_t* cr, const double width,
                        _i_in_map.get_src (dt, idx, &valid_sink);
                        _i_thru_map.get_src (dt, idx, &valid_thru);
                        if (!valid_thru && !valid_sink) {
-                               continue;
+                               if (!is_midi || i != 0) { // special case midi-bypass
+                                       continue;
+                               }
                        }
                }
                double c_x0 = pin_x_pos (i, width, pc_out, 0, false);
@@ -1443,7 +1449,9 @@ ProcessorEntry::RoutingIcon::expose_output_map (cairo_t* cr, const double width,
                                _i_in_map.get_src (dt, pn, &valid_sink);
                                _i_thru_map.get_src (dt, pn, &valid_thru_f);
                                if (!valid_thru_f && !valid_sink) {
-                                       continue;
+                                       if (!is_midi || i != 0) { // special case midi-bypass
+                                               continue;
+                                       }
                                }
                        }
 
@@ -1500,16 +1508,27 @@ ProcessorEntry::RoutingIcon::expose_output_map (cairo_t* cr, const double width,
        }
 }
 
-ProcessorEntry::PluginDisplay::PluginDisplay (boost::shared_ptr<ARDOUR::Plugin> p, uint32_t max_height)
-       : _plug (p)
+ProcessorEntry::PluginDisplay::PluginDisplay (ProcessorEntry& e, boost::shared_ptr<ARDOUR::Plugin> p, uint32_t max_height)
+       : _entry (e)
+       , _plug (p)
        , _surf (0)
        , _max_height (max_height)
        , _cur_height (1)
        , _scroll (false)
 {
        set_name ("processor prefader");
+       add_events (Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK);
        _plug->QueueDraw.connect (_qdraw_connection, invalidator (*this),
                        boost::bind (&Gtk::Widget::queue_draw, this), gui_context ());
+
+       std::string postfix = "";
+       if (_plug->has_editor()) {
+               ARDOUR_UI_UTILS::set_tooltip (*this,
+                               string_compose (_("<b>%1</b>\nDouble-click to show GUI.\n%2+double-click to show generic GUI.%3"), e.name (Wide), Keyboard::primary_modifier_name (), postfix));
+       } else {
+               ARDOUR_UI_UTILS::set_tooltip (*this,
+                               string_compose (_("<b>%1</b>\nDouble-click to show generic GUI.%2"), e.name (Wide), postfix));
+       }
 }
 
 ProcessorEntry::PluginDisplay::~PluginDisplay ()
@@ -1519,8 +1538,33 @@ ProcessorEntry::PluginDisplay::~PluginDisplay ()
        }
 }
 
+bool
+ProcessorEntry::PluginDisplay::on_button_press_event (GdkEventButton *ev)
+{
+       assert (_entry.processor ());
+
+       // consider some tweaks to pass this up to the DnDVBox somehow:
+       // select processor, then call (private)
+       //_entry._parent->processor_button_press_event (ev, &_entry);
+       if (Keyboard::is_edit_event (ev) || (ev->button == 1 && ev->type == GDK_2BUTTON_PRESS)) {
+               if (Keyboard::modifier_state_equals (ev->state, Keyboard::SecondaryModifier)) {
+                       _entry._parent->generic_edit_processor (_entry.processor ());
+               } else {
+                       _entry._parent->edit_processor (_entry.processor ());
+               }
+               return true;
+       }
+       return false;
+}
+
+bool
+ProcessorEntry::PluginDisplay::on_button_release_event (GdkEventButton *ev)
+{
+       return false;
+}
+
 void
-ProcessorEntry::PluginDisplay::on_size_request (Gtk::Requisition* req)
+ProcessorEntry::PluginDisplay::on_size_request (Requisition* req)
 {
        req->width = 56;
        req->height = _cur_height;
@@ -1594,6 +1638,7 @@ ProcessorEntry::PluginDisplay::render_inline (cairo_t* cr, uint32_t width)
                }
        }
 
+       cairo_surface_flush(_surf);
        cairo_surface_mark_dirty(_surf);
        const double xc = floor ((width - dis->width) * .5);
        cairo_set_source_surface(cr, _surf, xc, 0);
@@ -1653,8 +1698,8 @@ ProcessorEntry::PluginDisplay::on_expose_event (GdkEventExpose* ev)
        return true;
 }
 
-ProcessorEntry::LuaPluginDisplay::LuaPluginDisplay (boost::shared_ptr<ARDOUR::LuaProc> p, uint32_t max_height)
-       : PluginDisplay (p, max_height)
+ProcessorEntry::LuaPluginDisplay::LuaPluginDisplay (ProcessorEntry& e, boost::shared_ptr<ARDOUR::LuaProc> p, uint32_t max_height)
+       : PluginDisplay (e, p, max_height)
        , _luaproc (p)
        , _lua_render_inline (0)
 {
@@ -1683,7 +1728,9 @@ ProcessorEntry::LuaPluginDisplay::render_inline (cairo_t *cr, uint32_t width)
                        return h;
                }
        } catch (luabridge::LuaException const& e) {
-               ;
+#ifndef NDEBUG
+               cerr << "LuaException:" << e.what () << endl;
+#endif
        }
        return 0;
 }
@@ -1694,7 +1741,7 @@ static std::list<Gtk::TargetEntry> drop_targets()
        std::list<Gtk::TargetEntry> tmp;
        tmp.push_back (Gtk::TargetEntry ("processor")); // from processor-box to processor-box
        tmp.push_back (Gtk::TargetEntry ("PluginInfoPtr")); // from plugin-manager
-       tmp.push_back (Gtk::TargetEntry ("PluginPresetPtr")); // from sidebar
+       tmp.push_back (Gtk::TargetEntry ("PluginFavoritePtr")); // from sidebar
        return tmp;
 }
 
@@ -1864,7 +1911,7 @@ ProcessorBox::_drop_plugin_preset (Gtk::SelectionData const &data, Route::Proces
 
                        boost::shared_ptr<Processor> processor (new PluginInsert (*_session, p));
                        if (Config->get_new_plugins_active ()) {
-                               processor->activate ();
+                               processor->enable (true);
                        }
                        pl.push_back (processor);
                }
@@ -1887,7 +1934,7 @@ ProcessorBox::_drop_plugin (Gtk::SelectionData const &data, Route::ProcessorList
                        }
                        boost::shared_ptr<Processor> processor (new PluginInsert (*_session, p));
                        if (Config->get_new_plugins_active ()) {
-                               processor->activate ();
+                               processor->enable (true);
                        }
                        pl.push_back (processor);
                }
@@ -1906,7 +1953,7 @@ ProcessorBox::plugin_drop (Gtk::SelectionData const &data, ProcessorEntry* posit
        if (data.get_target() == "PluginInfoPtr") {
                _drop_plugin (data, pl);
        }
-       else if (data.get_target() == "PluginPresetPtr") {
+       else if (data.get_target() == "PluginFavoritePtr") {
                _drop_plugin_preset (data, pl);
        }
        else {
@@ -2085,19 +2132,22 @@ ProcessorBox::show_processor_menu (int arg)
                }
        }
 
-       Gtk::MenuItem* send_menu_item = dynamic_cast<Gtk::MenuItem*>(ActionManager::get_widget("/ProcessorMenu/send_options"));
-       if (send_menu_item) {
-               if (single_selection && !_route->is_monitor()) {
-                       Menu* m = single_selection->build_send_options_menu ();
-                       if (m && !m->items().empty()) {
-                               send_menu_item->set_submenu (*m);
-                               send_menu_item->set_sensitive (true);
+
+       if (!ARDOUR::Profile->get_mixbus()) {
+               Gtk::MenuItem* send_menu_item = dynamic_cast<Gtk::MenuItem*>(ActionManager::get_widget("/ProcessorMenu/send_options"));
+               if (send_menu_item) {
+                       if (single_selection && !_route->is_monitor()) {
+                               Menu* m = single_selection->build_send_options_menu ();
+                               if (m && !m->items().empty()) {
+                                       send_menu_item->set_submenu (*m);
+                                       send_menu_item->set_sensitive (true);
+                               } else {
+                                       gtk_menu_item_set_submenu (send_menu_item->gobj(), 0);
+                                       send_menu_item->set_sensitive (false);
+                               }
                        } else {
-                               gtk_menu_item_set_submenu (send_menu_item->gobj(), 0);
                                send_menu_item->set_sensitive (false);
                        }
-               } else {
-                       send_menu_item->set_sensitive (false);
                }
        }
 
@@ -2110,6 +2160,7 @@ ProcessorBox::show_processor_menu (int arg)
        cut_action->set_sensitive (sensitive && can_cut ());
        copy_action->set_sensitive (sensitive);
        delete_action->set_sensitive (sensitive || stub_processor_selected ());
+       backspace_action->set_sensitive (sensitive || stub_processor_selected ());
 
        edit_action->set_sensitive (one_processor_can_be_edited ());
        edit_generic_action->set_sensitive (one_processor_can_be_edited ());
@@ -2232,11 +2283,7 @@ ProcessorBox::processor_operation (ProcessorOperation op)
 
        case ProcessorsToggleActive:
                for (ProcSelection::iterator i = targets.begin(); i != targets.end(); ++i) {
-                       if ((*i)->active()) {
-                               (*i)->deactivate ();
-                       } else {
-                               (*i)->activate ();
-                       }
+                       (*i)->enable (!(*i)->enabled ());
                }
                break;
 
@@ -2328,12 +2375,7 @@ ProcessorBox::processor_button_release_event (GdkEventButton *ev, ProcessorEntry
                ) {
 
                /* button2-click with no/appropriate modifiers */
-
-               if (processor->active()) {
-                       processor->deactivate ();
-               } else {
-                       processor->activate ();
-               }
+               processor->enable (!processor->enabled ());
        }
 
        return false;
@@ -2365,49 +2407,6 @@ ProcessorBox::choose_plugin ()
        _get_plugin_selector()->set_interested_object (*this);
 }
 
-/** @return true if an error occurred, otherwise false */
-bool
-ProcessorBox::choose_lua ()
-{
-       LuaScriptInfoPtr spi;
-
-       ScriptSelector ss (_("Add Lua DSP Processor"), LuaScriptInfo::DSP);
-       switch (ss.run ()) {
-               case Gtk::RESPONSE_ACCEPT:
-                       spi = ss.script();
-                       break;
-               default:
-                       return true;
-       }
-       ss.hide ();
-
-       PluginPtr p;
-       try {
-               LuaPluginInfoPtr lpi (new LuaPluginInfo(spi));
-               p = (lpi->load (*_session));
-       } catch (...) {
-               string msg = _(
-                               "Failed to instantiate Lua DSP Processor,\n"
-                               "probably because the script is invalid (no dsp function).");
-               MessageDialog am (msg);
-               am.run ();
-               return true;
-       }
-
-       boost::shared_ptr<Processor> processor (new PluginInsert (*_session, p));
-
-       Route::ProcessorStreams err_streams;
-       if (_route->add_processor_by_index (processor, _placement, &err_streams, Config->get_new_plugins_active ())) {
-               string msg = _(
-                               "Failed to add Lua DSP Processor at the given position,\n"
-                               "probably because the I/O configuration of the plugins\n"
-                               "could not match the configuration of this track.");
-               MessageDialog am (msg);
-               am.run ();
-       }
-       return false;
-}
-
 /** @return true if an error occurred, otherwise false */
 bool
 ProcessorBox::use_plugins (const SelectedPlugins& plugins)
@@ -2497,7 +2496,7 @@ ProcessorBox::choose_send ()
        boost::shared_ptr<Send> send (new Send (*_session, _route->pannable (), _route->mute_master()));
 
        /* make an educated guess at the initial number of outputs for the send */
-       ChanCount outs = (_session->master_out())
+       ChanCount outs = (_route->n_outputs().n_audio() && _session->master_out())
                        ? _session->master_out()->n_outputs()
                        : _route->n_outputs();
 
@@ -2702,12 +2701,6 @@ ProcessorBox::maybe_add_processor_pin_mgr (boost::weak_ptr<Processor> w)
                wp->set_state (*ui_xml, 0);
        }
 
-       void* existing_ui = p->get_ui ();
-
-       if (existing_ui) {
-               wp->use_window (*(reinterpret_cast<Gtk::Window*>(existing_ui)));
-       }
-
        p->set_pingmgr_proxy (wp);
        WM::Manager::instance().register_window (wp);
 }
@@ -2921,9 +2914,9 @@ ProcessorBox::setup_routing_feeds ()
                        }
                } else {
                        (*i)->output_routing_icon.set_terminal(false);
-                       if (!(*i)->routing_icon.out_identity ()
-                                       && !(*i)->routing_icon.in_identity ()
-                                       && (*i)->routing_icon.can_coalesce ()) {
+                       if (   !(*i)->routing_icon.out_identity ()
+                                       && !(*next)->routing_icon.in_identity ()
+                                       &&  (*next)->routing_icon.can_coalesce ()) {
                                (*i)->output_routing_icon.hide();
                        } else if (!(*i)->routing_icon.out_identity ()) {
                                (*i)->output_routing_icon.show();
@@ -3648,8 +3641,6 @@ ProcessorBox::register_actions ()
        myactions.register_action (processor_box_actions, X_("newplugin"), _("New Plugin"),
                        sigc::ptr_fun (ProcessorBox::rb_choose_plugin));
 
-       act = myactions.register_action (processor_box_actions, X_("newlua"), _("New Lua DSP"),
-                       sigc::ptr_fun (ProcessorBox::rb_choose_lua));
        act = myactions.register_action (processor_box_actions, X_("newinsert"), _("New Insert"),
                        sigc::ptr_fun (ProcessorBox::rb_choose_insert));
        ActionManager::engine_sensitive_actions.push_back (act);
@@ -3677,10 +3668,13 @@ ProcessorBox::register_actions ()
                                                             sigc::ptr_fun (ProcessorBox::rb_copy));
        delete_action = myactions.register_action (processor_box_actions, X_("delete"), _("Delete"),
                                                               sigc::ptr_fun (ProcessorBox::rb_delete));
+       backspace_action = myactions.register_action (processor_box_actions, X_("backspace"), _("Delete"),
+                                                              sigc::ptr_fun (ProcessorBox::rb_delete));
 
        ActionManager::plugin_selection_sensitive_actions.push_back (cut_action);
        ActionManager::plugin_selection_sensitive_actions.push_back (copy_action);
        ActionManager::plugin_selection_sensitive_actions.push_back (delete_action);
+       ActionManager::plugin_selection_sensitive_actions.push_back (backspace_action);
 
        paste_action = myactions.register_action (processor_box_actions, X_("paste"), _("Paste"),
                        sigc::ptr_fun (ProcessorBox::rb_paste));
@@ -3754,15 +3748,6 @@ ProcessorBox::rb_choose_plugin ()
        _current_processor_box->choose_plugin ();
 }
 
-void
-ProcessorBox::rb_choose_lua ()
-{
-       if (_current_processor_box == 0) {
-               return;
-       }
-       _current_processor_box->choose_lua ();
-}
-
 void
 ProcessorBox::rb_choose_insert ()
 {
@@ -3947,6 +3932,9 @@ ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
        if (edit_aux_send (processor)) {
                return;
        }
+       if (!_session->engine().connected()) {
+               return;
+       }
 
        ProcessorWindowProxy* proxy = find_window_proxy (processor);
 
@@ -3965,6 +3953,9 @@ ProcessorBox::generic_edit_processor (boost::shared_ptr<Processor> processor)
        if (edit_aux_send (processor)) {
                return;
        }
+       if (!_session->engine().connected()) {
+               return;
+       }
 
        ProcessorWindowProxy* proxy = find_window_proxy (processor);
 
@@ -4207,7 +4198,7 @@ ProcessorWindowProxy::set_state (const XMLNode& node, int /*version*/)
        XMLNodeList children = node.children ();
        XMLNodeList::const_iterator i = children.begin ();
        while (i != children.end()) {
-               XMLProperty* prop = (*i)->property (X_("name"));
+               XMLProperty const * prop = (*i)->property (X_("name"));
                if ((*i)->name() == X_("Window") && prop && prop->value() == _name) {
                        break;
                }
@@ -4215,7 +4206,7 @@ ProcessorWindowProxy::set_state (const XMLNode& node, int /*version*/)
        }
 
        if (i != children.end()) {
-               XMLProperty* prop;
+               XMLProperty const * prop;
                if ((prop = (*i)->property (X_("custom-ui"))) != 0) {
                        want_custom = PBD::string_is_affirmative (prop->value ());
                }
@@ -4248,8 +4239,8 @@ ProcessorWindowProxy::get (bool create)
                if (_window) {
                        setup ();
                }
+               _window->show_all ();
        }
-       _window->show_all ();
        return _window;
 }
 
@@ -4259,12 +4250,7 @@ ProcessorWindowProxy::show_the_right_window ()
        if (_window && (is_custom != want_custom)) {
                /* drop existing window - wrong type */
                drop_window ();
-               get (true);
-               setup ();
-               assert (_window);
-               is_custom = want_custom;
        }
-
        toggle ();
 }
 
@@ -4311,9 +4297,8 @@ PluginPinWindowProxy::get (bool create)
                if (aw) {
                        aw->set_session (_session);
                }
+               _window->show_all ();
        }
-
-       _window->show_all ();
        return _window;
 }