Better choice for ports on external send creation
[ardour.git] / gtk2_ardour / processor_box.cc
index ff6731e6e7f955755726e6620c41ec81f09ddd31..852acf230f1de0323bf61909ccf2c3005aeb7041 100644 (file)
@@ -86,7 +86,7 @@
 #include "tooltips.h"
 #include "new_plugin_preset_dialog.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 #ifdef AUDIOUNIT_SUPPORT
 class AUPluginUI;
@@ -109,6 +109,7 @@ RefPtr<Action> ProcessorBox::cut_action;
 RefPtr<Action> ProcessorBox::copy_action;
 RefPtr<Action> ProcessorBox::rename_action;
 RefPtr<Action> ProcessorBox::delete_action;
+RefPtr<Action> ProcessorBox::backspace_action;
 RefPtr<Action> ProcessorBox::manage_pins_action;
 RefPtr<Action> ProcessorBox::edit_action;
 RefPtr<Action> ProcessorBox::edit_generic_action;
@@ -168,7 +169,7 @@ ProcessorEntry::ProcessorEntry (ProcessorBox* parent, boost::shared_ptr<Processo
        }
        {
                boost::shared_ptr<PluginInsert> pi = boost::dynamic_pointer_cast<PluginInsert> (_processor);
-               if (pi && pi->plugin() && pi->plugin()->get_info()->type != ARDOUR::Lua) {
+               if (pi && pi->plugin()) {
                        _plugin_preset_pointer = PluginPresetPtr (new PluginPreset (pi->plugin()->get_info()));
                }
        }
@@ -181,11 +182,11 @@ ProcessorEntry::ProcessorEntry (ProcessorBox* parent, boost::shared_ptr<Processo
                boost::shared_ptr<PluginInsert> pi = boost::dynamic_pointer_cast<PluginInsert> (_processor);
                if (pi && pi->plugin() && pi->plugin()->has_inline_display()) {
                        if (pi->plugin()->get_info()->type != ARDOUR::Lua) {
-                               _plugin_display = new PluginDisplay (pi->plugin(),
+                               _plugin_display = new PluginDisplay (*this, pi->plugin(),
                                                std::max (60.f, rintf(112.f * UIConfiguration::instance().get_ui_scale())));
                        } else {
                                assert (boost::dynamic_pointer_cast<LuaProc>(pi->plugin()));
-                               _plugin_display = new LuaPluginDisplay (boost::dynamic_pointer_cast<LuaProc>(pi->plugin()),
+                               _plugin_display = new LuaPluginDisplay (*this, boost::dynamic_pointer_cast<LuaProc>(pi->plugin()),
                                                std::max (60.f, rintf(112.f * UIConfiguration::instance().get_ui_scale())));
                        }
                        _vbox.pack_start (*_plugin_display);
@@ -197,10 +198,12 @@ ProcessorEntry::ProcessorEntry (ProcessorBox* parent, boost::shared_ptr<Processo
                _vbox.pack_end (output_routing_icon);
                _vbox.pack_end (output_icon);
 
-               _button.set_active (_processor->active());
+               _button.set_active (_processor->enabled ());
 
-               routing_icon.set_no_show_all(true);
                input_icon.set_no_show_all(true);
+               routing_icon.set_no_show_all(true);
+               output_icon.set_no_show_all(true);
+               output_routing_icon.set_no_show_all(true);
 
                _button.show ();
                input_icon.hide();
@@ -379,6 +382,13 @@ ProcessorEntry::setup_visuals ()
                _button.set_name ("processor stub");
                return;
        }
+       boost::shared_ptr<Send> send;
+       if ((send = boost::dynamic_pointer_cast<Send> (_processor))) {
+               if (send->remove_on_disconnect ()) {
+                       _button.set_name ("processor sidechain");
+                       return;
+               }
+       }
 
        switch (_position) {
        case PreFader:
@@ -430,11 +440,11 @@ ProcessorEntry::led_clicked(GdkEventButton *ev)
                                _parent->all_visible_processors_active(false);
 
                                if (_position == Fader) {
-                                       _processor->deactivate ();
+                                       _processor->enable (false);
                                }
                        }
                        else {
-                               _processor->deactivate ();
+                               _processor->enable (false);
                        }
 
                } else {
@@ -442,11 +452,11 @@ ProcessorEntry::led_clicked(GdkEventButton *ev)
                                _parent->all_visible_processors_active(true);
 
                                if (_position == Fader) {
-                                       _processor->activate ();
+                                       _processor->enable (true);
                                }
                        }
                        else {
-                               _processor->activate ();
+                               _processor->enable (true);
                        }
                }
        }
@@ -456,7 +466,7 @@ void
 ProcessorEntry::processor_active_changed ()
 {
        if (_processor) {
-               _button.set_active (_processor->active());
+               _button.set_active (_processor->enabled ());
        }
 }
 
@@ -504,6 +514,16 @@ ProcessorEntry::setup_tooltip ()
                                        string_compose (_("<b>%1</b>\nThe Plugin is not available on this system\nand has been replaced by a stub."), name (Wide)));
                        return;
                }
+               boost::shared_ptr<Send> send;
+               if ((send = boost::dynamic_pointer_cast<Send> (_processor)) != 0 &&
+                               !boost::dynamic_pointer_cast<InternalSend>(_processor)) {
+                       if (send->remove_on_disconnect ()) {
+                               ARDOUR_UI_UTILS::set_tooltip (_button, string_compose ("<b>&gt; %1</b>\nThis (sidechain) send will be removed when disconnected.", _processor->name()));
+                       } else {
+                               ARDOUR_UI_UTILS::set_tooltip (_button, string_compose ("<b>&gt; %1</b>", _processor->name()));
+                       }
+                       return;
+               }
        }
        ARDOUR_UI_UTILS::set_tooltip (_button, string_compose ("<b>%1</b>", name (Wide)));
 }
@@ -522,19 +542,52 @@ ProcessorEntry::name (Width w) const
            !boost::dynamic_pointer_cast<InternalSend>(_processor)) {
 
                name_display += '>';
+               std::string send_name;
+               bool pretty_ok = true;
+
+               if (send->remove_on_disconnect ()) {
+                       // assume it's a sidechain, find pretty name of connected port(s)
+                       PortSet& ps (send->output ()->ports ());
+                       for (PortSet::iterator i = ps.begin (); i != ps.end () && pretty_ok; ++i) {
+                               vector<string> connections;
+                               if (i->get_connections (connections)) {
+                                       vector<string>::const_iterator ci;
+                                       for (ci = connections.begin(); ci != connections.end(); ++ci) {
+                                               std::string pn = AudioEngine::instance()->get_pretty_name_by_name (*ci);
+                                               if (pn.empty ()) {
+                                                       continue;
+                                               }
+                                               if (send_name.empty ()) {
+                                                       send_name = pn;
+                                               } else if (send_name != pn) {
+                                                       // pretty names don't match
+                                                       pretty_ok = false;
+                                                       break;
+                                               }
+                                       }
+                               }
+                       }
+               }
 
-               /* grab the send name out of its overall name */
+               if (!pretty_ok) {
+                       send_name = "";
+               }
 
-               string::size_type lbracket, rbracket;
-               lbracket = send->name().find ('[');
-               rbracket = send->name().find (']');
+               /* grab the send name out of its overall name */
+               if (send_name.empty()) {
+                       send_name = send->name();
+                       string::size_type lbracket, rbracket;
+                       lbracket = send_name.find ('[');
+                       rbracket = send_name.find (']');
+                       send_name = send_name.substr (lbracket+1, lbracket-rbracket-1);
+               }
 
                switch (w) {
                case Wide:
-                       name_display += send->name().substr (lbracket+1, lbracket-rbracket-1);
+                       name_display += send_name;
                        break;
                case Narrow:
-                       name_display += PBD::short_version (send->name().substr (lbracket+1, lbracket-rbracket-1), 4);
+                       name_display += PBD::short_version (send_name, 5);
                        break;
                }
 
@@ -605,7 +658,7 @@ ProcessorEntry::set_control_state (XMLNode const * node)
 
        if (_plugin_display) {
                XMLNode* n = GUIObjectState::get_node (node, X_("InlineDisplay"));
-               XMLProperty* p = n ? n->property (X_("visible")) : NULL;
+               XMLProperty const * p = n ? n->property (X_("visible")) : NULL;
                if (p) {
                        if (string_is_affirmative (p->value ())) {
                                _plugin_display->show();
@@ -895,7 +948,7 @@ ProcessorEntry::Control::set_state (XMLNode const * node)
 {
        XMLNode* n = GUIObjectState::get_node (node, state_id ());
        if (n) {
-               XMLProperty* p = n->property (X_("visible"));
+               XMLProperty const * p = n->property (X_("visible"));
                set_visible (p && string_is_affirmative (p->value ()));
        } else {
                set_visible (false);
@@ -988,19 +1041,11 @@ ProcessorEntry::PortIcon::on_expose_event (GdkEventExpose* ev)
        cairo_fill (cr);
 
        const double dx = rint(max(2., 2. * UIConfiguration::instance().get_ui_scale()));
-       if (_ports.n_total() > 1) {
-               for (uint32_t i = 0; i < _ports.n_total(); ++i) {
-                       set_routing_color (cr, i < _ports.n_midi());
-                       const float x = rintf(width * (.2f + .6f * i / (_ports.n_total() - 1.f)));
-                       cairo_rectangle (cr, x-dx * .5, 0, 1+dx, height);
-                       cairo_fill(cr);
-               }
-       } else if (_ports.n_total() == 1) {
-               set_routing_color (cr, _ports.n_midi() == 1);
-               const float x = rintf(width * .5);
-               cairo_rectangle (cr, x-dx * .5, 0, 1+dx, height);
+       for (uint32_t i = 0; i < _ports.n_total(); ++i) {
+               set_routing_color (cr, i < _ports.n_midi());
+               const double x = ProcessorEntry::RoutingIcon::pin_x_pos (i, width, _ports.n_total(), 0 , false);
+               cairo_rectangle (cr, x - .5 - dx * .5, 0, 1 + dx, height);
                cairo_fill(cr);
-               cairo_stroke(cr);
        }
 
        cairo_destroy(cr);
@@ -1008,14 +1053,20 @@ ProcessorEntry::PortIcon::on_expose_event (GdkEventExpose* ev)
 }
 
 ProcessorEntry::RoutingIcon::RoutingIcon (bool input)
-       : _feed (false)
+       : _fed_by (false)
        , _input (input)
 {
-       if (input) {
-               set_size_request (-1, std::max (7.f, rintf(8.f * UIConfiguration::instance().get_ui_scale())));
-       } else {
-               set_size_request (-1, std::max (10.f, rintf(12.f * UIConfiguration::instance().get_ui_scale())));
+       set_terminal (false);
+}
+
+void
+ProcessorEntry::RoutingIcon::set_terminal (bool b) {
+       _terminal = b;
+       int h = std::max (8.f, rintf(8.f * sqrt (UIConfiguration::instance().get_ui_scale())));
+       if (_terminal) {
+               h += std::max (4.f, rintf(4.f * sqrt (UIConfiguration::instance().get_ui_scale())));
        }
+       set_size_request (-1, h);
 }
 
 void
@@ -1038,40 +1089,53 @@ ProcessorEntry::RoutingIcon::set (
 }
 
 bool
-ProcessorEntry::RoutingIcon::identity () const {
-       if (!_in_map.is_monotonic () || !_in_map.is_identity ()) {
+ProcessorEntry::RoutingIcon::in_identity () const {
+       if (_thru_map.n_total () > 0) {
                return false;
        }
-       if (_in_map.count () != _sinks.n_total () || _in.n_total () != _sinks.n_total ()) {
+       if (!_in_map.is_monotonic () || !_in_map.is_identity ()) {
                return false;
        }
-       if (_feed) {
-               if (!_f_out_map.is_monotonic () || !_f_out_map.is_identity ()) {
-                       return false;
-               }
-               if (_f_out_map.count () != _f_sources.n_total () || _sinks != _f_sources) {
-                       return false;
-               }
+       if (_in_map.n_total () != _sinks.n_total () || _in.n_total () != _sinks.n_total ()) {
+               return false;
        }
        return true;
 }
 
 bool
 ProcessorEntry::RoutingIcon::out_identity () const {
-       if (!_out_map.is_monotonic () || !_out_map.is_identity ()) {
+       if (_thru_map.n_total () > 0) {
+               // TODO skip if trhu is not connected to any of next's inputs
                return false;
        }
-       if (_out_map.count () != _sources.n_total () || _out.n_total () != _sources.n_total ()) {
+       if (!_out_map.is_monotonic () || !_out_map.is_identity ()) {
                return false;
        }
-       if (_thru_map.count () > 0) {
+       if (_out_map.n_total () != _sources.n_total () || _out.n_total () != _sources.n_total ()) {
                return false;
        }
        return true;
 }
 
+bool
+ProcessorEntry::RoutingIcon::can_coalesce () const {
+       if (_thru_map.n_total () > 0) {
+               return false;
+       }
+       if (_fed_by && _f_out != _f_sources) {
+               return false;
+       }
+       if (_fed_by && !_f_out_map.is_identity () && !_in_map.is_identity ()) {
+               return false;
+       }
+       if (_input && _sinks == _in && (!_fed_by || _f_out == _in)) {
+               return true;
+       }
+       return false;
+}
+
 void
-ProcessorEntry::RoutingIcon::set_feed (
+ProcessorEntry::RoutingIcon::set_fed_by (
                                const ARDOUR::ChanCount& out,
                                const ARDOUR::ChanCount& sources,
                                const ARDOUR::ChanMapping& out_map,
@@ -1081,7 +1145,21 @@ ProcessorEntry::RoutingIcon::set_feed (
        _f_sources  = sources;
        _f_out_map  = out_map;
        _f_thru_map = thru_map;
-       _feed       = true;
+       _fed_by     = true;
+}
+
+void
+ProcessorEntry::RoutingIcon::set_feeding (
+                               const ARDOUR::ChanCount& in,
+                               const ARDOUR::ChanCount& sinks,
+                               const ARDOUR::ChanMapping& in_map,
+                               const ARDOUR::ChanMapping& thru_map)
+{
+       _i_in       = in;
+       _i_sinks    = sinks;
+       _i_in_map   = in_map;
+       _i_thru_map = thru_map;
+       _feeding    = true;
 }
 
 double
@@ -1092,75 +1170,72 @@ ProcessorEntry::RoutingIcon::pin_x_pos (uint32_t i, double width, uint32_t n_tot
                assert (i == 0);
                return rint (width * .5) +.5;
        }
-       return rint (width * (.2 + .6 * i / (n_total - 1))) + .5;
+       return rint (width * (.15 + .7 * i / (n_total - 1))) + .5;
 }
 
 void
-ProcessorEntry::RoutingIcon::draw_X (cairo_t* cr, double x0, double height, bool midi)
+ProcessorEntry::RoutingIcon::draw_gnd (cairo_t* cr, double x0, double y0, double height, bool midi)
 {
-       const double y0 = rint (height * .4) + .5;
-       const double dx = min (y0 - .5, 1. + rint (max(2., 2. * UIConfiguration::instance().get_ui_scale())));
+       const double dx = 1 + rint (max(2., 2. * UIConfiguration::instance().get_ui_scale()));
+       const double y1 = rint (height * .66) + .5;
 
-       cairo_move_to (cr, x0, 0);
-       cairo_line_to (cr, x0, y0);
-       cairo_move_to (cr, x0 - dx, y0 - dx);
-       cairo_line_to (cr, x0 + dx, y0 + dx);
-       cairo_move_to (cr, x0 - dx, y0 + dx);
-       cairo_line_to (cr, x0 + dx, y0 - dx);
+       cairo_save (cr);
+       cairo_translate (cr, x0, y0);
+       cairo_move_to (cr, 0, height);
+       cairo_line_to (cr, 0, y1);
+       cairo_move_to (cr, 0 - dx, y1);
+       cairo_line_to (cr, 0 + dx, y1);
 
        set_routing_color (cr, midi);
-       cairo_set_line_width  (cr, 1.0);
-       cairo_stroke_preserve (cr);
-       cairo_set_source_rgba (cr, 0, 0, 0, .4); // darken
+       cairo_set_line_width (cr, 1.0);
        cairo_stroke (cr);
+       cairo_restore (cr);
 }
 
 void
-ProcessorEntry::RoutingIcon::draw_gnd (cairo_t* cr, double x0, double height, bool midi)
+ProcessorEntry::RoutingIcon::draw_sidechain (cairo_t* cr, double x0, double y0, double height, bool midi)
 {
        const double dx = 1 + rint (max(2., 2. * UIConfiguration::instance().get_ui_scale()));
-       const double y0 = rint (height * .66) + .5;
+       const double y1 = rint (height * .5) - .5;
 
-       cairo_move_to (cr, x0, height);
-       cairo_line_to (cr, x0, y0);
-       cairo_move_to (cr, x0 - dx, y0);
-       cairo_line_to (cr, x0 + dx, y0);
+       cairo_save (cr);
+       cairo_translate (cr, x0, y0);
+       cairo_move_to (cr, 0 - dx, height);
+       cairo_line_to (cr, 0, y1);
+       cairo_line_to (cr, 0 + dx, height);
+       cairo_close_path (cr);
 
        set_routing_color (cr, midi);
-       cairo_set_line_width  (cr, 1.0);
-       cairo_stroke (cr);
+       cairo_fill (cr);
+       cairo_restore (cr);
 }
 
 void
-ProcessorEntry::RoutingIcon::draw_sidechain (cairo_t* cr, double x0, double height, bool midi)
+ProcessorEntry::RoutingIcon::draw_thru_src (cairo_t* cr, double x0, double y0, double height, bool midi)
 {
-       const double dx = 1 + rint (max(2., 2. * UIConfiguration::instance().get_ui_scale()));
-       const double y0 = rint (height * .66) + .5;
-
-       cairo_move_to (cr, x0 - dx, height);
-       cairo_line_to (cr, x0, y0);
-       cairo_line_to (cr, x0 + dx, height);
-       cairo_close_path (cr);
+       const double rad = 1;
+       const double y1 = height - rad - 1.5;
 
+       cairo_arc (cr, x0, y0 + y1, rad, 0, 2. * M_PI);
+       cairo_move_to (cr, x0, y0 + height - 1.5);
+       cairo_line_to (cr, x0, y0 + height);
        set_routing_color (cr, midi);
        cairo_set_line_width  (cr, 1.0);
        cairo_stroke (cr);
 }
 
 void
-ProcessorEntry::RoutingIcon::draw_thru (cairo_t* cr, double x0, double height, bool midi)
+ProcessorEntry::RoutingIcon::draw_thru_sink (cairo_t* cr, double x0, double y0, double height, bool midi)
 {
-       const double dx = 1 + rint (max(2., 2. * UIConfiguration::instance().get_ui_scale()));
-       const double y0 = rint (height * .5) - .5;
-
-       cairo_move_to (cr, x0 - dx, y0);
-       cairo_line_to (cr, x0, height);
-       cairo_line_to (cr, x0 + dx, y0);
-       cairo_close_path (cr);
+       const double rad = 1;
+       const double y1 = rad + 1;
 
+       cairo_arc (cr, x0, y0 + y1, rad, 0, 2. * M_PI);
+       cairo_move_to (cr, x0, y0);
+       cairo_line_to (cr, x0, y0 + 1);
        set_routing_color (cr, midi);
        cairo_set_line_width  (cr, 1.0);
-       cairo_fill (cr);
+       cairo_stroke (cr);
 }
 
 void
@@ -1192,7 +1267,6 @@ ProcessorEntry::RoutingIcon::on_expose_event (GdkEventExpose* ev)
        cairo_rectangle (cr, ev->area.x, ev->area.y, ev->area.width, ev->area.height);
        cairo_clip (cr);
 
-       cairo_set_line_width (cr, max (1.f, UIConfiguration::instance().get_ui_scale()));
        cairo_set_line_cap (cr, CAIRO_LINE_CAP_ROUND);
 
        Gtk::Allocation a = get_allocation();
@@ -1206,7 +1280,11 @@ ProcessorEntry::RoutingIcon::on_expose_event (GdkEventExpose* ev)
        cairo_fill (cr);
 
        if (_input) {
-               expose_input_map (cr, width, height);
+               if (can_coalesce ()) {
+                       expose_coalesced_input_map (cr, width, height);
+               } else {
+                       expose_input_map (cr, width, height);
+               }
        } else {
                expose_output_map (cr, width, height);
        }
@@ -1216,14 +1294,11 @@ ProcessorEntry::RoutingIcon::on_expose_event (GdkEventExpose* ev)
 }
 
 void
-ProcessorEntry::RoutingIcon::expose_input_map (cairo_t* cr, const double width, const double height)
+ProcessorEntry::RoutingIcon::expose_coalesced_input_map (cairo_t* cr, const double width, const double height)
 {
        const uint32_t pc_in = _sinks.n_total();
        const uint32_t pc_in_midi = _sinks.n_midi();
 
-       // TODO indicate midi-bypass ??
-       // TODO indicate side-chain
-
        for (uint32_t i = 0; i < pc_in; ++i) {
                const bool is_midi = i < pc_in_midi;
                bool valid_in;
@@ -1232,19 +1307,19 @@ ProcessorEntry::RoutingIcon::expose_input_map (cairo_t* cr, const double width,
                uint32_t idx = _in_map.get (dt, pn, &valid_in);
                if (!valid_in) {
                        double x = pin_x_pos (i, width, pc_in, 0, is_midi);
-                       draw_gnd (cr, x, height, is_midi);
+                       draw_gnd (cr, x, 0, height, is_midi);
                        continue;
                }
                if (idx >= _in.get (dt)) {
                        // side-chain, probably
                        double x = pin_x_pos (i, width, pc_in, 0, is_midi);
-                       draw_sidechain (cr, x, height, is_midi);
+                       draw_sidechain (cr, x, 0, height, is_midi);
                        continue;
                }
                double c_x0;
                double c_x1 = pin_x_pos (i, width, pc_in, 0, false);
 
-               if (_feed) {
+               if (_fed_by) {
                        bool valid_src;
                        uint32_t src = _f_out_map.get_src (dt, idx, &valid_src);
                        if (!valid_src) {
@@ -1252,9 +1327,9 @@ ProcessorEntry::RoutingIcon::expose_input_map (cairo_t* cr, const double width,
                                bool valid_thru;
                                _f_thru_map.get (dt, idx, &valid_thru);
                                if (valid_thru) {
-                                       draw_thru (cr, x, height, is_midi);
+                                       draw_thru_src (cr, x, 0, height, is_midi);
                                } else {
-                                       draw_gnd (cr, x, height, is_midi);
+                                       draw_gnd (cr, x, 0, height, is_midi);
                                }
                                continue;
                        }
@@ -1266,12 +1341,72 @@ ProcessorEntry::RoutingIcon::expose_input_map (cairo_t* cr, const double width,
        }
 }
 
+void
+ProcessorEntry::RoutingIcon::expose_input_map (cairo_t* cr, const double width, const double height)
+{
+       const uint32_t n_in = _in.n_total();
+       const uint32_t n_in_midi = _in.n_midi();
+       const uint32_t pc_in = _sinks.n_total();
+       const uint32_t pc_in_midi = _sinks.n_midi();
+
+       // draw inputs to this
+       for (uint32_t i = 0; i < pc_in; ++i) {
+               const bool is_midi = i < pc_in_midi;
+               bool valid_in;
+               uint32_t pn = is_midi ? i : i - pc_in_midi;
+               DataType dt = is_midi ? DataType::MIDI : DataType::AUDIO;
+               uint32_t idx = _in_map.get (dt, pn, &valid_in);
+               // check if it's fed
+               bool valid_src = true;
+               if (valid_in && idx < _in.get (dt) && _fed_by) {
+                       bool valid_out;
+                       bool valid_thru;
+                       _f_out_map.get_src (dt, idx, &valid_out);
+                       _f_thru_map.get (dt, idx, &valid_thru);
+                       if (!valid_out && !valid_thru) {
+                               valid_src = false;
+                       }
+               }
+               if (!valid_in || !valid_src) {
+                       double x = pin_x_pos (i, width, pc_in, 0, is_midi);
+                       draw_gnd (cr, x, 0, height, is_midi);
+                       continue;
+               }
+               if (idx >= _in.get (dt)) {
+                       // side-chain, probably
+                       double x = pin_x_pos (i, width, pc_in, 0, is_midi);
+                       draw_sidechain (cr, x, 0, height, is_midi);
+                       continue;
+               }
+               double c_x1 = pin_x_pos (i, width, pc_in, 0, false);
+               double c_x0 = pin_x_pos (idx, width, n_in, n_in_midi, is_midi);
+               draw_connection (cr, c_x0, c_x1, 0, height, is_midi);
+       }
+
+       // draw reverse thru
+       for (uint32_t i = 0; i < n_in; ++i) {
+               const bool is_midi = i < n_in_midi;
+               bool valid_thru;
+               uint32_t pn = is_midi ? i : i - n_in_midi;
+               DataType dt = is_midi ? DataType::MIDI : DataType::AUDIO;
+               _thru_map.get_src (dt, pn, &valid_thru);
+               if (!valid_thru) {
+                       continue;
+               }
+               double x = pin_x_pos (i, width, n_in, 0, is_midi);
+               draw_thru_sink (cr, x, 0, height, is_midi);
+       }
+}
+
 void
 ProcessorEntry::RoutingIcon::expose_output_map (cairo_t* cr, const double width, const double height)
 {
+       int dh = std::max (4.f, rintf(4.f * UIConfiguration::instance().get_ui_scale()));
+       double ht = _terminal ? height - dh : height;
+
+       // draw outputs of this
        const uint32_t pc_out = _sources.n_total();
        const uint32_t pc_out_midi = _sources.n_midi();
-
        const uint32_t n_out = _out.n_total();
        const uint32_t n_out_midi = _out.n_midi();
 
@@ -1282,52 +1417,118 @@ ProcessorEntry::RoutingIcon::expose_output_map (cairo_t* cr, const double width,
                DataType dt = is_midi ? DataType::MIDI : DataType::AUDIO;
                uint32_t idx = _out_map.get (dt, pn, &valid_out);
                if (!valid_out) {
-                       double x = pin_x_pos (i, width, pc_out, 0, is_midi);
-                       draw_X (cr, x, height - 5, is_midi);
                        continue;
                }
+               // skip connections that are not used in the next's input
+               if (_feeding) {
+                       bool valid_thru, valid_sink;
+                       _i_in_map.get_src (dt, idx, &valid_sink);
+                       _i_thru_map.get_src (dt, idx, &valid_thru);
+                       if (!valid_thru && !valid_sink) {
+                               if (!is_midi || i != 0) { // special case midi-bypass
+                                       continue;
+                               }
+                       }
+               }
                double c_x0 = pin_x_pos (i, width, pc_out, 0, false);
                double c_x1 = pin_x_pos (idx, width, n_out, n_out_midi, is_midi);
-               draw_connection (cr, c_x0, c_x1, 0, height - 3, is_midi);
+               draw_connection (cr, c_x0, c_x1, 0, ht, is_midi);
        }
 
-       // arrows
        for (uint32_t i = 0; i < n_out; ++i) {
                const bool is_midi = i < n_out_midi;
-               double x = pin_x_pos (i, width, n_out, 0, is_midi);
                uint32_t pn = is_midi ? i : i - n_out_midi;
                DataType dt = is_midi ? DataType::MIDI : DataType::AUDIO;
-               // TODO check thru
-               bool valid_src;
-               _out_map.get_src (dt, pn, &valid_src);
-               if (!valid_src) {
-                       bool valid_thru;
-                       _thru_map.get (dt, pn, &valid_thru);
-                       if (valid_thru) {
-                               draw_thru (cr, x, height, is_midi);
-                       } else {
-                               draw_gnd (cr, x, height, is_midi);
+               double x = pin_x_pos (i, width, n_out, 0, is_midi);
+
+               if (!_terminal) {
+                       bool valid_thru_f = false;
+                       // skip connections that are not used in the next's input
+                       if (_feeding) {
+                               bool valid_sink;
+                               _i_in_map.get_src (dt, pn, &valid_sink);
+                               _i_thru_map.get_src (dt, pn, &valid_thru_f);
+                               if (!valid_thru_f && !valid_sink) {
+                                       if (!is_midi || i != 0) { // special case midi-bypass
+                                               continue;
+                                       }
+                               }
+                       }
+
+                       bool valid_src;
+                       _out_map.get_src (dt, pn, &valid_src);
+                       if (!valid_src) {
+                               bool valid_thru;
+                               uint32_t idx = _thru_map.get (dt, pn, &valid_thru);
+                               if (valid_thru) {
+                                       if (idx >= _in.get (dt)) {
+                                               draw_sidechain (cr, x, 0, height, is_midi);
+                                       } else {
+                                               draw_thru_src (cr, x, 0, height, is_midi);
+                                       }
+                               } else if (valid_thru_f){
+                                       // gnd is part of input, unless it's a thru input
+                                       // (also only true if !coalesced into one small display)
+                                       draw_gnd (cr, x, 0, height, is_midi);
+                               }
                        }
+               } else {
+                       // terminal node, add arrows
+                       bool valid_src;
+                       _out_map.get_src (dt, pn, &valid_src);
+                       if (!valid_src) {
+                               bool valid_thru;
+                               uint32_t idx = _thru_map.get (dt, pn, &valid_thru);
+                               if (valid_thru) {
+                                       if (idx >= _in.get (dt)) {
+                                               draw_sidechain (cr, x, 0, height - dh, is_midi);
+                                       } else {
+                                               draw_thru_src (cr, x, 0, height - dh, is_midi);
+                                       }
+                               } else {
+                                       draw_gnd (cr, x, 0, height - dh, is_midi);
+                               }
+                       }
+
+                       set_routing_color (cr, is_midi);
+                       cairo_set_line_width (cr, 1.0);
+                       cairo_move_to (cr, x, height - dh);
+                       cairo_line_to (cr, x, height - 2);
+                       cairo_stroke (cr);
+
+                       const double ar = dh - 1;
+                       cairo_move_to (cr, x - ar, height - ar);
+                       cairo_line_to (cr, x     , height - .5);
+                       cairo_line_to (cr, x + ar, height - ar);
+                       cairo_line_to (cr, x     , height - ar * .5);
+                       cairo_close_path (cr);
+                       cairo_fill_preserve (cr);
+                       cairo_stroke (cr);
                }
-               set_routing_color (cr, is_midi);
-               cairo_move_to (cr, x    , height);
-               cairo_line_to (cr, x - 3, height - 3);
-               cairo_line_to (cr, x + 3, height - 3);
-               cairo_close_path (cr);
-               cairo_fill (cr);
        }
 }
 
-ProcessorEntry::PluginDisplay::PluginDisplay (boost::shared_ptr<ARDOUR::Plugin> p, uint32_t max_height)
-       : _plug (p)
+ProcessorEntry::PluginDisplay::PluginDisplay (ProcessorEntry& e, boost::shared_ptr<ARDOUR::Plugin> p, uint32_t max_height)
+       : _entry (e)
+       , _plug (p)
        , _surf (0)
        , _max_height (max_height)
        , _cur_height (1)
        , _scroll (false)
 {
        set_name ("processor prefader");
+       add_events (Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK);
        _plug->QueueDraw.connect (_qdraw_connection, invalidator (*this),
                        boost::bind (&Gtk::Widget::queue_draw, this), gui_context ());
+
+       std::string postfix = "";
+       if (_plug->has_editor()) {
+               ARDOUR_UI_UTILS::set_tooltip (*this,
+                               string_compose (_("<b>%1</b>\nDouble-click to show GUI.\n%2+double-click to show generic GUI.%3"), e.name (Wide), Keyboard::primary_modifier_name (), postfix));
+       } else {
+               ARDOUR_UI_UTILS::set_tooltip (*this,
+                               string_compose (_("<b>%1</b>\nDouble-click to show generic GUI.%2"), e.name (Wide), postfix));
+       }
 }
 
 ProcessorEntry::PluginDisplay::~PluginDisplay ()
@@ -1337,8 +1538,33 @@ ProcessorEntry::PluginDisplay::~PluginDisplay ()
        }
 }
 
+bool
+ProcessorEntry::PluginDisplay::on_button_press_event (GdkEventButton *ev)
+{
+       assert (_entry.processor ());
+
+       // consider some tweaks to pass this up to the DnDVBox somehow:
+       // select processor, then call (private)
+       //_entry._parent->processor_button_press_event (ev, &_entry);
+       if (Keyboard::is_edit_event (ev) || (ev->button == 1 && ev->type == GDK_2BUTTON_PRESS)) {
+               if (Keyboard::modifier_state_equals (ev->state, Keyboard::SecondaryModifier)) {
+                       _entry._parent->generic_edit_processor (_entry.processor ());
+               } else {
+                       _entry._parent->edit_processor (_entry.processor ());
+               }
+               return true;
+       }
+       return false;
+}
+
+bool
+ProcessorEntry::PluginDisplay::on_button_release_event (GdkEventButton *ev)
+{
+       return false;
+}
+
 void
-ProcessorEntry::PluginDisplay::on_size_request (Gtk::Requisition* req)
+ProcessorEntry::PluginDisplay::on_size_request (Requisition* req)
 {
        req->width = 56;
        req->height = _cur_height;
@@ -1412,6 +1638,7 @@ ProcessorEntry::PluginDisplay::render_inline (cairo_t* cr, uint32_t width)
                }
        }
 
+       cairo_surface_flush(_surf);
        cairo_surface_mark_dirty(_surf);
        const double xc = floor ((width - dis->width) * .5);
        cairo_set_source_surface(cr, _surf, xc, 0);
@@ -1471,8 +1698,8 @@ ProcessorEntry::PluginDisplay::on_expose_event (GdkEventExpose* ev)
        return true;
 }
 
-ProcessorEntry::LuaPluginDisplay::LuaPluginDisplay (boost::shared_ptr<ARDOUR::LuaProc> p, uint32_t max_height)
-       : PluginDisplay (p, max_height)
+ProcessorEntry::LuaPluginDisplay::LuaPluginDisplay (ProcessorEntry& e, boost::shared_ptr<ARDOUR::LuaProc> p, uint32_t max_height)
+       : PluginDisplay (e, p, max_height)
        , _luaproc (p)
        , _lua_render_inline (0)
 {
@@ -1501,7 +1728,9 @@ ProcessorEntry::LuaPluginDisplay::render_inline (cairo_t *cr, uint32_t width)
                        return h;
                }
        } catch (luabridge::LuaException const& e) {
-               ;
+#ifndef NDEBUG
+               cerr << "LuaException:" << e.what () << endl;
+#endif
        }
        return 0;
 }
@@ -1512,7 +1741,7 @@ static std::list<Gtk::TargetEntry> drop_targets()
        std::list<Gtk::TargetEntry> tmp;
        tmp.push_back (Gtk::TargetEntry ("processor")); // from processor-box to processor-box
        tmp.push_back (Gtk::TargetEntry ("PluginInfoPtr")); // from plugin-manager
-       tmp.push_back (Gtk::TargetEntry ("PluginPresetPtr")); // from sidebar
+       tmp.push_back (Gtk::TargetEntry ("PluginFavoritePtr")); // from sidebar
        return tmp;
 }
 
@@ -1682,7 +1911,7 @@ ProcessorBox::_drop_plugin_preset (Gtk::SelectionData const &data, Route::Proces
 
                        boost::shared_ptr<Processor> processor (new PluginInsert (*_session, p));
                        if (Config->get_new_plugins_active ()) {
-                               processor->activate ();
+                               processor->enable (true);
                        }
                        pl.push_back (processor);
                }
@@ -1705,7 +1934,7 @@ ProcessorBox::_drop_plugin (Gtk::SelectionData const &data, Route::ProcessorList
                        }
                        boost::shared_ptr<Processor> processor (new PluginInsert (*_session, p));
                        if (Config->get_new_plugins_active ()) {
-                               processor->activate ();
+                               processor->enable (true);
                        }
                        pl.push_back (processor);
                }
@@ -1724,7 +1953,7 @@ ProcessorBox::plugin_drop (Gtk::SelectionData const &data, ProcessorEntry* posit
        if (data.get_target() == "PluginInfoPtr") {
                _drop_plugin (data, pl);
        }
-       else if (data.get_target() == "PluginPresetPtr") {
+       else if (data.get_target() == "PluginFavoritePtr") {
                _drop_plugin_preset (data, pl);
        }
        else {
@@ -1757,6 +1986,11 @@ ProcessorBox::object_drop (DnDVBox<ProcessorEntry>* source, ProcessorEntry* posi
 
                PBD::ID id = pi->id();
                XMLNode& state = otherproc->get_state ();
+               /* strip side-chain state (processor inside processor must be a side-chain)
+                * otherwise we'll end up with duplicate ports-names.
+                * (this needs a better solution which retains connections)
+                */
+               state.remove_nodes ("Processor");
                proc->set_state (state, Stateful::loading_state_version);
                boost::dynamic_pointer_cast<PluginInsert>(proc)->update_id (id);
                return;
@@ -1898,19 +2132,22 @@ ProcessorBox::show_processor_menu (int arg)
                }
        }
 
-       Gtk::MenuItem* send_menu_item = dynamic_cast<Gtk::MenuItem*>(ActionManager::get_widget("/ProcessorMenu/send_options"));
-       if (send_menu_item) {
-               if (single_selection && !_route->is_monitor()) {
-                       Menu* m = single_selection->build_send_options_menu ();
-                       if (m && !m->items().empty()) {
-                               send_menu_item->set_submenu (*m);
-                               send_menu_item->set_sensitive (true);
+
+       if (!ARDOUR::Profile->get_mixbus()) {
+               Gtk::MenuItem* send_menu_item = dynamic_cast<Gtk::MenuItem*>(ActionManager::get_widget("/ProcessorMenu/send_options"));
+               if (send_menu_item) {
+                       if (single_selection && !_route->is_monitor()) {
+                               Menu* m = single_selection->build_send_options_menu ();
+                               if (m && !m->items().empty()) {
+                                       send_menu_item->set_submenu (*m);
+                                       send_menu_item->set_sensitive (true);
+                               } else {
+                                       gtk_menu_item_set_submenu (send_menu_item->gobj(), 0);
+                                       send_menu_item->set_sensitive (false);
+                               }
                        } else {
-                               gtk_menu_item_set_submenu (send_menu_item->gobj(), 0);
                                send_menu_item->set_sensitive (false);
                        }
-               } else {
-                       send_menu_item->set_sensitive (false);
                }
        }
 
@@ -1923,6 +2160,7 @@ ProcessorBox::show_processor_menu (int arg)
        cut_action->set_sensitive (sensitive && can_cut ());
        copy_action->set_sensitive (sensitive);
        delete_action->set_sensitive (sensitive || stub_processor_selected ());
+       backspace_action->set_sensitive (sensitive || stub_processor_selected ());
 
        edit_action->set_sensitive (one_processor_can_be_edited ());
        edit_generic_action->set_sensitive (one_processor_can_be_edited ());
@@ -2045,11 +2283,7 @@ ProcessorBox::processor_operation (ProcessorOperation op)
 
        case ProcessorsToggleActive:
                for (ProcSelection::iterator i = targets.begin(); i != targets.end(); ++i) {
-                       if ((*i)->active()) {
-                               (*i)->deactivate ();
-                       } else {
-                               (*i)->activate ();
-                       }
+                       (*i)->enable (!(*i)->enabled ());
                }
                break;
 
@@ -2141,12 +2375,7 @@ ProcessorBox::processor_button_release_event (GdkEventButton *ev, ProcessorEntry
                ) {
 
                /* button2-click with no/appropriate modifiers */
-
-               if (processor->active()) {
-                       processor->deactivate ();
-               } else {
-                       processor->activate ();
-               }
+               processor->enable (!processor->enabled ());
        }
 
        return false;
@@ -2178,49 +2407,6 @@ ProcessorBox::choose_plugin ()
        _get_plugin_selector()->set_interested_object (*this);
 }
 
-/** @return true if an error occurred, otherwise false */
-bool
-ProcessorBox::choose_lua ()
-{
-       LuaScriptInfoPtr spi;
-
-       ScriptSelector ss (_("Add Lua DSP Processor"), LuaScriptInfo::DSP);
-       switch (ss.run ()) {
-               case Gtk::RESPONSE_ACCEPT:
-                       spi = ss.script();
-                       break;
-               default:
-                       return true;
-       }
-       ss.hide ();
-
-       PluginPtr p;
-       try {
-               LuaPluginInfoPtr lpi (new LuaPluginInfo(spi));
-               p = (lpi->load (*_session));
-       } catch (...) {
-               string msg = _(
-                               "Failed to instantiate Lua DSP Processor,\n"
-                               "probably because the script is invalid (no dsp function).");
-               MessageDialog am (msg);
-               am.run ();
-               return true;
-       }
-
-       boost::shared_ptr<Processor> processor (new PluginInsert (*_session, p));
-
-       Route::ProcessorStreams err_streams;
-       if (_route->add_processor_by_index (processor, _placement, &err_streams, Config->get_new_plugins_active ())) {
-               string msg = _(
-                               "Failed to add Lua DSP Processor at the given position,\n"
-                               "probably because the I/O configuration of the plugins\n"
-                               "could not match the configuration of this track.");
-               MessageDialog am (msg);
-               am.run ();
-       }
-       return false;
-}
-
 /** @return true if an error occurred, otherwise false */
 bool
 ProcessorBox::use_plugins (const SelectedPlugins& plugins)
@@ -2307,11 +2493,10 @@ ProcessorBox::choose_insert ()
 void
 ProcessorBox::choose_send ()
 {
-       boost::shared_ptr<Pannable> sendpan(new Pannable (*_session));
-       boost::shared_ptr<Send> send (new Send (*_session, sendpan, _route->mute_master()));
+       boost::shared_ptr<Send> send (new Send (*_session, _route->pannable (), _route->mute_master()));
 
        /* make an educated guess at the initial number of outputs for the send */
-       ChanCount outs = (_session->master_out())
+       ChanCount outs = (_route->n_outputs().n_audio() && _session->master_out())
                        ? _session->master_out()->n_outputs()
                        : _route->n_outputs();
 
@@ -2516,12 +2701,6 @@ ProcessorBox::maybe_add_processor_pin_mgr (boost::weak_ptr<Processor> w)
                wp->set_state (*ui_xml, 0);
        }
 
-       void* existing_ui = p->get_ui ();
-
-       if (existing_ui) {
-               wp->use_window (*(reinterpret_cast<Gtk::Window*>(existing_ui)));
-       }
-
        p->set_pingmgr_proxy (wp);
        WM::Manager::instance().register_window (wp);
 }
@@ -2624,6 +2803,9 @@ void
 ProcessorBox::setup_routing_feeds ()
 {
        list<ProcessorEntry*> children = processor_display.children ();
+       /* first set the i/o maps for every processor */
+       list<ProcessorEntry*>::iterator prev = children.begin();
+
        for (list<ProcessorEntry*>::iterator i = children.begin(); i != children.end(); ++i) {
                boost::shared_ptr<ARDOUR::Processor> p = (*i)->processor();
                boost::shared_ptr<PluginInsert> pi = boost::dynamic_pointer_cast<PluginInsert> (p);
@@ -2661,7 +2843,13 @@ ProcessorBox::setup_routing_feeds ()
                                        pi->thru_map ());
 
                        if (next != children.end()) {
-                               (*next)->routing_icon.set_feed (out, sources * count + midi_bypass, pi->output_map (), pi->thru_map ());
+                               (*next)->routing_icon.set_fed_by (out, sources * count + midi_bypass,
+                                               pi->output_map (), pi->thru_map ());
+                       }
+
+                       if (prev != i) {
+                               (*prev)->routing_icon.set_feeding (in, sinks * count + midi_thru,
+                                               pi->input_map (), pi->thru_map ());
                        }
 
                } else {
@@ -2678,22 +2866,34 @@ ProcessorBox::setup_routing_feeds ()
                                        inmap, outmap, thrumap);
 
                        if (next != children.end()) {
-                               (*next)->routing_icon.set_feed (p->output_streams(),  p->output_streams(), outmap, thrumap);
+                               (*next)->routing_icon.set_fed_by (
+                                               p->output_streams(),
+                                               p->output_streams(),
+                                               outmap, thrumap);
+                       }
+                       if (prev != i) {
+                               (*prev)->routing_icon.set_feeding (
+                                               p->input_streams(),
+                                               p->output_streams(),
+                                               inmap, thrumap);
                        }
                }
 
                if (i == children.begin()) {
-                       (*i)->routing_icon.unset_feed ();
+                       (*i)->routing_icon.unset_fed_by ();
                }
+               prev = i;
+               (*i)->input_icon.hide();
        }
 
+       /* now set which icons need to be displayed */
        for (list<ProcessorEntry*>::iterator i = children.begin(); i != children.end(); ++i) {
-               if ((*i)->routing_icon.identity ()) {
+               (*i)->output_routing_icon.copy_state ((*i)->routing_icon);
+
+               if ((*i)->routing_icon.in_identity ()) {
                        (*i)->routing_icon.hide();
                        if (i == children.begin()) {
                                (*i)->input_icon.show();
-                       } else {
-                               (*i)->input_icon.hide();
                        }
                } else {
                        (*i)->routing_icon.show();
@@ -2703,15 +2903,28 @@ ProcessorBox::setup_routing_feeds ()
 
                list<ProcessorEntry*>::iterator next = i;
                if (++next == children.end()) {
-                       // show additional wires if outputs of last processor are not an identity map.
+                       // last processor in the chain
+                       (*i)->output_routing_icon.set_terminal(true);
+                       (*i)->output_routing_icon.unset_feeding ();
                        if ((*i)->routing_icon.out_identity ()) {
                                (*i)->output_routing_icon.hide();
                        } else {
-                               (*i)->output_routing_icon.copy_state ((*i)->routing_icon);
                                (*i)->output_routing_icon.show();
+                               (*i)->output_routing_icon.queue_draw();
                        }
                } else {
-                       (*i)->output_routing_icon.hide();
+                       (*i)->output_routing_icon.set_terminal(false);
+                       if (   !(*i)->routing_icon.out_identity ()
+                                       && !(*next)->routing_icon.in_identity ()
+                                       &&  (*next)->routing_icon.can_coalesce ()) {
+                               (*i)->output_routing_icon.hide();
+                       } else if (!(*i)->routing_icon.out_identity ()) {
+                               (*i)->output_routing_icon.show();
+                               (*i)->output_routing_icon.queue_draw();
+                               (*next)->input_icon.show();
+                       } else {
+                               (*i)->output_routing_icon.hide();
+                       }
                }
        }
 }
@@ -3132,8 +3345,22 @@ ProcessorBox::paste_processor_state (const XMLNodeList& nlist, boost::shared_ptr
                                   is a plugin.
                                */
                                p.reset (new PluginInsert (*_session));
+                               /* we can't use RAII Stateful::ForceIDRegeneration
+                                * because that'd void copying the state and wrongly bump
+                                * the state-version counter.
+                                * we need to load the state (incl external files) first and
+                                * only then update the ID)
+                                */
                                PBD::ID id = p->id();
-                               p->set_state (**niter, Stateful::current_state_version);
+                               /* strip side-chain state (processor inside processor must be a side-chain)
+                                * otherwise we'll end up with duplicate ports-names.
+                                * (this needs a better solution which retains connections)
+                                * We really would want Stateful::ForceIDRegeneration here :(
+                                */
+                               XMLNode state (**niter);
+                               state.remove_nodes ("Processor");
+
+                               p->set_state (state, Stateful::current_state_version);
                                boost::dynamic_pointer_cast<PluginInsert>(p)->update_id (id);
                        }
 
@@ -3414,8 +3641,6 @@ ProcessorBox::register_actions ()
        myactions.register_action (processor_box_actions, X_("newplugin"), _("New Plugin"),
                        sigc::ptr_fun (ProcessorBox::rb_choose_plugin));
 
-       act = myactions.register_action (processor_box_actions, X_("newlua"), _("New Lua Proc"),
-                       sigc::ptr_fun (ProcessorBox::rb_choose_lua));
        act = myactions.register_action (processor_box_actions, X_("newinsert"), _("New Insert"),
                        sigc::ptr_fun (ProcessorBox::rb_choose_insert));
        ActionManager::engine_sensitive_actions.push_back (act);
@@ -3443,10 +3668,13 @@ ProcessorBox::register_actions ()
                                                             sigc::ptr_fun (ProcessorBox::rb_copy));
        delete_action = myactions.register_action (processor_box_actions, X_("delete"), _("Delete"),
                                                               sigc::ptr_fun (ProcessorBox::rb_delete));
+       backspace_action = myactions.register_action (processor_box_actions, X_("backspace"), _("Delete"),
+                                                              sigc::ptr_fun (ProcessorBox::rb_delete));
 
        ActionManager::plugin_selection_sensitive_actions.push_back (cut_action);
        ActionManager::plugin_selection_sensitive_actions.push_back (copy_action);
        ActionManager::plugin_selection_sensitive_actions.push_back (delete_action);
+       ActionManager::plugin_selection_sensitive_actions.push_back (backspace_action);
 
        paste_action = myactions.register_action (processor_box_actions, X_("paste"), _("Paste"),
                        sigc::ptr_fun (ProcessorBox::rb_paste));
@@ -3520,15 +3748,6 @@ ProcessorBox::rb_choose_plugin ()
        _current_processor_box->choose_plugin ();
 }
 
-void
-ProcessorBox::rb_choose_lua ()
-{
-       if (_current_processor_box == 0) {
-               return;
-       }
-       _current_processor_box->choose_lua ();
-}
-
 void
 ProcessorBox::rb_choose_insert ()
 {
@@ -3713,6 +3932,9 @@ ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
        if (edit_aux_send (processor)) {
                return;
        }
+       if (!_session->engine().connected()) {
+               return;
+       }
 
        ProcessorWindowProxy* proxy = find_window_proxy (processor);
 
@@ -3731,6 +3953,9 @@ ProcessorBox::generic_edit_processor (boost::shared_ptr<Processor> processor)
        if (edit_aux_send (processor)) {
                return;
        }
+       if (!_session->engine().connected()) {
+               return;
+       }
 
        ProcessorWindowProxy* proxy = find_window_proxy (processor);
 
@@ -3973,7 +4198,7 @@ ProcessorWindowProxy::set_state (const XMLNode& node, int /*version*/)
        XMLNodeList children = node.children ();
        XMLNodeList::const_iterator i = children.begin ();
        while (i != children.end()) {
-               XMLProperty* prop = (*i)->property (X_("name"));
+               XMLProperty const * prop = (*i)->property (X_("name"));
                if ((*i)->name() == X_("Window") && prop && prop->value() == _name) {
                        break;
                }
@@ -3981,7 +4206,7 @@ ProcessorWindowProxy::set_state (const XMLNode& node, int /*version*/)
        }
 
        if (i != children.end()) {
-               XMLProperty* prop;
+               XMLProperty const * prop;
                if ((prop = (*i)->property (X_("custom-ui"))) != 0) {
                        want_custom = PBD::string_is_affirmative (prop->value ());
                }
@@ -4014,8 +4239,8 @@ ProcessorWindowProxy::get (bool create)
                if (_window) {
                        setup ();
                }
+               _window->show_all ();
        }
-       _window->show_all ();
        return _window;
 }
 
@@ -4025,12 +4250,7 @@ ProcessorWindowProxy::show_the_right_window ()
        if (_window && (is_custom != want_custom)) {
                /* drop existing window - wrong type */
                drop_window ();
-               get (true);
-               setup ();
-               assert (_window);
-               is_custom = want_custom;
        }
-
        toggle ();
 }
 
@@ -4077,9 +4297,8 @@ PluginPinWindowProxy::get (bool create)
                if (aw) {
                        aw->set_session (_session);
                }
+               _window->show_all ();
        }
-
-       _window->show_all ();
        return _window;
 }