use quotes for in-tree pbd/glib wrapper include
[ardour.git] / gtk2_ardour / sfdb_ui.cc
index 98df970e391a699f1e8e9574ea6cad596c9bab35..733e1f9015cd807eaa219e47758e7deb1283e242 100644 (file)
 #include "gtk2ardour-config.h"
 #endif
 
+#include "i18n.h"
+
 #include <map>
 #include <cerrno>
 #include <sstream>
 
 #include <unistd.h>
 #include <limits.h>
-#include <sys/stat.h>
 
 #include <gtkmm/box.h>
 #include <gtkmm/stock.h>
 
-#include <glib/gstdio.h>
+#include "pbd/gstdio_compat.h"
 #include <glibmm/fileutils.h>
 
 #include "pbd/convert.h"
 #include "ardour/auditioner.h"
 #include "ardour/audioregion.h"
 #include "ardour/audiofilesource.h"
+#include "ardour/midi_region.h"
 #include "ardour/smf_source.h"
 #include "ardour/region_factory.h"
 #include "ardour/source_factory.h"
 #include "ardour/session.h"
 #include "ardour/session_directory.h"
+#include "ardour/srcfilesource.h"
 
 #include "ardour_ui.h"
 #include "editing.h"
 #include "prompter.h"
 #include "sfdb_ui.h"
 #include "editing.h"
-#include "utils.h"
 #include "gain_meter.h"
 #include "main_clock.h"
 #include "public_editor.h"
+#include "timers.h"
+#include "ui_config.h"
 
 #include "sfdb_freesound_mootcher.h"
 
-#include "i18n.h"
-
 using namespace ARDOUR;
 using namespace PBD;
 using namespace std;
@@ -113,16 +115,18 @@ importmode2string (ImportMode mode)
        case ImportAsTapeTrack:
                return _("as new tape tracks");
        }
-       /*NOTREACHED*/
+       abort(); /*NOTREACHED*/
        return _("as new tracks");
 }
 
-SoundFileBox::SoundFileBox (bool persistent)
+SoundFileBox::SoundFileBox (bool /*persistent*/)
        : table (6, 2),
-         length_clock ("sfboxLengthClock", !persistent, "", false, false, true, false),
-         timecode_clock ("sfboxTimecodeClock", !persistent, "", false, false, false, false),
+         length_clock ("sfboxLengthClock", true, "", false, false, true, false),
+         timecode_clock ("sfboxTimecodeClock", true, "", false, false, false, false),
          main_box (false, 6),
-         autoplay_btn (_("Auto-play"))
+         autoplay_btn (_("Auto-play")),
+         seek_slider(0,1000,1),
+         _seeking(false)
 
 {
        set_name (X_("SoundFileBox"));
@@ -200,9 +204,18 @@ SoundFileBox::SoundFileBox (bool persistent)
        bottom_box.pack_start(stop_btn, true, true);
        bottom_box.pack_start(autoplay_btn, false, false);
 
+       seek_slider.set_draw_value(false);
+
+       seek_slider.add_events(Gdk::BUTTON_PRESS_MASK|Gdk::BUTTON_RELEASE_MASK);
+       seek_slider.signal_button_press_event().connect(sigc::mem_fun(*this, &SoundFileBox::seek_button_press), false);
+       seek_slider.signal_button_release_event().connect(sigc::mem_fun(*this, &SoundFileBox::seek_button_release), false);
+       main_box.pack_start (seek_slider, false, false);
+
        play_btn.signal_clicked().connect (sigc::mem_fun (*this, &SoundFileBox::audition));
        stop_btn.signal_clicked().connect (sigc::mem_fun (*this, &SoundFileBox::stop_audition));
 
+       stop_btn.set_sensitive (false);
+
        channels_value.set_alignment (0.0f, 0.5f);
        samplerate_value.set_alignment (0.0f, 0.5f);
 }
@@ -218,9 +231,45 @@ SoundFileBox::set_session(Session* s)
        if (!_session) {
                play_btn.set_sensitive (false);
                stop_btn.set_sensitive (false);
+               auditioner_connections.drop_connections();
+       } else {
+               auditioner_connections.drop_connections();
+               _session->AuditionActive.connect(auditioner_connections, invalidator (*this), boost::bind (&SoundFileBox::audition_active, this, _1), gui_context());
+               _session->the_auditioner()->AuditionProgress.connect(auditioner_connections, invalidator (*this), boost::bind (&SoundFileBox::audition_progress, this, _1, _2), gui_context());
+       }
+}
+
+void
+SoundFileBox::audition_active(bool active) {
+       stop_btn.set_sensitive (active);
+       seek_slider.set_sensitive (active);
+       if (!active) {
+               seek_slider.set_value(0);
+       }
+}
+
+void
+SoundFileBox::audition_progress(ARDOUR::framecnt_t pos, ARDOUR::framecnt_t len) {
+       if (!_seeking) {
+               seek_slider.set_value( 1000.0 * pos / len);
+               seek_slider.set_sensitive (true);
        }
 }
 
+bool
+SoundFileBox::seek_button_press(GdkEventButton*) {
+       _seeking = true;
+       return false; // pass on to slider
+}
+
+bool
+SoundFileBox::seek_button_release(GdkEventButton*) {
+       _seeking = false;
+       _session->the_auditioner()->seek_to_percent(seek_slider.get_value() / 10.0);
+       seek_slider.set_sensitive (false);
+       return false; // pass on to slider
+}
+
 bool
 SoundFileBox::setup_labels (const string& filename)
 {
@@ -233,6 +282,43 @@ SoundFileBox::setup_labels (const string& filename)
 
        string error_msg;
 
+       if (SMFSource::valid_midi_file (path)) {
+
+               boost::shared_ptr<SMFSource> ms;
+               try {
+                       ms = boost::dynamic_pointer_cast<SMFSource> (
+                               SourceFactory::createExternal (DataType::MIDI, *_session,
+                                                              path, 0, Source::Flag (0), false));
+               } catch (const std::exception& e) {
+                       error << string_compose(_("Could not read file: %1 (%2)."),
+                                               path, e.what()) << endmsg;
+               }
+
+               preview_label.set_markup (_("<b>Midi File Information</b>"));
+
+               format_text.set_text ("MIDI");
+               samplerate_value.set_text ("-");
+               tags_entry.get_buffer()->set_text ("");
+               timecode_clock.set (0);
+               tags_entry.set_sensitive (false);
+
+               if (ms) {
+                       channels_value.set_text (to_string(ms->num_tracks(), std::dec));
+                       length_clock.set (ms->length(ms->timeline_position()));
+               } else {
+                       channels_value.set_text ("");
+                       length_clock.set (0);
+               }
+
+               if (_session && ms) {
+                       play_btn.set_sensitive (true);
+               } else {
+                       play_btn.set_sensitive (false);
+               }
+
+               return true;
+       }
+
        if(!AudioFileSource::get_soundfile_info (filename, sf_info, error_msg)) {
 
                preview_label.set_markup (_("<b>Sound File Information</b>"));
@@ -317,11 +403,6 @@ SoundFileBox::audition ()
                return;
        }
 
-       if (SMFSource::safe_midi_file_extension (path)) {
-               error << _("Auditioning of MIDI files is not yet supported") << endmsg;
-               return;
-       }
-
        _session->cancel_audition();
 
        if (!Glib::file_test (path, Glib::FILE_TEST_EXISTS)) {
@@ -330,47 +411,91 @@ SoundFileBox::audition ()
        }
 
        boost::shared_ptr<Region> r;
-       SourceList srclist;
-       boost::shared_ptr<AudioFileSource> afs;
-       bool old_sbp = AudioSource::get_build_peakfiles ();
 
-       /* don't even think of building peakfiles for these files */
+       if (SMFSource::valid_midi_file (path)) {
 
-       AudioSource::set_build_peakfiles (false);
+               boost::shared_ptr<SMFSource> ms =
+                       boost::dynamic_pointer_cast<SMFSource> (
+                                       SourceFactory::createExternal (DataType::MIDI, *_session,
+                                                                                        path, 0, Source::Flag (0), false));
 
-       for (int n = 0; n < sf_info.channels; ++n) {
-               try {
-                       afs = boost::dynamic_pointer_cast<AudioFileSource> (
-                               SourceFactory::createExternal (DataType::AUDIO, *_session,
-                                                              path, n,
-                                                              Source::Flag (0), false));
-                       
-                       srclist.push_back(afs);
-
-               } catch (failed_constructor& err) {
-                       error << _("Could not access soundfile: ") << path << endmsg;
-                       AudioSource::set_build_peakfiles (old_sbp);
-                       return;
+               string rname = region_name_from_path (ms->path(), false);
+
+               PropertyList plist;
+
+               plist.add (ARDOUR::Properties::start, 0);
+               plist.add (ARDOUR::Properties::length, ms->length(ms->timeline_position()));
+               plist.add (ARDOUR::Properties::name, rname);
+               plist.add (ARDOUR::Properties::layer, 0);
+
+               r = boost::dynamic_pointer_cast<MidiRegion> (RegionFactory::create (boost::dynamic_pointer_cast<Source>(ms), plist, false));
+               assert(r);
+
+       } else {
+
+               SourceList srclist;
+               boost::shared_ptr<AudioFileSource> afs;
+               bool old_sbp = AudioSource::get_build_peakfiles ();
+
+               /* don't even think of building peakfiles for these files */
+
+               AudioSource::set_build_peakfiles (false);
+
+               for (int n = 0; n < sf_info.channels; ++n) {
+                       try {
+                               afs = boost::dynamic_pointer_cast<AudioFileSource> (
+                                       SourceFactory::createExternal (DataType::AUDIO, *_session,
+                                                                                        path, n,
+                                                                                        Source::Flag (ARDOUR::AudioFileSource::NoPeakFile), false));
+                               if (afs->sample_rate() != _session->nominal_frame_rate()) {
+                                       boost::shared_ptr<SrcFileSource> sfs (new SrcFileSource(*_session, afs, _src_quality));
+                                       srclist.push_back(sfs);
+                               } else {
+                                       srclist.push_back(afs);
+                               }
+
+                       } catch (failed_constructor& err) {
+                               error << _("Could not access soundfile: ") << path << endmsg;
+                               AudioSource::set_build_peakfiles (old_sbp);
+                               return;
+                       }
                }
-       }
 
-       AudioSource::set_build_peakfiles (old_sbp);
+               AudioSource::set_build_peakfiles (old_sbp);
 
-       if (srclist.empty()) {
-               return;
-       }
+               if (srclist.empty()) {
+                       return;
+               }
 
-       afs = boost::dynamic_pointer_cast<AudioFileSource> (srclist[0]);
-       string rname = region_name_from_path (afs->path(), false);
+               afs = boost::dynamic_pointer_cast<AudioFileSource> (srclist[0]);
+               string rname = region_name_from_path (afs->path(), false);
 
-       PropertyList plist;
+               PropertyList plist;
 
-       plist.add (ARDOUR::Properties::start, 0);
-       plist.add (ARDOUR::Properties::length, srclist[0]->length(srclist[0]->timeline_position()));
-       plist.add (ARDOUR::Properties::name, rname);
-       plist.add (ARDOUR::Properties::layer, 0);
+               plist.add (ARDOUR::Properties::start, 0);
+               plist.add (ARDOUR::Properties::length, srclist[0]->length(srclist[0]->timeline_position()));
+               plist.add (ARDOUR::Properties::name, rname);
+               plist.add (ARDOUR::Properties::layer, 0);
 
-       r = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (srclist, plist, false));
+               r = boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (srclist, plist, false));
+       }
+
+       frameoffset_t audition_position = 0;
+       switch(_import_position) {
+               case ImportAtTimestamp:
+                       audition_position = 0;
+                       break;
+               case ImportAtPlayhead:
+                       audition_position = _session->transport_frame();
+                       break;
+               case ImportAtStart:
+                       audition_position = _session->current_start_frame();
+                       break;
+               case ImportAtEditPoint:
+                       audition_position = PublicEditor::instance().get_preferred_edit_position ();
+                       break;
+       }
+       r->set_position(audition_position);
 
        _session->audition_region(r);
 }
@@ -430,35 +555,40 @@ SoundFileBrowser::SoundFileBrowser (string title, ARDOUR::Session* s, bool persi
        , matches (0)
        , _status (0)
        , _done (false)
-       , ok_button (Stock::OK)
-       , cancel_button (Stock::CANCEL)
-       , apply_button (Stock::APPLY)
+       , import_button (_("Import"))
+       , close_button (Stock::CLOSE)
        , gm (0)
 {
 
 #ifdef GTKOSX
-        chooser.add_shortcut_folder_uri("file:///Library/GarageBand/Apple Loops");
-        chooser.add_shortcut_folder_uri("file:///Library/Audio/Apple Loops");
-        chooser.add_shortcut_folder_uri("file:///Library/Application Support/GarageBand/Instrument Library/Sampler/Sampler Files");
-        chooser.add_shortcut_folder_uri("file:///Volumes");
+       try {
+               /* add_shortcut_folder throws an exception if the folder being added already has a shortcut */
+               chooser.add_shortcut_folder_uri("file:///Library/GarageBand/Apple Loops");
+               chooser.add_shortcut_folder_uri("file:///Library/Audio/Apple Loops");
+               chooser.add_shortcut_folder_uri("file:///Library/Application Support/GarageBand/Instrument Library/Sampler/Sampler Files");
+               chooser.add_shortcut_folder_uri("file:///Volumes");
+       }
+       catch (Glib::Error & e) {
+               std::cerr << "sfdb.add_shortcut_folder() threw Glib::Error " << e.what() << std::endl;
+       }
 #endif
 
        //add the file chooser
 
        chooser.set_border_width (12);
-       
+
        audio_and_midi_filter.add_custom (FILE_FILTER_FILENAME, sigc::mem_fun (*this, &SoundFileBrowser::on_audio_and_midi_filter));
        audio_and_midi_filter.set_name (_("Audio and MIDI files"));
-       
+
        audio_filter.add_custom (FILE_FILTER_FILENAME, sigc::mem_fun(*this, &SoundFileBrowser::on_audio_filter));
        audio_filter.set_name (_("Audio files"));
-       
+
        midi_filter.add_custom (FILE_FILTER_FILENAME, sigc::mem_fun(*this, &SoundFileBrowser::on_midi_filter));
        midi_filter.set_name (_("MIDI files"));
-       
+
        matchall_filter.add_pattern ("*.*");
        matchall_filter.set_name (_("All files"));
-       
+
        chooser.add_filter (audio_and_midi_filter);
        chooser.add_filter (audio_filter);
        chooser.add_filter (midi_filter);
@@ -471,13 +601,13 @@ SoundFileBrowser::SoundFileBrowser (string title, ARDOUR::Session* s, bool persi
        /* some broken redraw behaviour - this is a bandaid */
        chooser.signal_selection_changed().connect (mem_fun (chooser, &Widget::queue_draw));
 #endif
-       
+
        if (!persistent_folder.empty()) {
                chooser.set_current_folder (persistent_folder);
        }
 
        notebook.append_page (chooser, _("Browse Files"));
-       
+
        hpacker.set_spacing (6);
        hpacker.pack_start (notebook, true, true);
        hpacker.pack_start (preview, false, false);
@@ -491,52 +621,52 @@ SoundFileBrowser::SoundFileBrowser (string title, ARDOUR::Session* s, bool persi
 
        VBox* vbox;
        HBox* hbox;
-       
-       
+
+
        hbox = manage(new HBox);
        hbox->pack_start (found_entry);
        hbox->pack_start (found_search_btn);
-       
+
        Gtk::ScrolledWindow *scroll = manage(new ScrolledWindow);
        scroll->add(found_list_view);
        scroll->set_policy(Gtk::POLICY_AUTOMATIC, Gtk::POLICY_AUTOMATIC);
-       
+
        vbox = manage(new VBox);
        vbox->pack_start (*hbox, PACK_SHRINK);
        vbox->pack_start (*scroll);
-       
+
        found_list_view.append_column(_("Paths"), found_list_columns.pathname);
-       
+
        found_list_view.get_selection()->signal_changed().connect(sigc::mem_fun(*this, &SoundFileBrowser::found_list_view_selected));
-       
+
        found_list_view.signal_row_activated().connect (sigc::mem_fun (*this, &SoundFileBrowser::found_list_view_activated));
-       
+
        found_search_btn.signal_clicked().connect(sigc::mem_fun(*this, &SoundFileBrowser::found_search_clicked));
        found_entry.signal_activate().connect(sigc::mem_fun(*this, &SoundFileBrowser::found_search_clicked));
-       
+
        notebook.append_page (*vbox, _("Search Tags"));
 
        //add freesound search
 
        HBox* passbox;
        Label* label;
-       
+
        passbox = manage(new HBox);
        passbox->set_spacing (6);
-       
+
        label = manage (new Label);
        label->set_text (_("Tags:"));
        passbox->pack_start (*label, false, false);
        passbox->pack_start (freesound_entry, true, true);
-       
+
        label = manage (new Label);
        label->set_text (_("Sort:"));
        passbox->pack_start (*label, false, false);
        passbox->pack_start (freesound_sort, false, false);
        freesound_sort.clear_items();
-       
+
        // Order of the following must correspond with enum sortMethod
-       // in sfdb_freesound_mootcher.h 
+       // in sfdb_freesound_mootcher.h
        freesound_sort.append_text(_("None"));
        freesound_sort.append_text(_("Longest"));
        freesound_sort.append_text(_("Shortest"));
@@ -547,7 +677,7 @@ SoundFileBrowser::SoundFileBrowser (string title, ARDOUR::Session* s, bool persi
        freesound_sort.append_text(_("Highest rated"));
        freesound_sort.append_text(_("Lowest rated"));
        freesound_sort.set_active(0);
-       
+
        passbox->pack_start (freesound_search_btn, false, false);
        passbox->pack_start (freesound_more_btn, false, false);
        freesound_more_btn.set_label(_("More"));
@@ -556,11 +686,11 @@ SoundFileBrowser::SoundFileBrowser (string title, ARDOUR::Session* s, bool persi
        passbox->pack_start (freesound_similar_btn, false, false);
        freesound_similar_btn.set_label(_("Similar"));
        freesound_similar_btn.set_sensitive(false);
-       
+
        scroll = manage(new ScrolledWindow);
        scroll->add(freesound_list_view);
        scroll->set_policy(Gtk::POLICY_AUTOMATIC, Gtk::POLICY_AUTOMATIC);
-       
+
        vbox = manage(new VBox);
        vbox->set_spacing (3);
        vbox->pack_start (*passbox, PACK_SHRINK);
@@ -580,7 +710,7 @@ SoundFileBrowser::SoundFileBrowser (string title, ARDOUR::Session* s, bool persi
        freesound_list_view.get_column(3)->set_alignment(0.5);
        freesound_list_view.get_column(4)->set_alignment(0.5);
        freesound_list_view.get_column(5)->set_alignment(0.5);
-       
+
        freesound_list_view.get_selection()->signal_changed().connect(sigc::mem_fun(*this, &SoundFileBrowser::freesound_list_view_selected));
        freesound_list_view.set_tooltip_column(1);
 
@@ -600,19 +730,14 @@ SoundFileBrowser::SoundFileBrowser (string title, ARDOUR::Session* s, bool persi
        Gtk::HButtonBox* button_box = manage (new HButtonBox);
 
        button_box->set_layout (BUTTONBOX_END);
-       button_box->pack_start (cancel_button, false, false);
-       cancel_button.signal_clicked().connect (sigc::bind (sigc::mem_fun (*this, &SoundFileBrowser::do_something), RESPONSE_CANCEL));
-       if (persistent) {
-               button_box->pack_start (apply_button, false, false);
-               apply_button.signal_clicked().connect (sigc::bind (sigc::mem_fun (*this, &SoundFileBrowser::do_something), RESPONSE_APPLY));
-       }
+       button_box->pack_start (close_button, false, false);
+       close_button.signal_clicked().connect (sigc::bind (sigc::mem_fun (*this, &SoundFileBrowser::do_something), RESPONSE_CLOSE));
 
-       button_box->pack_start (ok_button, false, false);
-       ok_button.signal_clicked().connect (sigc::bind (sigc::mem_fun (*this, &SoundFileBrowser::do_something), RESPONSE_OK));
+       button_box->pack_start (import_button, false, false);
+       import_button.signal_clicked().connect (sigc::bind (sigc::mem_fun (*this, &SoundFileBrowser::do_something), RESPONSE_OK));
 
-       Gtkmm2ext::UI::instance()->set_tip (ok_button, _("Press to import selected files and close this window"));
-       Gtkmm2ext::UI::instance()->set_tip (apply_button, _("Press to import selected files and leave this window open"));
-       Gtkmm2ext::UI::instance()->set_tip (cancel_button, _("Press to close this window without importing any files"));
+       Gtkmm2ext::UI::instance()->set_tip (import_button, _("Press to import selected files"));
+       Gtkmm2ext::UI::instance()->set_tip (close_button, _("Press to close this window without importing any files"));
 
        vpacker.pack_end (*button_box, false, false);
 
@@ -643,8 +768,7 @@ SoundFileBrowser::run ()
 void
 SoundFileBrowser::set_action_sensitive (bool yn)
 {
-       ok_button.set_sensitive (yn);
-       apply_button.set_sensitive (yn);
+       import_button.set_sensitive (yn);
 }
 
 void
@@ -709,7 +833,7 @@ SoundFileBrowser::add_gain_meter ()
        boost::shared_ptr<Route> r = _session->the_auditioner ();
 
        gm->set_controls (r, r->shared_peak_meter(), r->amp());
-       gm->set_fader_name (X_("AudioTrackFader"));
+       gm->set_fader_name (X_("GainFader"));
 
        meter_packer.set_border_width (12);
        meter_packer.pack_start (*gm, false, true);
@@ -732,7 +856,7 @@ SoundFileBrowser::remove_gain_meter ()
 void
 SoundFileBrowser::start_metering ()
 {
-       metering_connection = ARDOUR_UI::instance()->SuperRapidScreenUpdate.connect (sigc::mem_fun(*this, &SoundFileBrowser::meter));
+       metering_connection = Timers::super_rapid_connect (sigc::mem_fun(*this, &SoundFileBrowser::meter));
 }
 
 void
@@ -899,7 +1023,7 @@ SoundFileBrowser::refresh_display(std::string ID, std::string file)
                // there's a single item selected in the freesound list
                //XXX make a function to be used to construct the actual file name both here and in the mootcher
                Gtk::TreeIter row = freesound_list->get_iter(*rows.begin());
-               std::string selected_ID = (*row)[freesound_list_columns.id]; 
+               std::string selected_ID = (*row)[freesound_list_columns.id];
                if (ID == selected_ID) {
                        // the selected item in the freesound list is the item that has just finished downloading
                        chooser.set_filename(file);
@@ -943,9 +1067,9 @@ SoundFileBrowser::freesound_similar_clicked ()
                prev_cursor = gdk_window_get_cursor (get_window()->gobj());
                gdk_window_set_cursor (get_window()->gobj(), gdk_cursor_new(GDK_WATCH));
                gdk_flush();
-               
+
                std::string theString = mootcher.searchSimilar(id);
-               
+
                gdk_window_set_cursor (get_window()->gobj(), prev_cursor);
                handle_freesound_results(theString);
        }
@@ -965,7 +1089,7 @@ SoundFileBrowser::freesound_search()
        gdk_flush();
 
        std::string theString = mootcher.searchText(
-                       search_string, 
+                       search_string,
                        freesound_page,
 #ifdef GTKOSX
                        "", // OSX eats anything incl mp3
@@ -1130,8 +1254,8 @@ SoundFileBrowser::get_paths ()
                vector<string>::iterator i;
 
                for (i = filenames.begin(); i != filenames.end(); ++i) {
-                       struct stat buf;
-                       if ((!stat((*i).c_str(), &buf)) && S_ISREG(buf.st_mode)) {
+                       GStatBuf buf;
+                       if ((!g_stat((*i).c_str(), &buf)) && S_ISREG(buf.st_mode)) {
                                results.push_back (*i);
                        }
                }
@@ -1192,7 +1316,7 @@ SoundFileOmega::reset_options ()
                   to do embedding (or if we are importing a MIDI file).
                */
 
-               if (Config->get_only_copy_imported_files()) {
+               if (UIConfiguration::instance().get_only_copy_imported_files()) {
                        copy_files_btn.set_sensitive (false);
                } else {
                        copy_files_btn.set_sensitive (false);
@@ -1207,7 +1331,7 @@ SoundFileOmega::reset_options ()
 
        /* See if we are thinking about importing any MIDI files */
        vector<string>::iterator i = paths.begin ();
-       while (i != paths.end() && SMFSource::safe_midi_file_extension (*i) == false) {
+       while (i != paths.end() && SMFSource::valid_midi_file (*i) == false) {
                ++i;
        }
        bool const have_a_midi_file = (i != paths.end ());
@@ -1229,28 +1353,28 @@ SoundFileOmega::reset_options ()
                if (selected_audio_track_cnt > 0) {
                        if (channel_combo.get_active_text().length()) {
                                ImportDisposition id = get_channel_disposition();
-                               
+
                                switch (id) {
                                case Editing::ImportDistinctFiles:
                                        if (selected_audio_track_cnt == paths.size()) {
                                                action_strings.push_back (importmode2string (ImportToTrack));
                                        }
                                        break;
-                                       
+
                                case Editing::ImportDistinctChannels:
                                        /* XXX it would be nice to allow channel-per-selected track
                                           but its too hard we don't want to deal with all the
                                           different per-file + per-track channel configurations.
                                        */
                                        break;
-                                       
+
                                default:
                                        action_strings.push_back (importmode2string (ImportToTrack));
                                        break;
                                }
                        }
                }
-               
+
        }  else {
 
                /* MIDI ONLY */
@@ -1365,8 +1489,8 @@ SoundFileOmega::reset_options ()
        /* We must copy MIDI files or those from Freesound
         * or any file if we are under nsm control */
        bool const must_copy = _session->get_nsm_state() || have_a_midi_file || notebook.get_current_page() == 2;
-       
-       if (Config->get_only_copy_imported_files()) {
+
+       if (UIConfiguration::instance().get_only_copy_imported_files()) {
 
                if (selection_can_be_embedded_with_links && !must_copy) {
                        copy_files_btn.set_sensitive (true);
@@ -1381,7 +1505,7 @@ SoundFileOmega::reset_options ()
 
                if (must_copy) {
                        copy_files_btn.set_active (true);
-               }                       
+               }
                copy_files_btn.set_sensitive (!must_copy);
        }
 
@@ -1435,7 +1559,7 @@ SoundFileOmega::check_info (const vector<string>& paths, bool& same_size, bool&
                                src_needed = true;
                        }
 
-               } else if (SMFSource::safe_midi_file_extension (*i)) {
+               } else if (SMFSource::valid_midi_file (*i)) {
 
                        Evoral::SMF reader;
                        reader.open(*i);
@@ -1459,13 +1583,13 @@ SoundFileOmega::check_info (const vector<string>& paths, bool& same_size, bool&
 bool
 SoundFileOmega::check_link_status (const Session* s, const vector<string>& paths)
 {
-#ifdef WIN32
+#ifdef PLATFORM_WINDOWS
        return false;
 #else
        std::string tmpdir(Glib::build_filename (s->session_directory().sound_path(), "linktest"));
        bool ret = false;
 
-       if (mkdir (tmpdir.c_str(), 0744)) {
+       if (g_mkdir (tmpdir.c_str(), 0744)) {
                if (errno != EEXIST) {
                        return false;
                }
@@ -1489,7 +1613,7 @@ SoundFileOmega::check_link_status (const Session* s, const vector<string>& paths
        ret = true;
 
   out:
-       rmdir (tmpdir.c_str());
+       g_rmdir (tmpdir.c_str());
        return ret;
 #endif
 }
@@ -1531,9 +1655,9 @@ SoundFileChooser::get_filename ()
        return paths.front();
 }
 
-SoundFileOmega::SoundFileOmega (string title, ARDOUR::Session* s, 
-                               uint32_t selected_audio_tracks, 
-                               uint32_t selected_midi_tracks, 
+SoundFileOmega::SoundFileOmega (string title, ARDOUR::Session* s,
+                               uint32_t selected_audio_tracks,
+                               uint32_t selected_midi_tracks,
                                bool persistent,
                                Editing::ImportMode mode_hint)
        : SoundFileBrowser (title, s, persistent)
@@ -1560,6 +1684,7 @@ SoundFileOmega::SoundFileOmega (string title, ARDOUR::Session* s,
        str.push_back (_("session start"));
        set_popdown_strings (where_combo, str);
        where_combo.set_active_text (str.front());
+       where_combo.signal_changed().connect (sigc::mem_fun (*this, &SoundFileOmega::where_combo_changed));
 
        Label* l = manage (new Label);
        l->set_markup (_("<b>Add files as ...</b>"));
@@ -1573,16 +1698,6 @@ SoundFileOmega::SoundFileOmega (string title, ARDOUR::Session* s,
        hbox->pack_start (*vbox, false, false);
        options.pack_start (*hbox, false, false);
 
-       /* dummy entry for action combo so that it doesn't look odd if we
-          come up with no tracks selected.
-       */
-
-       str.clear ();
-       str.push_back (importmode2string (mode_hint));
-       set_popdown_strings (action_combo, str);
-       action_combo.set_active_text (str.front());
-       action_combo.set_sensitive (false);
-
        l = manage (new Label);
        l->set_markup (_("<b>Insert at</b>"));
 
@@ -1626,6 +1741,18 @@ SoundFileOmega::SoundFileOmega (string title, ARDOUR::Session* s,
        hbox->pack_start (*vbox, false, false);
        options.pack_start (*hbox, false, false);
 
+       l = manage (new Label);
+       l->set_markup (_("<b>Instrument</b>"));
+
+       vbox = manage (new VBox);
+       vbox->set_border_width (12);
+       vbox->set_spacing (6);
+       vbox->pack_start (*l, false, false);
+       vbox->pack_start (instrument_combo, false, false);
+       hbox = manage (new HBox);
+       hbox->pack_start (*vbox, false, false);
+       options.pack_start (*hbox, false, false);
+
        str.clear ();
        str.push_back (_("Best"));
        str.push_back (_("Good"));
@@ -1636,8 +1763,7 @@ SoundFileOmega::SoundFileOmega (string title, ARDOUR::Session* s,
        set_popdown_strings (src_combo, str);
        src_combo.set_active_text (str.front());
        src_combo.set_sensitive (false);
-
-       reset_options ();
+       src_combo.signal_changed().connect (sigc::mem_fun (*this, &SoundFileOmega::src_combo_changed));
 
        action_combo.signal_changed().connect (sigc::mem_fun (*this, &SoundFileOmega::reset_options_noret));
        channel_combo.signal_changed().connect (sigc::mem_fun (*this, &SoundFileOmega::reset_options_noret));
@@ -1676,19 +1802,22 @@ SoundFileOmega::SoundFileOmega (string title, ARDOUR::Session* s,
           selects a file to import, which in turn prevents the size of the dialog from jumping
           around. */
 
-       vector<string> t;
-       t.push_back (_("one track per file"));
-       t.push_back (_("one track per channel"));
-       t.push_back (_("sequence files"));
-       t.push_back (_("all files in one region"));
-       set_popdown_strings (channel_combo, t);
+       str.clear ();
+       str.push_back (_("one track per file"));
+       str.push_back (_("one track per channel"));
+       str.push_back (_("sequence files"));
+       str.push_back (_("all files in one region"));
+       set_popdown_strings (channel_combo, str);
+
+       str.clear ();
+       str.push_back (importmode2string (ImportAsTrack));
+       str.push_back (importmode2string (ImportToTrack));
+       str.push_back (importmode2string (ImportAsRegion));
+       str.push_back (importmode2string (ImportAsTapeTrack));
+       set_popdown_strings (action_combo, str);
+       action_combo.set_active_text (importmode2string(mode_hint));
 
-       t.clear ();
-       t.push_back (importmode2string (ImportAsTrack));
-       t.push_back (importmode2string (ImportToTrack));
-       t.push_back (importmode2string (ImportAsRegion));
-       t.push_back (importmode2string (ImportAsTapeTrack));
-       set_popdown_strings (action_combo, t);
+       reset (selected_audio_tracks, selected_midi_tracks);
 }
 
 void
@@ -1746,6 +1875,18 @@ SoundFileOmega::get_src_quality() const
        }
 }
 
+void
+SoundFileOmega::src_combo_changed()
+{
+       preview.set_src_quality(get_src_quality());
+}
+
+void
+SoundFileOmega::where_combo_changed()
+{
+       preview.set_import_position(get_position());
+}
+
 ImportDisposition
 SoundFileOmega::get_channel_disposition () const
 {
@@ -1759,7 +1900,7 @@ SoundFileOmega::get_channel_disposition () const
 
        if (x == disposition_map.end()) {
                fatal << string_compose (_("programming error: %1 (%2)"), "unknown string for import disposition", str) << endmsg;
-               /*NOTREACHED*/
+               abort(); /*NOTREACHED*/
        }
 
        return x->second;
@@ -1805,19 +1946,20 @@ SoundFileOmega::do_something (int action)
 {
        SoundFileBrowser::do_something (action);
 
-       if (action == RESPONSE_CANCEL) {
+       if (action == RESPONSE_CLOSE) {
                hide ();
                return;
        }
 
        /* lets do it */
-       
+
        vector<string> paths = get_paths ();
        ImportPosition pos = get_position ();
        ImportMode mode = get_mode ();
        ImportDisposition chns = get_channel_disposition ();
+       PluginInfoPtr instrument = instrument_combo.selected_instrument();
        framepos_t where;
-       
+
        switch (pos) {
        case ImportAtEditPoint:
                where = PublicEditor::instance().get_preferred_edit_position ();
@@ -1832,17 +1974,13 @@ SoundFileOmega::do_something (int action)
                where = _session->current_start_frame();
                break;
        }
-       
+
        SrcQuality quality = get_src_quality();
-       
+
        if (copy_files_btn.get_active()) {
-               PublicEditor::instance().do_import (paths, chns, mode, quality, where);
+               PublicEditor::instance().do_import (paths, chns, mode, quality, where, instrument);
        } else {
-               PublicEditor::instance().do_embed (paths, chns, mode, where);
-       }
-       
-       if (action == RESPONSE_OK) {
-               hide ();
+               PublicEditor::instance().do_embed (paths, chns, mode, where, instrument);
        }
 }
-       
+