Part 1 of loading 2.X sessions; some things work, some things don't, hacks a-plenty.
[ardour.git] / libs / ardour / audio_playlist.cc
index be8680882f86baf199df01f84f0d52db142d760a..812aa8783ba301f22989ae9da79d7d29da3af484 100644 (file)
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2003 Paul Davis 
+    Copyright (C) 2003 Paul Davis
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -15,7 +15,6 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
-    $Id$
 */
 
 #include <algorithm>
 
 #include <sigc++/bind.h>
 
-#include <ardour/types.h>
-#include <ardour/configuration.h>
-#include <ardour/audioplaylist.h>
-#include <ardour/audioregion.h>
-#include <ardour/crossfade.h>
-#include <ardour/crossfade_compare.h>
-#include <ardour/session.h>
+#include "ardour/types.h"
+#include "ardour/configuration.h"
+#include "ardour/audioplaylist.h"
+#include "ardour/audioregion.h"
+#include "ardour/crossfade.h"
+#include "ardour/crossfade_compare.h"
+#include "ardour/session.h"
+#include "pbd/enumwriter.h"
 
 #include "i18n.h"
 
@@ -40,55 +40,50 @@ using namespace std;
 using namespace PBD;
 
 AudioPlaylist::AudioPlaylist (Session& session, const XMLNode& node, bool hidden)
-       : Playlist (session, node, hidden)
+       : Playlist (session, node, DataType::AUDIO, hidden)
 {
-       in_set_state = true;
-       set_state (node);
-       in_set_state = false;
+       const XMLProperty* prop = node.property("type");
+       assert(!prop || DataType(prop->value()) == DataType::AUDIO);
 
-       if (!hidden) {
-               PlaylistCreated (this); /* EMIT SIGNAL */
-       }
+       in_set_state++;
+       set_state (node);
+       in_set_state--;
 }
 
 AudioPlaylist::AudioPlaylist (Session& session, string name, bool hidden)
-       : Playlist (session, name, hidden)
+       : Playlist (session, name, DataType::AUDIO, hidden)
 {
-       if (!hidden) {
-               PlaylistCreated (this); /* EMIT SIGNAL */
-       }
-
 }
 
-AudioPlaylist::AudioPlaylist (const AudioPlaylist& other, string name, bool hidden)
+AudioPlaylist::AudioPlaylist (boost::shared_ptr<const AudioPlaylist> other, string name, bool hidden)
        : Playlist (other, name, hidden)
 {
-       RegionList::const_iterator in_o  = other.regions.begin();
+       RegionList::const_iterator in_o  = other->regions.begin();
        RegionList::iterator in_n = regions.begin();
 
-       while (in_o != other.regions.end()) {
+       while (in_o != other->regions.end()) {
                boost::shared_ptr<AudioRegion> ar = boost::dynamic_pointer_cast<AudioRegion>(*in_o);
 
                // We look only for crossfades which begin with the current region, so we don't get doubles
-               for (list<Crossfade *>::const_iterator xfades = other._crossfades.begin(); xfades != other._crossfades.end(); ++xfades) {
+               for (Crossfades::const_iterator xfades = other->_crossfades.begin(); xfades != other->_crossfades.end(); ++xfades) {
                        if ((*xfades)->in() == ar) {
                                // We found one! Now copy it!
 
-                               RegionList::const_iterator out_o = other.regions.begin();
+                               RegionList::const_iterator out_o = other->regions.begin();
                                RegionList::const_iterator out_n = regions.begin();
 
-                               while (out_o != other.regions.end()) {
-                                       
+                               while (out_o != other->regions.end()) {
+
                                        boost::shared_ptr<AudioRegion>ar2 = boost::dynamic_pointer_cast<AudioRegion>(*out_o);
-                                       
+
                                        if ((*xfades)->out() == ar2) {
                                                boost::shared_ptr<AudioRegion>in  = boost::dynamic_pointer_cast<AudioRegion>(*in_n);
                                                boost::shared_ptr<AudioRegion>out = boost::dynamic_pointer_cast<AudioRegion>(*out_n);
-                                               Crossfade *new_fade = new Crossfade (*(*xfades), in, out);
-                                               add_crossfade(*new_fade);
+                                               boost::shared_ptr<Crossfade> new_fade = boost::shared_ptr<Crossfade> (new Crossfade (*xfades, in, out));
+                                               add_crossfade(new_fade);
                                                break;
                                        }
-                                       
+
                                        out_o++;
                                        out_n++;
                                }
@@ -99,13 +94,9 @@ AudioPlaylist::AudioPlaylist (const AudioPlaylist& other, string name, bool hidd
                in_o++;
                in_n++;
        }
-
-       if (!hidden) {
-               PlaylistCreated (this); /* EMIT SIGNAL */
-       }
 }
 
-AudioPlaylist::AudioPlaylist (const AudioPlaylist& other, nframes_t start, nframes_t cnt, string name, bool hidden)
+AudioPlaylist::AudioPlaylist (boost::shared_ptr<const AudioPlaylist> other, nframes_t start, nframes_t cnt, string name, bool hidden)
        : Playlist (other, start, cnt, name, hidden)
 {
        /* this constructor does NOT notify others (session) */
@@ -113,26 +104,22 @@ AudioPlaylist::AudioPlaylist (const AudioPlaylist& other, nframes_t start, nfram
 
 AudioPlaylist::~AudioPlaylist ()
 {
-       set<Crossfade*> all_xfades;
-
-       GoingAway (); /* EMIT SIGNAL */
+       GoingAway (); /* EMIT SIGNAL */
 
        /* drop connections to signals */
 
        notify_callbacks ();
 
-       for (Crossfades::iterator x = _crossfades.begin(); x != _crossfades.end(); ++x) {
-               delete *x;
-       }
+       _crossfades.clear ();
 }
 
 struct RegionSortByLayer {
-    bool operator() (boost::shared_ptr<Region>a, boost::shared_ptr<Region>b) {
+    bool operator() (boost::shared_ptr<Region> a, boost::shared_ptr<Region> b) {
            return a->layer() < b->layer();
     }
 };
 
-nframes_t
+ARDOUR::nframes_t
 AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, nframes_t start,
                     nframes_t cnt, unsigned chan_n)
 {
@@ -142,9 +129,9 @@ AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, nf
        nframes_t skip_frames;
 
        /* optimizing this memset() away involves a lot of conditionals
-          that may well cause more of a hit due to cache misses 
+          that may well cause more of a hit due to cache misses
           and related stuff than just doing this here.
-          
+
           it would be great if someone could measure this
           at some point.
 
@@ -156,23 +143,31 @@ AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, nf
 
        memset (buf, 0, sizeof (Sample) * cnt);
 
-       /* this function is never called from a realtime thread, so 
+       /* this function is never called from a realtime thread, so
           its OK to block (for short intervals).
        */
 
-       Glib::Mutex::Lock rm (region_lock);
+       Glib::RecMutex::Lock rm (region_lock);
 
        end =  start + cnt - 1;
-
        read_frames = 0;
        skip_frames = 0;
        _read_data_count = 0;
 
+       _read_data_count = 0;
+
+       RegionList* rlist = regions_to_read (start, start+cnt);
+
+       if (rlist->empty()) {
+               delete rlist;
+               return cnt;
+       }
+
        map<uint32_t,vector<boost::shared_ptr<Region> > > relevant_regions;
-       map<uint32_t,vector<Crossfade*> > relevant_xfades;
+       map<uint32_t,vector<boost::shared_ptr<Crossfade> > > relevant_xfades;
        vector<uint32_t> relevant_layers;
 
-       for (RegionList::iterator i = regions.begin(); i != regions.end(); ++i) {
+       for (RegionList::iterator i = rlist->begin(); i != rlist->end(); ++i) {
                if ((*i)->coverage (start, end) != OverlapNone) {
                        relevant_regions[(*i)->layer()].push_back (*i);
                        relevant_layers.push_back ((*i)->layer());
@@ -199,7 +194,7 @@ AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, nf
        for (vector<uint32_t>::iterator l = relevant_layers.begin(); l != relevant_layers.end(); ++l) {
 
                vector<boost::shared_ptr<Region> > r (relevant_regions[*l]);
-               vector<Crossfade*>& x (relevant_xfades[*l]);
+               vector<boost::shared_ptr<Crossfade> >& x (relevant_xfades[*l]);
 
                for (vector<boost::shared_ptr<Region> >::iterator i = r.begin(); i != r.end(); ++i) {
                        boost::shared_ptr<AudioRegion> ar = boost::dynamic_pointer_cast<AudioRegion>(*i);
@@ -207,8 +202,8 @@ AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, nf
                        ar->read_at (buf, mixdown_buffer, gain_buffer, start, cnt, chan_n, read_frames, skip_frames);
                        _read_data_count += ar->read_data_count();
                }
-               
-               for (vector<Crossfade*>::iterator i = x.begin(); i != x.end(); ++i) {
+
+               for (vector<boost::shared_ptr<Crossfade> >::iterator i = x.begin(); i != x.end(); ++i) {
                        (*i)->read_at (buf, mixdown_buffer, gain_buffer, start, cnt, chan_n);
 
                        /* don't JACK up _read_data_count, since its the same data as we just
@@ -217,6 +212,7 @@ AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, nf
                }
        }
 
+       delete rlist;
        return ret;
 }
 
@@ -224,25 +220,25 @@ AudioPlaylist::read (Sample *buf, Sample *mixdown_buffer, float *gain_buffer, nf
 void
 AudioPlaylist::remove_dependents (boost::shared_ptr<Region> region)
 {
-       Crossfades::iterator i, tmp;
        boost::shared_ptr<AudioRegion> r = boost::dynamic_pointer_cast<AudioRegion> (region);
-       
+
+       if (in_set_state) {
+               return;
+       }
+
        if (r == 0) {
                fatal << _("programming error: non-audio Region passed to remove_overlap in audio playlist")
                      << endmsg;
                return;
        }
 
-       for (i = _crossfades.begin(); i != _crossfades.end(); ) {
-               tmp = i;
-               tmp++;
+       for (Crossfades::iterator i = _crossfades.begin(); i != _crossfades.end(); ) {
 
-               
                if ((*i)->involves (r)) {
-                       delete *i;
+                       i = _crossfades.erase (i);
+               } else {
+                       ++i;
                }
-               
-               i = tmp;
        }
 }
 
@@ -264,7 +260,7 @@ AudioPlaylist::flush_notifications ()
        }
 
        _pending_xfade_adds.clear ();
-       
+
        in_flush = false;
 }
 
@@ -272,7 +268,7 @@ void
 AudioPlaylist::refresh_dependents (boost::shared_ptr<Region> r)
 {
        boost::shared_ptr<AudioRegion> ar = boost::dynamic_pointer_cast<AudioRegion>(r);
-       set<Crossfade*> updated;
+       set<boost::shared_ptr<Crossfade> > updated;
 
        if (ar == 0) {
                return;
@@ -281,7 +277,7 @@ AudioPlaylist::refresh_dependents (boost::shared_ptr<Region> r)
        for (Crossfades::iterator x = _crossfades.begin(); x != _crossfades.end();) {
 
                Crossfades::iterator tmp;
-               
+
                tmp = x;
                ++tmp;
 
@@ -289,10 +285,16 @@ AudioPlaylist::refresh_dependents (boost::shared_ptr<Region> r)
 
                if ((*x)->involves (ar)) {
 
-                       if (find (updated.begin(), updated.end(), *x) == updated.end()) {
-                               if ((*x)->refresh ()) {
-                                       /* not invalidated by the refresh */
-                                       updated.insert (*x);
+                       pair<set<boost::shared_ptr<Crossfade> >::iterator, bool> const u = updated.insert (*x);
+
+                       if (u.second) {
+                               /* x was successfully inserted into the set, so it has not already been updated */
+                               try {
+                                       (*x)->refresh ();
+                               }
+
+                               catch (Crossfade::NoCrossfadeHere& err) {
+                                       // relax, Invalidated during refresh
                                }
                        }
                }
@@ -313,29 +315,29 @@ AudioPlaylist::finalize_split_region (boost::shared_ptr<Region> o, boost::shared
                tmp = x;
                ++tmp;
 
-               Crossfade *fade = 0;
-               
+               boost::shared_ptr<Crossfade> fade;
+
                if ((*x)->_in == orig) {
                        if (! (*x)->covers(right->position())) {
-                               fade = new Crossfade (**x, left, (*x)->_out);
+                               fade = boost::shared_ptr<Crossfade> (new Crossfade (*x, left, (*x)->_out));
                        } else {
                                // Overlap, the crossfade is copied on the left side of the right region instead
-                               fade = new Crossfade (**x, right, (*x)->_out);
+                               fade = boost::shared_ptr<Crossfade> (new Crossfade (*x, right, (*x)->_out));
                        }
                }
-               
+
                if ((*x)->_out == orig) {
                        if (! (*x)->covers(right->position())) {
-                               fade = new Crossfade (**x, (*x)->_in, right);
+                               fade = boost::shared_ptr<Crossfade> (new Crossfade (*x, (*x)->_in, right));
                        } else {
                                // Overlap, the crossfade is copied on the right side of the left region instead
-                               fade = new Crossfade (**x, (*x)->_in, left);
+                               fade = boost::shared_ptr<Crossfade> (new Crossfade (*x, (*x)->_in, left));
                        }
                }
-               
+
                if (fade) {
                        _crossfades.remove (*x);
-                       add_crossfade (*fade);
+                       add_crossfade (fade);
                }
                x = tmp;
        }
@@ -348,7 +350,8 @@ AudioPlaylist::check_dependents (boost::shared_ptr<Region> r, bool norefresh)
        boost::shared_ptr<AudioRegion> region;
        boost::shared_ptr<AudioRegion> top;
        boost::shared_ptr<AudioRegion> bottom;
-       Crossfade*   xfade;
+       boost::shared_ptr<Crossfade>   xfade;
+       RegionList*  touched_regions;
 
        if (in_set_state || in_partition) {
                return;
@@ -364,12 +367,15 @@ AudioPlaylist::check_dependents (boost::shared_ptr<Region> r, bool norefresh)
                refresh_dependents (r);
        }
 
-       if (!Config->get_auto_xfade()) {
+
+       if (!_session.config.get_auto_xfade()) {
                return;
        }
 
        for (RegionList::iterator i = regions.begin(); i != regions.end(); ++i) {
 
+               nframes_t xfade_length;
+
                other = boost::dynamic_pointer_cast<AudioRegion> (*i);
 
                if (other == region) {
@@ -380,6 +386,7 @@ AudioPlaylist::check_dependents (boost::shared_ptr<Region> r, bool norefresh)
                        continue;
                }
 
+
                if (other->layer() < region->layer()) {
                        top = region;
                        bottom = other;
@@ -388,78 +395,146 @@ AudioPlaylist::check_dependents (boost::shared_ptr<Region> r, bool norefresh)
                        bottom = region;
                }
 
+               if (!top->opaque()) {
+                       continue;
+               }
+
+               OverlapType c = top->coverage (bottom->position(), bottom->last_frame());
+
                try {
-                               
-                       if (top->coverage (bottom->position(), bottom->last_frame()) != OverlapNone) {
-                               
-                               /* check if the upper region is within the lower region */
-                               
-                               if (top->first_frame() > bottom->first_frame() &&
-                                   top->last_frame() < bottom->last_frame()) {
-                                       
-                                       
-                                       /*     [ -------- top ------- ]
-                                        * {=========== bottom =============}
-                                        */
-                                       
-                                       /* to avoid discontinuities at the region boundaries of an internal
-                                          overlap (this region is completely within another), we create
-                                          two hidden crossfades at each boundary. this is not dependent
-                                          on the auto-xfade option, because we require it as basic
-                                          audio engineering.
+                       switch (c) {
+                       case OverlapNone:
+                               break;
+
+                       case OverlapInternal:
+                                /* {=============== top  =============}
+                                 *     [ ----- bottom  ------- ]
+                                 */
+                               break;
+
+                       case OverlapExternal:
+
+                               /*     [ -------- top ------- ]
+                                * {=========== bottom =============}
+                                */
+
+                               /* to avoid discontinuities at the region boundaries of an internal
+                                  overlap (this region is completely within another), we create
+                                  two hidden crossfades at each boundary. this is not dependent
+                                  on the auto-xfade option, because we require it as basic
+                                  audio engineering.
+                               */
+
+                               xfade_length = min ((nframes_t) 720, top->length());
+
+                               if (top_region_at (top->first_frame()) == top) {
+
+                                       xfade = boost::shared_ptr<Crossfade> (new Crossfade (top, bottom, xfade_length, top->first_frame(), StartOfIn));
+                                       add_crossfade (xfade);
+                               }
+
+                               if (top_region_at (top->last_frame() - 1) == top) {
+
+                                       /*
+                                          only add a fade out if there is no region on top of the end of 'top' (which
+                                          would cover it).
                                        */
-                                       
-                                       nframes_t xfade_length = min ((nframes_t) 720, top->length());
-                                       
-                                                           /*  in,      out */
-                                       xfade = new Crossfade (top, bottom, xfade_length, top->first_frame(), StartOfIn);
-                                       add_crossfade (*xfade);
-                                       xfade = new Crossfade (bottom, top, xfade_length, top->last_frame() - xfade_length, EndOfOut);
-                                       add_crossfade (*xfade);
-                                       
+
+                                       xfade = boost::shared_ptr<Crossfade> (new Crossfade (bottom, top, xfade_length, top->last_frame() - xfade_length, EndOfOut));
+                                       add_crossfade (xfade);
+                               }
+                               break;
+                       case OverlapStart:
+
+                               /*                   { ==== top ============ }
+                                *   [---- bottom -------------------]
+                                */
+
+                               if (_session.config.get_xfade_model() == FullCrossfade) {
+                                       touched_regions = regions_touched (top->first_frame(), bottom->last_frame());
+                                       if (touched_regions->size() <= 2) {
+                                               xfade = boost::shared_ptr<Crossfade> (new Crossfade (region, other, _session.config.get_xfade_model(), _session.config.get_xfades_active()));
+                                               add_crossfade (xfade);
+                                       }
                                } else {
 
-                                       xfade = new Crossfade (other, region, Config->get_xfade_model(), Config->get_xfades_active());
-                                       add_crossfade (*xfade);
+                                       touched_regions = regions_touched (top->first_frame(),
+                                                                          top->first_frame() + min ((nframes_t)_session.config.get_short_xfade_seconds() * _session.frame_rate(),
+                                                                                                    top->length()));
+                                       if (touched_regions->size() <= 2) {
+                                               xfade = boost::shared_ptr<Crossfade> (new Crossfade (region, other, _session.config.get_xfade_model(), _session.config.get_xfades_active()));
+                                               add_crossfade (xfade);
+                                       }
+                               }
+                               break;
+                       case OverlapEnd:
+
+
+                               /* [---- top ------------------------]
+                                *                { ==== bottom ============ }
+                                */
+
+                               if (_session.config.get_xfade_model() == FullCrossfade) {
+
+                                       touched_regions = regions_touched (bottom->first_frame(), top->last_frame());
+                                       if (touched_regions->size() <= 2) {
+                                               xfade = boost::shared_ptr<Crossfade> (new Crossfade (region, other,
+                                                                                                    _session.config.get_xfade_model(), _session.config.get_xfades_active()));
+                                               add_crossfade (xfade);
+                                       }
+
+                               } else {
+                                       touched_regions = regions_touched (bottom->first_frame(),
+                                                                          bottom->first_frame() + min ((nframes_t)_session.config.get_short_xfade_seconds() * _session.frame_rate(),
+                                                                                                       bottom->length()));
+                                       if (touched_regions->size() <= 2) {
+                                               xfade = boost::shared_ptr<Crossfade> (new Crossfade (region, other, _session.config.get_xfade_model(), _session.config.get_xfades_active()));
+                                               add_crossfade (xfade);
+                                       }
                                }
-                       } 
+                               break;
+                       default:
+                               xfade = boost::shared_ptr<Crossfade> (new Crossfade (region, other,
+                                                                                    _session.config.get_xfade_model(), _session.config.get_xfades_active()));
+                               add_crossfade (xfade);
+                       }
                }
-               
+
                catch (failed_constructor& err) {
                        continue;
                }
-               
+
                catch (Crossfade::NoCrossfadeHere& err) {
                        continue;
                }
-               
+
        }
 }
 
 void
-AudioPlaylist::add_crossfade (Crossfade& xfade)
+AudioPlaylist::add_crossfade (boost::shared_ptr<Crossfade> xfade)
 {
        Crossfades::iterator ci;
 
        for (ci = _crossfades.begin(); ci != _crossfades.end(); ++ci) {
-               if (*(*ci) == xfade) { // Crossfade::operator==()
+               if (*(*ci) == *xfade) { // Crossfade::operator==()
                        break;
                }
        }
-       
+
        if (ci != _crossfades.end()) {
-               delete &xfade;
+               // it will just go away
        } else {
-               _crossfades.push_back (&xfade);
+               _crossfades.push_back (xfade);
 
-               xfade.Invalidated.connect (mem_fun (*this, &AudioPlaylist::crossfade_invalidated));
-               xfade.StateChanged.connect (mem_fun (*this, &AudioPlaylist::crossfade_changed));
+               xfade->Invalidated.connect (mem_fun (*this, &AudioPlaylist::crossfade_invalidated));
+               xfade->StateChanged.connect (mem_fun (*this, &AudioPlaylist::crossfade_changed));
 
-               notify_crossfade_added (&xfade);
+               notify_crossfade_added (xfade);
        }
 }
-       
-void AudioPlaylist::notify_crossfade_added (Crossfade *x)
+
+void AudioPlaylist::notify_crossfade_added (boost::shared_ptr<Crossfade> x)
 {
        if (g_atomic_int_get(&block_notifications)) {
                _pending_xfade_adds.insert (_pending_xfade_adds.end(), x);
@@ -469,9 +544,10 @@ void AudioPlaylist::notify_crossfade_added (Crossfade *x)
 }
 
 void
-AudioPlaylist::crossfade_invalidated (Crossfade* xfade)
+AudioPlaylist::crossfade_invalidated (boost::shared_ptr<Region> r)
 {
        Crossfades::iterator i;
+       boost::shared_ptr<Crossfade> xfade = boost::dynamic_pointer_cast<Crossfade> (r);
 
        xfade->in()->resume_fade_in ();
        xfade->out()->resume_fade_out ();
@@ -482,14 +558,18 @@ AudioPlaylist::crossfade_invalidated (Crossfade* xfade)
 }
 
 int
-AudioPlaylist::set_state (const XMLNode& node)
+AudioPlaylist::set_state (const XMLNode& node, int version)
 {
        XMLNode *child;
        XMLNodeList nlist;
        XMLNodeConstIterator niter;
 
+       in_set_state++;
+
        Playlist::set_state (node);
 
+       freeze ();
+
        nlist = node.children();
 
        for (niter = nlist.begin(); niter != nlist.end(); ++niter) {
@@ -501,40 +581,31 @@ AudioPlaylist::set_state (const XMLNode& node)
                }
 
                try {
-                       Crossfade* xfade = new Crossfade (*((const Playlist *)this), *child);
+                       boost::shared_ptr<Crossfade> xfade = boost::shared_ptr<Crossfade> (new Crossfade (*((const Playlist *)this), *child));
                        _crossfades.push_back (xfade);
                        xfade->Invalidated.connect (mem_fun (*this, &AudioPlaylist::crossfade_invalidated));
                        xfade->StateChanged.connect (mem_fun (*this, &AudioPlaylist::crossfade_changed));
                        NewCrossfade(xfade);
                }
-               
+
                catch (failed_constructor& err) {
                        //      cout << string_compose (_("could not create crossfade object in playlist %1"),
-                       //        _name) 
+                       //        _name)
                        //    << endl;
                        continue;
                }
        }
 
+       thaw ();
+       in_set_state--;
+
        return 0;
 }
 
 void
 AudioPlaylist::clear (bool with_signals)
 {
-       for (Crossfades::iterator i = _crossfades.begin(); i != _crossfades.end(); ) {
-
-               Crossfades::iterator tmp;
-               tmp = i;
-               ++tmp;
-
-               delete *i;
-
-               i = tmp;
-       }
-
        _crossfades.clear ();
-       
        Playlist::clear (with_signals);
 }
 
@@ -548,7 +619,7 @@ AudioPlaylist::state (bool full_state)
                        node.add_child_nocopy ((*i)->get_state());
                }
        }
-       
+
        return node;
 }
 
@@ -556,7 +627,7 @@ void
 AudioPlaylist::dump () const
 {
        boost::shared_ptr<Region>r;
-       Crossfade *x;
+       boost::shared_ptr<Crossfade> x;
 
        cerr << "Playlist \"" << _name << "\" " << endl
             << regions.size() << " regions "
@@ -565,9 +636,9 @@ AudioPlaylist::dump () const
 
        for (RegionList::const_iterator i = regions.begin(); i != regions.end(); ++i) {
                r = *i;
-               cerr << "  " << r->name() << " @ " << r << " [" 
-                    << r->start() << "+" << r->length() 
-                    << "] at " 
+               cerr << "  " << r->name() << " @ " << r << " ["
+                    << r->start() << "+" << r->length()
+                    << "] at "
                     << r->position()
                     << " on layer "
                     << r->layer ()
@@ -576,13 +647,13 @@ AudioPlaylist::dump () const
 
        for (Crossfades::const_iterator i = _crossfades.begin(); i != _crossfades.end(); ++i) {
                x = *i;
-               cerr << "  xfade [" 
+               cerr << "  xfade ["
                     << x->out()->name()
                     << ','
                     << x->in()->name()
                     << " @ "
                     << x->position()
-                    << " length = " 
+                    << " length = "
                     << x->length ()
                     << " active ? "
                     << (x->active() ? "yes" : "no")
@@ -596,7 +667,7 @@ AudioPlaylist::destroy_region (boost::shared_ptr<Region> region)
        boost::shared_ptr<AudioRegion> r = boost::dynamic_pointer_cast<AudioRegion> (region);
        bool changed = false;
        Crossfades::iterator c, ctmp;
-       set<Crossfade*> unique_xfades;
+       set<boost::shared_ptr<Crossfade> > unique_xfades;
 
        if (r == 0) {
                fatal << _("programming error: non-audio Region passed to remove_overlap in audio playlist")
@@ -605,23 +676,36 @@ AudioPlaylist::destroy_region (boost::shared_ptr<Region> region)
                return false;
        }
 
-       { 
+       {
                RegionLock rlock (this);
-               RegionList::iterator i;
-               RegionList::iterator tmp;
 
-               for (i = regions.begin(); i != regions.end(); ) {
-                       
-                       tmp = i;
+               for (RegionList::iterator i = regions.begin(); i != regions.end(); ) {
+
+                       RegionList::iterator tmp = i;
                        ++tmp;
-                       
+
                        if ((*i) == region) {
                                regions.erase (i);
                                changed = true;
                        }
-                       
+
                        i = tmp;
                }
+
+               for (set<boost::shared_ptr<Region> >::iterator x = all_regions.begin(); x != all_regions.end(); ) {
+
+                       set<boost::shared_ptr<Region> >::iterator xtmp = x;
+                       ++xtmp;
+
+                       if ((*x) == region) {
+                               all_regions.erase (x);
+                               changed = true;
+                       }
+
+                       x = xtmp;
+               }
+
+               region->set_playlist (boost::shared_ptr<Playlist>());
        }
 
        for (c = _crossfades.begin(); c != _crossfades.end(); ) {
@@ -632,12 +716,8 @@ AudioPlaylist::destroy_region (boost::shared_ptr<Region> region)
                        unique_xfades.insert (*c);
                        _crossfades.erase (c);
                }
-               
-               c = ctmp;
-       }
 
-       for (set<Crossfade*>::iterator c = unique_xfades.begin(); c != unique_xfades.end(); ++c) {
-               delete *c;
+               c = ctmp;
        }
 
        if (changed) {
@@ -649,7 +729,7 @@ AudioPlaylist::destroy_region (boost::shared_ptr<Region> region)
 }
 
 void
-AudioPlaylist::crossfade_changed (Change ignored)
+AudioPlaylist::crossfade_changed (Change)
 {
        if (in_flush || in_set_state) {
                return;
@@ -686,7 +766,7 @@ AudioPlaylist::region_changed (Change what_changed, boost::shared_ptr<Region> re
                notify_modified ();
        }
 
-       return true; 
+       return true;
 }
 
 void
@@ -702,7 +782,15 @@ AudioPlaylist::crossfades_at (nframes_t frame, Crossfades& clist)
 
                if (frame >= start && frame <= end) {
                        clist.push_back (*i);
-               } 
+               }
        }
 }
 
+void
+AudioPlaylist::foreach_crossfade (sigc::slot<void, boost::shared_ptr<Crossfade> > s)
+{
+       RegionLock rl (this, false);
+       for (Crossfades::iterator i = _crossfades.begin(); i != _crossfades.end(); ++i) {
+               s (*i);
+       }
+}