fix crash when copy'ing latent plugins

[ardour.git] / libs / ardour / broadcast_info.cc

diff --git a/libs/ardour/broadcast_info.cc b/libs/ardour/broadcast_info.cc
index a7fa41aaf9217d6330366ba2a97392112d22fd91..98175a6da668a3bade384287c396c52684c46444 100644 (file)
--- a/libs/ardour/broadcast_info.cc
+++ b/libs/ardour/broadcast_info.cc
@@ -22,6 +22,7 @@
 #include <iostream>
 #include <sstream>
 #include <iomanip>
+#include <vector>
 
 #include <glibmm.h>
 
@@ -37,15 +38,15 @@ namespace ARDOUR
 static void
 snprintf_bounded_null_filled (char* target, size_t target_size, char const * fmt, ...)
 {
-       char buf[target_size+1];
+       std::vector<char> buf(target_size+1);
        va_list ap;
 
        va_start (ap, fmt);
-       vsnprintf (buf, target_size+1, fmt, ap);
+       vsnprintf (&buf[0], target_size+1, fmt, ap);
        va_end (ap);
 
        memset (target, 0, target_size);
-       memcpy (target, buf, target_size);
+       memcpy (target, &buf[0], target_size);
 
 }
 
@@ -84,17 +85,24 @@ BroadcastInfo::set_originator_ref_from_session (Session const & /*session*/)
 
        /* random code is 9 digits */
 
-       int random_code = random() % 999999999;
+       int random_code = g_random_int() % 999999999;
 
        /* Serial number is 12 chars */
 
        std::ostringstream serial_number;
-       serial_number << "ARDOUR" << "r" <<  std::setfill('0') << std::right << std::setw(5) << revision;
-
+       serial_number << PROGRAM_NAME << revision;
+
+       /* https://tech.ebu.ch/docs/r/r099.pdf
+        * CC Country code: (2 characters) based on the ISO 3166-1 standard
+        * OOO Organisation code: (3 characters) based on the EBU facility codes, Tech 3279
+        * NNNNNNNNNNNN Serial number: (12 characters extracted from the recorder model and serial number) This should identify the machine’s type and serial number.
+        * HHMMSS OriginationTime (6 characters,) from the <OriginationTime> field of the BWF.
+        * RRRRRRRRR Random Number (9 characters 0-9) Generated locally by the recorder using some reasonably random algorithm.
+        */
        snprintf_bounded_null_filled (info->originator_reference, sizeof (info->originator_reference), "%2s%3s%12s%02d%02d%02d%9d",
-                 SessionMetadata::Metadata()->country().c_str(),
-                 SessionMetadata::Metadata()->organization().c_str(),
-                 serial_number.str().c_str(),
+                 SessionMetadata::Metadata()->country().substr (0, 2).c_str(),
+                 SessionMetadata::Metadata()->organization().substr (0, 3).c_str(),
+                 serial_number.str().substr (0, 12).c_str(),
                  _time.tm_hour,
                  _time.tm_min,
                  _time.tm_sec,