Make the configuration penalty subtler about inputs
[ardour.git] / libs / ardour / luaproc.cc
index a030691e9fe8b6b8cfb375878dc24ecd540ae2c2..09be770b0a9bd2b4719acfdfffe68d58832d124e 100644 (file)
 */
 
 #include <glib.h>
-#include "pbd/gstdio_compat.h"
+#include <glibmm/miscutils.h>
+#include <glibmm/fileutils.h>
 
+#include "pbd/gstdio_compat.h"
+#include "pbd/locale_guard.h"
 #include "pbd/pthread_utils.h"
 
 #include "ardour/audio_buffer.h"
 #include "ardour/buffer_set.h"
+#include "ardour/filesystem_paths.h"
 #include "ardour/luabindings.h"
 #include "ardour/luaproc.h"
 #include "ardour/luascripting.h"
@@ -31,7 +35,9 @@
 #include "ardour/plugin.h"
 #include "ardour/session.h"
 
-#include "i18n.h"
+#include "LuaBridge/LuaBridge.h"
+
+#include "pbd/i18n.h"
 
 using namespace ARDOUR;
 using namespace PBD;
@@ -40,12 +46,19 @@ LuaProc::LuaProc (AudioEngine& engine,
                   Session& session,
                   const std::string &script)
        : Plugin (engine, session)
-       , _mempool ("LuaProc", 1048576) // 1 MB is plenty. (64K would be enough)
+       , _mempool ("LuaProc", 2097152)
+#ifdef USE_TLSF
+       , lua (lua_newstate (&PBD::TLSF::lalloc, &_mempool))
+#elif defined USE_MALLOC
+       , lua ()
+#else
        , lua (lua_newstate (&PBD::ReallocPool::lalloc, &_mempool))
+#endif
        , _lua_dsp (0)
-       , _lua_params (0)
        , _script (script)
        , _lua_does_channelmapping (false)
+       , _lua_has_inline_display (false)
+       , _designated_bypass_port (UINT32_MAX)
        , _control_data (0)
        , _shadow_data (0)
        , _has_midi_input (false)
@@ -63,12 +76,19 @@ LuaProc::LuaProc (AudioEngine& engine,
 
 LuaProc::LuaProc (const LuaProc &other)
        : Plugin (other)
-       , _mempool ("LuaProc", 1048576) // 1 MB is plenty. (64K would be enough)
+       , _mempool ("LuaProc", 2097152)
+#ifdef USE_TLSF
+       , lua (lua_newstate (&PBD::TLSF::lalloc, &_mempool))
+#elif defined USE_MALLOC
+       , lua ()
+#else
        , lua (lua_newstate (&PBD::ReallocPool::lalloc, &_mempool))
+#endif
        , _lua_dsp (0)
-       , _lua_params (0)
        , _script (other.script ())
        , _lua_does_channelmapping (false)
+       , _lua_has_inline_display (false)
+       , _designated_bypass_port (UINT32_MAX)
        , _control_data (0)
        , _shadow_data (0)
        , _has_midi_input (false)
@@ -101,7 +121,6 @@ LuaProc::~LuaProc () {
 #endif
        lua.do_command ("collectgarbage();");
        delete (_lua_dsp);
-       delete (_lua_params);
        delete [] _control_data;
        delete [] _shadow_data;
 }
@@ -113,9 +132,8 @@ LuaProc::init ()
        _stats_avg[0] = _stats_avg[1] = _stats_max[0] = _stats_max[1] = _stats_cnt = 0;
 #endif
 
-#ifndef NDEBUG
+       lua.tweak_rt_gc ();
        lua.Print.connect (sigc::mem_fun (*this, &LuaProc::lua_print));
-#endif
        // register session object
        lua_State* L = lua.getState ();
        LuaBindings::stddef (L);
@@ -127,6 +145,7 @@ LuaProc::init ()
                .beginClass <LuaProc> ("LuaProc")
                .addFunction ("queue_draw", &LuaProc::queue_draw)
                .addFunction ("shmem", &LuaProc::instance_shm)
+               .addFunction ("table", &LuaProc::instance_ref)
                .endClass ()
                .endNamespace ();
 
@@ -149,12 +168,14 @@ LuaProc::init ()
 void
 LuaProc::lua_print (std::string s) {
        std::cout <<"LuaProc: " << s << "\n";
+       PBD::error << "LuaProc: " << s << "\n";
 }
 
 bool
 LuaProc::load_script ()
 {
        assert (!_lua_dsp); // don't allow to re-initialize
+       LuaPluginInfoPtr lpi;
 
        // TODO: refine APIs; function arguments..
        // - perform channel-map in ardour (silent/scratch buffers) ?
@@ -166,7 +187,7 @@ LuaProc::load_script ()
 
        try {
                LuaScriptInfoPtr lsi = LuaScripting::script_info (_script);
-               LuaPluginInfoPtr lpi (new LuaPluginInfo (lsi));
+               lpi = LuaPluginInfoPtr (new LuaPluginInfo (lsi));
                assert (lpi);
                set_info (lpi);
                _mempool.set_name ("LuaProc: " + lsi->name);
@@ -207,10 +228,20 @@ LuaProc::load_script ()
                }
        }
 
-       luabridge::LuaRef lua_dsp_midi_in = luabridge::getGlobal (L, "dsp_midi_input");
-       if (lua_dsp_midi_in.type () == LUA_TFUNCTION) {
+       // query midi i/o
+       luabridge::LuaRef lua_dsp_has_midi_in = luabridge::getGlobal (L, "dsp_has_midi_input");
+       if (lua_dsp_has_midi_in.type () == LUA_TFUNCTION) {
                try {
-                       _has_midi_input = lua_dsp_midi_in ();
+                       _has_midi_input = lua_dsp_has_midi_in ();
+               } catch (luabridge::LuaException const& e) {
+                       ;
+               }
+       }
+
+       luabridge::LuaRef lua_dsp_has_midi_out = luabridge::getGlobal (L, "dsp_has_midi_output");
+       if (lua_dsp_has_midi_out.type () == LUA_TFUNCTION) {
+               try {
+                       _has_midi_output = lua_dsp_has_midi_out ();
                } catch (luabridge::LuaException const& e) {
                        ;
                }
@@ -231,8 +262,6 @@ LuaProc::load_script ()
 
                if (params.isTable ()) {
 
-                       _lua_params = new luabridge::LuaRef (params);
-
                        for (luabridge::Iterator i (params); !i.isNil (); ++i) {
                                // required fields
                                if (!i.key ().isNumber ())           { return false; }
@@ -242,17 +271,55 @@ LuaProc::load_script ()
                                if (!i.value ()["min"].isNumber ())  { return false; }
                                if (!i.value ()["max"].isNumber ())  { return false; }
 
+                               int pn = i.key ().cast<int> ();
                                std::string type = i.value ()["type"].cast<std::string> ();
                                if (type == "input") {
                                        if (!i.value ()["default"].isNumber ()) { return false; }
-                                       _ctrl_params.push_back (std::make_pair (false, i.key ().cast<int> ()));
+                                       _ctrl_params.push_back (std::make_pair (false, pn));
                                }
                                else if (type == "output") {
-                                       _ctrl_params.push_back (std::make_pair (true, i.key ().cast<int> ()));
+                                       _ctrl_params.push_back (std::make_pair (true, pn));
                                } else {
                                        return false;
                                }
-                               assert (i.key ().cast<int> () == (int) _ctrl_params.size ());
+                               assert (pn == (int) _ctrl_params.size ());
+
+                               //_param_desc[pn] = boost::shared_ptr<ParameterDescriptor> (new ParameterDescriptor());
+                               luabridge::LuaRef lr = i.value ();
+
+                               if (type == "input") {
+                                       _param_desc[pn].normal     = lr["default"].cast<float> ();
+                               } else {
+                                       _param_desc[pn].normal     = lr["min"].cast<float> (); // output-port, no default
+                               }
+                               _param_desc[pn].lower        = lr["min"].cast<float> ();
+                               _param_desc[pn].upper        = lr["max"].cast<float> ();
+                               _param_desc[pn].toggled      = lr["toggled"].isBoolean () && (lr["toggled"]).cast<bool> ();
+                               _param_desc[pn].logarithmic  = lr["logarithmic"].isBoolean () && (lr["logarithmic"]).cast<bool> ();
+                               _param_desc[pn].integer_step = lr["integer"].isBoolean () && (lr["integer"]).cast<bool> ();
+                               _param_desc[pn].sr_dependent = lr["ratemult"].isBoolean () && (lr["ratemult"]).cast<bool> ();
+                               _param_desc[pn].enumeration  = lr["enum"].isBoolean () && (lr["enum"]).cast<bool> ();
+
+                               if (lr["bypass"].isBoolean () && (lr["bypass"]).cast<bool> ()) {
+                                       _designated_bypass_port = pn - 1; // lua table starts at 1.
+                               }
+
+                               if (lr["unit"].isString ()) {
+                                       std::string unit = lr["unit"].cast<std::string> ();
+                                       if (unit == "dB")             { _param_desc[pn].unit = ParameterDescriptor::DB; }
+                                       else if (unit == "Hz")        { _param_desc[pn].unit = ParameterDescriptor::HZ; }
+                                       else if (unit == "Midi Note") { _param_desc[pn].unit = ParameterDescriptor::MIDI_NOTE; }
+                               }
+                               _param_desc[pn].label        = (lr["name"]).cast<std::string> ();
+                               _param_desc[pn].scale_points = parse_scale_points (&lr);
+
+                               luabridge::LuaRef doc = lr["doc"];
+                               if (doc.isString ()) {
+                                       _param_doc[pn] = doc.cast<std::string> ();
+                               } else {
+                                       _param_doc[pn] = "";
+                               }
+                               assert (!(_param_desc[pn].toggled && _param_desc[pn].logarithmic));
                        }
                }
        }
@@ -274,11 +341,10 @@ LuaProc::load_script ()
 }
 
 bool
-LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out)
+LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out, ChanCount* imprecise)
 {
-       if (in.n_midi() > 0 && !_has_midi_input) {
-               return false;
-       }
+       // caller must hold process lock (no concurrent calls to interpreter
+       _output_configs.clear ();
 
        lua_State* L = lua.getState ();
        luabridge::LuaRef ioconfig = luabridge::getGlobal (L, "dsp_ioconfig");
@@ -286,14 +352,9 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out)
                return false;
        }
 
-       luabridge::LuaRef table = luabridge::getGlobal (L, "table"); //lua std lib
-       luabridge::LuaRef tablesort = table["sort"];
-       assert (tablesort.isFunction ());
-
        luabridge::LuaRef *_iotable = NULL; // can't use reference :(
        try {
                luabridge::LuaRef iotable = ioconfig ();
-               tablesort (iotable);
                if (iotable.isTable ()) {
                        _iotable = new luabridge::LuaRef (iotable);
                }
@@ -313,193 +374,235 @@ LuaProc::can_support_io_configuration (const ChanCount& in, ChanCount& out)
                return false;
        }
 
-       int32_t audio_in = in.n_audio ();
-       int32_t audio_out;
+       const int audio_in = in.n_audio ();
+       const int midi_in = in.n_midi ();
 
-       if (in.n_midi() > 0 && audio_in == 0) {
-               audio_out = 2; // prefer stereo version if available.
-       } else {
-               audio_out = audio_in;
-       }
+       // preferred setting (provided by plugin_insert)
+       const int preferred_out = out.n_audio ();
 
-       for (luabridge::Iterator i (iotable); !i.isNil (); ++i) {
-               assert (i.value ().type () == LUA_TTABLE);
-               luabridge::LuaRef io (i.value ());
+       int midi_out = -1;
+       int audio_out = -1;
+       float penalty = 9999;
+       bool found = false;
 
-               int possible_in = io["audio_in"];
-               int possible_out = io["audio_out"];
+#define FOUNDCFG_PENALTY(in, out, p) {                              \
+  _output_configs.insert (out);                                     \
+  if (p < penalty) {                                                \
+    audio_out = (out);                                              \
+    midi_out = possible_midiout;                                    \
+    if (imprecise) {                                                \
+      imprecise->set (DataType::AUDIO, (in));                       \
+      imprecise->set (DataType::MIDI, possible_midiin);             \
+    }                                                               \
+    penalty = p;                                                    \
+    found = true;                                                   \
+  }                                                                 \
+}
 
-               // exact match
-               if ((possible_in == audio_in) && (possible_out == audio_out)) {
-                       out.set (DataType::MIDI, 0);
-                       out.set (DataType::AUDIO, audio_out);
-                       return true;
-               }
-       }
+#define FOUNDCFG_IMPRECISE(in, out) {                               \
+  const float p = fabsf ((float)(out) - preferred_out) *            \
+                      (((out) > preferred_out) ? 1.1 : 1)           \
+                + fabsf ((float)(in) - audio_in) *                  \
+                      (((in) > audio_in) ? 275 : 250);              \
+  FOUNDCFG_PENALTY(in, out, p);                                     \
+}
 
-       /* now allow potentially "imprecise" matches */
-       audio_out = -1;
-       bool found = false;
+#define FOUNDCFG(out)                                               \
+  FOUNDCFG_IMPRECISE(audio_in, out)
+
+#define ANYTHINGGOES                                                \
+  _output_configs.insert (0);
+
+#define UPTO(nch) {                                                 \
+  for (int n = 1; n < nch; ++n) {                                   \
+    _output_configs.insert (n);                                     \
+  }                                                                 \
+}
+
+       if (imprecise) {
+               *imprecise = in;
+       }
 
        for (luabridge::Iterator i (iotable); !i.isNil (); ++i) {
-               assert (i.value ().type () == LUA_TTABLE);
                luabridge::LuaRef io (i.value ());
+               if (!io.isTable()) {
+                       continue;
+               }
 
-               int possible_in = io["audio_in"];
-               int possible_out = io["audio_out"];
+               int possible_in = io["audio_in"].isNumber() ? io["audio_in"] : -1;
+               int possible_out = io["audio_out"].isNumber() ? io["audio_out"] : -1;
+               int possible_midiin = _has_midi_input ? 1 : 0;
+               int possible_midiout = _has_midi_output ? 1 : 0;
 
-               if (possible_out == 0) {
+               if (midi_in > 0 && possible_midiin == 0 && !imprecise) {
                        continue;
                }
-               if (possible_in == 0) {
-                       /* no inputs, generators & instruments */
-                       if (possible_out == -1) {
-                               /* any configuration possible, provide stereo output */
-                               audio_out = 2;
-                               found = true;
-                       } else if (possible_out == -2) {
-                               /* invalid, should be (0, -1) */
-                               audio_out = 2;
-                               found = true;
-                       } else if (possible_out < -2) {
-                               /* variable number of outputs. -> whatever */
-                               audio_out = 2;
-                               found = true;
-                       } else {
-                               /* exact number of outputs */
-                               audio_out = possible_out;
-                               found = true;
-                       }
+
+               // exact match
+               if ((possible_in == audio_in) && (possible_out == preferred_out)) {
+                       /* Set penalty so low that this output configuration
+                        * will trump any other one */
+                       FOUNDCFG_PENALTY(audio_in, preferred_out, -1);
                }
 
-               if (possible_in == -1) {
-                       /* wildcard for input */
-                       if (possible_out == -1) {
-                               /* out much match in */
-                               audio_out = audio_in;
-                               found = true;
-                       } else if (possible_out == -2) {
-                               /* any configuration possible, pick matching */
-                               audio_out = audio_in;
-                               found = true;
-                       } else if (possible_out < -2) {
-                               /* explicitly variable number of outputs, pick maximum */
-                               audio_out = -possible_out;
-                               found = true;
-                       } else {
-                               /* exact number of outputs */
-                               audio_out = possible_out;
-                               found = true;
+               // "imprecise" matches
+               if (possible_out == 0) {
+                       /* skip configurations with no audio output, unless
+                        * the plugin is a midi filter or generator */
+                       if (possible_in == 0 && _has_midi_output) {
+                               if (audio_in == 0) {
+                                       FOUNDCFG(possible_out);
+                                       break;
+                               } else if (imprecise) {
+                                       // TODO hide audio input from plugin
+                                       FOUNDCFG_IMPRECISE (possible_in, possible_out);
+                               }
                        }
+                       continue;
                }
 
-               if (possible_in == -2) {
-
-                       if (possible_out == -1) {
-                               /* any configuration possible, pick matching */
-                               audio_out = audio_in;
-                               found = true;
-                       } else if (possible_out == -2) {
-                               /* invalid. interpret as (-1, -1) */
-                               audio_out = audio_in;
-                               found = true;
+               if (possible_in == -1 || possible_in == -2) {
+                       /* wildcard for input */
+                       if (possible_out == possible_in) {
+                               /* either both -1 or both -2 (invalid and
+                                * interpreted as both -1): out must match in */
+                               FOUNDCFG (audio_in);
+                       } else if (possible_out == -3 - possible_in) {
+                               /* one is -1, the other is -2: any output configuration
+                                * possible, pick what the insert prefers */
+                               FOUNDCFG (preferred_out);
+                               ANYTHINGGOES;
                        } else if (possible_out < -2) {
-                               /* explicitly variable number of outputs, pick maximum */
-                               audio_out = -possible_out;
-                               found = true;
+                               /* variable number of outputs up to -N,
+                                * invalid if in == -2 but we accept it anyway */
+                               FOUNDCFG (min (-possible_out, preferred_out));
+                               UPTO (-possible_out)
                        } else {
                                /* exact number of outputs */
-                               audio_out = possible_out;
-                               found = true;
+                               FOUNDCFG (possible_out);
                        }
                }
 
-               if (possible_in < -2) {
-                       /* explicit variable number of inputs */
-                       if (audio_in > -possible_in) {
-                               /* request is too large */
-                       }
-                       if (possible_out == -1) {
-                               /* any output configuration possible, provide stereo out */
-                               audio_out = 2;
-                               found = true;
-                       } else if (possible_out == -2) {
-                               /* invalid. interpret as (<-2, -1) */
-                               audio_out = 2;
-                               found = true;
-                       } else if (possible_out < -2) {
-                               /* explicitly variable number of outputs, pick stereo */
-                               audio_out = 2;
-                               found = true;
+               if (possible_in < -2 || possible_in >= 0) {
+                       /* specified number, exact or up to */
+                       int desired_in;
+                       if (possible_in >= 0) {
+                               /* configuration can only match possible_in */
+                               desired_in = possible_in;
                        } else {
-                               /* exact number of outputs */
-                               audio_out = possible_out;
-                               found = true;
+                               /* configuration can match up to -possible_in */
+                               desired_in = min (-possible_in, audio_in);
                        }
-               }
-
-               if (possible_in && (possible_in == audio_in)) {
-                       /* exact number of inputs ... must match obviously */
-                       if (possible_out == -1) {
-                               /* any output configuration possible, provide stereo output */
-                               audio_out = 2;
-                               found = true;
-                       } else if (possible_out == -2) {
-                               /* invalid. interpret as (>0, -1) */
-                               audio_out = 2;
-                               found = true;
+                       if (!imprecise && audio_in != desired_in) {
+                               /* skip that configuration, it cannot match
+                                * the required audio input count, and we
+                                * cannot ask for change via \imprecise */
+                       } else if (possible_out == -1 || possible_out == -2) {
+                               /* any output configuration possible
+                                * out == -2 is invalid, interpreted as out == -1.
+                                * Really imprecise only if desired_in != audio_in */
+                               FOUNDCFG_IMPRECISE (desired_in, preferred_out);
+                               ANYTHINGGOES;
                        } else if (possible_out < -2) {
-                               /* explicitly variable number of outputs, pick maximum */
-                               audio_out = -possible_out;
-                               found = true;
+                               /* variable number of outputs up to -N
+                                * not specified if in > 0, but we accept it anyway.
+                                * Really imprecise only if desired_in != audio_in */
+                               FOUNDCFG_IMPRECISE (desired_in, min (-possible_out, preferred_out));
+                               UPTO (-possible_out)
                        } else {
-                               /* exact number of outputs */
-                               audio_out = possible_out;
-                               found = true;
+                               /* exact number of outputs
+                                * Really imprecise only if desired_in != audio_in */
+                               FOUNDCFG_IMPRECISE (desired_in, possible_out);
                        }
+                       // ideally we'll also find the closest, best matching
+                       // input configuration with minimal output penalty...
                }
 
-               if (found) {
-                       break;
-               }
        }
 
        if (!found) {
                return false;
        }
 
-       out.set (DataType::MIDI, 0);
+       if (imprecise) {
+               _selected_in = *imprecise;
+       } else {
+               _selected_in = in;
+       }
+
+       out.set (DataType::MIDI, midi_out);
        out.set (DataType::AUDIO, audio_out);
+       _selected_out = out;
+
        return true;
 }
 
 bool
 LuaProc::configure_io (ChanCount in, ChanCount out)
 {
-       _configured_in = in;
-       _configured_out = out;
+       in.set (DataType::MIDI, _has_midi_input ? 1 : 0);
+       out.set (DataType::MIDI, _has_midi_output ? 1 : 0);
 
-       _configured_in.set (DataType::MIDI, _has_midi_input ? 1 : 0);
-       _configured_out.set (DataType::MIDI, _has_midi_output ? 1 : 0);
+       _info->n_inputs = _selected_in;
+       _info->n_outputs = _selected_out;
 
        // configure the DSP if needed
-       lua_State* L = lua.getState ();
-       luabridge::LuaRef lua_dsp_configure = luabridge::getGlobal (L, "dsp_configure");
-       if (lua_dsp_configure.type () == LUA_TFUNCTION) {
-               try {
-                       lua_dsp_configure (&in, &out);
-               } catch (luabridge::LuaException const& e) {
-                       ;
+       if (in != _configured_in || out != _configured_out) {
+               lua_State* L = lua.getState ();
+               luabridge::LuaRef lua_dsp_configure = luabridge::getGlobal (L, "dsp_configure");
+               if (lua_dsp_configure.type () == LUA_TFUNCTION) {
+                       try {
+                               luabridge::LuaRef io = lua_dsp_configure (&in, &out);
+                               if (io.isTable ()) {
+                                       ChanCount lin (_selected_in);
+                                       ChanCount lout (_selected_out);
+
+                                       if (io["audio_in"].type() == LUA_TNUMBER) {
+                                               const int c = io["audio_in"].cast<int> ();
+                                               if (c >= 0) {
+                                                       lin.set (DataType::AUDIO, c);
+                                               }
+                                       }
+                                       if (io["audio_out"].type() == LUA_TNUMBER) {
+                                               const int c = io["audio_out"].cast<int> ();
+                                               if (c >= 0) {
+                                                       lout.set (DataType::AUDIO, c);
+                                               }
+                                       }
+                                       if (io["midi_in"].type() == LUA_TNUMBER) {
+                                               const int c = io["midi_in"].cast<int> ();
+                                               if (c >= 0) {
+                                                       lin.set (DataType::MIDI, c);
+                                               }
+                                       }
+                                       if (io["midi_out"].type() == LUA_TNUMBER) {
+                                               const int c = io["midi_out"].cast<int> ();
+                                               if (c >= 0) {
+                                                       lout.set (DataType::MIDI, c);
+                                               }
+                                       }
+                                       _info->n_inputs = lin;
+                                       _info->n_outputs = lout;
+                               }
+                       } catch (luabridge::LuaException const& e) {
+                               PBD::error << "LuaException: " << e.what () << "\n";
+#ifndef NDEBUG
+                               std::cerr << "LuaException: " << e.what () << "\n";
+#endif
+                               return false;
+                       }
                }
        }
 
-       _info->n_inputs = _configured_in;
-       _info->n_outputs = _configured_out;
+       _configured_in = in;
+       _configured_out = out;
+
        return true;
 }
 
 int
 LuaProc::connect_and_run (BufferSet& bufs,
+               framepos_t start, framepos_t end, double speed,
                ChanMapping in, ChanMapping out,
                pframes_t nframes, framecnt_t offset)
 {
@@ -507,7 +610,7 @@ LuaProc::connect_and_run (BufferSet& bufs,
                return 0;
        }
 
-       Plugin::connect_and_run (bufs, in, out, nframes, offset);
+       Plugin::connect_and_run (bufs, start, end, speed, in, out, nframes, offset);
 
        // This is needed for ARDOUR::Session requests :(
        if (! SessionEvent::has_per_thread_pool ()) {
@@ -565,7 +668,7 @@ LuaProc::connect_and_run (BufferSet& bufs,
                                }
                        }
 
-                       luabridge::LuaRef lua_midi_tbl (luabridge::newTable (L));
+                       luabridge::LuaRef lua_midi_src_tbl (luabridge::newTable (L));
                        int e = 1; // > 1 port, we merge events (unsorted)
                        for (uint32_t mp = 0; mp < midi_in; ++mp) {
                                bool valid;
@@ -582,31 +685,65 @@ LuaProc::connect_and_run (BufferSet& bufs,
                                                luabridge::LuaRef lua_midi_event (luabridge::newTable (L));
                                                lua_midi_event["time"] = 1 + (*m).time();
                                                lua_midi_event["data"] = lua_midi_data;
-                                               lua_midi_tbl[e] = lua_midi_event;
+                                               lua_midi_src_tbl[e] = lua_midi_event;
                                        }
                                }
                        }
 
                        if (_has_midi_input) {
                                // XXX TODO This needs a better solution than global namespace
-                               luabridge::push (L, lua_midi_tbl);
-                               lua_setglobal (L, "mididata");
+                               luabridge::push (L, lua_midi_src_tbl);
+                               lua_setglobal (L, "midiin");
                        }
 
+                       luabridge::LuaRef lua_midi_sink_tbl (luabridge::newTable (L));
+                       if (_has_midi_output) {
+                               luabridge::push (L, lua_midi_sink_tbl);
+                               lua_setglobal (L, "midiout");
+                       }
 
                        // run the DSP function
                        (*_lua_dsp)(in_map, out_map, nframes);
+
+                       // copy back midi events
+                       if (_has_midi_output && lua_midi_sink_tbl.isTable ()) {
+                               bool valid;
+                               const uint32_t idx = out.get(DataType::MIDI, 0, &valid);
+                               if (valid && bufs.count().n_midi() > idx) {
+                                       MidiBuffer& mbuf = bufs.get_midi(idx);
+                                       mbuf.silence(0, 0);
+                                       for (luabridge::Iterator i (lua_midi_sink_tbl); !i.isNil (); ++i) {
+                                               if (!i.key ().isNumber ()) { continue; }
+                                               if (!i.value ()["time"].isNumber ()) { continue; }
+                                               if (!i.value ()["data"].isTable ()) { continue; }
+                                               luabridge::LuaRef data_tbl (i.value ()["data"]);
+                                               framepos_t tme = i.value ()["time"];
+                                               if (tme < 1 || tme > nframes) { continue; }
+                                               uint8_t data[64];
+                                               size_t size = 0;
+                                               for (luabridge::Iterator di (data_tbl); !di.isNil () && size < sizeof(data); ++di, ++size) {
+                                                       data[size] = di.value ();
+                                               }
+                                               if (size > 0 && size < 64) {
+                                                       mbuf.push_back(tme - 1, size, data);
+                                               }
+                                       }
+
+                               }
+                       }
                }
        } catch (luabridge::LuaException const& e) {
+               PBD::error << "LuaException: " << e.what () << "\n";
 #ifndef NDEBUG
-               printf ("LuaException: %s\n", e.what ());
+               std::cerr << "LuaException: " << e.what () << "\n";
 #endif
                return -1;
        }
 #ifdef WITH_LUAPROC_STATS
        int64_t t1 = g_get_monotonic_time ();
 #endif
-       lua.collect_garbage (); // rt-safe, slight *regular* performance overhead
+
+       lua.collect_garbage_step ();
 #ifdef WITH_LUAPROC_STATS
        ++_stats_cnt;
        int64_t t2 = g_get_monotonic_time ();
@@ -626,7 +763,7 @@ LuaProc::add_state (XMLNode* root) const
 {
        XMLNode*    child;
        char        buf[32];
-       LocaleGuard lg(X_("C"));
+       LocaleGuard lg;
 
        gchar* b64 = g_base64_encode ((const guchar*)_script.c_str (), _script.size ());
        std::string b64s (b64);
@@ -689,14 +826,14 @@ LuaProc::set_state (const XMLNode& node, int version)
 {
 #ifndef NO_PLUGIN_STATE
        XMLNodeList nodes;
-       XMLProperty *prop;
+       XMLProperty const * prop;
        XMLNodeConstIterator iter;
        XMLNode *child;
        const char *value;
        const char *port;
        uint32_t port_id;
 #endif
-       LocaleGuard lg (X_("C"));
+       LocaleGuard lg;
 
        if (_script.empty ()) {
                if (set_script_from_state (node)) {
@@ -747,8 +884,7 @@ LuaProc::default_value (uint32_t port)
                return 0;
        }
        int lp = _ctrl_params[port].second;
-       luabridge::LuaRef lr = (*_lua_params)[lp];
-       return (lr["default"]).cast<float> ();
+       return _param_desc[lp].normal;
 }
 
 void
@@ -777,35 +913,20 @@ LuaProc::get_parameter_descriptor (uint32_t port, ParameterDescriptor& desc) con
 {
        assert (port <= parameter_count ());
        int lp = _ctrl_params[port].second;
+       const ParameterDescriptor& d (_param_desc.find(lp)->second);
+
+       desc.lower        = d.lower;
+       desc.upper        = d.upper;
+       desc.normal       = d.normal;
+       desc.toggled      = d.toggled;
+       desc.logarithmic  = d.logarithmic;
+       desc.integer_step = d.integer_step;
+       desc.sr_dependent = d.sr_dependent;
+       desc.enumeration  = d.enumeration;
+       desc.unit         = d.unit;
+       desc.label        = d.label;
+       desc.scale_points = d.scale_points;
 
-       luabridge::LuaRef lr = (*_lua_params)[lp];
-       desc.lower  = (lr["min"]).cast<float> ();
-       desc.upper  = (lr["max"]).cast<float> ();
-
-       if (_ctrl_params[port].first) {
-               desc.normal = desc.lower; // output-port, no default
-       } else {
-               desc.normal = (lr["default"]).cast<float> ();
-       }
-
-       desc.toggled      = lr["toggled"].isBoolean () && (lr["toggled"]).cast<bool> ();
-       desc.logarithmic  = lr["logarithmic"].isBoolean () && (lr["logarithmic"]).cast<bool> ();
-       desc.integer_step = lr["integer"].isBoolean () && (lr["integer"]).cast<bool> ();
-       desc.sr_dependent = lr["ratemult"].isBoolean () && (lr["ratemult"]).cast<bool> ();
-       desc.enumeration  = lr["enum"].isBoolean () && (lr["enum"]).cast<bool> ();
-
-       // TODO check if assignments make sense, e.g
-       assert (!(desc.toggled && desc.logarithmic));
-
-       if (lr["unit"].isString ()) {
-               std::string unit = lr["unit"].cast<std::string> ();
-               if (unit == "dB") { desc.unit = ParameterDescriptor::DB; }
-               else if (unit == "Hz") { desc.unit = ParameterDescriptor::HZ; }
-               else if (unit == "Midi Note") { desc.unit = ParameterDescriptor::MIDI_NOTE; }
-       }
-
-       desc.label = (lr["name"]).cast<std::string> ();
-       desc.scale_points = get_scale_points (port);
        desc.update_steps ();
        return 0;
 }
@@ -814,12 +935,7 @@ std::string
 LuaProc::get_parameter_docs (uint32_t port) const {
        assert (port <= parameter_count ());
        int lp = _ctrl_params[port].second;
-       luabridge::LuaRef lr = (*_lua_params)[lp];
-       luabridge::LuaRef doc = lr["doc"];
-       if (doc.isString ()) {
-               return doc.cast<std::string> ();
-       }
-       return "";
+       return _param_doc.find(lp)->second;
 }
 
 uint32_t
@@ -864,11 +980,9 @@ LuaProc::describe_parameter (Evoral::Parameter param)
 {
        if (param.type () == PluginAutomation && param.id () < parameter_count ()) {
                int lp = _ctrl_params[param.id ()].second;
-               luabridge::LuaRef lr = (*_lua_params)[lp];
-               return (lr["name"]).cast<std::string> ();
-       } else {
-               return "??";
+               return _param_desc[lp].label;
        }
+       return "??";
 }
 
 void
@@ -884,18 +998,15 @@ LuaProc::print_parameter (uint32_t param, char* buf, uint32_t len) const
 }
 
 boost::shared_ptr<ScalePoints>
-LuaProc::get_scale_points (uint32_t port) const
+LuaProc::parse_scale_points (luabridge::LuaRef* lr)
 {
-       int lp = _ctrl_params[port].second;
-       luabridge::LuaRef lr = (*_lua_params)[lp];
-
-       if (!lr["scalepoints"].isTable()) {
+       if (!(*lr)["scalepoints"].isTable()) {
                return boost::shared_ptr<ScalePoints> ();
        }
 
        int cnt = 0;
        boost::shared_ptr<ScalePoints> rv = boost::shared_ptr<ScalePoints>(new ScalePoints());
-       luabridge::LuaRef scalepoints (lr["scalepoints"]);
+       luabridge::LuaRef scalepoints ((*lr)["scalepoints"]);
 
        for (luabridge::Iterator i (scalepoints); !i.isNil (); ++i) {
                if (!i.key ().isString ())    { continue; }
@@ -911,6 +1022,12 @@ LuaProc::get_scale_points (uint32_t port) const
        return boost::shared_ptr<ScalePoints> ();
 }
 
+boost::shared_ptr<ScalePoints>
+LuaProc::get_scale_points (uint32_t port) const
+{
+       int lp = _ctrl_params[port].second;
+       return _param_desc.find(lp)->second.scale_points;
+}
 
 void
 LuaProc::setup_lua_inline_gui (LuaState *lua_gui)
@@ -920,10 +1037,7 @@ LuaProc::setup_lua_inline_gui (LuaState *lua_gui)
        LuaBindings::common (LG);
        LuaBindings::dsp (LG);
 
-#ifndef NDEBUG
        lua_gui->Print.connect (sigc::mem_fun (*this, &LuaProc::lua_print));
-#endif
-
        lua_gui->do_command ("function ardour () end");
        lua_gui->do_command (_script);
 
@@ -933,6 +1047,7 @@ LuaProc::setup_lua_inline_gui (LuaState *lua_gui)
                .beginNamespace ("Ardour")
                .beginClass <LuaProc> ("LuaProc")
                .addFunction ("shmem", &LuaProc::instance_shm)
+               .addFunction ("table", &LuaProc::instance_ref)
                .endClass ()
                .endNamespace ();
 
@@ -942,10 +1057,153 @@ LuaProc::setup_lua_inline_gui (LuaState *lua_gui)
        luabridge::push <float *> (LG, _shadow_data);
        lua_setglobal (LG, "CtrlPorts");
 }
+////////////////////////////////////////////////////////////////////////////////
+
+#include "ardour/search_paths.h"
+#include "sha1.c"
+
+std::string
+LuaProc::preset_name_to_uri (const std::string& name) const
+{
+       std::string uri ("urn:lua:");
+       char hash[41];
+       Sha1Digest s;
+       sha1_init (&s);
+       sha1_write (&s, (const uint8_t *) name.c_str(), name.size ());
+       sha1_write (&s, (const uint8_t *) _script.c_str(), _script.size ());
+       sha1_result_hash (&s, hash);
+       return uri + hash;
+}
+
+std::string
+LuaProc::presets_file () const
+{
+       return string_compose ("lua-%1", _info->unique_id);
+}
+
+XMLTree*
+LuaProc::presets_tree () const
+{
+       XMLTree* t = new XMLTree;
+       std::string p = Glib::build_filename (ARDOUR::user_config_directory (), "presets");
+
+       if (!Glib::file_test (p, Glib::FILE_TEST_IS_DIR)) {
+               if (g_mkdir_with_parents (p.c_str(), 0755) != 0) {
+                       error << _("Unable to create LuaProc presets directory") << endmsg;
+               };
+       }
+
+       p = Glib::build_filename (p, presets_file ());
+
+       if (!Glib::file_test (p, Glib::FILE_TEST_EXISTS)) {
+               t->set_root (new XMLNode (X_("LuaPresets")));
+               return t;
+       }
+
+       t->set_filename (p);
+       if (!t->read ()) {
+               delete t;
+               return 0;
+       }
+       return t;
+}
+
+bool
+LuaProc::load_preset (PresetRecord r)
+{
+       boost::shared_ptr<XMLTree> t (presets_tree ());
+       if (t == 0) {
+               return false;
+       }
+
+       XMLNode* root = t->root ();
+       for (XMLNodeList::const_iterator i = root->children().begin(); i != root->children().end(); ++i) {
+               XMLProperty const * label = (*i)->property (X_("label"));
+               assert (label);
+               if (label->value() != r.label) {
+                       continue;
+               }
+
+               for (XMLNodeList::const_iterator j = (*i)->children().begin(); j != (*i)->children().end(); ++j) {
+                       if ((*j)->name() == X_("Parameter")) {
+                               XMLProperty const * index = (*j)->property (X_("index"));
+                               XMLProperty const * value = (*j)->property (X_("value"));
+                               assert (index);
+                               assert (value);
+                               LocaleGuard lg;
+                               set_parameter (atoi (index->value().c_str()), atof (value->value().c_str ()));
+                       }
+               }
+               return Plugin::load_preset(r);
+       }
+       return false;
+}
+
+std::string
+LuaProc::do_save_preset (std::string name) {
+
+       boost::shared_ptr<XMLTree> t (presets_tree ());
+       if (t == 0) {
+               return "";
+       }
+
+       std::string uri (preset_name_to_uri (name));
+
+       XMLNode* p = new XMLNode (X_("Preset"));
+       p->add_property (X_("uri"), uri);
+       p->add_property (X_("label"), name);
+
+       for (uint32_t i = 0; i < parameter_count(); ++i) {
+               if (parameter_is_input (i)) {
+                       XMLNode* c = new XMLNode (X_("Parameter"));
+                       c->add_property (X_("index"), string_compose ("%1", i));
+                       c->add_property (X_("value"), string_compose ("%1", get_parameter (i)));
+                       p->add_child_nocopy (*c);
+               }
+       }
+       t->root()->add_child_nocopy (*p);
+
+       std::string f = Glib::build_filename (ARDOUR::user_config_directory (), "presets");
+       f = Glib::build_filename (f, presets_file ());
+
+       t->write (f);
+       return uri;
+}
+
+void
+LuaProc::do_remove_preset (std::string name)
+{
+       boost::shared_ptr<XMLTree> t (presets_tree ());
+       if (t == 0) {
+               return;
+       }
+       t->root()->remove_nodes_and_delete (X_("label"), name);
+       std::string f = Glib::build_filename (ARDOUR::user_config_directory (), "presets");
+       f = Glib::build_filename (f, presets_file ());
+       t->write (f);
+}
+
+void
+LuaProc::find_presets ()
+{
+       boost::shared_ptr<XMLTree> t (presets_tree ());
+       if (t) {
+               XMLNode* root = t->root ();
+               for (XMLNodeList::const_iterator i = root->children().begin(); i != root->children().end(); ++i) {
+
+                       XMLProperty const * uri = (*i)->property (X_("uri"));
+                       XMLProperty const * label = (*i)->property (X_("label"));
+
+                       assert (uri);
+                       assert (label);
+
+                       PresetRecord r (uri->value(), label->value(), true);
+                       _presets.insert (make_pair (r.uri, r));
+               }
+       }
+}
 
 ////////////////////////////////////////////////////////////////////////////////
-#include <glibmm/miscutils.h>
-#include <glibmm/fileutils.h>
 
 LuaPluginInfo::LuaPluginInfo (LuaScriptInfoPtr lsi) {
        if (lsi->type != LuaScriptInfo::DSP) {
@@ -956,11 +1214,13 @@ LuaPluginInfo::LuaPluginInfo (LuaScriptInfoPtr lsi) {
        name = lsi->name;
        creator = lsi->author;
        category = lsi->category;
-       unique_id = "luascript"; // the interpreter is not unique.
+       unique_id = lsi->unique_id;
 
        n_inputs.set (DataType::AUDIO, 1);
        n_outputs.set (DataType::AUDIO, 1);
        type = Lua;
+
+       _is_instrument = category == "Instrument";
 }
 
 PluginPtr
@@ -994,5 +1254,19 @@ std::vector<Plugin::PresetRecord>
 LuaPluginInfo::get_presets (bool /*user_only*/) const
 {
        std::vector<Plugin::PresetRecord> p;
+       XMLTree* t = new XMLTree;
+       std::string pf = Glib::build_filename (ARDOUR::user_config_directory (), "presets", string_compose ("lua-%1", unique_id));
+       if (Glib::file_test (pf, Glib::FILE_TEST_EXISTS)) {
+               t->set_filename (pf);
+               if (t->read ()) {
+                       XMLNode* root = t->root ();
+                       for (XMLNodeList::const_iterator i = root->children().begin(); i != root->children().end(); ++i) {
+                               XMLProperty const * uri = (*i)->property (X_("uri"));
+                               XMLProperty const * label = (*i)->property (X_("label"));
+                               p.push_back (Plugin::PresetRecord (uri->value(), label->value(), true));
+                       }
+               }
+       }
+       delete t;
        return p;
 }